From nobody Tue Dec 2 01:04:11 2025 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7F9D2DFF1D for ; Mon, 24 Nov 2025 08:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763973623; cv=none; b=lBv2Ec0t1lz28NshpEGGtt+AY8RepZL3QRkp58LiTVZJA2izvD2EXykbtzsrUyO6N+WMYGXvb4pw2UGibF8XwMkiLvItK4vDsLlDzKRLxd6yHzixY7jF72aIG2phhhDbaNxAmVs4LtviZgZezq3qya60g0G6s540GdC95raolKw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763973623; c=relaxed/simple; bh=0gVSSlkfZ7/G/ViXIJGF/a7AS/PSsMXtmDfqXMvGemE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AlBki9K0sRqcLn0zvHzOyrYy7ArHDsn0/Cs+gGGG8TNWj/OOC6OhEcWeaRvx0Ie651ZELDb/ct0SmgtcF4xr/JQyP8Z//9QNJl9vBLU3dKycX614d78qgLC6fLC5FOznZFyJyeretO73+bePmsYGu6yQOEFSZZA0oIUcGJQlNQY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=JHBMVif7; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=crADgmnQ; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="JHBMVif7"; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="crADgmnQ" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D4E915BD79; Mon, 24 Nov 2025 08:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1763973619; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7Q5k407pMWHn13JviZaygSuNBa3cflMA83SB44GzADw=; b=JHBMVif7w3Ywcl6L2TbvECEb81JSIaF7LPloC8CrBmc16oPYceon6AVPGf30wh0jEwo3wJ YHRHWlOlSZdFOri95pDwRok0A2CZtsd9PLnzqxCZcGaYkP5ueQ/1GFLB2LgfjzVwOwVO0q 5t2HhKTbHiPBpPmYrnjRW7n2Q7wkBQs= Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.com header.s=susede1 header.b=crADgmnQ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1763973618; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7Q5k407pMWHn13JviZaygSuNBa3cflMA83SB44GzADw=; b=crADgmnQQzJp7hWwBj6/G+Z2zEGfRUvU5uKcaRzeppjDV+nxPk/GaWl1pGgfAzc++A0D9b 9BjLsRaHPaEn6FcBYiCT6EvQBxlPJCM4iBNeWj0xYe//qPdYhBerwwWkclmQYCm82BDN78 RX4NX2wya0ZQ4mZy41/nZV0vm+MmehM= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8A6F83EA61; Mon, 24 Nov 2025 08:40:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HhpoH/IZJGl1OwAAD6G6ig (envelope-from ); Mon, 24 Nov 2025 08:40:18 +0000 From: Nikolay Borisov To: linux-edac@vger.kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, Yazen.Ghannam@amd.com, Nikolay Borisov Subject: [PATCH v2] RAS/AMD/ATL: Remove bitwise_xor_bits Date: Mon, 24 Nov 2025 10:40:11 +0200 Message-ID: <20251124084011.1575166-1-nik.borisov@suse.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Level: X-Spam-Flag: NO X-Rspamd-Queue-Id: D4E915BD79 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.com:dkim,suse.com:mid,suse.com:email]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; DKIM_TRACE(0.00)[suse.com:+] X-Spam-Score: -3.01 Content-Type: text/plain; charset="utf-8" Both LLVM/GCC support a __builtin_parity function which is functionally equivalent to the custom bitwise_xor_bits() one. Let's simplify the code by relying on the built-in. No functional changes. Signed-off-by: Nikolay Borisov --- Changes since v1: * Reworded the commit message drivers/ras/amd/atl/umc.c | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/ras/amd/atl/umc.c b/drivers/ras/amd/atl/umc.c index 6e072b7667e9..7ff4a5a1c5da 100644 --- a/drivers/ras/amd/atl/umc.c +++ b/drivers/ras/amd/atl/umc.c @@ -49,18 +49,6 @@ static u8 get_coh_st_inst_id_mi300(struct atl_err *err) return i; } -/* XOR the bits in @val. */ -static u16 bitwise_xor_bits(u16 val) -{ - u16 tmp =3D 0; - u8 i; - - for (i =3D 0; i < 16; i++) - tmp ^=3D (val >> i) & 0x1; - - return tmp; -} - struct xor_bits { bool xor_enable; u16 col_xor; @@ -250,17 +238,17 @@ static unsigned long convert_dram_to_norm_addr_mi300(= unsigned long addr) if (!addr_hash.bank[i].xor_enable) continue; - temp =3D bitwise_xor_bits(col & addr_hash.bank[i].col_xor); - temp ^=3D bitwise_xor_bits(row & addr_hash.bank[i].row_xor); + temp =3D (u16)__builtin_parity(col & addr_hash.bank[i].col_xor); + temp ^=3D (u16)__builtin_parity(row & addr_hash.bank[i].row_xor); bank ^=3D temp << i; } /* Calculate hash for PC bit. */ if (addr_hash.pc.xor_enable) { - temp =3D bitwise_xor_bits(col & addr_hash.pc.col_xor); - temp ^=3D bitwise_xor_bits(row & addr_hash.pc.row_xor); + temp =3D (u16)__builtin_parity(col & addr_hash.pc.col_xor); + temp ^=3D (u16)__builtin_parity(row & addr_hash.pc.row_xor); /* Bits SID[1:0] act as Bank[5:4] for PC hash, so apply them here. */ - temp ^=3D bitwise_xor_bits((bank | sid << NUM_BANK_BITS) & addr_hash.ban= k_xor); + temp ^=3D (u16)__builtin_parity((bank | sid << NUM_BANK_BITS) & addr_has= h.bank_xor); pc ^=3D temp; } -- 2.52.0