From nobody Tue Dec 2 01:04:47 2025 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0BCF2DFF19 for ; Mon, 24 Nov 2025 06:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763967036; cv=none; b=CwItI42MORXLvWfCEz//+NzoQ1KtQKxKDKsCsmOZ6bXX/uH9fVjv4F4sqIqbe1gr9jPw3c4oxlz4yLGfTCzbbS+egF+oIPCBN2aKDibY9NR9ocaYTP24sKl1q0Sq/pk848JKk1875O2yLRwgBQeH0ZY44Oi3Xab7pu5yx0oq09c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763967036; c=relaxed/simple; bh=d6WN5H/+767vMaQcJjAjNCbjrtbpcRP4HbSZ+EaFPAg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ubd7Be/E31Ev3LpBx05aXcXd4BOUzgVgKa4JY9yMNekNxBrSToemeBVEzedLmEdlpH1cIewO6k9Xuw5+Pg/pIKiDJPWTMsEQ0HMUAdHuowtoYZa/fOUa1RG6SrKlmVGh9jHs7t5awAsQdnHv7+QnWJ+iZg3R3wLEhhZ//d3ztJE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca; spf=pass smtp.mailfrom=marek.ca; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b=SMGIUgTR; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marek.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b="SMGIUgTR" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-8b220ddc189so470788385a.0 for ; Sun, 23 Nov 2025 22:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek.ca; s=google; t=1763967034; x=1764571834; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0SbhPk+cIbagc0g7g2HIdLEmkXHw9QB9UvdhnuSgHsc=; b=SMGIUgTRRxYH5DGNp4MNCP7vjvOGwdhbRDTax/z21Rc0bgYIp225y7W9DQsxlVpquj t5MweCmOFXhL5GiyCpld9Dd/6qsfRWKhQCSVP+PyUlQzk+JrJI4LWzVi0B7TbiiVMP/a Yflp4xK/gz7axfTMW0F3t0syDQRPCY52LIhTuoOcvCy4ISmw9lXBhDwmdIJpZF7K4xmX isU+OTtwgbJxUuCJR7rPumSXVi/mnt+dc0+jXtlCpaXMCcDUWsd9aziXGkMaW6kmI/Zg 6XNFuMqFVt7obA0HD8fQKRRcDU5AMplniL70xqznhgoonifSEy9mQv4uEoBxqMEHrAjO cPWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763967034; x=1764571834; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0SbhPk+cIbagc0g7g2HIdLEmkXHw9QB9UvdhnuSgHsc=; b=vIipWUm6OV4vEiX0fFWkiFePShO46mg2ZFC/bsospt8wjgWTb9iMRX/tiNk0ANilkK BlurwqK86Wsq5moahnix1Eru0zoG8YVyhloaz/wnqg4LFzlTzeov42kbbQd0ilE2Suzs 94F6NwjYF2dpyTAXuTbdtI1tFLUpI9LrJ3uUWNUm9Mw3zfrXcKia4/z/MfH1JuyP4ZDA x9Ac6pHluHNKxldM8p7LjAzZUQ0j+AEPogtTIl2r5H+H5vn5otULW1Vfpr8bI1HLQDUJ Z4ax+9X/+AFuTuYYwPccnA7Q4krS9x4A6fmqgGAwP89S43TnqSeyM2GoC7H4jOWU21dg 35zw== X-Forwarded-Encrypted: i=1; AJvYcCXz133Ih4NKqS36EXMx/fzBL4oh9P9dpeQbNB/yPniKCfHpe98A03Xr7HpMKXzh9uO96w6fOwpH/z3zOGA=@vger.kernel.org X-Gm-Message-State: AOJu0YyAix9UUTgidjlelqHSFrYDIg5Dku7iufeKKD40gTlA8wheLsIz /tKOg8ljBpwAdxyH5cSvzN/23UdVNiGqqDhdweoorrF1r20bdbJbesAut6BVxFgHqqo= X-Gm-Gg: ASbGncsdda2aPQKg8f65wnVXtMIIajMwrhcg8LOgIj0sW7ePCDnQHtxy1dVKvNG+lrj +xbnG3gGLTAUSmA1fwGL80UXOCWTUqrFPeNLWEwkwmuR10J7aocvA6bwLL24+LDkKWTNUhyjLx9 XLgBkH9xmiL6F/OtfkxG7H+i4Qh0uhCKmsSmn+DCHH1E/y7qNZEFnYZ8yYGxBxIWyEY1RQ+dore qj16hq/EIx1k+P6RTSWM3H+E9BSquBrQth0XSvYxHCI/jfJppII5tqqiqRMKGO1SO95vmDMAQ6X EN+rBU3HlPzGXFHqyyjKJ5zyFUuxlmd/IwNgQS6QXWmh7VX2HvWbT1CCktRr8RlPlcqGFgFcXrk U8M2XM7AzWBw6nupN5xHf7vrH8ASjqaiU9TC7pRsw2rm0UEhdPSXkwNXe2Xzk6SMd8v1FvuebbU TBDtYRWKZVAFnAxdVv0csHW5Z9m52c8EMoEeZCiLBH4Jcdh3qu/b+Fs7LsQRtnNdfEYQ== X-Google-Smtp-Source: AGHT+IEBHwNCw3W+jfg9jESuLTfvci7rPCprytBblNB0K+hOqYvW2BCwSblqlDokDkAkj9jWN2s1ew== X-Received: by 2002:a05:620a:450c:b0:8b2:e922:529a with SMTP id af79cd13be357-8b33d1f93acmr1221802585a.19.1763967032817; Sun, 23 Nov 2025 22:50:32 -0800 (PST) Received: from localhost.localdomain (modemcable125.110-19-135.mc.videotron.ca. [135.19.110.125]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b3295db8b1sm889075185a.40.2025.11.23.22.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Nov 2025 22:50:31 -0800 (PST) From: Jonathan Marek To: linux-arm-msm@vger.kernel.org Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Krzysztof Kozlowski , Neil Armstrong , linux-sound@vger.kernel.org (open list:QCOM AUDIO (ASoC) DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/6] ASoC: codecs: wsa884x: remove mute_unmute_on_trigger Date: Mon, 24 Nov 2025 01:45:54 -0500 Message-ID: <20251124064850.15419-2-jonathan@marek.ca> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251124064850.15419-1-jonathan@marek.ca> References: <20251124064850.15419-1-jonathan@marek.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" trigger is atomic (non-schedulable), and soundwire register writes are not safe to run in an atomic context. (bus is locked with a mutex, and qcom driver's callback can also sleep if the FIFO is full). The important part of fixing the click/pop issue was removing the PA_EN writes from the dapm events, AFAICT this flag doesn't help anyway. Fixes: 28b0b18d5346 ("ASoC: codec: wsa884x: make use of new mute_unmute_on_= trigger flag") Signed-off-by: Jonathan Marek --- sound/soc/codecs/wsa884x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/wsa884x.c b/sound/soc/codecs/wsa884x.c index 2484d4b8e2d94..0218dfc13bc77 100644 --- a/sound/soc/codecs/wsa884x.c +++ b/sound/soc/codecs/wsa884x.c @@ -1840,7 +1840,6 @@ static const struct snd_soc_dai_ops wsa884x_dai_ops = =3D { .hw_free =3D wsa884x_hw_free, .mute_stream =3D wsa884x_mute_stream, .set_stream =3D wsa884x_set_stream, - .mute_unmute_on_trigger =3D true, }; =20 static struct snd_soc_dai_driver wsa884x_dais[] =3D { --=20 2.51.0