From nobody Tue Dec 2 00:46:05 2025 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E68D41D6BB for ; Mon, 24 Nov 2025 01:19:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763947187; cv=none; b=OJ07RLvOUnam84Jn30QoGrTDuR+/dSc8x7GbPhR95f8kGFRaMH254IvklI7IpT+6TmJ2H4E1CP9vFhuI9+YgmxpeRLS/rmEoaFfiLbPBYQYLDr7hM2QjYfig7GHAGDwNXm/4fdQEEPr+9ZrNv8XZ8ptU4YK84gaDW8TSFWObgUY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763947187; c=relaxed/simple; bh=TtD5nVDal96w5biqf1bV/+iOIjwTkQrW4Bo3nncpTzg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=s/MvTfBzOd0F6wxA8/1KyijIGIuVoOkZn/vtG6STb5iVMzRbWZ74PkvlNf6Wstn/1ipJcEyka5IXpo3FG6GFmCbF6+of1WV2F5AcKDSSW5gsia0xc41LZuJwHMzVxfn0nCZLObwiHjNH+ltZBlKEgy0zYF4RrIY77yQ58QGsyaU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [124.16.141.245]) by APP-01 (Coremail) with SMTP id qwCowAC3SsqrsiNpYhbSAQ--.9519S2; Mon, 24 Nov 2025 09:19:40 +0800 (CST) From: Haotian Zhang To: vkoul@kernel.org, kishon@kernel.org Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Haotian Zhang Subject: [PATCH] phy: ti: da8xx-usb: Handle devm_pm_runtime_enable() errors Date: Mon, 24 Nov 2025 09:19:19 +0800 Message-ID: <20251124011919.1581-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowAC3SsqrsiNpYhbSAQ--.9519S2 X-Coremail-Antispam: 1UD129KBjvJXoW7KryUWr17Jw15Xw4rtr1rCrg_yoW8Cr17pF WfXas2krWFg348Gw4DJw4kuFWYk3yrtry8KF97C3WF9a45W3yUXa4rAFyjvFsYvrykuF15 J3WrJFy7Aa1avF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvj14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxV WxJr0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2Wl Yx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbV WUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AF wI0_JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4 xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1D MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I 0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWU JVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUeh L0UUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwkQA2kjIsDjaQAAs- Content-Type: text/plain; charset="utf-8" devm_pm_runtime_enable() can fail due to memory allocation. The current code ignores its return value after calling pm_runtime_set_active(), leaving the device in an inconsistent state if runtime PM initialization fails. Check the return value of devm_pm_runtime_enable() and return on failure. Also move the declaration of 'ret' to the function scope to support this check. Fixes: ee8e41b5044f ("phy: ti: phy-da8xx-usb: Add runtime PM support") Signed-off-by: Haotian Zhang --- drivers/phy/ti/phy-da8xx-usb.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/phy/ti/phy-da8xx-usb.c b/drivers/phy/ti/phy-da8xx-usb.c index 1d81a1e6ec6b..be9c77f8c288 100644 --- a/drivers/phy/ti/phy-da8xx-usb.c +++ b/drivers/phy/ti/phy-da8xx-usb.c @@ -180,6 +180,7 @@ static int da8xx_usb_phy_probe(struct platform_device *= pdev) struct da8xx_usb_phy_platform_data *pdata =3D dev->platform_data; struct device_node *node =3D dev->of_node; struct da8xx_usb_phy *d_phy; + int ret; =20 d_phy =3D devm_kzalloc(dev, sizeof(*d_phy), GFP_KERNEL); if (!d_phy) @@ -233,8 +234,6 @@ static int da8xx_usb_phy_probe(struct platform_device *= pdev) return PTR_ERR(d_phy->phy_provider); } } else { - int ret; - ret =3D phy_create_lookup(d_phy->usb11_phy, "usb-phy", "ohci-da8xx"); if (ret) @@ -249,7 +248,11 @@ static int da8xx_usb_phy_probe(struct platform_device = *pdev) PHY_INIT_BITS, PHY_INIT_BITS); =20 pm_runtime_set_active(dev); - devm_pm_runtime_enable(dev); + ret =3D devm_pm_runtime_enable(dev); + if (ret) { + dev_err(dev, "Failed to enable runtime PM\n"); + return ret; + } /* * Prevent runtime pm from being ON by default. Users can enable * it using power/control in sysfs. --=20 2.50.1.windows.1