From nobody Tue Dec 2 01:08:19 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3DD92F7AA9 for ; Mon, 24 Nov 2025 09:26:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763976386; cv=none; b=GXKZFQJQ4aXvOxZkIPwUxG1qts+JOwqBoV4SXl/SyzUd1Iuh9uypm3GWQPUBJYvDScrh6xQt4S4JHQuKwIqGqYelCxo6YQtGjjLTPSd1kgCdim9s2QbI5LP5FmsAFYqKCSY207ArDWjKHwzlo2685B5Sj2N05m1quE3ZUD2EyqQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763976386; c=relaxed/simple; bh=DR9ZshB3tCF8ot5jNA0cLJbKXckeVnTyWsQbBdZAI5k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QAu3ES8T43Sl6XbjoM0myiPw18quS6tWNHL88kEDNECo04ZJM3T1EhqxBGJrQjDzUZfsR0CwS4EeO9ijW5YbHyqLzMizYpbmor3kpx4TSuyRuDWw47kItjwzFMrSeFTHppIYqqPU4EP+eE8mMd7vQyuBMz8lvc+IeKkpKx1G7K8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gE9SZfel; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S5cWSGcp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gE9SZfel"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S5cWSGcp" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AO8APKo2283499 for ; Mon, 24 Nov 2025 09:26:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OJY7Rj8zcXCk0C9xSYbel9jvd/INPXaMfmQIQcX+9wY=; b=gE9SZfelrcOABPcy bPc9JgjFFoyHzhtrBHSuKkjdeZXYEUlPKxARjW91ALOsu+7vA9KgGavU8MRprr+K SJb0z5eO7f8qQmdeG40Osk8ZPYsT+r02NzvElnNincKe+VZoqH54cuBnen0e02KG heE37+IWWv2uzqTJtJIha+F3RD8hbpYxR4HigA5EssR5PbPvYBXI/IJyhMXZvoSg AAcDu/KhVDpaUqXXfwDd5hrD+IbT9jYZyOzKrica/LViaTxn6IEAL4/c+2xeWndc 3Z9j8oIjL+WtJCqc9LhigVDg9hPQ29k9dAKUezvIXc+Z2ZDzW6qVMrVOm1lop+oL HGaG6g== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ak67x4fh7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Nov 2025 09:26:23 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29806c42760so168410065ad.2 for ; Mon, 24 Nov 2025 01:26:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763976383; x=1764581183; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OJY7Rj8zcXCk0C9xSYbel9jvd/INPXaMfmQIQcX+9wY=; b=S5cWSGcpmF3Bi7net5vIHHUKD08qKmmxdF6G2KKUBd+JPR1radFPZ+uSrbFdP39MOj mqYHlpWRTbi7WzCXHk4hezfJiBm3wl8XJYqTMOWFpbZSU3L9lKt8/reIhaKKGynLkoLI p9FCDGRB0Db54TKvwvYqXK5fYeDxBL4wrJWDFDWLQ+FXyrHw/4nEd0qSjcXV1OAh2SmU NRid7uEh2fPsRM3sWe1anCvk7hsJ3SUGJLnFG7GybA1CgX/7voF8sTt1YBvPdHXpdOis zFnpADIkVrxa4cAoD+z5MOg3y1/RD7mF/BMk3gVeuB3/Zl8pXuaRko2td1ovPFyp0mWQ lVRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763976383; x=1764581183; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=OJY7Rj8zcXCk0C9xSYbel9jvd/INPXaMfmQIQcX+9wY=; b=LvaipdH0k/r0+I+QMpCVPxJTh4ZXJiYu5lxy/tsFM/KmmdjaXD8rZDdzOACwQZF0xU aDmDc4URg+joy0dfaotnGP/W64AJEgwqrI5CEcZICxkIqImRM2igqqttB6FDp3gifySa HLdCP1E/0A2M961MuwrZQrQITGMDXmgIW2r7/Q2izkYwZJV4WpGMgYITPjQ+ab7xEmhm zxYY3ajq238Zg2PIMymD/v13WERw5llhqZt8jjqwot0wsonhTlULet2CEpItg5tkpHLm +ejCT+KlIkBV8GQ7fhCKZCnh2mRjLVwUFU4Q26ShmE0gPLmc75Wf7Cya/OGbMlvd4jtk epqA== X-Forwarded-Encrypted: i=1; AJvYcCUAav6NCGOvuHm4362F5dFAzaTGbYKLcmVZ7t4OxqHkUQqHm3++Bn7dl+wouLnQ57zeFDHXF4ON2YxYTrk=@vger.kernel.org X-Gm-Message-State: AOJu0YxhrN+kZzxduflvm7eGIOcR/XsK/6WI6dKVsm4ZXzCLfMTL6ipe Dcoxwky1PSlq4nVcKAk/sRH/Bbbi+SF1PzH61MUJi8V9+NeB3wwfFTNXqGqbgJxvBinGpic9916 EQn8EItfq8VUOgDB3wRLt/TJApgus+nbRSDw7Kcp6I6Vha+sgrKjbyW5XSideAg3cCZI= X-Gm-Gg: ASbGnctiW3S9aOJJFw7VEDht5SIvvVW3yt633DaUQMWOqXq5eNPe83EVpe3iZNZqnSJ 4BL7jdWSnF5zfWecj44QftAbOrwt14dAZeIipT46FbsJthzBEGChkiGBuZAQd0hRpNVopBAljLd WDRAiGuCt0ROlJ3cCZR6Sr0MZuh+ptNuoqmi9upDnJ9AawlfolPzdmWn8y2tHdSyrolZ5QL6cDi y/BftTUjUODYQxhRHk+Pd3viyqgi1jISw9o0VFns+5IdMPXJg775iyV7QJsgJNFokkQFhH/NB5N 3lVHk8w0DPj7E27/YOIlqiQSjao3frz779iISXgcMgL9JcSTuMBlaDA0qdnP+xQ7lZzQAs6Ot0V Eo0FWpO0DunvJ3wib+htqn55EAERlPYAqVbfmlTk= X-Received: by 2002:a17:903:1a83:b0:295:888e:d204 with SMTP id d9443c01a7336-29b6bf73815mr117612085ad.57.1763976383059; Mon, 24 Nov 2025 01:26:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IFXiu4X8k99lPstiKTSh++HZ+UDc77Vx174r918bKFVvRjzwR5/PL/BIK0pJ0dX100a60NL+w== X-Received: by 2002:a17:903:1a83:b0:295:888e:d204 with SMTP id d9443c01a7336-29b6bf73815mr117611775ad.57.1763976382548; Mon, 24 Nov 2025 01:26:22 -0800 (PST) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b29b1c2sm128444675ad.81.2025.11.24.01.26.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 01:26:22 -0800 (PST) From: Mohd Ayaan Anwar Date: Mon, 24 Nov 2025 14:55:22 +0530 Subject: [PATCH 6/6] phy: qcom: sgmii-eth: add second regulator support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251124-sgmiieth_serdes_regulator-v1-6-73ae8f9cbe2a@oss.qualcomm.com> References: <20251124-sgmiieth_serdes_regulator-v1-0-73ae8f9cbe2a@oss.qualcomm.com> In-Reply-To: <20251124-sgmiieth_serdes_regulator-v1-0-73ae8f9cbe2a@oss.qualcomm.com> To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Wasim Nazir , Mohd Ayaan Anwar , Yijie Yang Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763976350; l=2606; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=DR9ZshB3tCF8ot5jNA0cLJbKXckeVnTyWsQbBdZAI5k=; b=mPop2tXPQ4qQaO+f9OHG/yKFpsjo/voNre3K2+Bs/qAos4xoq4jMK5gCGTip9ybAh9MIaJ0vA zdvPDtZF5TeDG7YyEdJX+dBP3UlB2SulMGGj0pQ4JPaQQ9NtBb73QFa X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-GUID: DqwlPYMGQxQ-YGZO9FBotzKDvsuNB-SN X-Authority-Analysis: v=2.4 cv=AcC83nXG c=1 sm=1 tr=0 ts=692424bf cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=gIf8zwsM_d9Eo6wCimYA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: DqwlPYMGQxQ-YGZO9FBotzKDvsuNB-SN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI0MDA4MiBTYWx0ZWRfX7O1MRqJR2xeu XIwToDFkRleEVRoWUGYbkv5ZOhx69hZH2UGdLwLgkU9rwEBS89Kk/gqcj2gdnquX6/hQpjha3yc tex1CZwy+XZpEgLlWgwlwXzPdTKvD104FFIcuT6zEJD6n1ntTH77nRvGrAybgx+UOWfTsjCENRo wbktl4dM87ol0S21iWQ74Bv23htll8K4NA8zgClQH1BtbvZDE8ItWSviKwD/KssPNhftyevuk/X sfVcM0pZRqg6YanC6vzGjhaUtlFpytb2arZABN/BrzjgUV7a0CDK32okQkjrpA/9POgIRKp4PQB RaMtdSB7PsEI0sM2ZMblFzhdT/kpDvLTOilhT8JXKF2Opyr+0OBfSbK8CFv5TtIzRfUkfJjSrZB V364AVQ5HteqBAc/GzKvJjDMZHy4lA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-24_04,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511240082 The Qualcomm SGMII SerDes PHY requires two regulators to function properly. If both of these are not enabled, the following error is observed: [ 77.105651] qcom-dwmac-sgmii-phy 8909000.phy: QSERDES_COM_C_READY_STATUS= timed-out [ 77.113447] qcom-ethqos 23040000.ethernet eth0: __stmmac_open: Serdes po= werup failed Therefore, add support for handling the additional regulator in the driver. Fixes: 601d06277007 ("phy: qcom: add the SGMII SerDes PHY driver") Signed-off-by: Mohd Ayaan Anwar --- drivers/phy/qualcomm/phy-qcom-sgmii-eth.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c b/drivers/phy/qualco= mm/phy-qcom-sgmii-eth.c index 5b1c82459c126fe3a046a89601483d8c73090fd3..5044f244762f4bb2318618b83bd= 94324d445b62d 100644 --- a/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c +++ b/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c @@ -10,6 +10,7 @@ #include #include #include +#include =20 #include "phy-qcom-qmp-pcs-sgmii.h" #include "phy-qcom-qmp-qserdes-com-v5.h" @@ -26,6 +27,7 @@ #define QSERDES_COM_C_PLL_LOCKED BIT(1) =20 struct qcom_dwmac_sgmii_phy_data { + struct regulator *vdda_0p9; struct regmap *regmap; struct clk *refclk; int speed; @@ -266,9 +268,23 @@ static int qcom_dwmac_sgmii_phy_calibrate(struct phy *= phy) =20 static int qcom_dwmac_sgmii_phy_power_on(struct phy *phy) { + int ret; struct qcom_dwmac_sgmii_phy_data *data =3D phy_get_drvdata(phy); =20 - return clk_prepare_enable(data->refclk); + ret =3D regulator_enable(data->vdda_0p9); + if (ret) + goto out_ret; + + ret =3D clk_prepare_enable(data->refclk); + if (ret) + goto out_reg_disable; + + return 0; + +out_reg_disable: + regulator_disable(data->vdda_0p9); +out_ret: + return ret; } =20 static int qcom_dwmac_sgmii_phy_power_off(struct phy *phy) @@ -283,6 +299,8 @@ static int qcom_dwmac_sgmii_phy_power_off(struct phy *p= hy) =20 clk_disable_unprepare(data->refclk); =20 + regulator_disable(data->vdda_0p9); + return 0; } =20 @@ -343,6 +361,10 @@ static int qcom_dwmac_sgmii_phy_probe(struct platform_= device *pdev) if (IS_ERR(data->refclk)) return PTR_ERR(data->refclk); =20 + data->vdda_0p9 =3D devm_regulator_get(dev, "vdda-0p9"); + if (IS_ERR(data->vdda_0p9)) + return PTR_ERR(data->vdda_0p9); + provider =3D devm_of_phy_provider_register(dev, of_phy_simple_xlate); if (IS_ERR(provider)) return PTR_ERR(provider); --=20 2.34.1