From nobody Tue Dec 2 00:26:06 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9031274FE3; Tue, 25 Nov 2025 03:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764042421; cv=none; b=Jf6cDLY5ckJJ17lcFlZ6PJqdqA8gv5jAi45mNnibAwMrmZnbCeL45m2F+A8YOLb2XaMek3cgYH1ZHU/3guWwJyC13O1pbSVa5BnFfdvOFd4ff54bMhL6ZLJQtLLHU00pcNMj6NMQu6CCcL4eyekg1E8L+p1uZYNu/GoKUptkapM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764042421; c=relaxed/simple; bh=4J3g5j51PBpP7n9+7mbzEOrB/xPKifWDPpyCNDHAijs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GU0iuiLBJL8ODV4Z4rVAsF6Gz0dfKrmnRb5sOLl9ISS9IyvsaSTw3OdYySjqFLcrV9SY51DgdSaaFCtzHkQvCffsJL0eHwn0V6OiY3ghm5eC2V7MBtUX8uMyM4YzuB7R8skR+Gmz89Dz0ju5DJ1Z6wJdFiSYIUkv16e/3mlZBtc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cgz7ubki; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cgz7ubki" Received: by smtp.kernel.org (Postfix) with ESMTPS id 4B8DDC116C6; Tue, 25 Nov 2025 03:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764042421; bh=4J3g5j51PBpP7n9+7mbzEOrB/xPKifWDPpyCNDHAijs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=cgz7ubkiHQB+YPvJjBzXk4y4/EV4gcWAmbVLc9+A7mGlbLiAsHv00zS3SGuF2N9aF VyqXCQ6D7dw8cIQZaSQ4sG7u0t/E2pWBSYUP+Z8h/+drd8hCqLZ3+45dRJXZLSiuFh 39gpW9CIX1/DW3yOiLAg4Dq8t93re1FqQqsdJ5XPGRSxLxnmqestJ4CyQt/DmxiEYg IOkTImNfBARJIkn887xFp6rMYtXOabmoRctYC5YcEEIw4BKmhOuAFLTNJF1KSQ51vh gG6qbhc6zS9xJf/GEr5dcms/AuZFvYUOk7foWfB2Z4IJKAJabJKIocxwHDmV9Z9kUq JdlA1ROCY5/Gw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 408A2CFD315; Tue, 25 Nov 2025 03:47:01 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Mon, 24 Nov 2025 19:47:00 -0800 Subject: [PATCH v5 1/4] arm64: dts: rockchip: Add light/proximity sensor to Pinephone Pro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251124-ppp_light_accel_mag_vol-down-v5-1-f9a10a0a50eb@gmail.com> References: <20251124-ppp_light_accel_mag_vol-down-v5-0-f9a10a0a50eb@gmail.com> In-Reply-To: <20251124-ppp_light_accel_mag_vol-down-v5-0-f9a10a0a50eb@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta , Ondrej Jirman , Martijn Braam , =?utf-8?q?Kamil_Trzci=C5=84ski?= X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764042420; l=2100; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=P3jxHkWmNKoMTa/ZH2mI0b285/Gcq9KBGUYb5ASdyDI=; b=ePPb+2twvyymvlXtx7y6tuGBD2TrnI06XJtJAi3RUVXg/E81weVnx5FMV9z0bHTAH20GUuxG9 lLv17Ls0n5dAqqvlqB7pJBDa+PTWHU6QL7vHzdUvjEfz7SL7brgj+V+ X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Ondrej Jirman Pinephone Pro uses STK3311 according to the schematics. Tests: ~ $ monitor-sensor --light // When the sensor is exposed, it get's fluctating values such as Light changed: 1.800000 (lux) Light changed: 1.700000 (lux) Light changed: 1.800000 (lux) Light changed: 1.700000 (lux) Light changed: 1.600000 (lux) Light changed: 1.100000 (lux) // When covering the sensor, it prints a low value and stops printing Light changed: 0.200000 (lux) ~ $ monitor-sensor --proximity // When it goes away from an object Proximity value changed: 0 // When it comes near an object Proximity value changed: 1 Co-developed-by: Martijn Braam Signed-off-by: Martijn Braam Co-developed-by: Kamil Trzci=C5=84ski Signed-off-by: Kamil Trzci=C5=84ski Signed-off-by: Ondrej Jirman Signed-off-by: Rudraksha Gupta --- arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/a= rm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 6f97e57f36f5..2d2858ee149e 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -520,6 +520,16 @@ touchscreen@14 { touchscreen-size-x =3D <720>; touchscreen-size-y =3D <1440>; }; + + light-sensor@48 { + compatible =3D "sensortek,stk3311"; + proximity-near-level =3D <300>; + reg =3D <0x48>; + interrupt-parent =3D <&gpio4>; + interrupts =3D ; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&light_int_l>; + }; }; =20 &i2c4 { @@ -689,6 +699,12 @@ vcc1v8_codec_en: vcc1v8-codec-en { }; }; =20 + stk3311 { + light_int_l: light-int-l { + rockchip,pins =3D <4 RK_PD3 RK_FUNC_GPIO &pcfg_input_pull_up>; + }; + }; + wireless-bluetooth { bt_wake_pin: bt-wake-pin { rockchip,pins =3D <2 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>; --=20 2.52.0 From nobody Tue Dec 2 00:26:06 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8FCD1E0DD8; Tue, 25 Nov 2025 03:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764042421; cv=none; b=h3ZGzBEkUPfPUsYeLCAmNAyE2lg7We4+bi1zv2Rt6ST+pjhMiYrSGeJbqC5Ylbhfh6sBNjQ86AKjQIWAS2GDbxVQlpOhfllDLCxGeGgiQjIw3xYhm7WjwN2cdtfPfguYILXn7Qd71J7EGx9SoWJMtiX090b30Iowmt9wm3K0cR8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764042421; c=relaxed/simple; bh=ycM7LXSKbuEanMKnAqYP54DyEq9xsY1JOHTdVmdmdrs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QiFGAltuHlkdw9NwcsErT9Zxu0MsgtW0T3usHBTNnwAqB1mxuuGbMXCffZ3WL0FVUhqGspZLlXVg6NNcGYpVqo8bPzhemClXE1mTiRORBgADR+SKD7G8CCLGehC+/RLZ7f2em0m7+t/U/XJceuk+Du8YbeoI6GkFIeYihx0hhjk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mZvPGvwS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mZvPGvwS" Received: by smtp.kernel.org (Postfix) with ESMTPS id 599AEC116B1; Tue, 25 Nov 2025 03:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764042421; bh=ycM7LXSKbuEanMKnAqYP54DyEq9xsY1JOHTdVmdmdrs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=mZvPGvwSZmfA2Xv76Eaoh2Nq0QduKe/rrFDuNLRmF/sovTWu3WznWhVDq6e1yEPJk +5G7RUN3Rp7iTWY2fkJpJysWunIJ9gHAZ380zQpx55Awp4Qh46x1TwP+iSuAN29LIT 4lbbLltn6usdBq675cH6sf4FTuqAEMLeNIczboIUgG6qGh+1XyK5ZEFGiMT3mkhGG3 0DMU7kpCUM/Pj+bxV1Hl+Xa1xPYBRlAC16We5yjARQvEV+DWBsmNi759fYcvlcYZBf m4S12vBolPLc/EFPSw2MG0MG681zKTlI7Pxi+pZUZ1yId+klJa7srRMhsNSXLHjZzp cqAHFcAZ2sebg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50036CFD377; Tue, 25 Nov 2025 03:47:01 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Mon, 24 Nov 2025 19:47:01 -0800 Subject: [PATCH v5 2/4] arm64: dts: rockchip: Add accelerometer sensor to Pinephone Pro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251124-ppp_light_accel_mag_vol-down-v5-2-f9a10a0a50eb@gmail.com> References: <20251124-ppp_light_accel_mag_vol-down-v5-0-f9a10a0a50eb@gmail.com> In-Reply-To: <20251124-ppp_light_accel_mag_vol-down-v5-0-f9a10a0a50eb@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta , Ondrej Jirman , Martijn Braam , =?utf-8?q?Kamil_Trzci=C5=84ski?= , Pavel Machek X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764042420; l=1266; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=owuI4HZdlvQp/fF0o2W6LK/Li46MndqpBMI0zHW5OxA=; b=FsSvN3r0QicnJ/w3S/WAeTY96iFwVszQDSQC0oT7MLn0LeC4PC5RFl3S5/VDEb1Y/4qGuCgQc ciIlNIszl9wDaFG9F9VZCx+tlca+23MeQ1xrJPXA0fj6iVKW99UO08h X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Ondrej Jirman Pinephone Pro uses mpu6500 according to the schematic. This was verified via `monitor-sensor --accel`. While rotating the device, the output was correct (eg. when it was face up, left edge was up, vertical, etc.). Co-developed-by: Martijn Braam Signed-off-by: Martijn Braam Co-developed-by: Kamil Trzci=C5=84ski Signed-off-by: Kamil Trzci=C5=84ski Signed-off-by: Ondrej Jirman Signed-off-by: Rudraksha Gupta Reviewed-by: Pavel Machek --- arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/a= rm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 2d2858ee149e..f8c74b43ae9f 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -543,7 +543,13 @@ mpu6500@68 { reg =3D <0x68>; interrupt-parent =3D <&gpio1>; interrupts =3D ; + vdd-supply =3D <&vcc_1v8>; vddio-supply =3D <&vcc_1v8>; + + mount-matrix =3D + "1", "0", "0", + "0", "-1", "0", + "0", "0", "-1"; }; }; =20 --=20 2.52.0 From nobody Tue Dec 2 00:26:06 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF94827F727; Tue, 25 Nov 2025 03:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764042422; cv=none; b=aX4Gb8O3xvNo1B1z3RJ5LzAwtqTlXO7y+7VjslJtPEbIytCxAw6To+7jG22V/3hDqduJ+28If+N1/aBxp2obe4IBmy+fy5anvC84F4QAV9ZbiWxshwr6EbeZUhy4++wiT1jcmblnAMC8zJP5Y9wedKarlxjN6t30IUqPf2OZjlw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764042422; c=relaxed/simple; bh=5l7nup7DC0Y8dqHhsU6KY6mQSCmRILk4Zjbco+Fq9Jg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=T0Ugx6gh+wQkQ4HNurHW/MAMtuIcjwMGFEpVDY+rA1taeGGbb9V5VGWao2hXCS6txio0ry8MIs8UypG2e/zBhHL6tEyneAKAHF2mCH3yg1LgslMPSEWpxi46d0xk24ytICPR4AL6rLRV5e22+T6wMGbqPay4pc17bMogL/13B7E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G7rQxDp6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G7rQxDp6" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6B11AC19425; Tue, 25 Nov 2025 03:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764042421; bh=5l7nup7DC0Y8dqHhsU6KY6mQSCmRILk4Zjbco+Fq9Jg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=G7rQxDp6LFp6SImskkZNkYHvZPColq6OuCe6e4ZatPWGKyMNMwN6pTbMa5mc4UrL8 JJfhHqaO99P9+y4crcXyUSo73vOwoOLudUyuqhazf0q7CQS8Jp0n5mVy0t/a3kUdBx b+5+c8gTQmWLEvQ/6lhxsplLxr53X+4Z39DX5y6BfGw5jXbV72FkR1b28GFXlWpXQO NvClOrdOYnW1Cn+v0cc4xmFq226HIfN2QLIe9QdTM6JXjHnfToPuQ3iEa01xGGnz5C LTSEEvim94ktPiCaakYMkpE3ttBexenN8dfJTp0K2d3midMmVyyzsL6E/TE3ooYyvH ks0APOMsFFlug== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F4CACFD37A; Tue, 25 Nov 2025 03:47:01 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Mon, 24 Nov 2025 19:47:02 -0800 Subject: [PATCH v5 3/4] arm64: dts: rockchip: Add magnetometer sensor to Pinephone Pro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251124-ppp_light_accel_mag_vol-down-v5-3-f9a10a0a50eb@gmail.com> References: <20251124-ppp_light_accel_mag_vol-down-v5-0-f9a10a0a50eb@gmail.com> In-Reply-To: <20251124-ppp_light_accel_mag_vol-down-v5-0-f9a10a0a50eb@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta , Ondrej Jirman , "Leonardo G. Trombetta" , Pavel Machek X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764042420; l=1356; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=6kNPA+rufMDaioiLjzVrw3yC2YKarI4Xs7vCiBTyO0Y=; b=mjYYXO4VbxbQzJyStmB8AZAeOSbBj75gjJppJVbTQOdHHt/2CWOeQhbgrytShK5eHi5ku4QNZ fuP4qIKj7w2AxQqtJKaj3+ht/F8kA6jIf1mEFpB6PerrijUO2jTOo6z X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Ondrej Jirman Pinephone Pro uses AF8133J according to the schematic. The mount-matrix was added by Leonardo on top of Ondrej's work of adding the magnetometer. It was verified with Leonardo's compass app: https://gitlab.com/lgtrombetta/compass Co-developed-by: Leonardo G. Trombetta Signed-off-by: Leonardo G. Trombetta Signed-off-by: Ondrej Jirman Signed-off-by: Rudraksha Gupta Reviewed-by: Pavel Machek --- arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/a= rm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index f8c74b43ae9f..03721d71766c 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -553,6 +553,21 @@ mpu6500@68 { }; }; =20 +&i2c4 { + af8133j: compass@1c { + compatible =3D "voltafield,af8133j"; + reg =3D <0x1c>; + reset-gpios =3D <&gpio1 RK_PA1 GPIO_ACTIVE_LOW>; + avdd-supply =3D <&vcc_3v0>; + dvdd-supply =3D <&vcc_1v8>; + + mount-matrix =3D + "0", "1", "0", + "-1", "0", "0", + "0", "0", "1"; + }; +}; + &io_domains { bt656-supply =3D <&vcc1v8_dvp>; audio-supply =3D <&vcca1v8_codec>; --=20 2.52.0 From nobody Tue Dec 2 00:26:06 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FD1927FD59; Tue, 25 Nov 2025 03:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764042422; cv=none; b=H7u3rIVKFqF5eBRpSoKOqmqkX5i6h4VJ+3CtgLd0j1QAiXDA9/PiJvXRoM7aBqu8c76V9M0L9oAvvxFN59eg9ERV28x3nTooIc4eRqF6RKU6pwGh8SZ9w3GcDHnbl218359hzjReRK+MnEzbRM0ufBiK53RkO1T8I2ZwLuDYnZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764042422; c=relaxed/simple; bh=U2sKGfrG1AuXfw/WKYwLvQsUXr5m8ldv6cClmddJY0w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YuzhemNd2cHWvkMMYbcYdoeOhho0pnqswh34FEhwTTyohzliD0/g/PXM1upQ5bbCPnGp9jlbVpxsLf/ymFb0ws/UG5av2JOeu5OH2mg7CHovTiETT0F1xwIw5I8tQhvcw1ZhBoddlmVtO9Z5bLenmMaPPLbrRlzTMupcCfjpNgE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=quWUt6dY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="quWUt6dY" Received: by smtp.kernel.org (Postfix) with ESMTPS id 93C5EC19421; Tue, 25 Nov 2025 03:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764042421; bh=U2sKGfrG1AuXfw/WKYwLvQsUXr5m8ldv6cClmddJY0w=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=quWUt6dYC5b3SpWV9Rye7QkchNc+YUPh0c07GZa6QaIChSx+yKRnghUkDylLw3CY2 GxvxziRFCaI7e7ciC0TOlO/ux7iVCdLH6hcdkZtbGVoR2yxlTFRwZiSElB8z8abPSA ztJVURMqyMexZQtovSdr+jXwk7A0sup7hFOJxITs8LTmR6WMXqAr3srfUStRn9sNBr 8TYqNbXGtI/iFMoVd7zsxzkg/YLcOd1RQsOKHqTbiCu3XG38tqbG68RIPGMTmJuydR G1YvuU5ChwnRNCxbcz8F2CgSTQuvVJCPgbVggnEMQ+/EeW9o/xEzoMf6G/OG5P7GlM Ajr3zj6sqQsVQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BD3ECFD370; Tue, 25 Nov 2025 03:47:01 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Mon, 24 Nov 2025 19:47:03 -0800 Subject: [PATCH v5 4/4] arm64: dts: rockchip: Fix voltage threshold for volume keys for Pinephone Pro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251124-ppp_light_accel_mag_vol-down-v5-4-f9a10a0a50eb@gmail.com> References: <20251124-ppp_light_accel_mag_vol-down-v5-0-f9a10a0a50eb@gmail.com> In-Reply-To: <20251124-ppp_light_accel_mag_vol-down-v5-0-f9a10a0a50eb@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta , Ondrej Jirman , Pavel Machek X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764042420; l=1551; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=8q5u/rrJlx+VcAI9BxZ+DVAqqoWsJx3wKRY3rg0cQgg=; b=5gNGjBiWQzw+Cia1/yrUL22IXp/WlWSV5+18Ip8iwkRCq8OzW9u5aVpnA8oMATmi3zDk8EYum FxWAeo9EsGXB2vf3+jyx5RVRoYyMrBeFOndSq6t47IXjeuNAi18CpJ6 X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Ondrej Jirman Previously sometimes pressing the volume-down button would register as a volume-up button. Match the thresholds as shown in the Pinephone Pro schematic. Tests: ~ $ evtest // Mashed the volume down ~100 times with varying intensity Event: time xxx, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 1 Event: time xxx, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 0 // Mashed the volume up ~100 times with varying intensity Event: time xxx, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 1 Event: time xxx, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 0 Signed-off-by: Ondrej Jirman Signed-off-by: Rudraksha Gupta Reviewed-by: Pavel Machek --- arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/a= rm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 03721d71766c..5de08a155d10 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -40,13 +40,13 @@ adc-keys { button-up { label =3D "Volume Up"; linux,code =3D ; - press-threshold-microvolt =3D <100000>; + press-threshold-microvolt =3D <2000>; }; =20 button-down { label =3D "Volume Down"; linux,code =3D ; - press-threshold-microvolt =3D <600000>; + press-threshold-microvolt =3D <300000>; }; }; =20 --=20 2.52.0