From nobody Tue Dec 2 00:25:20 2025 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76EBB313E3F for ; Mon, 24 Nov 2025 16:17:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764001024; cv=none; b=HqSaj3uVfg7/hOmA6cNd4fdpB3ooWYMtdUQvntDxgoBLY6u/9wo35cbRhp9AYxTwfGB+dAJ42QZFdbA3kE+XMKcs/cOlzmFjD6Ex1ttkL5o7nKks9Rh+JRgQrVD/WA2Plr58OC6yU0GEnKm6xuvbqFI7xmQ2Dm+wmDewhWPpT2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764001024; c=relaxed/simple; bh=s8td4kwv49gxwghLpvZt/8ZICA2Cl6ibpd/jilHhWMI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=bQW/ZRSOvUaJwRwFS8Y1l4XaUXz71LZoF2P47z1BJCOuqPGXIKQE0nnA3n5AbFMnDV6X4BiF8aEqWckjwJ6zgRNO5eZg4G63wdqvn9t87QUg5iOlMbykxls+wyQuP6o/PeN0rVfYncfPfDtTyjm+2Rta2hNRNGUXH+rSO5EcWTE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RYSNd9tb; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RYSNd9tb" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5957d7e0bf3so5216172e87.0 for ; Mon, 24 Nov 2025 08:17:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764001020; x=1764605820; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=r6R0clNbUmj3qJHOh4GOPaicob3aNEXinPfPEisg7I0=; b=RYSNd9tbeLz4DeoMMsKxdTnHa8U/gLG1rtxuEntgjY06N6XViabm6R4e67y4jCxTer vZ1+6eGRkKqfybCi2Lvxx1Npr3qW4BfAnQzXiwiQGMWfRo0WjB7LtwYBh/i15qR9PkEG qBIqxDF82OKwJldqANaW52nemrJx9/+jAnp8wqnTOFB33FHfFXBh5v/bHnAKgSX4kGEU +6yXawuBUa5GQKRDxRC5doZYxvIw4/ViS8ReOs/S3/et55zcfDeYGIR1bsyFc0xq0lyz J4X0ND2hzRJk3l7hqbAX9kR1eYWrbaymMoWruEsq8qal3TOYgpkEgNxY0hQq5FLniLiI Q0FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764001020; x=1764605820; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r6R0clNbUmj3qJHOh4GOPaicob3aNEXinPfPEisg7I0=; b=vzxbf01gp+s71kbX7yoyvLE+vojX41lPTAoHtAiZ3TVaxF+Aip4aNPWz6cyGj7uXUx 7JgBjRJ49bLHBi6iFgZa6ljjb4AUGKYkL81ymWLyg4ViGlNftB3uo/U9ixOzjt+Xwe2k FIMV+ZvGQa+tWx0W3OH/qwSD0IY9DN1TtyHK+641vGT6z2aX5viX0SeDAnmXis4AfaXe O9eBERdfJdrJLtSLHW5MER1XdmLJ3SdKoDuXqcJXdioNPs4076ZkjYEN8wuk3UjfZuDF dyWVEtphVQ9ncNBZ8nhCDbIi4DltuERaNoigBTBNBJOKFYrkmbXOe3BF0kAgvgaPMeXJ Mkxg== X-Gm-Message-State: AOJu0YxdWFGOn22I+4vGiBOIM5CcDUm7xc02gEDdtES8F1uTx2Zb3wSF YzbjxQcvmsN6iAmVVXhbUM7MZbJKnt04MXpWpLpJhXZhlVpLzEILEZRfeasMGg== X-Gm-Gg: ASbGncs92Afojds4AJ3JSa3CQ6T0OFbBWIrSOHX7jvXCibbZ09i5V3PliON3rOVuiMV y6ecO9sXYyCvAJnLmsCy8v+QwTRyLuUtciQs5gwUcF8cripsU+g8A0MiV9T8ru4+MGaGxwRTQdm XiwghyuaXkfHjaAx9hr8j+K29+uBKcOhrgOKawAvDOvjzYgseqi483cOHJrsDpSXu00NVSJ5j5W ArS3HrmZK2VwoJCQMPU7nQAENAtq3McQVDHoOGzGVwGERpzx2LFl9iF+dY97ye0WmLafZl+1FUd CzI5ELM0KeLWsqdW6XfmcHa2QAB/R52vo/KUeEJeL6Wt3QpQJX3XHej1CRIsRQ3LTP2foVYpLGk Qp7TnfgUEsWvsvRV92raArQ9yaDedY6revzEIi+CIFuSxhU/+qVF4bEYtn71doEQsRCofxVMIr9 Ka2qHoHpomJV13Gtm3I1mOk5IZfgHWDpHVXzTZ/hwhyj39Wti8nvpWUFz2QkKCwtWFHnE= X-Google-Smtp-Source: AGHT+IE3WAh7C8gXkuk7atEwSFgb9OZtjro/4nPYFhyRkM+nahunRzEyLJnItAuml3bPwog3Bu2iKg== X-Received: by 2002:a05:6512:2216:b0:596:9cf0:fb85 with SMTP id 2adb3069b0e04-5969e9d3099mr5722980e87.4.1764001020279; Mon, 24 Nov 2025 08:17:00 -0800 (PST) Received: from [192.168.1.168] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5969dbbee86sm4298862e87.49.2025.11.24.08.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 08:16:59 -0800 (PST) From: Marcus Folkesson Date: Mon, 24 Nov 2025 17:16:51 +0100 Subject: [PATCH] Revert "mfd: da9052-spi: Change read-mask to write-mask" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251124-da9052-revert-v1-1-fbeb2c894002@gmail.com> X-B4-Tracking: v=1; b=H4sIAPKEJGkC/x2MQQqAMAzAviI9O2g3J+pXxIPMqr2odCLC2N8dH gNJEkRW4QhDlUD5kSjnUYDqCsI+HxsbWQqDReuJbGOWuUdvTXFZb4PUNQE7dA5bKM2lvMr7/8Y p5w8JA0ayXwAAAA== X-Change-ID: 20251124-da9052-revert-0184c0803306 To: Support Opensource , Lee Jones Cc: linux-kernel@vger.kernel.org, Marcus Folkesson X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1136; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=s8td4kwv49gxwghLpvZt/8ZICA2Cl6ibpd/jilHhWMI=; b=owEBbQKS/ZANAwAKAYiATm9ZXVIyAcsmYgBpJIT13QPu4rujNtF/iGIwr/1Eh7RzpOBueo1vg Z8fRdkJkwGJAjMEAAEKAB0WIQQFUaLotmy1TWTBLGWIgE5vWV1SMgUCaSSE9QAKCRCIgE5vWV1S Mn67EACmcs8DGi+nRMCenw4g5okgdKiOwf7OEJN1MYzsjuNyejn802Oq7VhfvyjptsRDfYtfSvq wz2iJ2pGwSelIJHtwKwQQ8+ga7+z3OCVKQlos+eGd+13kp+nabfHp8fVK4I2HRkrD8HrSSYP9WW tJpZzUMFpzfsbXQKMBzv+Rc76CZNO957T1qJ82+zSxRqcpkEVPeMlLWb6YU+tFI/3UtuYIWdvUq VP5YbxNsRmGVEu7rU9XJO3YoLKuL1tTOV6+gVBKxTenq0chCgqcOxNTeJwkUnBz1VjdNAzwMKdM 2TM3EKtXNVHEhRHUk7FgbPoAh3AwEQ7qFOAKLa9uWi6+K24DwK8X3+bKe4fwoJIFe7+yvt7hNKz V41UUv1ZUvGaFKWKV7fnlBFkcyqkGhjlsLXDMD6XbPXY9gYXRN127bozHshhJ4ClEFH7jv/NbBJ d9O40cZk0ipGrRUeWmnn4T2AQgVfAcvt3is4ot/NAEeBhGrRt0NqyhXoSWXJEtY7ACsWSngrB2M ykp1meiA5xKserNEVk9MappkTtsMr+KcjCnI2uVp1lEm2/EuCCcGlLRN4BjbN7yM1O+ByEfIIXP 8ilOS7orePsZ+EUGr/MjT3Y4wT9lKSsDbFawaDSYyaGtcddjJV0yNRDHQ6V1MhNc4xUmH0d8JV8 qxC2MC2BVYv3mzQ== X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 This reverts commit 2e3378f6c79a1b3f7855ded1ef306ea4406352ed. Almost every register in this chip can be customized via OTP memory. Somehow the value for R19, which decide if the flag is set on read or write operation, seems to have been overwritten for the chip the original patch were written for. Revert the change to follow the default behavior. Signed-off-by: Marcus Folkesson --- drivers/mfd/da9052-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c index 80fc5c0cac2f..be5f2b34e18a 100644 --- a/drivers/mfd/da9052-spi.c +++ b/drivers/mfd/da9052-spi.c @@ -37,7 +37,7 @@ static int da9052_spi_probe(struct spi_device *spi) spi_set_drvdata(spi, da9052); =20 config =3D da9052_regmap_config; - config.write_flag_mask =3D 1; + config.read_flag_mask =3D 1; config.reg_bits =3D 7; config.pad_bits =3D 1; config.val_bits =3D 8; --- base-commit: 552c50713f273b494ac6c77052032a49bc9255e2 change-id: 20251124-da9052-revert-0184c0803306 Best regards, --=20 Marcus Folkesson