From nobody Tue Dec 2 01:05:43 2025 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CA102E973A for ; Mon, 24 Nov 2025 07:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763970062; cv=none; b=cClX3CER/JmlU74TaD7BTD9HSX5iuHrLhKbptvy6CtQ7bYuz58RnCeGuaRcfpkxZt+IWNXLv+PCfQpcxcQlQ0zrPYktCi8ES/oJb8g460Q7+k6SBWVA+wr6m4ygvnzWt0G794OntmLQZKnF7sSuHGWHauzU+JLxBP26BI5uJiAQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763970062; c=relaxed/simple; bh=Usqx83ivKY4w0KNMbSY7X0Z+d+La037+pNfmug8W6AY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SWWNH1p6h1o0lce8EgVBYD4x4pG2aubcak+ufWd+yzpy9Dq96yNVRPvcWHIYOw3o7SkQ2hZbAkT/cMW1ThMgWycrzt74Hs6RGng8Ge7ZagnF4ElvBId62WR9Zi9hpdevzn+1U8t6+iaSz5IC8pibruM+fv/xyHOjoJafDJfnQkk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dVE8HIYO; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dVE8HIYO" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7a9cdf62d31so4867616b3a.3 for ; Sun, 23 Nov 2025 23:41:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763970060; x=1764574860; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=I1gxk1DsHCEeyciyJk4Gm3Xoh1TUbmw4WS4h5BWbH44=; b=dVE8HIYOWxYwU7fsMbzdoWvka2acM2IzeSjadWIrBOCaX9q6dvMzocxxtmD2yUfPzJ JLEIdVHEKTxcVxTiTapZbsMzuYpj04LJXa1hIGXnbonDhets1nO1SpNp3H8j0fuAVhw5 3XTPVrfoTVqKmoQuMXkWzCRMmYHwRZlTygoAIa3+YMI3Q2kNPgmc5qqT4LVcBRQkIR4r 8q7dcMZ68Gy4WRIpegMh4h1aeecMrPGHxLUkPti5VYt+5H77lKLgpk94j3zzVSxPmF51 pI82hQhrRiKX3589CyK6zrjXslamN8At2+8KZZY/49n/4cvLsu1A1X5MyydCExtSvj1D wreA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763970060; x=1764574860; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=I1gxk1DsHCEeyciyJk4Gm3Xoh1TUbmw4WS4h5BWbH44=; b=GFbkPeU1G5ntk+wXlE5XSU45GFyPWo8PfYeybGIHFFW6987oOeYHP7VQY0Mj6yFPZZ bVWhP2p/FHRcAcuU42CMz+QcRKuezTsDmwBQBvkJWa1/JOCoCtkIIatWDYxyN2dgj2pZ AmhKD8IOzLVFJGYPCv2cqu5eoIgywDIU7KeCGowJMFRywI7wEMwBSKmz50Uuwoci25jF jK7PMwjff7QMlOWpzvWibo0uKaHEhqKa8bNRdMvb/HIq0uVRUkK1MEkaDSc+6iDlExwb 09vP7HhmrnMztwmVz5V/YXLMiB/lxkPnNP5QQJIFW9mQCDvpFuXsQXxt9k4u12FDE0q4 UmHg== X-Forwarded-Encrypted: i=1; AJvYcCV+pYhnzE1txS5b5bFBYAKX8l6PxTkUiuTBvY3HajjUxej618BTWt7CVGQk/CgKFi3BC27AxmwNIuVO6mM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxu/4bsWnjGq9goDjj3LXywLoESitQHZ99PtuB3g9bygiROgxnp jUR6C7E7PhJFBzqGKB6ENB/92+RBIN6nhSYnk3WjRBoMJti8hc+3H2CEnb4m0g== X-Gm-Gg: ASbGncvMARW0tFg8Sz59zGYjr0uE4u/emuGO/n9UjD1ZO36kfEWdvD/HPLrojQGYdyQ wkpYetoh3sdS0Hlrh1ZoYn791BKoQdygWXETiJufIIZw4dD3t8w5GIchYZqSamvI275TB0rKp2X OekU/ME8YnSjyT7PppUznEiKvRsNxzZu19qaDjDL9+YUq/M50EKNtTub3WkHWjmluMEcN3XzI2F lUKjIBZ3R2sOVleXrmANTXbQJG+n1hNuZZJK/mm2arjvNEZKr7xyeRqGBH5EDgfiZVkXyTPQiBu CDL4/eXWoAnqGxmPghauUKJkHxotrDA2kvr+/BDGc6/Z9s1QfRbWBIWi23gEjoNBNdyOBmYKQme OlK99etJeW07YvOPxCFY4al+ynbTyFEuNEhvAgBrn93CEc+rrtEQqZslPYz0ZLBb918VPTJ3MFt 4y3FTb314y X-Google-Smtp-Source: AGHT+IHfmjaPhmxevuKoc2EwOR5VBTWwkzOxUx7y1W2AyW7Z2BnA/hIC6PVmsv9rbVMC2nmz9/O3bg== X-Received: by 2002:a05:6a00:9286:b0:782:5ca1:e1c with SMTP id d2e1a72fcca58-7c58e112b18mr11801430b3a.21.1763970059740; Sun, 23 Nov 2025 23:40:59 -0800 (PST) Received: from aheev.home ([2401:4900:8fce:eb65:99e9:53c:32e6:4996]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f024b4aesm13410818b3a.33.2025.11.23.23.40.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Nov 2025 23:40:59 -0800 (PST) From: Ally Heev Date: Mon, 24 Nov 2025 13:10:42 +0530 Subject: [PATCH RESEND RFT net-next 2/2] idpf: remove __free usage in idpf_virtchnl Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251124-aheev-fix-free-uninitialized-ptrs-ethernet-intel-v1-2-a03fcd1937c0@gmail.com> References: <20251124-aheev-fix-free-uninitialized-ptrs-ethernet-intel-v1-0-a03fcd1937c0@gmail.com> In-Reply-To: <20251124-aheev-fix-free-uninitialized-ptrs-ethernet-intel-v1-0-a03fcd1937c0@gmail.com> To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ally Heev , Simon Horman , Dan Carpenter X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2680; i=allyheev@gmail.com; h=from:subject:message-id; bh=Usqx83ivKY4w0KNMbSY7X0Z+d+La037+pNfmug8W6AY=; b=owGbwMvMwCU2zXbRFfvr1TKMp9WSGDJVuP9Y31rts6Yue0fpcp8Xt5s52FwP73Fh43N8EaW1s dWgyFyto5SFQYyLQVZMkYVRVMpPb5PUhLjDSd9g5rAygQxh4OIUgIlo5zMy/FEUvO7e3Pxs86K9 RfaGpfPvTAqO+MZd3tn72qxlLY/MB4b/SX+vKAcsEPTaNJ2H95DAts1Nuleqr6c0XA2vXWmrlbq XCQA= X-Developer-Key: i=allyheev@gmail.com; a=openpgp; fpr=01151A4E2EB21A905EC362F6963DA2D43FD77B1C usage of cleanup attributes is discouraged in net [1], achieve cleanup using goto. In this patch though, only uninitialized pointers with __free attribute are cleaned as they can cause undefined behavior when they go out of scope Suggested-by: Simon Horman Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/aPiG_F5EBQUjZqsl@stanley.mountain/ Signed-off-by: Ally Heev [1] https://docs.kernel.org/process/maintainer-netdev.html#using-device-man= aged-and-cleanup-h-constructs Signed-off-by: Ally Heev Reviewed-by: Aleksandr Loktionov --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 28 +++++++++++++++++----= ---- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/= ethernet/intel/idpf/idpf_virtchnl.c index cbb5fa30f5a0ec778c1ee30470da3ca21cc1af24..5b2bf8c3205bc1ea0746f78afa2= a24f3f8ad2a8c 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -1012,7 +1012,7 @@ static int idpf_send_get_caps_msg(struct idpf_adapter= *adapter) */ static int idpf_send_get_lan_memory_regions(struct idpf_adapter *adapter) { - struct virtchnl2_get_lan_memory_regions *rcvd_regions __free(kfree); + struct virtchnl2_get_lan_memory_regions *rcvd_regions =3D NULL; struct idpf_vc_xn_params xn_params =3D { .vc_op =3D VIRTCHNL2_OP_GET_LAN_MEMORY_REGIONS, .recv_buf.iov_len =3D IDPF_CTLQ_MAX_BUF_LEN, @@ -1029,21 +1029,29 @@ static int idpf_send_get_lan_memory_regions(struct = idpf_adapter *adapter) =20 xn_params.recv_buf.iov_base =3D rcvd_regions; reply_sz =3D idpf_vc_xn_exec(adapter, &xn_params); - if (reply_sz < 0) - return reply_sz; + if (reply_sz < 0) { + err =3D reply_sz; + goto out; + } =20 num_regions =3D le16_to_cpu(rcvd_regions->num_memory_regions); size =3D struct_size(rcvd_regions, mem_reg, num_regions); - if (reply_sz < size) - return -EIO; + if (reply_sz < size) { + err =3D -EIO; + goto out; + } =20 - if (size > IDPF_CTLQ_MAX_BUF_LEN) - return -EINVAL; + if (size > IDPF_CTLQ_MAX_BUF_LEN) { + err =3D -EINVAL; + goto out; + } =20 hw =3D &adapter->hw; hw->lan_regs =3D kcalloc(num_regions, sizeof(*hw->lan_regs), GFP_KERNEL); - if (!hw->lan_regs) - return -ENOMEM; + if (!hw->lan_regs) { + err =3D -ENOMEM; + goto out; + } =20 for (int i =3D 0; i < num_regions; i++) { hw->lan_regs[i].addr_len =3D @@ -1053,6 +1061,8 @@ static int idpf_send_get_lan_memory_regions(struct id= pf_adapter *adapter) } hw->num_lan_regs =3D num_regions; =20 +out: + kfree(rcvd_regions); return err; } =20 --=20 2.47.3