From nobody Tue Dec 2 01:05:44 2025 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 010192EA481 for ; Mon, 24 Nov 2025 07:40:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763970056; cv=none; b=QplITwam0c4XJs/3yQCbq9oHnWPO6I48BRFcZu9eqjlgCqUzXuw9Fig0rIObz/LyhUQi1dRbjZ2ez42VFBh8hgoc4oUDNlkUVFGwj0uZvCbkEvZOvdxe5N02yN37zuDlXZfS2p6K4kEl8ARgEreCzKdW10VP3s4jIyNFHlcPiZs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763970056; c=relaxed/simple; bh=ufCbvxIRBVQHCzUSRhXUdWL2YVW5ycqhQc1EXb99qW8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fw2F/NZJKEbd9Gsu1wUOTx+LFxYBAiJJbYVxESA0R0pMK+ngo0UruL5GkcbZxdqcabWTe6ixf89ChJkq1GsM9bvyOWHpsEcxFszTmy5cn5GT2yTycmuxR57A78EvuKuxo5UjuZAX+KSkAH5HvoNP3wYlBtY7/JxhGbAneg3VeMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l8KGulUx; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l8KGulUx" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7b80fed1505so4518211b3a.3 for ; Sun, 23 Nov 2025 23:40:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763970054; x=1764574854; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=R+K9MAxb4ZBBa8U7x004Sm9bCoWfglzoRMNcWRH1ZAc=; b=l8KGulUx7MjlHjMos/qgnBHgPA8K7nTPU3wmGqlkx9ygstXS2OhAD2g73wmJYLnOD8 QcmO4X6IpNMJMXKNLKOYiaPGRMuLAXlQEDah89teGY1YbJyMgMgljnacdeDJjTheq+li j7dDTBX6WHI0gcs0s9IHGi4Wm4aK3r+PgjH2KqGevJyIXR+S+4aQTmhm9oiFycTG062f B628nvA5/v+iLeqp9hRX4uaF2EzgWEcrWrvtuhz/BihOcVk86lEEPeY+KwLF+lVkl5HQ j6u+lHvpJaNxQUjr4tE/2e0IBKAXwogc/UIIBEA3UygOKZ8COJX2K++sXJwFBb4153fZ zi5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763970054; x=1764574854; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=R+K9MAxb4ZBBa8U7x004Sm9bCoWfglzoRMNcWRH1ZAc=; b=dl+buvJ6735XErWMXRgVrrBTn5hgGdlAfTOSf+d2IZjsRSCN6aOGyO8PgA7HBk9D/j fPUJHed9RYklN+/NbEEErYyr89LJa1u6//Dx2uvsSkLUK43HJgkLr/IUWHCUMFETF0mF LKX5F6SMirVevEwQZraFKBF2Cn7FaSvyeGAYUjOvljNZSrZCPbGv0yMc75QUbCQAiqPQ vgqiDalfpgpRQkU8pEnv89ngZB3DhwkAlY7gQn0+f5ihU7W5ye6dy23YBer5AaOmGVrL 860vYg8D6gnv801e78iNw7VPUzjlOwmtwzDWkV3jE0oKcxDwMR9782CVrLo3jqFjH0Tu DbGA== X-Forwarded-Encrypted: i=1; AJvYcCXgcsvNl76ldBmB9vNlYq772+NkVEUsQRJsnw2J3HlgJ4BFPKvE/zi+bv1sYJwA7h1mOoqoJquAGgV+LXU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8iMGy+zuLhb5XozmFPagpGVbcCF5bTsz0I52Tgm+wvMl3PD/r hpWTShEECwUyfOHaKWgoVGRUek4bCB23ZinBej0Da09V0TpHDmLwkhzx X-Gm-Gg: ASbGncve5vcVOD+76gNsakmLHkUsZdE9MqhfZxc6mWXyRNlqju27y/0xz+CHxhDH8yi +BPY4A8eZzyRwRkb1+cRL9cLkBxiBhlGCC+Lulq7PWs6l91SEJnMpO2NLOmILseSWVRTvhZpoe/ QJQps5nbUmdJ9XMCNFY8Jc5WRnSUt2lh6Gwyrsgjn57KBjpjnY6yjKJD4g7s+qTnplwkXSVq33u s9eQs8wsmJfFxzflpXsc2iiERTecwRE46qyYWBB/FmYnmnSJDTx7oyu+si1oZKHAWJuA7Gg4GfG FJQEi/vBneYJRjaFJo+RfYlQUsAnbs6a0rxq00BLodqc5Fbqw01C8hjJ8X5kV+B32nKEZBn3Cl2 WLl7UwntKBUVczYOm7ltqHU8l1ftVfJQgVw37cVn+1GDRkpJkjdbO3aktLELq2V60oJl2Z6gKTG Z6F90r7cT+imwCs3dro/U= X-Google-Smtp-Source: AGHT+IEPYnRgpYVEveCbU01kGtjxHAKa5FApKeCv+NruF3NYPEK3DWUd1nec9k94JoygcajJ+fMyFg== X-Received: by 2002:a05:6a20:729e:b0:35d:5d40:6d65 with SMTP id adf61e73a8af0-3614eaf5281mr12077444637.5.1763970054294; Sun, 23 Nov 2025 23:40:54 -0800 (PST) Received: from aheev.home ([2401:4900:8fce:eb65:99e9:53c:32e6:4996]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f024b4aesm13410818b3a.33.2025.11.23.23.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Nov 2025 23:40:53 -0800 (PST) From: Ally Heev Date: Mon, 24 Nov 2025 13:10:41 +0530 Subject: [PATCH RESEND RFT net-next 1/2] ice: remove __free usage in ice_flow Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251124-aheev-fix-free-uninitialized-ptrs-ethernet-intel-v1-1-a03fcd1937c0@gmail.com> References: <20251124-aheev-fix-free-uninitialized-ptrs-ethernet-intel-v1-0-a03fcd1937c0@gmail.com> In-Reply-To: <20251124-aheev-fix-free-uninitialized-ptrs-ethernet-intel-v1-0-a03fcd1937c0@gmail.com> To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ally Heev , Simon Horman , Dan Carpenter X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1688; i=allyheev@gmail.com; h=from:subject:message-id; bh=ufCbvxIRBVQHCzUSRhXUdWL2YVW5ycqhQc1EXb99qW8=; b=owGbwMvMwCU2zXbRFfvr1TKMp9WSGDJVuH+fLT8i4MiarX3V2Zfz45EtZhER13qC9RZ2f5gsf 8Im5cfGjlIWBjEuBlkxRRZGUSk/vU1SE+IOJ32DmcPKBDKEgYtTACaiIMfwV6h4w7q5V16Ixuxm UhHxm80bEcQcUJAZGNYclnRZxP/0W0aGQ4tnBK49Nfv1myveZsyHYvm2Hlml7uQwOWOpUkzB7a+ LOAE= X-Developer-Key: i=allyheev@gmail.com; a=openpgp; fpr=01151A4E2EB21A905EC362F6963DA2D43FD77B1C usage of cleanup attributes is discouraged in net [1], achieve cleanup using goto Suggested-by: Simon Horman Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/aPiG_F5EBQUjZqsl@stanley.mountain/ Signed-off-by: Ally Heev [1] https://docs.kernel.org/process/maintainer-netdev.html#using-device-man= aged-and-cleanup-h-constructs Signed-off-by: Ally Heev Reviewed-by: Aleksandr Loktionov --- drivers/net/ethernet/intel/ice/ice_flow.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_flow.c b/drivers/net/ethern= et/intel/ice/ice_flow.c index 6d5c939dc8a515c252cd2b77d155b69fa264ee92..dd62f5f14d60401d6a24cb9f866= 64425db1532d0 100644 --- a/drivers/net/ethernet/intel/ice/ice_flow.c +++ b/drivers/net/ethernet/intel/ice/ice_flow.c @@ -1573,7 +1573,7 @@ ice_flow_set_parser_prof(struct ice_hw *hw, u16 dest_= vsi, u16 fdir_vsi, struct ice_parser_profile *prof, enum ice_block blk) { u64 id =3D find_first_bit(prof->ptypes, ICE_FLOW_PTYPE_MAX); - struct ice_flow_prof_params *params __free(kfree); + struct ice_flow_prof_params *params =3D NULL; u8 fv_words =3D hw->blk[blk].es.fvw; int status; int i, idx; @@ -1621,12 +1621,14 @@ ice_flow_set_parser_prof(struct ice_hw *hw, u16 des= t_vsi, u16 fdir_vsi, params->attr, params->attr_cnt, params->es, params->mask, false, false); if (status) - return status; + goto out; =20 status =3D ice_flow_assoc_fdir_prof(hw, blk, dest_vsi, fdir_vsi, id); if (status) ice_rem_prof(hw, blk, id); =20 +out: + kfree(params); return status; } =20 --=20 2.47.3