From nobody Tue Dec 2 01:04:37 2025 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B2241096F for ; Sun, 23 Nov 2025 16:20:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763914806; cv=none; b=XMPXGN9H4MEBQyFR8jR81AszstEkPdDWKLO5/DfBVPxm9DxBmE0LARyhFo/SmlWS9NLhZqaKVk9qqGhbv8J/G/NI1sbjm3hEALNIkawmcvImgLiPVYfqxFqGEm5fcUgZ94P9nuOwdH4QhAZ/7i8zVf/wRVYKHm1qxiqShA8Tcts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763914806; c=relaxed/simple; bh=zYJtYYD7Jj181z3xqKMizvHWFwwP/qA7bQ1YLcPYXZI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ki7FO5+mooAidBImWrTE8Hlcs5AzwSdK9mgtZ6vtdrOYIPHYIgW6yHU4sTeXcq+3b/6VLWEawR1yC+TtgxhUut2/nlLQGCsQNn3WonMOxAy/X0ZrW0oYwKmWh+GWxGGzHELXPHd9fiklGaE/hL7wFSrmaFBw9rupRaSDmo9QpPI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [114.245.38.183]) by APP-01 (Coremail) with SMTP id qwCowABn_84vNCNpZdnFAQ--.20314S2; Mon, 24 Nov 2025 00:20:00 +0800 (CST) From: Haotian Zhang To: jassisinghbrar@gmail.com Cc: afd@ti.com, linux-kernel@vger.kernel.org, Haotian Zhang Subject: [PATCH] mailbox: omap: Handle devm_pm_runtime_enable() errors Date: Mon, 24 Nov 2025 00:19:35 +0800 Message-ID: <20251123161935.1738-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowABn_84vNCNpZdnFAQ--.20314S2 X-Coremail-Antispam: 1UD129KBjvdXoW7GF45CF4rAw1UGr1kAw4ruFg_yoWkGFg_Gr s8ZF47WF10vF1rKw1DG343Zr92gFyrWr1YvrZYqr4aqayxXr1qqrWjvFn8Cws8Ww4DAFyY ka1UKF13AwnxCjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbwxFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr 1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48J MxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwV AFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv2 0xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4 v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AK xVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfUozVbDUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCQ8PA2kjIpcLXAABsj Content-Type: text/plain; charset="utf-8" Although unlikely, devm_pm_runtime_enable() can fail due to memory allocations. Without proper error handling, the subsequent pm_runtime_resume_and_get() call may operate on incorrectly initialized runtime PM state. Add error handling to check the return value of devm_pm_runtime_enable() and return on failure. Fixes: e4e8b1fe742f ("mailbox: omap: Use devm_pm_runtime_enable() helper") Signed-off-by: Haotian Zhang --- drivers/mailbox/omap-mailbox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c index 680243751d62..e4fb8ffdde37 100644 --- a/drivers/mailbox/omap-mailbox.c +++ b/drivers/mailbox/omap-mailbox.c @@ -579,7 +579,9 @@ static int omap_mbox_probe(struct platform_device *pdev) return ret; =20 platform_set_drvdata(pdev, mdev); - devm_pm_runtime_enable(mdev->dev); + ret =3D devm_pm_runtime_enable(mdev->dev); + if (ret) + return ret; =20 ret =3D pm_runtime_resume_and_get(mdev->dev); if (ret < 0) --=20 2.50.1.windows.1