From nobody Tue Dec 2 01:25:31 2025 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A27C41F181F for ; Sun, 23 Nov 2025 02:32:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763865153; cv=none; b=WaxCkWPPIcKh/XStbnDsDdUOXJbpns2En1u78Pb7OwlIaMzZHMqvm60w1okcA8hm1GSuFxma+vXT1jFCEIBfqNSPA29CwyrqjqjQyY7CczFijMoGfnOj7FfpU675+ZSjOLOSKioiEX1S8i2xQ8XMaizVWzPAT2gPN0c3cosxFxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763865153; c=relaxed/simple; bh=5QMdl7eVBNTewwuuJO3lMgdAqN0GWRRlNGk3e8qasGg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=uO+ze+UMnL+U23vX5P1qy/3qpfwA1D2lb3PPVP0VH5zFypgOUNGqjs79VzbzpUaOU6LUAlVUTQNhpaxCcb3Dvz6eijucz2ZlztKvfSAlWiAK4pqe6TPr33RY3pC6I8+wh8iRBmQmSauMO6a4JxtGvyUVJE+s+EYOpN+wkEWmd8w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XbWtcnNm; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XbWtcnNm" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b9ceccbd7e8so7956942a12.0 for ; Sat, 22 Nov 2025 18:32:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763865151; x=1764469951; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=a3m6U2A9WK68emhqbKZBFX3D9dZLpGkE+dA1a3ZMrcY=; b=XbWtcnNmkzhIhdX6y+Ej3cL+bp/42IWw5pCrBUlvOsTifU3NN0dkHo+XwcMMDotLX/ LG2wetlnTiRtJ4/5RlKJbB9OSBfajQLtXZFavmoHxmvTASE3owko64NJXr/SRl+e7596 HAwaRVYQU+1vNUv3s9sWMGG5G7zKIQBId1PVHWGJrKKmLXsS5O3tpkVpydXo87F+PTDV qRT+FVM/Nop03bcoA9yC8fdp3jqK3rQv8EmT2zkvH3emCB5BguVB4bMPuhRZvUq0mRJb KLkhpwGcH5tC+wL9jlllp3Ei/2vlWwjmcprvWi8Ck3C1SEXANJVIa85M5BHp9SlxoQnQ v+og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763865151; x=1764469951; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a3m6U2A9WK68emhqbKZBFX3D9dZLpGkE+dA1a3ZMrcY=; b=UqwxEHysWxR7oXonYbymgYy42ygbQ3ubYwrdlvJJFshjhB7WrCYBM+qo9DKGolD9oB xkHwzPN0JKwYZW2bL+7hY9h0pTAAfiOly4oPTKKwq8/fK53xDEKKl5eXsf2SDBq270b1 ewWHTVCJawnrQe+pAEAZ/I7DYM2nNbos6PFeLmN+mcdLpf8/3vqy4MsbMQuTH/gtD+YV 15TSWhTKMtGdBHY8cIobaWLZ2uH9TU+/mh7KSg0LI1YK8O9wnPalMq3CuCX8iZv/g/vA 7sCgbE7sZ3A7DUW7JcrSmgKU+5XfjAMHv7miGozi44k8tfLR7Y6mB5s0o2+coqWxknJr nPAg== X-Forwarded-Encrypted: i=1; AJvYcCUA5H80Xwvm0Ru7Fwuqd4m8TnQKXrvoIv1AvOi5hW+ORNvkbi3b+gwd/+Hn3MYjWmZoKMpTlD2mKgz4mW4=@vger.kernel.org X-Gm-Message-State: AOJu0YzRUUjXBGRwHMA05kftxlm9klsFCXNkTL+CbVLlNK7U0Hgfh3rI cvMIPnhRSRlaeb0w/2cXsm1HJ+czoNlb+9lV29PatCY8tEwycfJjGHwFskYtxjR+l0Z9g0eTTwl XRJdvST5WZw== X-Google-Smtp-Source: AGHT+IH3pIkeTqQHy76r4obdhe86Ny6izg2Sh0yksr9YISTMimKKaq+pmHRF86AOvIkaLfNtdVyaVB15Gd7R X-Received: from dybhi45.prod.google.com ([2002:a05:7301:29ad:b0:2a4:75f7:2135]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:4625:b0:2a4:61d1:f451 with SMTP id 5a478bee46e88-2a7190f6638mr3165341eec.16.1763865150882; Sat, 22 Nov 2025 18:32:30 -0800 (PST) Date: Sat, 22 Nov 2025 18:32:17 -0800 In-Reply-To: <20251123023225.8069-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251123023225.8069-1-irogers@google.com> X-Mailer: git-send-email 2.52.0.rc2.455.g230fcf2819-goog Message-ID: <20251123023225.8069-2-irogers@google.com> Subject: [PATCH v1 1/9] perf symbol: Reduce scope of elf__needs_adjust_symbols From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Suzuki K Poulose , Mike Leach , James Clark , John Garry , Will Deacon , Leo Yan , Athira Rajeev , tanze , Aditya Bodkhe , Stephen Brennan , Andi Kleen , Chun-Tse Shao , Thomas Falcon , Dapeng Mi , "Dr. David Alan Gilbert" , Christophe Leroy , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , "Masami Hiramatsu (Google)" , Alexandre Ghiti , Haibo Xu , Sergei Trofimovich , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Function is only used by symsrc__init in symbol-elf.c, make static to reduce scope. Switch to not passing the argument by value but as a pointer. Signed-off-by: Ian Rogers --- tools/perf/util/symbol-elf.c | 8 ++++---- tools/perf/util/symbol.h | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 9e820599bab3..5cd4844f9bb4 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c @@ -1051,15 +1051,15 @@ void symsrc__destroy(struct symsrc *ss) close(ss->fd); } =20 -bool elf__needs_adjust_symbols(GElf_Ehdr ehdr) +static bool elf__needs_adjust_symbols(const GElf_Ehdr *ehdr) { /* * Usually vmlinux is an ELF file with type ET_EXEC for most * architectures; except Arm64 kernel is linked with option * '-share', so need to check type ET_DYN. */ - return ehdr.e_type =3D=3D ET_EXEC || ehdr.e_type =3D=3D ET_REL || - ehdr.e_type =3D=3D ET_DYN; + return ehdr->e_type =3D=3D ET_EXEC || ehdr->e_type =3D=3D ET_REL || + ehdr->e_type =3D=3D ET_DYN; } =20 static Elf *read_gnu_debugdata(struct dso *dso, Elf *elf, const char *name= , int *fd_ret) @@ -1232,7 +1232,7 @@ int symsrc__init(struct symsrc *ss, struct dso *dso, = const char *name, if (dso__kernel(dso) =3D=3D DSO_SPACE__USER) ss->adjust_symbols =3D true; else - ss->adjust_symbols =3D elf__needs_adjust_symbols(ehdr); + ss->adjust_symbols =3D elf__needs_adjust_symbols(&ehdr); =20 ss->name =3D strdup(name); if (!ss->name) { diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index 347106218799..d91dc89386e2 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h @@ -217,7 +217,6 @@ int setup_intlist(struct intlist **list, const char *li= st_str, const char *list_name); =20 #ifdef HAVE_LIBELF_SUPPORT -bool elf__needs_adjust_symbols(GElf_Ehdr ehdr); void arch__sym_update(struct symbol *s, GElf_Sym *sym); #endif =20 --=20 2.52.0.rc2.455.g230fcf2819-goog