From nobody Tue Dec 2 00:46:33 2025 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36AC2242D6A for ; Sat, 22 Nov 2025 22:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763849270; cv=none; b=UrclgoWg0uvqcLKnWXkTxcIR+s1YmEZsBw8nyz9fF1Y+44F9KTZbkKOdvxlLYtD4chGwO16a7LQVQ0ub59QAt7bAq6Ak3kbPbTGVAi7K/uZ/qF9khCloI20xU9oCPA39e/hPc+ybHz1Pb8xggZI5l4BZ0VA5AhaShyS4mhtTgkA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763849270; c=relaxed/simple; bh=Sgkr3BOkoHvoC42Qcdk9BLlrCQr8EPVLd18SJJTdxYo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=faOY7TV4pfY4vjtiohMWF3lc4Plj0bnzNg2+X5kFoDFXsLHpHqsYTpdV5viSZRlcCQX/ld7z1QhUs40LloBl+LVF3EFZTAKHzGGTQq1/hrwLdOjPG+YNtIfba56S+pGLq6KA8jLhF53F2FH5pJlBz5BiIrNydLga6TwDgRqDCi4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gu5KK6EF; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gu5KK6EF" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3436d9da02eso363207a91.1 for ; Sat, 22 Nov 2025 14:07:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763849267; x=1764454067; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lc4NuB1MYbl0Ec1tEVOR4gMOjb6I7UKXp2m54dbfHfM=; b=Gu5KK6EFRS0Li15dPZ+Jt+zKn1L50MRkjx7SpP18rebvRh5irhPjM2ub687NNBMcEi LBQbLf3w0PJpg+dc7FQFXBcdvM4hWujiPR+cuHofC3cbJfhFt2vMoI2M4fdwOtjtQZVT vqjdB0r66SN8AVjb5VMQ2qgJCzGJKJBij6ZIuJ6Z8J1UwkpJpS4moRKf9jcu8aabAvTD gEh2C4AzhWG2a9dYPnr2yUrUyqWvctj9sUPE680eUNjo29LF7tM1C78lKYPVVcULfeXc Rvgq/uWXTt5kst8T9eQAaTBHnZBa0eASp2EFsytSljWkz05YTjzYCG2jYoo0/fAw/QL/ rZrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763849267; x=1764454067; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lc4NuB1MYbl0Ec1tEVOR4gMOjb6I7UKXp2m54dbfHfM=; b=nnt9/ASQZL1LtD3eD2HEIBnuvDbh7j32gTp7DHVrbsp6fv9GL27uePjMBzUIRcc1BT EtMLLI4FB5wcLhJv7HOvmmlQFLjDzJts27/Xou/oNiDYiNNJ7otXAnAZ2vgGZP7FGHWA 8UzfpfUGD5Sn5x9DxMg69sKG7KD+xl1aHezLvxQRL1FURDAJu/o+jVYCRXP1V0r86psA 7FVMI9ANIl6dNkq2fPkHjHwaKfmCtWuX9yJfr5rqQaPQMTxtIyA92VMeWwYPxeQG+Usq omKdN8ouVXQ7hwJguCpPO9rQx3Ykj68M5OUcmKIZR+CQc8i3LBKk0Rzm1Z56IguBoTOJ uJ7g== X-Forwarded-Encrypted: i=1; AJvYcCXuPnySdSp45A16Egy9kUVWwb5ooQY6cWO+WjYkv2X2SL7pCc0WprD727fh/bpUcYFNfSmlgb9C+yzIxRw=@vger.kernel.org X-Gm-Message-State: AOJu0YwwuA5og03wG+1EiJq0h+jdgF0/VX22GyCDV3gGrP0c5NK4PndK 1E1uECAh0ainEwrfEeuSUpYDMADTaYgFFsuWEmq8tR4uHsKlM/qIatIQ X-Gm-Gg: ASbGncuW0bOVa9iXMaR0MR+zxnkfR8jJbq/47SqLIFtpt3W1EG/xGsvQcTZ5BO4hYa9 VvcnC4wj2vcdwEswgNdHdofFV3w1+vDV4/n2ZjdkKhZOrnzFf5KRjVlUa+mXBXuKmh9+MzwSF6v /o9NNz437c/dLg/ROlOZ55xdh4RDm9XHUKfLKfvsQxDWPmhAAPWUeGg5oDnFIeZi91TqqQYkT6A gLp8nLjdmfJb/UPclUoKno5QgVPRfqfI2r1zz4Sebz4VZJZhdzHwE/Fb/v9F7CbHv02PyrOY0fV Lqf4fJDtKsiCDPj9/ITS317Jim5YW5stB+euk4qBjNMRLYzfrFuWY3wLUKFQR9mfsk+sMik5Dxw Gxz71kMh23ZQRIP4dt//Nsgmbkh3W2yun8YODVNR2oVn9SgXFlBwj7SrS74t2mY9a+X1pysz+kS oXW2b+8jztoI2LzMc= X-Google-Smtp-Source: AGHT+IEWBysY+tsF4Q0xGNDkQZz4zc0jDJqwP3kVBZl5BGnIucalazm+kJyDRt2WsgTaeiK5Hwju7g== X-Received: by 2002:a17:903:13ce:b0:298:529b:85d7 with SMTP id d9443c01a7336-29b6bf1f7admr45954295ad.5.1763849267490; Sat, 22 Nov 2025 14:07:47 -0800 (PST) Received: from morax ([2405:201:4039:48b0:c6f2:57d3:9f1d:7d73]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-29b5b138628sm93344715ad.31.2025.11.22.14.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Nov 2025 14:07:46 -0800 (PST) From: Aaditya Kansal To: sfrench@samba.org, pc@manguebit.org Cc: ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Aaditya Kansal Subject: [PATCH] ksmb: add ipv6 support in parse_srvaddr() in smb client Date: Sun, 23 Nov 2025 03:37:32 +0530 Message-ID: <20251122220732.3203444-1-aadityakansal390@gmail.com> X-Mailer: git-send-email 2.51.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add ipv6 support in parse_srvaddr() in fs/smb/client/cifsroot.c. The existing parser filters out ipv4 out of the given string. The updated implementation identifies the ip version by checking the characters used and filters out the ip. Signed-off-by: Aaditya Kansal --- fs/smb/client/cifsroot.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/fs/smb/client/cifsroot.c b/fs/smb/client/cifsroot.c index 56ec1b233f52..d957db8b2efe 100644 --- a/fs/smb/client/cifsroot.c +++ b/fs/smb/client/cifsroot.c @@ -24,13 +24,20 @@ static char root_opts[1024] __initdata =3D DEFAULT_MNT_= OPTS; =20 static __be32 __init parse_srvaddr(char *start, char *end) { - /* TODO: ipv6 support */ - char addr[sizeof("aaa.bbb.ccc.ddd")]; + char addr[sizeof("aaaa.bbbb.cccc.dddd.eeee.ffff.gggg.hhhh")]; int i =3D 0; + int ipv6 =3D -1; =20 while (start < end && i < sizeof(addr) - 1) { - if (isdigit(*start) || *start =3D=3D '.') + if (isdigit(*start)) addr[i++] =3D *start; + else if (*start =3D=3D '.' && ipv6 !=3D 1) { + addr[i++] =3D *start; + ipv6 =3D 0; + } else if ((isalpha(*start) || *start =3D=3D ':') && ipv6 !=3D 0) { + addr[i++] =3D *start; + ipv6 =3D 1; + } start++; } addr[i] =3D '\0'; --=20 2.51.1