From nobody Tue Dec 2 01:04:41 2025 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 075BD28B3E2 for ; Sat, 22 Nov 2025 18:57:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763837840; cv=none; b=j+jHX4Fqthd0l+2J/5OSR89Wk/4aa2bV/SA7WBhpmjoaYPGanlHGRdM8aHYsnEGrVFzuvwPErIUx1Ti/n7dBjNtubTymf4EF7Tfdg/isXS8HKGVIozS2BZU9SI0YV94of46GcGW30ldJTjHaanE+3T8RYVM33/htfR+0TMCk8s4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763837840; c=relaxed/simple; bh=FyeMTFWXQEtRzQRRB+ND7H2hIAMCRwhxRmOSK7mYiqc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=a6uOklOpE2pznAuuY2gJ4NWLgsTypNFgxEGRUM/cKp8Ld1GVzY312FYebbCsw3jteQeO0/bD56TqCKFqpBJ11Y7w4TAiSSn3Tuo2ualPCCpFANmBYS93c0LePxv5EkxwdRVSB6AzjdRRkJPnneyCk3af4SUECjQqflVRCIxUWgE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LBATlAEM; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LBATlAEM" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-7a9cdf62d31so3730850b3a.3 for ; Sat, 22 Nov 2025 10:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763837838; x=1764442638; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fS0mw443M6QxSkVgXyyHCqsY/MzqrCLE+Xj30w6faIY=; b=LBATlAEMd+ETjF4ESkHT9MtIBMT9Zlc4ii/EWK9Pzl47Za73vN+k9gtUsu0bTyAycH hMolmtvcZjaNxBdkYnvcj4Xe8Lr36WTdOqoL2+jUPdB0O0Y6qmnsh4K4kcSIqOgrms+b 1M+OGtBdnHwm/IH1UBZCaKzuMUiVUS/GOO+Ba500HWXo76xVPnSSnef8d/8iM4Nf/w1X h/F0i8Q5iaa3bziu6snKR77PVUIV6RpRH7FSmzcBFh+mdGsPxDrg3iNpnesXp8BevW5k iodKKztETv+MdU3Pe1AVDz2XiB7bPbHl/ZexN7wZqI/ahXgkgPK53Jznf/DlNZPa2cdP 7V+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763837838; x=1764442638; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fS0mw443M6QxSkVgXyyHCqsY/MzqrCLE+Xj30w6faIY=; b=OCtv0I37EAuhnahwTaEtxQBBuG1vb0+7ux1Z/ILOzjJ61AAgYHO7We7gvzrrSp7Hdn LOs2SbIonUd0AfhQe/vxd5WQ484swcC/8ci9RlgYDToXk+L7Xw7SNeAStOkwYaaDLi5/ ISACydYTPR8HJK5nkiR8sTJfyGlPGuV90oVPtjmmUguCeeqQDQUO5L4kxPNrdjdfby8B xNVawJ73tc1u1h2W6nDg3eoQhTcNZdkbuqFBeZgVSJyfNCymjMsutnO21jLD3UOYh/cL +ZwCiHwQ+z8tzICG1DAJq6/qw+Zq6itBauRrZyVPfaD51jZp7vBoyzS/jLXUmtBRESQh HtZg== X-Forwarded-Encrypted: i=1; AJvYcCULgKvwKr3bkxMwG3uvEmBOQmyLJj7VlZHNj2Kabso6gLrAH1jBeJ4RGVNrX026EGuQBD359GMzKuJYgEE=@vger.kernel.org X-Gm-Message-State: AOJu0YzEB4J/lI+aEPxIJSkdROaJZt2CyeQYewvk6imKlx3TV/BHXKoz FAos+z8v6lKtBTDVDJ/J6mjufSMvJZi4wtzIHg17krY8Rr/Vd0manJDELMd6GuMwvq1h0g== X-Gm-Gg: ASbGncvo74oa7z+TzUM9g/ncAKpAxxU0hXG/F9iry88DRDjwrdde6uJdRhCm2BS7V0k BJ4wKsigQ8ERkzG4ss/kLkIW9P52gQfxoO+oE+dxuz5PYGxJiU6z+p8w0bNqB3lhmCoR7l4MB8+ U2BuOr9LZVMnB2zmhsGzY0GZOZix0YhpRvFOAjVpbeaFHR3qAmNELPE4xB+dgvDuXz2H9BB7w+W RUlr/Xn4jQidznXRCHa9/d61f92RQy/3mvo3bjZwgjGzpIAvSBmQfoBUBaeD/lvPpUHzgKIuv1Q UEC1nHrUfCln/8U7JVZpGp/ifk4D+FZgByOZLrIx7IUMyC1+VvTgSrg90KMEEWnfMfKk+Jwnync DqSJvANdShmv/elTVQtL48PQgP7VDuAUKPmuoN8ypy7ixNhOJmmiNSXxxYqKm0slRJSHr78/DMk Cr8Z7sI6VY+t6VVRrPcErw+f8/so65M2Yrxq7KzKGlYu8AA72WUBvTHbkC+GdEFJbk7J6qBTrV8 XnT858P9kr8VAZbiyY= X-Google-Smtp-Source: AGHT+IGWy5B7C9q07ADZpbLgxycFL2lVuffM7oqACRFZfdQnr+Nh2+VHHAZ/dlMPVmgygkLkYYwRHQ== X-Received: by 2002:a05:6a21:9988:b0:35d:cc9a:8bbb with SMTP id adf61e73a8af0-3614edf88e2mr7692966637.47.1763837838339; Sat, 22 Nov 2025 10:57:18 -0800 (PST) Received: from CyberKunju.localdomain ([103.92.100.163]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bd75b61c29dsm8795259a12.0.2025.11.22.10.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Nov 2025 10:57:17 -0800 (PST) From: Navaneeth K To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Navaneeth K Subject: [PATCH] staging: most: dim2: fix missing cleanup on interface registration failure Date: Sat, 22 Nov 2025 18:56:56 +0000 Message-ID: <20251122185656.251902-1-knavaneeth786@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If most_register_interface() fails, the function returned immediately without freeing the allocated 'dev' structure or resetting the hardware state via dim_shutdown(). Add a proper error path that jumps to the existing error handling label to ensure resources are freed and the hardware is shut down correctly. Signed-off-by: Navaneeth K --- drivers/staging/most/dim2/dim2.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index dad2abe6c0c9..ddf86d794448 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -889,7 +889,11 @@ static int dim2_probe(struct platform_device *pdev) dev->dev.parent =3D &pdev->dev; dev->dev.release =3D dim2_release; =20 - return most_register_interface(&dev->most_iface); + ret =3D most_register_interface(&dev->most_iface); + if (ret) + goto err_shutdown_dim; + + return 0; =20 err_shutdown_dim: dim_shutdown(); --=20 2.43.0