From nobody Tue Dec 2 01:06:32 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA1CF221271 for ; Sat, 22 Nov 2025 18:50:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763837414; cv=none; b=IVnwpSmZ8zc8pccoRr1IcZevyhip2rxWR60ZXPGD4akyKFL+suoW5ok5C0G8KL3czxQVgfGdemTX8mQgdq5z+mt3g2YHeZtx7FgHqlb1xjGAMJ84PBSr2EsZXWF1aCVoeoS2j0ikQAytSKbVMyLmk28k5NBYiDwSPYT1eFpdIxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763837414; c=relaxed/simple; bh=EpucUUr6+JapJBZmrTFAng/xqEIN+aULKRSMhV3h9Ec=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kAtiHE4A1aJkI8NPirQnfviBZqfF4KLOl+8RXVbXcYk5tDd4JHocDbQSBYUUliIsClLWEOHb2fIy04u1rDQlY0dul+JVvw4D95i/ThMlremge0boKGIGd+YDgxCJVQafkjekNu3dEZI0W48qeGF4pbJoLowu/sHjIxXocp/fJoM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P/f4qhMr; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P/f4qhMr" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47118259fd8so26719245e9.3 for ; Sat, 22 Nov 2025 10:50:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763837410; x=1764442210; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rJ8y42NprNFMBfVavEZyzrfZZtf4tjZ19hVBv6BlKNk=; b=P/f4qhMrjROv09nU9D9MpifLkiTQdy2fbAvfyuwCkfvZ2nHNCmzMmGmxxNgZ/N0m65 th9c2MBnPUKcqWxz98fOquIE/CtTat0uX23cVNA8ZZbWdhceVOywJFY0GiRWPs8QIbQ6 YnSzyRp+WF/7ykIOg+geFAiL3QzRcoxpc3yd+6p/9mfx8gwt2pk7B1uwT7K8LMjj2Uzd dOheVJ+dwbohDdxBD0FcVC2Xlne6vp8dHMs8mHBsXWo4G7XlI7BXYUNil3RWcFf0qszq QBeZ2IFDzmtO+ciL6Nj0O85MV1dTQtBKThtHaRi2HJFk7huxVpVVlcplFtYqCxLCgi0H RKZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763837410; x=1764442210; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rJ8y42NprNFMBfVavEZyzrfZZtf4tjZ19hVBv6BlKNk=; b=wzGqg5+NuSwURgm9JAvjso4sJ4BnRvdpZKnghMbTAUH3/0hXCB0CptYtcPyn3QOWSu lXBV+79p2MACdTpCxuEFsUgptJxrCF/TXXenF6eaJNAKeCZ8W4JDgUVt2FTIk9CiDFFo 6P53aNryvPdaUIlbL8BVHIfpPUzM6zZEy+SIVSpKs3S+JZu4mBghe2IDPuhA8wK9nVTd LrtHyIA0NH96k1dXhqsIcRHB5xzbZrFlDFzMYq1sz/G2ikQjTdhFuY9QMpQ0jQsRuyYd gEz+yVfxYG0Fgy0y2qtPl+Tj4aM5vxSY4hWGtX2cJ48DZr4xEgwaazgNF5BlgE9V76q4 LZDw== X-Forwarded-Encrypted: i=1; AJvYcCUNW6EkK7GgZdEWvqofXGes7ZU8CVaqtcGgLV44yHJ6V1WbTVswrB5k1LOFnSaWlB2XylmAdWy9p+UBTGk=@vger.kernel.org X-Gm-Message-State: AOJu0YxliIE7U1f6bmeOB4fFyS9ibdmDOMxraxpaTQ3DWnI0e0joi9Js byMfWPSYMRyuBUODwltxpvLgYKcQtKnBvfpG7gykXSCJiLQIt61OjIcmR91dFg== X-Gm-Gg: ASbGncsd05w69x0yz24ah7pGzBQtCEMpPrEJcD/NTjdFXIFjlfI8VlnVDiB1r1kaL6X FkojSNAz51Vb/JEHIX19Z4poXSY6opmz8MX+JZ6nwjkhhjwb+yjj261XrFdlC0KNkUwxKb0mYbE WKx/n7CXm6RYC6e6VRqm7fKpr8fIY1W8xeAKoGJEv2y6sVUKQNSTqXVmemZJBxVdrxMxP4W09yn uxaoislT+iqmC1g8hydunolmrOoCzvhV5I6WGaGfNh7hPuAtRHRm4QpdxxU/+0AmZUblDsjVW3H 0auG639/1FDc1sA5F7GDROfKv+hS48A/7wppsDmyu4olejnatA89ft4F9VXQnAMoMrn1pX5FnVk jZpgVGj+kh4WOWqP6MRfxMhDcxufnqMBhsasm7FxwPD9lmnk+izLxgr9aIS119YQ1/bNkeOhvMX 9aa2DFZ0EMLVfs2l12+p7Y7KeVGA0DJBDDiCSDZ464 X-Google-Smtp-Source: AGHT+IGJZpqmDfN9eSIBxSbiBA4I0WL4OE97LxOUVQMyn5cFkeQv1kE0+aXZFfEqYZD5CZsk+7fnIQ== X-Received: by 2002:a05:600c:1994:b0:477:a9e:859a with SMTP id 5b1f17b1804b1-477c01c0073mr59371525e9.22.1763837409879; Sat, 22 Nov 2025 10:50:09 -0800 (PST) Received: from Ansuel-XPS24 (93-34-90-37.ip49.fastwebnet.it. [93.34.90.37]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-477bf22dfc1sm106733955e9.12.2025.11.22.10.50.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Nov 2025 10:50:09 -0800 (PST) From: Christian Marangi To: Bjorn Andersson , Konrad Dybcio , Christian Marangi , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dan Carpenter Subject: [PATCH v2] soc: qcom: smem: fix qcom_smem_is_available and check if __smem is valid Date: Sat, 22 Nov 2025 19:49:56 +0100 Message-ID: <20251122185002.26524-1-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit 7a94d5f31b54 ("soc: qcom: smem: better track SMEM uninitialized state") changed the usage of __smem and init now as an error pointer instead of NULL. qcom_smem_is_available() wasn't updated to reflect this change and also .qcom_smem_remove doesn't reset it on module exit. Update both entry to reflect new handling of __smem. Fixes: 7a94d5f31b54 ("soc: qcom: smem: better track SMEM uninitialized stat= e") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/aSAnR3ECa04CoPqp@stanley.mountain/ Signed-off-by: Christian Marangi Reviewed-by: Konrad Dybcio --- Changes v2: - Drop unrelated changes drivers/soc/qcom/smem.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c index fef840b54574..c18a0c946f76 100644 --- a/drivers/soc/qcom/smem.c +++ b/drivers/soc/qcom/smem.c @@ -396,7 +396,7 @@ EXPORT_SYMBOL_GPL(qcom_smem_bust_hwspin_lock_by_host); */ bool qcom_smem_is_available(void) { - return !!__smem; + return !IS_ERR(__smem); } EXPORT_SYMBOL_GPL(qcom_smem_is_available); =20 @@ -1247,7 +1247,8 @@ static void qcom_smem_remove(struct platform_device *= pdev) { platform_device_unregister(__smem->socinfo); =20 - __smem =3D NULL; + /* Set to -EPROBE_DEFER to signal unprobed state */ + __smem =3D ERR_PTR(-EPROBE_DEFER); } =20 static const struct of_device_id qcom_smem_of_match[] =3D { --=20 2.51.0