From nobody Tue Dec 2 01:36:14 2025 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3F792E2852 for ; Sat, 22 Nov 2025 08:19:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763799584; cv=none; b=GHGLhn1ojGmGHFl4r82/eeALyEeuSwTcZO1xd1G0AZN4krK5wWtlUWeMwn93rp/g9TIyNvVhXItGQSwn65zieZLIy6rfa6oZ2rvjZTzo+KXGzqvycVYxk9L+PURGZDj6Vtt1EaYJT9DJQrzzpgCfzexPim4beWcqyfYHkP8p67w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763799584; c=relaxed/simple; bh=sx7HYHks3ytj7Jes2KeHQ4gHIyvcIcsZS20MoUx3Rf0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=Af80X0i3FI2fvnRNcKqCQqFTFLrqm/m9U/5GOVKrhoFG1aOYE0nVH94mchu9hbKqOwkxEqU/57U89vbxcO8994vhbTzzDmRjjxtzq0/LPd95jqZEyrw5Vn4JL79UDweyMxxKEVThsWS5IAI+/1e6QZe3GIAbZSPUE/xahPoZFRc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=E/hSQFwa; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="E/hSQFwa" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-7b9c91b814cso8781328b3a.2 for ; Sat, 22 Nov 2025 00:19:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763799581; x=1764404381; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=PfPxaYlK1t4toeHzJ2SOIsfB7c+WhL2RCiW1BSoMqL4=; b=E/hSQFwaGPK27GWjYueiFil4TFWSv+2NngqQk4L1KnmqSYgl08DHa0B/9xPUGn6a02 7vUVhu2aSZJYuKSRi7XJ7dl15MPWmQ3Uar7UwkTApSntlUqWWpDXZLgpo8bxCi7koXuO 8TkAdyDMdBHlDtbUrLWArodUhhlvUC2fK/z3dTrfDkcnSFF8mNcqYu29NyOKfu49C9gJ gu5GcMqk9IlavMqT3XUd4nIkx7Mn4NdFXYV1ayHc8Okg3P3EanEtWebt7Sp0vTeKqTmw x2IdtcRacR4dJ6G1IgzyHhPEWtC5nAHIHqQ2HkRBso5viPhXmUGuwd70MhdRDKHrhcv5 i2Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763799581; x=1764404381; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PfPxaYlK1t4toeHzJ2SOIsfB7c+WhL2RCiW1BSoMqL4=; b=bLqIspBWk1mzxj8IMwZ57Qg237oAE6AuCbMlig/8dv1+HUVSDIz484i3M1Yv1yybY8 Zc08+r4pP6VOAxdsHvt5OUnJTJMRs2wmAxlCpZrQXWzyylXnEMkb7v6VsIOH2shyWp8b dJx5AM3PFXw4e5Ekc7qLfWzLvQ8AZ4QU3n844ouombTu2hgg+J0dGGPoD9gDuv4/Q8bV wTMmWKrzRp3wLdzKkSKH9C+RBVcAgR6p5NmFMOKYt1QLbMNoBByAoOpuQFQWZNTHkkxS Vtc7x0DUx03AiXnNgXyy4cZbjHChNxjOKxZdYxAEYPW3Jwmfv64rFooTjYHMTjWqFlti OFgA== X-Forwarded-Encrypted: i=1; AJvYcCXvc6qYWxL+qeDffFMnMU7dR3BceY4YV6A9f0P9kXX9yDjlakpNmZFUIRiDmdLelDKzMRTzXMLVClLnLjk=@vger.kernel.org X-Gm-Message-State: AOJu0YynVSF+nyZeU26Bw/2s9mKQBfhDCsLCvIKdrx6iLS2YTh6udILi 9fxUIV30kftu501WLYhkBY2gKEIZUkWRkjI2bCJGgY9iDnmLas+5D0eulOigpf1LBZYJxz2ziel noA+ODubPww== X-Google-Smtp-Source: AGHT+IG0rfZfyZv/KsW4SMkzha2L2s97MUZn6ZWmw1Xt/qrPrIa8qfuUMlZTN5DccGBLCB/Kg+hUvS2kXAQC X-Received: from pgmj1.prod.google.com ([2002:a63:5941:0:b0:bd9:a349:94b1]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:938c:b0:350:9b6b:8ea8 with SMTP id adf61e73a8af0-3614ee6bb4cmr7151492637.51.1763799581068; Sat, 22 Nov 2025 00:19:41 -0800 (PST) Date: Sat, 22 Nov 2025 00:19:15 -0800 In-Reply-To: <20251122081929.7588-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251122081929.7588-1-irogers@google.com> X-Mailer: git-send-email 2.52.0.rc2.455.g230fcf2819-goog Message-ID: <20251122081929.7588-4-irogers@google.com> Subject: [PATCH v1 03/17] perf symbol-elf: Add missing puts on error path From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Collin Funk , Dmitry Vyukov , Andi Kleen , Thomas Falcon , Leo Yan , Yicong Yang , Greg Kroah-Hartman , "Masami Hiramatsu (Google)" , Stephen Brennan , Haibo Xu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In dso__process_kernel_symbol if inserting a map fails, probably ENOMEM, then the reference count puts were missing on the dso and map. Signed-off-by: Ian Rogers Reviewed-by: Arnaldo Carvalho de Melo --- tools/perf/util/symbol-elf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 9e820599bab3..4c76e680b13d 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c @@ -1446,8 +1446,11 @@ static int dso__process_kernel_symbol(struct dso *ds= o, struct map *map, map__set_mapping_type(curr_map, MAPPING_TYPE__IDENTITY); } dso__set_symtab_type(curr_dso, dso__symtab_type(dso)); - if (maps__insert(kmaps, curr_map)) + if (maps__insert(kmaps, curr_map)) { + dso__put(curr_dso); + map__put(curr_map); return -1; + } dsos__add(&maps__machine(kmaps)->dsos, curr_dso); dso__set_loaded(curr_dso); dso__put(*curr_dsop); --=20 2.52.0.rc2.455.g230fcf2819-goog