From nobody Tue Dec 2 01:27:24 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BE142DC34F for ; Sat, 22 Nov 2025 07:40:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763797257; cv=none; b=ap5aDKPXHqT0CmSqg17uhi8pw4n8fLPBjhJ9/nKn8NTc1/GUx5a/KwzLeWV9e/oa9KODDDt2p+ZIprPpf8wafWTH/9YdtSwPxJ+GI3mkwK0cpb9EtRCn5kyZ02POPJU1yMp88ZtyHasenoB8Gpxv2HqJT6xTIEQX+F2yiQ5axx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763797257; c=relaxed/simple; bh=0lvT62u7g2hF4e73HEKdSTUKddQUZd7pbA6qKmK7XgE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h1hOnxEQ7yL5TaV8NWc1VWI6pZqziMOBR/QG1T0IJnTEZeaFZQClBA4upu0GfOAWtvCg7pg3H0L7C6nmwSsLoAUDRzzQSmwphN0yhhUM62dmDSQ0Z7eA2G1w6a+u/2nPIWpfW6Ro2tQKIlekfti6ntI4KGEOoJeW7mqKPoIXlb0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=X12BBd45; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="X12BBd45" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2981f9ce15cso32548255ad.1 for ; Fri, 21 Nov 2025 23:40:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1763797256; x=1764402056; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SP8ZymlO8cuxujreNygTi0dHk6OzbncHB3g2TEGb8AY=; b=X12BBd45p7hMcsDJsvrZh2BPdcYPYdrFQoaOHeBGCq9zJwuuVSpQIPeqapeUqYbNJp ExTl4QxTr7fKaKtO/da0EfpDeH39qiyUf7ckOFOseer6mTbsB9lgP1G2Nj2BHBfs2BUu vqDcUdZe+R03Bw4t9Mp1T4cYNfLxhOU9rs2uI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763797256; x=1764402056; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SP8ZymlO8cuxujreNygTi0dHk6OzbncHB3g2TEGb8AY=; b=bRlsBAqO+DcXCy4eEInzXe4dLeQ8CbI4/Arg42NMciDfmYuKdnLSj/+B8ymDIEcZ/y k4yJvpfifLiMgDCTZ77G8f5ELzTg+z5zN8VRJM1zYrrDRiquu8UIvTQEuSefQOnFSUm1 HTcSx1xXHNe1Z1iNpMa8GfjtQJfHww4fdy5YW2nVUBk/uJOMs69FpSojrGea5rSJ0sQz cFUVyN36RYBwyH/iX+iYqIpj8YcTnaKhlcVNo0ZGtAoZ84ioIEStdH2umd3sBf+RgsGw pZttUzRGwMJ0vt4fRK/04OljsTFd0jO+HfF9fYFlfv9q43gyaUt5wgrNDqzvZzVTEOQq gO3A== X-Forwarded-Encrypted: i=1; AJvYcCU/fwyL1VgjZaXJK9Yh0jSSKcIyeQwSIEEDzu32auvweGiWt3pTzXmZ2afFz0HdZmB1/UnNUD2dG/v3K7c=@vger.kernel.org X-Gm-Message-State: AOJu0YyfAl+o+ILEbDwzW2aF3soNJgazCep9ngXyZthgfIa6LgnyN40q tnwf0nruWrgymrb7KLtUFu9KP+DnsL8fGWHkugvA4dhKJ1kknsHrNt/kQgbAsUD6Lw== X-Gm-Gg: ASbGncteQkh2YdwT3mLG0C752clZVJvxmekBuvyLTiWUBTk1KGz7BQhoXp+IF2zQNRt o6Br7uYstlOKei2xRaJ98aQghAyq8fuTHoHtJtE9Xsghe/WQW2V0j7PadA9zMx3zklIqDKN48aj 0e0CWip2QBnTd047Px3shs/XE8ofORyMiS4x2r63hJbc9B7Lqz9s0QQF65aPsQDKxv+VRYwNzbr LUERWfXAnpZf3W9Royi5+l2FelFwCfFeyDpm69q/GgCcyhF5mRSGFnlY+ieQNkMPPpd4qB9Q+NL XnOV9+Fc8o6OKAAaAslI57NQlwfMzNAD9Y99x0Mza9BM7wA+xycxJM88If/VvWM0K1kTWc2Ty/8 BubY9TTT3oaZBiwGij/5O8b1cjPVGOsBbgk1OFtO5YpxOxNm4uxXGzm5oNd1LZJXJxZjR3OwGdx WAHkyOeOc/dUKDe6pbElIJs0kGjPrTleviu6w/AooXTHV+XJdkQGNHKRVFrr4MKf1gkrHXID79C w== X-Google-Smtp-Source: AGHT+IEM8/Y4dIBBOwac1lJfHeplWi/wxjKlMN7X/1wlrBnzk52Ba8uHOaEg9loOMYDOH+d1fhjFKw== X-Received: by 2002:a17:902:f608:b0:295:9cb5:ae12 with SMTP id d9443c01a7336-29b6becc884mr62810705ad.25.1763797255895; Fri, 21 Nov 2025 23:40:55 -0800 (PST) Received: from tigerii.tok.corp.google.com ([2a00:79e0:2031:6:948e:149d:963b:f660]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b138628sm77771555ad.31.2025.11.21.23.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 23:40:55 -0800 (PST) From: Sergey Senozhatsky To: Andrew Morton , Minchan Kim , Yuwen Chen , Richard Chang Cc: Brian Geffon , Fengyu Lian , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, Sergey Senozhatsky Subject: [PATCHv6 3/6] zram: take write lock in wb limit store handlers Date: Sat, 22 Nov 2025 16:40:26 +0900 Message-ID: <20251122074029.3948921-4-senozhatsky@chromium.org> X-Mailer: git-send-email 2.52.0.460.gd25c4c69ec-goog In-Reply-To: <20251122074029.3948921-1-senozhatsky@chromium.org> References: <20251122074029.3948921-1-senozhatsky@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Write device attrs handlers should take write zram init_lock. While at it, fixup coding styles. Signed-off-by: Sergey Senozhatsky Reviewed-by: Brian Geffon --- drivers/block/zram/zram_drv.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 5906ba061165..8dd733707a40 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -521,7 +521,8 @@ struct zram_wb_req { }; =20 static ssize_t writeback_limit_enable_store(struct device *dev, - struct device_attribute *attr, const char *buf, size_t len) + struct device_attribute *attr, + const char *buf, size_t len) { struct zram *zram =3D dev_to_zram(dev); u64 val; @@ -530,18 +531,19 @@ static ssize_t writeback_limit_enable_store(struct de= vice *dev, if (kstrtoull(buf, 10, &val)) return ret; =20 - down_read(&zram->init_lock); + down_write(&zram->init_lock); spin_lock(&zram->wb_limit_lock); zram->wb_limit_enable =3D val; spin_unlock(&zram->wb_limit_lock); - up_read(&zram->init_lock); + up_write(&zram->init_lock); ret =3D len; =20 return ret; } =20 static ssize_t writeback_limit_enable_show(struct device *dev, - struct device_attribute *attr, char *buf) + struct device_attribute *attr, + char *buf) { bool val; struct zram *zram =3D dev_to_zram(dev); @@ -556,7 +558,8 @@ static ssize_t writeback_limit_enable_show(struct devic= e *dev, } =20 static ssize_t writeback_limit_store(struct device *dev, - struct device_attribute *attr, const char *buf, size_t len) + struct device_attribute *attr, + const char *buf, size_t len) { struct zram *zram =3D dev_to_zram(dev); u64 val; @@ -565,11 +568,11 @@ static ssize_t writeback_limit_store(struct device *d= ev, if (kstrtoull(buf, 10, &val)) return ret; =20 - down_read(&zram->init_lock); + down_write(&zram->init_lock); spin_lock(&zram->wb_limit_lock); zram->bd_wb_limit =3D val; spin_unlock(&zram->wb_limit_lock); - up_read(&zram->init_lock); + up_write(&zram->init_lock); ret =3D len; =20 return ret; --=20 2.52.0.460.gd25c4c69ec-goog