From nobody Tue Dec 2 01:27:23 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A34B25A642 for ; Sat, 22 Nov 2025 07:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763797255; cv=none; b=fGtjRfpQr6dpVpRJZdDe+sDL3YoPznXRw4BWl34flCb93hUBcHUi3BnSK5qAuAf8tXX/82iNEYGSkzUxTRn2HxqN4LN9uMBsyCWgMrrnmBKYPnUti3QYKl6BA2FBv2J6T0ZLymq3Yv8RYhYIifdk3eOgW3i6K1aNfirap/iFBzs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763797255; c=relaxed/simple; bh=RU7LKKkrOdPOazKvr9ZHQjeWATjBMgcJ+HOgz91KiKc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qSa3L4jTnIQejcEQuNvddceln2Ytp0PdosMyZDQNTDvuqTFjR6VTY9f9JXUvAdH+v7bQXKSzVMtEyU/HZWvQGkkN+mWvO3jDwYfmghjgnSRnkFBb7GS6PiMyx4OBRmdBRY1MFeaHYF69On855wY5FuNOjvAr0TTfv6+MgmP/EfQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=nmzPSXIT; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nmzPSXIT" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-295548467c7so32619885ad.2 for ; Fri, 21 Nov 2025 23:40:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1763797253; x=1764402053; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SX4VpemLPNnHEK+as4wej/2Q8OupmjwjrzAvH21+biQ=; b=nmzPSXIT18UjzkozSVKR5CtqzZrUP3UHTdpPG4QL/sCbgCcdhoJUJuu+55Ef0MeFSd lE72bA9SWOD3riJam/qviTnRSLud2B3xJDaPlzlp0krUHI3iYZ15DRbmxRSpv9OvbZjt eSMZLfPsltdhjWGh/SETa3G8yPxvg0dV9KJxY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763797253; x=1764402053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SX4VpemLPNnHEK+as4wej/2Q8OupmjwjrzAvH21+biQ=; b=TggKOEbq8szIKJ1sw3ppJQ3ceSXI61RiSps3AxZokyDFqPCCd0QTMrKPi7r21RdNR8 l9H7eTH0QAC3QYfVoFxRpLOnzFL/QB2VPRmoTBJeh1Io4bV2tlY0EJhCeVyv3d+BGTB6 KbJezW11cHV6iuL6QkNcEBkJgwxzhGkrv+9AXRXYPXlTs0VUAjd8SOfBkMnKxZ/Z4vin fC3uVaaVbDlIY2mKgbT7R5qSHxM7EZKWO7X5ypVSA4H2KWwD4AmJj36+jlyNgoc83LDS X+aTMm/bxG9Zv9rNsvaQZYkvsA0GVeD3Gn+NQNOKnBi7J/lzccwQopE4alsRIc6HeD47 kFIA== X-Forwarded-Encrypted: i=1; AJvYcCXN9UJXuJUZfoNNW+ofx7/asa9nunKTWdqRBX7cLFVfN0V5wmn0eAerb4KRDOOFWYA6Ervv+yzYmL25MEs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz39WQTXBaI3gXcXmGlC+hboVmorwjnBeT1hsy7vplLHNsIQpGx Gqt7T0lfMlMb4cCZDqfI0qTuft+J8LP/5K+9ysARkG8rZHtw+eDNEXSQT1MMVYdunzYbUyUlZtg ij68= X-Gm-Gg: ASbGnctNFX4jtPBFEo33+moPdeZKaD1NQ9XHp57qGBfd2NVlzntYnK7kGZ9zBGiPFwI GxAicVmGYVfaYTQT1iff3CXTVi0KOc0sbYYyXDFE18SgCNcst6ghy7MFTYr2eDjpfE6C/vxeJH7 QyELKKw11uCtEY3LNPtH9XUujEz2kZHi1Foky2rh00VO4Jr667bpKIKxc4I5xBz3T3jP2kTRubH iQI+n+IOx0Pd3R46zqoAM0aiS9HGNOtqgHMRlPGfUap0ujagND/dtMgSmF+gioWyfBDxRZj+bAg 3OtP9tmuh3lX3TNTR7FwyQ6bTjQJe1ndhdx77MEIvQaR0ZRQp4/FTAe1gP2/88Cu5N9xi4Pzh+T 9djNBpWvWrt7xOanLaX6VSrU1tUR209E9jotq8xlKZliAv/yXpM1anhXgmWC9pqLXm3CR/uf4ww yWxIscxJUmkDmYSfYJbMBQf6698DnnhKR9PUR/KL1vnEBhTxYq3H55tJlvoyPEFp1feCor/wWLW ghk2jT9jbI3 X-Google-Smtp-Source: AGHT+IFnu2Sudoe6jxzn5HtnDaCFVbXUPGcH4YtmUDiSHkmwz2BuN3F8fTnfFOOCqEYv14rgm5x3cw== X-Received: by 2002:a17:903:320a:b0:29a:5ce:b467 with SMTP id d9443c01a7336-29b6bf9e98amr65542735ad.54.1763797253269; Fri, 21 Nov 2025 23:40:53 -0800 (PST) Received: from tigerii.tok.corp.google.com ([2a00:79e0:2031:6:948e:149d:963b:f660]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b138628sm77771555ad.31.2025.11.21.23.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 23:40:52 -0800 (PST) From: Sergey Senozhatsky To: Andrew Morton , Minchan Kim , Yuwen Chen , Richard Chang Cc: Brian Geffon , Fengyu Lian , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, Sergey Senozhatsky Subject: [PATCHv6 2/6] zram: add writeback batch size device attr Date: Sat, 22 Nov 2025 16:40:25 +0900 Message-ID: <20251122074029.3948921-3-senozhatsky@chromium.org> X-Mailer: git-send-email 2.52.0.460.gd25c4c69ec-goog In-Reply-To: <20251122074029.3948921-1-senozhatsky@chromium.org> References: <20251122074029.3948921-1-senozhatsky@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Introduce writeback_batch_size device attribute so that the maximum number of in-flight writeback bio requests can be configured at run-time per-device. This essentially enables batched bio writeback. Signed-off-by: Sergey Senozhatsky Reviewed-by: Brian Geffon --- drivers/block/zram/zram_drv.c | 46 ++++++++++++++++++++++++++++++----- drivers/block/zram/zram_drv.h | 1 + 2 files changed, 41 insertions(+), 6 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 06ea56f0a00f..5906ba061165 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -590,6 +590,40 @@ static ssize_t writeback_limit_show(struct device *dev, return sysfs_emit(buf, "%llu\n", val); } =20 +static ssize_t writeback_batch_size_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t len) +{ + struct zram *zram =3D dev_to_zram(dev); + u32 val; + + if (kstrtouint(buf, 10, &val)) + return -EINVAL; + + if (!val) + return -EINVAL; + + down_write(&zram->init_lock); + zram->wb_batch_size =3D val; + up_write(&zram->init_lock); + + return len; +} + +static ssize_t writeback_batch_size_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + u32 val; + struct zram *zram =3D dev_to_zram(dev); + + down_read(&zram->init_lock); + val =3D zram->wb_batch_size; + up_read(&zram->init_lock); + + return sysfs_emit(buf, "%u\n", val); +} + static void reset_bdev(struct zram *zram) { if (!zram->backing_dev) @@ -781,10 +815,7 @@ static void release_wb_ctl(struct zram_wb_ctl *wb_ctl) kfree(wb_ctl); } =20 -/* XXX: should be a per-device sysfs attr */ -#define ZRAM_WB_REQ_CNT 32 - -static struct zram_wb_ctl *init_wb_ctl(void) +static struct zram_wb_ctl *init_wb_ctl(struct zram *zram) { struct zram_wb_ctl *wb_ctl; int i; @@ -799,7 +830,7 @@ static struct zram_wb_ctl *init_wb_ctl(void) init_waitqueue_head(&wb_ctl->done_wait); spin_lock_init(&wb_ctl->done_lock); =20 - for (i =3D 0; i < ZRAM_WB_REQ_CNT; i++) { + for (i =3D 0; i < zram->wb_batch_size; i++) { struct zram_wb_req *req; =20 /* @@ -1200,7 +1231,7 @@ static ssize_t writeback_store(struct device *dev, goto release_init_lock; } =20 - wb_ctl =3D init_wb_ctl(); + wb_ctl =3D init_wb_ctl(zram); if (!wb_ctl) { ret =3D -ENOMEM; goto release_init_lock; @@ -2843,6 +2874,7 @@ static DEVICE_ATTR_RW(backing_dev); static DEVICE_ATTR_WO(writeback); static DEVICE_ATTR_RW(writeback_limit); static DEVICE_ATTR_RW(writeback_limit_enable); +static DEVICE_ATTR_RW(writeback_batch_size); #endif #ifdef CONFIG_ZRAM_MULTI_COMP static DEVICE_ATTR_RW(recomp_algorithm); @@ -2864,6 +2896,7 @@ static struct attribute *zram_disk_attrs[] =3D { &dev_attr_writeback.attr, &dev_attr_writeback_limit.attr, &dev_attr_writeback_limit_enable.attr, + &dev_attr_writeback_batch_size.attr, #endif &dev_attr_io_stat.attr, &dev_attr_mm_stat.attr, @@ -2925,6 +2958,7 @@ static int zram_add(void) =20 init_rwsem(&zram->init_lock); #ifdef CONFIG_ZRAM_WRITEBACK + zram->wb_batch_size =3D 32; spin_lock_init(&zram->wb_limit_lock); #endif =20 diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h index 6cee93f9c0d0..1a647f42c1a4 100644 --- a/drivers/block/zram/zram_drv.h +++ b/drivers/block/zram/zram_drv.h @@ -129,6 +129,7 @@ struct zram { struct file *backing_dev; spinlock_t wb_limit_lock; bool wb_limit_enable; + u32 wb_batch_size; u64 bd_wb_limit; struct block_device *bdev; unsigned long *bitmap; --=20 2.52.0.460.gd25c4c69ec-goog