From nobody Tue Dec 2 01:05:40 2025 Received: from mail-il1-f202.google.com (mail-il1-f202.google.com [209.85.166.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65EE436D4E3 for ; Sat, 22 Nov 2025 07:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763795999; cv=none; b=UCBFG+MZXlW6/p5UfMCPCPPlS4pVgwIVQbKr9zUNJ6gwdplAVmvv9MvrDpManDpk9sf/wgeAQPx9STTOmaCWT/XyRGp6d6Q12ltrsD1IdbPifJ8MYeUd3h6XM9OZ0noicrDBubhZ2PvpO86LnJruQQC/VD6MqBBQIQ1PTWcToYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763795999; c=relaxed/simple; bh=FFdNK+3ZLxXxPnEZRkbPwb5NdvomInu1/DRGUUi4Nqk=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=d0bjjysqqibfJ31CMUqurDdt57fgtoHyO1jQ+LXmQ/pukpU7vq+KPsCNR8CtBnbH1q5X8KwkZS+/bUwFNYxqg4EemIVJDQIYsVnk9Z712tGcbAaf4Vxo1ZpuufNlFq+PCVhjLbL3qezWYY49wYSLCxuqVRNwhTv1Lu5z00OGiis= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--avagin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=imPLo215; arc=none smtp.client-ip=209.85.166.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--avagin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="imPLo215" Received: by mail-il1-f202.google.com with SMTP id e9e14a558f8ab-433770ba913so31602945ab.1 for ; Fri, 21 Nov 2025 23:19:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763795997; x=1764400797; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=PivCgLxrGX/2vRgbBHY2gdLcCSo4vHktstVYVlsvVDw=; b=imPLo215cpACdTninTtJSNRcjk0J91VkFWvk04kc2cxGdTmYI35W7bnMbcuaYZ4gkX poewnzhrqCfQCQUe7QLvSqBYyFcaTa7kNNRiuV7/EKO32zERg6lisrykWgZIAu/bYB97 HuBLv22BEAmRF1y/NHAqZv1Ir40feUfTRsbNLEVrqvj7HkS/F0OEJMGzISLraWgWMkvL FJDkqGOxGYY6V7ust8i+ushs13tVsB04+Z+6Ltf9BCFTDcF89XMlsJztiu6389UuJSE5 fyA+czOhGzZfADOLZI2tG7GNBTQeqkJ6J/sVrkBYrsEnYyOrYMPot+FoNgzL8kvGk+Ee gtbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763795997; x=1764400797; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PivCgLxrGX/2vRgbBHY2gdLcCSo4vHktstVYVlsvVDw=; b=Ptu2rhEy+2tPpScukuVg2ij8J3dVDjouPYss48UwEg8nWDeGYBcGc0dezmaxFxgXD9 nHZTKCFM9+SEywIZxocM8hsXIcDU9nV8gLTbWJ+GY87+WS+6tUWiJMbCCj39fNZvcIDB j8jap+WgKraEGiSzxhrlcve4DbnHa7Zq0xt34HhSFIpf8jbU4mYp3P1tnpt09CKecNgq iZz71OyT3Cl941pAsvOpVDZbeqUNLfN25p2fqdJ6O2BvzdcU/2FHiN/o85elxffT7y2T qT62WL5cdlAdfxUqCtTW48+GQZKvrPFPKlEm8lf4P/JHtBHU0VFId5SoIZ1qBrLnXWp/ KsMQ== X-Gm-Message-State: AOJu0Yw8yL/efXbkiz2uWem5Yd/Ub8KZ9VIL1JztXQDFxQhBl49XhhBT Q3Jk9biH3H5fjxAuNgglsRtNI1viqSzHYhb45RJ1n9hMD4aWjYD2ydsoyzzo0VR0nDUeZFHpTsz FRr5HFQ== X-Google-Smtp-Source: AGHT+IGGLZtgC5FLgdkVJofZlQ6j3GuUfq8ybk+qGRvtumbpUvYwXNHZCjJQoxEkq1/TuOdrWfcXEloEIno= X-Received: from ilbdd1.prod.google.com ([2002:a05:6e02:3d81:b0:433:4f9d:6ee3]) (user=avagin job=prod-delivery.src-stubby-dispatcher) by 2002:a92:b006:0:b0:434:96ea:ff48 with SMTP id e9e14a558f8ab-435b8ec96ddmr34521605ab.33.1763795997690; Fri, 21 Nov 2025 23:19:57 -0800 (PST) Date: Sat, 22 Nov 2025 07:19:53 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.487.g5c8c507ade-goog Message-ID: <20251122071953.3053755-1-avagin@google.com> Subject: [PATCH] fs/namespace: fix reference leak in grab_requested_mnt_ns From: Andrei Vagin To: Christian Brauner Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrei Vagin Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" lookup_mnt_ns() already takes a reference on mnt_ns. grab_requested_mnt_ns() doesn't need to take an extra reference. Fixes: 78f0e33cd6c93 ("fs/namespace: correctly handle errors returned by gr= ab_requested_mnt_ns") Signed-off-by: Andrei Vagin --- fs/namespace.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index 2bad25709b2c..4272349650b1 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -5746,6 +5746,8 @@ static struct mnt_namespace *grab_requested_mnt_ns(co= nst struct mnt_id_req *kreq =20 if (kreq->mnt_ns_id) { mnt_ns =3D lookup_mnt_ns(kreq->mnt_ns_id); + if (!mnt_ns) + return ERR_PTR(-ENOENT); } else if (kreq->mnt_ns_fd) { struct ns_common *ns; =20 @@ -5761,13 +5763,12 @@ static struct mnt_namespace *grab_requested_mnt_ns(= const struct mnt_id_req *kreq return ERR_PTR(-EINVAL); =20 mnt_ns =3D to_mnt_ns(ns); + refcount_inc(&mnt_ns->passive); } else { mnt_ns =3D current->nsproxy->mnt_ns; + refcount_inc(&mnt_ns->passive); } - if (!mnt_ns) - return ERR_PTR(-ENOENT); =20 - refcount_inc(&mnt_ns->passive); return mnt_ns; } =20 --=20 2.52.0.487.g5c8c507ade-goog