From nobody Tue Dec 2 01:36:39 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9634D29E113 for ; Sat, 22 Nov 2025 05:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763787644; cv=none; b=WL+Up/bcm5UuGpaH+PVd9+jPQAlzaJxLz0P7CHZFvh7mFnp5I+qP1nW3lDcRN1ybonsWCHSiwtLT+vjc4Gikc9a9DY9cOBbFnxiB+hWgBZrZC1eXcfOr8mat0CgqVDk5m9BfHX+iaV47EHeQT0CCN2EDKG3PSTaJUWGtsbKa9Ks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763787644; c=relaxed/simple; bh=cwIEc0HF5caawSt6gOxOI+pMExQY63TqviBqzRA+S28=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ejkMevqmKxu+Q+xTdR7Ahg3AuID7RnuvHr8XAGfNhftucep8C50y77VvVOGXjJs470EFn1SYc40xBVxgd4aAv8nUCZMqNL+wrZsqsqy8YxVhXVLRmI2+6SMcdmwTGvrplusYudnP+dFrgtd/AlT4yWzcH0KthUlIzvZFN6jkbg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jtx8FVeM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bk5dVVa/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jtx8FVeM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bk5dVVa/" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AM4Wxn01509954 for ; Sat, 22 Nov 2025 05:00:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=OykaP3QXAEq G4yI9kL9Noaj3OcsMMG9dgRdTlVS4bzE=; b=Jtx8FVeM4gSL3KVXYJA7rVkDVUX 4ovtx7+yA/0WZBL5xT4EuLcSQNCh8ChwYzfb16fpQjWE5RL6VJIH6x8SvPFgju7v cy/fxdGQVka/nHNME1A0L2XkCN+nMUeXVjes6VzCxgYIdQZyk3GOUGtsgi9JaXD4 XfRuo9bhe/T5Xp3Scqi87Gjy39J48Rcvx25+gRPxSrNvqStRadBuZsmXSJ3/Tk0i wu5galeIkVLy/clHi3PoFgL1jzwNJW4PFBjZyhKNtuSUbS3vmu9NBPQOw51m4zQh 6fkKZwuSPU0jmCoovmFwwionx0Y+fHOVbwDYbL+ubLi84pwhUPrm87Xuu0g== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ak68dr198-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 22 Nov 2025 05:00:41 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-29845b18d1aso63611935ad.1 for ; Fri, 21 Nov 2025 21:00:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763787641; x=1764392441; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OykaP3QXAEqG4yI9kL9Noaj3OcsMMG9dgRdTlVS4bzE=; b=bk5dVVa/30F7K3qseNbgR69ybf5b8CLgH/ZaZ/T3+d3Tchaw2FeJHlNZtoSaCfTqrG 37XCdaR1nsKnqyUJcHymSk9frnmI9C4ocq/vStGbCFHjRRC8nfcyXx9r4I+aO+OdQwlp +A7z+YW5CgKB7dGHmPILulEkIlpO7ul3hC0AGnZBNR6uSp7qipBj+VylrKIvJ5UqTbHr 60Ao/TcVKCToE82lEIS8540e1aNrBJVAATJh93+H5D8RAVqqT3PwZ8etjCK6yO2TNdHd YTjbWKf5RBVApoqw/WUkOYkPQzNmoOuBUvWXr0Q9FBKuiseoEtbFOJSvB/lJUpJfXY0P 14MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763787641; x=1764392441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OykaP3QXAEqG4yI9kL9Noaj3OcsMMG9dgRdTlVS4bzE=; b=YyVXnHggf48cb/uOy77y5yV7a2wHHedQJfFPTk17qz1fYRA8XAY629ne+dU0xtxDOO J1BPUhx9glO3cC3RKsu9c1k0q8Ud9/mlERPV8GepFEeNFkfV2uBMUZBRRojLmYAn21O9 Ys84/rAL/mjy7vVjg7HRN0CkFWwRF0oHB1fDqRxI0gIeiRGymwoWLLvLIRdpaeKVIQz0 AUIoFbSmVqi98mH4W5DR+5Q0k+HE8VEGsnrIYcjRfGELBSp+NOtcrjHKO5jgG8xEluYX HzjeLTPwBAx/dCgAuQP+MKIKsbih626aE08maf3E+G/1HwiNR36+tSoBOJYzkB7i25tN 8pJw== X-Forwarded-Encrypted: i=1; AJvYcCWVUt8iB0f14/ozhwf/ykMS2s3msZ1ZSl0q3s91VnPhWHgbSYWPwDQt1ZEJgm+O8qRMTZQBs8pd7m6+bdQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxKR0uyR9gYvfogzJX3C23DtvQmpQVqWQ23nsJkzQrxP+L+JUga zrIJaVo+ZfVAXiARvkFQKuwMRn6ir53PDSdISxx6O37U+Mg+dHaBmDxouc5DX6QxvwxTJ21KzFM 4lAGiicKyxYQsNMw9eE1Waus5AbP/5WRXvB6ASeJ7nd4Q7LpQTRpkKKNF16hMFnEC2iM= X-Gm-Gg: ASbGncuOYh+hQZGByHPuxEIOzFs7yMDYfrgKC8zmaryit9YJsSXzHZE01c+2+yhPwBj /kgq6pbJw7FTMF4Xdlsg4pJvyLXK/noW5vKQgoi6U2kCXYj2kQY8eVzXN4ySOAkmksbd6e9039G 9Bwgi7u5t1f064YNejMhH2RThprWKuUrS2a1RMnIiD12xtPyktUWdiX3ugQizypfHHL3U6txiiT ZrhFQgSPeUQeLCXjv+/xE8guRcp9Blcbr4OEM+8v4Xf2p1QpUUhaYPkKzVFgV7dH+5fbuPlTQOw YDFf/8Z8+bbvKcak5OdHZHN76q0KUsg+E5fcLZg8kpf4PCL26Nyu+qtO8w2ukaJUD0afbdbmLMl K8Qw62PzNWaU4ZpAMtQudkXKNxvkaFS4LwgtIw3BfsFg= X-Received: by 2002:a17:902:ebc1:b0:27e:f018:d312 with SMTP id d9443c01a7336-29b6c3c71c1mr57439065ad.1.1763787641081; Fri, 21 Nov 2025 21:00:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IGzaJB3tETHFGPKwtS5H4CJ4sdq+g/8P4mFhp+moshcF5KdpfshYLuqDo5fwCI563FmZq1eIg== X-Received: by 2002:a17:902:ebc1:b0:27e:f018:d312 with SMTP id d9443c01a7336-29b6c3c71c1mr57438695ad.1.1763787640449; Fri, 21 Nov 2025 21:00:40 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b138c08sm70688725ad.25.2025.11.21.21.00.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 21:00:40 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: psodagud@quicinc.com, djaggi@quicinc.com, quic_msavaliy@quicinc.com, quic_vtanuku@quicinc.com, quic_arandive@quicinc.com, quic_shazhuss@quicinc.com, Konrad Dybcio Subject: [PATCH v1 01/12] soc: qcom: geni-se: Refactor geni_icc_get() and make qup-memory ICC path optional Date: Sat, 22 Nov 2025 10:30:07 +0530 Message-Id: <20251122050018.283669-2-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251122050018.283669-1-praveen.talari@oss.qualcomm.com> References: <20251122050018.283669-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIyMDAzNyBTYWx0ZWRfXyFnQh89K2MJV i/7YmdiPMuYg0AW3UCfvzFekx34GFuJaHw8XLGcfu77uFxtG8elNpofhN5tXaV3o3W+NtFYmUA1 CwYNgrBnATA2jsArLMe4Y0sUAHTigH2To0UZmKrza5cDpjWwamRf138WE0xsD6CspUwLfAfYuUs h9gc2uTEGlU6LHThql8llsIFB6w2asHVp68liVZIO0qveySEfxhYnV1a4ytuvFupxBOxFTHpTTa lRfMf7j7/7qj5H6SkemEWL00qasj5Oukll9ENa0ckc5zWRNLTDKS0m4zFXxw21mMwyd/K4q0WGL 3kEo2S6qLrpDbTUyMENg0pW4rurarIpFWVXyFyQ9I8lOQLuZXBTT1axCsnOy35XQksC4xoVQ7um 5Wyb5UEeurLw/C0qqebY4m2XiDIuKg== X-Proofpoint-GUID: OkovylZrqQnNBgdHUf2gvG153E30ZAwf X-Proofpoint-ORIG-GUID: OkovylZrqQnNBgdHUf2gvG153E30ZAwf X-Authority-Analysis: v=2.4 cv=UsBu9uwB c=1 sm=1 tr=0 ts=69214379 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=GTpMjWLy6HWSKpZSgkwA:9 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-22_01,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 priorityscore=1501 impostorscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511220037 Content-Type: text/plain; charset="utf-8" Refactor the geni_icc_get() function to replace the loop-based ICC path initialization with explicit handling of each interconnect path. This improves code readability and allows for different error handling per path type. The "qup-core" and "qup-config" paths remain mandatory, while "qup-memory" is now optional and skipped if not defined in DT. Co-developed-by: Konrad Dybcio Signed-off-by: Konrad Dybcio Signed-off-by: Praveen Talari --- drivers/soc/qcom/qcom-geni-se.c | 36 +++++++++++++++++---------------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index cd1779b6a91a..b6167b968ef6 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -899,30 +899,32 @@ EXPORT_SYMBOL_GPL(geni_se_rx_dma_unprep); =20 int geni_icc_get(struct geni_se *se, const char *icc_ddr) { - int i, err; - const char *icc_names[] =3D {"qup-core", "qup-config", icc_ddr}; + struct geni_icc_path *icc_paths =3D se->icc_paths; =20 if (has_acpi_companion(se->dev)) return 0; =20 - for (i =3D 0; i < ARRAY_SIZE(se->icc_paths); i++) { - if (!icc_names[i]) - continue; - - se->icc_paths[i].path =3D devm_of_icc_get(se->dev, icc_names[i]); - if (IS_ERR(se->icc_paths[i].path)) - goto err; + icc_paths[GENI_TO_CORE].path =3D devm_of_icc_get(se->dev, "qup-core"); + if (IS_ERR(icc_paths[GENI_TO_CORE].path)) + return dev_err_probe(se->dev, PTR_ERR(icc_paths[GENI_TO_CORE].path), + "Failed to get 'qup-core' ICC path\n"); + + icc_paths[CPU_TO_GENI].path =3D devm_of_icc_get(se->dev, "qup-config"); + if (IS_ERR(icc_paths[CPU_TO_GENI].path)) + return dev_err_probe(se->dev, PTR_ERR(icc_paths[CPU_TO_GENI].path), + "Failed to get 'qup-config' ICC path\n"); + + /* The DDR path is optional, depending on protocol and hw capabilities */ + icc_paths[GENI_TO_DDR].path =3D devm_of_icc_get(se->dev, "qup-memory"); + if (IS_ERR(icc_paths[GENI_TO_DDR].path)) { + if (PTR_ERR(icc_paths[GENI_TO_DDR].path) =3D=3D -ENODATA) + icc_paths[GENI_TO_DDR].path =3D NULL; + else + return dev_err_probe(se->dev, PTR_ERR(icc_paths[GENI_TO_DDR].path), + "Failed to get 'qup-memory' ICC path\n"); } =20 return 0; - -err: - err =3D PTR_ERR(se->icc_paths[i].path); - if (err !=3D -EPROBE_DEFER) - dev_err_ratelimited(se->dev, "Failed to get ICC path '%s': %d\n", - icc_names[i], err); - return err; - } EXPORT_SYMBOL_GPL(geni_icc_get); =20 --=20 2.34.1