From nobody Tue Dec 2 01:26:44 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E84292C11C4 for ; Sat, 22 Nov 2025 05:01:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763787708; cv=none; b=kaHd6iTKqIkT83dWl9oYyxH55I+pC0LAb4F9Xaixv5x4DeMJD20VGbjCsJ96X5kadVjD6btZZEsvEgK9ZEBnwJZQoaiH6VpRUimQu27e/P71b61r4GCcgfpvvViaLBdjN9xtFZb5dRyJn0/paTJEKR/ynIZwubdAdESaB3mWMrg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763787708; c=relaxed/simple; bh=mbJR727ggrtrvgHXfUkmla3xXcuIgQNfVcXl74QOnS8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bvkPBbV383TVErjNKPvcE/c/AlKCFKIzGJ+4ZKGEeK8b0HA2oADaECVZ9le1/HIMlaccf9ykgrDfHYO4K9rAwKh75jf2NdxP1p8b+jwYLmdh8yyP6FtbXoii8GXJ2So4tW/70S4N5leng/YJ4Q6ZpOgrdrz0Dj9z1zDZxiAozwo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Y2A9yWiH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HYT2vFif; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Y2A9yWiH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HYT2vFif" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AM4dZ4O1090473 for ; Sat, 22 Nov 2025 05:01:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=cYCVHWiTnrq EYRLdnl7gmKSduhx1q7VxqZ9bihRVOkM=; b=Y2A9yWiH2h8PnKlKwMmELGn/esn 4YP6EU39sTHCsSRqvo/cuRSZg+yrY5MxHmJpbHiOy3QqeGNjgt9rOROTNLpt+f6K w8ZOqGKEMObVdf2EKkWDFNfUcU1tFA9d3wBH4+uNbATFmVOV30JeokbKx3oh0RRa vq6U6S/ptnBdwH6HdG7C9BYbbELwZx8zMUPQLtz2h8HejgYIX+tfgbg0jwdvwbkn zh/3E/MDnupynFWrk5D5i6bsh57gp5j5rvTqzhOxSe0alwozGx2rXrZB1bImnMPR 3sx/sctzhpg0hmZCE4Dhp3fsYdbGdTUC+53pIBOFmkwkk4ro5F2VsSgP8HA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ak6bgr137-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 22 Nov 2025 05:01:46 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2954d676f9dso20194375ad.0 for ; Fri, 21 Nov 2025 21:01:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763787705; x=1764392505; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cYCVHWiTnrqEYRLdnl7gmKSduhx1q7VxqZ9bihRVOkM=; b=HYT2vFifSwdIHkpKVzdByw77aKDuIh0hhPeRbUjpXn7yhEnTZ1jBXFrO3syX88g8Uz lkbdWz3H+MBdLdgAybSvstXIYNFGdy/H1V9z09ny0y4IC2+11gPN3+IWnmQCW1h643Uq 3D3RUcWooWPsMkMyQL8RiDTF94Oq9esM09c8L3bLu2VtqevUZcH/Wf0B/b2qqVbo7hcN EUauQr6T2Im7l2MEsi64PwE3ajjoRCqnZG2fmx7jDJRsT3BEjAd83Ds4qPr7MEnj+Vj6 nRxjj9kDM9E2yzlp9bMl6iF1rcqJMwlxE/gkI0QCt2Myq5d3BeVMmXDfmaXPhQX4/+3P /DZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763787705; x=1764392505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cYCVHWiTnrqEYRLdnl7gmKSduhx1q7VxqZ9bihRVOkM=; b=oOMcwSIvQLp8+7vy3PsiQINcSxU419ie3XnqEbufynoNUJYHCg8fKqz0c2Y64mZ5Do 4NsmSAjptO/DRU/NlNQSQzbX5Hu0+DwW3iPTM9CO/NztQ6eS1xZbLdGdYR7hNs721YTm TpddMXCrr3RBPqNfZ7jnTyJqk+1z2e3wT2fMb1ZK0gxg5UujlmiF5/82lHQ+lOwA/th4 aLhM8/WKDaUlBHvm/VFbBwmgOwrz8IZTVqHCxrOkLgMIFrndGG4sudxKnFdKeDX1loV3 bXij9aZktv+bPiAJyqEXMNMxoH/vticA8WCh52iLwbKYRuUN3d0h1RhKoUxeJ5HztZ2N ePcg== X-Forwarded-Encrypted: i=1; AJvYcCVAX/98KvByALa2h94sYG0RJTy1GFMYcRixBx3AhME0IbrT2ZEm1zLu138YBVoiPme9wcxNzYK2p9pk3ok=@vger.kernel.org X-Gm-Message-State: AOJu0YxYChWsNNkwPc8oZkPVnv8mpdcNprzbR0vPHsHdF3w/3WFx/02q XB4fqGQ2lbULCm/hUjelUE3mJ4ZfsYlIKEtF1FgQJBuJlQIaVeJLbaQaL2ZCfXAD8pH0LssGCi7 GkTe/p6spBs1Y2Cm4PnDsFwvN9S32IpqjzXs//arp3qSSEgtoe071LEt1739ndNSIy5A= X-Gm-Gg: ASbGncvJx9nFCK1dlK6Pt8+spRPJxyipxy3cqD3dKnK0uFUvHd6kiYxiOHzSHl1suIL KCIPATenvtCeVNSvd6m4h6i6jBQQ5ZVeJ37jl5VJKuaY9fYiAVvTe2mDS0v/YUZnrDC5VF1fqAA lLW9szK1Gp2uC619tEbHRBCg8X7dWDxObZwNjV021bJu/mxTQlQwSIdE8eGZjOSOEofKHM4FKRn IVNyCL9SMUcqn73R3xRHyVFTbo62QUVu60cpPktXzwfbkUBFxQcbuf8JwB918JXK+zBj3S71Dzc BqumBEBqXcvGoeeQOsulVJwevNDY/2xhA17MmGHaPZVgzFKEOZLOKYI2BbYRNxnMFoxj3BXnMNt SPlkTmB/yLUEV3gIrACHJtvicQIq7ZYHFTqQJUbmgPII= X-Received: by 2002:a17:902:d588:b0:295:c2e7:7199 with SMTP id d9443c01a7336-29b6bf38528mr51869705ad.29.1763787705421; Fri, 21 Nov 2025 21:01:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8OAiROK7F5GVWbTxASpswDLwPXSs+Afy8DSzGXuPGImfgg2wHiAcv4P7FgsnG632nij/7gQ== X-Received: by 2002:a17:902:d588:b0:295:c2e7:7199 with SMTP id d9443c01a7336-29b6bf38528mr51869315ad.29.1763787704849; Fri, 21 Nov 2025 21:01:44 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b138c08sm70688725ad.25.2025.11.21.21.01.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 21:01:44 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: psodagud@quicinc.com, djaggi@quicinc.com, quic_msavaliy@quicinc.com, quic_vtanuku@quicinc.com, quic_arandive@quicinc.com, quic_shazhuss@quicinc.com Subject: [PATCH v1 11/12] i2c: qcom-geni: Store of_device_id data in driver private struct Date: Sat, 22 Nov 2025 10:30:17 +0530 Message-Id: <20251122050018.283669-12-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251122050018.283669-1-praveen.talari@oss.qualcomm.com> References: <20251122050018.283669-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: YmBdK2kThfz9iGCoF9gp3rFxEaUwCZfr X-Authority-Analysis: v=2.4 cv=MtJfKmae c=1 sm=1 tr=0 ts=692143ba cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=mUiiJuWc4wU39pmrI74A:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: YmBdK2kThfz9iGCoF9gp3rFxEaUwCZfr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIyMDAzNyBTYWx0ZWRfX1JOpKf6oGLrq 5z5B54K7VFT/Smj2bD4oLSq11HlZnnciGfno+xl3r+eISflwTkw0f/oA/gO4+PByZ8G0cAqZM8X LIMIiVMr+z/igjxiQb9vCXdLTf8NKJQapCLzIcqpzfc6UbAFiy+5NNlH5CZJMMlCx3fVfcDWgiW PhSaOxzIF1qfDrdOwo04XsKVPTjx+S/PJgiksNY04UuYmaqDw2r2uQ5mVrGTSskdvPq/uaZSZJ0 y6xFYySWsMHfJ/5yjFN1Ln7OtZ4hISheyVWQPu/Oe2evIMV3UdWzt39LkGWGkAq6gkWPAoq1iNa zpFPOLycpIB5wf6/9uRH0DV9l8x5flRnB7PPTGuxnc0rM3Hk+rUnjYmJmDtnmQAhQqelxGArnv2 3yZiDMB+ivRFN6nxB0F64IbAszBSWQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-22_01,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 priorityscore=1501 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511220037 Content-Type: text/plain; charset="utf-8" To avoid repeatedly fetching and checking platform data across various functions, store the struct of_device_id data directly in the i2c private structure. This change enhances code maintainability and reduces redundancy. Signed-off-by: Praveen Talari --- drivers/i2c/busses/i2c-qcom-geni.c | 32 ++++++++++++++++-------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qc= om-geni.c index ea117a4667e0..a0f68fdd4078 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -77,6 +77,13 @@ enum geni_i2c_err_code { #define XFER_TIMEOUT HZ #define RST_TIMEOUT HZ =20 +struct geni_i2c_desc { + bool has_core_clk; + char *icc_ddr; + bool no_dma_support; + unsigned int tx_fifo_depth; +}; + #define QCOM_I2C_MIN_NUM_OF_MSGS_MULTI_DESC 2 =20 /** @@ -121,13 +128,7 @@ struct geni_i2c_dev { bool is_tx_multi_desc_xfer; u32 num_msgs; struct geni_i2c_gpi_multi_desc_xfer i2c_multi_desc_config; -}; - -struct geni_i2c_desc { - bool has_core_clk; - char *icc_ddr; - bool no_dma_support; - unsigned int tx_fifo_depth; + const struct geni_i2c_desc *dev_data; }; =20 struct geni_i2c_err_log { @@ -978,7 +979,6 @@ static int setup_gpi_dma(struct geni_i2c_dev *gi2c) =20 static int geni_i2c_init(struct geni_i2c_dev *gi2c) { - const struct geni_i2c_desc *desc =3D NULL; u32 proto, tx_depth; bool fifo_disable; int ret; @@ -1001,8 +1001,7 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c) goto err; } =20 - desc =3D device_get_match_data(gi2c->se.dev); - if (desc && desc->no_dma_support) + if (gi2c->dev_data->no_dma_support) fifo_disable =3D false; else fifo_disable =3D readl_relaxed(gi2c->se.base + GENI_IF_DISABLE_RO) & FIF= O_IF_DISABLE; @@ -1020,8 +1019,8 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c) tx_depth =3D geni_se_get_tx_fifo_depth(&gi2c->se); =20 /* I2C Master Hub Serial Elements doesn't have the HW_PARAM_0 register */ - if (!tx_depth && desc) - tx_depth =3D desc->tx_fifo_depth; + if (!tx_depth && gi2c->dev_data->has_core_clk) + tx_depth =3D gi2c->dev_data->tx_fifo_depth; =20 if (!tx_depth) { ret =3D dev_err_probe(gi2c->se.dev, -EINVAL, @@ -1064,7 +1063,6 @@ static int geni_i2c_probe(struct platform_device *pde= v) struct geni_i2c_dev *gi2c; int ret; struct device *dev =3D &pdev->dev; - const struct geni_i2c_desc *desc =3D NULL; =20 gi2c =3D devm_kzalloc(dev, sizeof(*gi2c), GFP_KERNEL); if (!gi2c) @@ -1076,7 +1074,7 @@ static int geni_i2c_probe(struct platform_device *pde= v) if (IS_ERR(gi2c->se.base)) return PTR_ERR(gi2c->se.base); =20 - desc =3D device_get_match_data(&pdev->dev); + gi2c->dev_data =3D device_get_match_data(&pdev->dev); =20 ret =3D device_property_read_u32(dev, "clock-frequency", &gi2c->clk_freq_out); @@ -1221,6 +1219,10 @@ static const struct dev_pm_ops geni_i2c_pm_ops =3D { NULL) }; =20 +static const struct geni_i2c_desc geni_i2c =3D { + .icc_ddr =3D "qup-memory", +}; + static const struct geni_i2c_desc i2c_master_hub =3D { .has_core_clk =3D true, .icc_ddr =3D NULL, @@ -1229,7 +1231,7 @@ static const struct geni_i2c_desc i2c_master_hub =3D { }; =20 static const struct of_device_id geni_i2c_dt_match[] =3D { - { .compatible =3D "qcom,geni-i2c" }, + { .compatible =3D "qcom,geni-i2c", .data =3D &geni_i2c }, { .compatible =3D "qcom,geni-i2c-master-hub", .data =3D &i2c_master_hub }, {} }; --=20 2.34.1