From nobody Tue Dec 2 01:06:24 2025 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 920522BE64A for ; Fri, 21 Nov 2025 22:34:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763764492; cv=none; b=sWLe6TYQg1fBy3nhB0DcsowBcxEeafYI7R7Nv4xJGplgvUJgjR3WQtYw4PiOw8Ex51Tw50VJn8RZFBgHIePYdnwU5ZhEpm8nVC7LzwVjICstGX4Xgz5BTAn6Lw6fhX6UKcxfFCNktYGQuoo1vl7mk+HnmLxqhpYR3lAu9tZrBXo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763764492; c=relaxed/simple; bh=Cm8gNTD5HDKhB/YGSur7bO18CAjWuu8P/nm0G7TmJAI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=OctKg1UVAiLqaPCqoLXBV9LD0pRvHvdnmPr3CTW6WQ72M/F/c2XanGXDNv6W6OE/nYLqFuUh0vgPHenudTj7qkZ/ZSQ00ym6hi/kztn5oGnO0jtvWRgqlLZHct8CJoZdJaHKn6B8NLqEL7OzXZjUiKNvcppsx5Tpavr9hqmKh0c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=KxoNE8cz; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KxoNE8cz" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-3436d81a532so5227871a91.3 for ; Fri, 21 Nov 2025 14:34:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763764489; x=1764369289; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=fL7AO/YbZegwLET4orHpyrj5KMZ/eiSlht4bCLj4XfI=; b=KxoNE8czMhrAIuqTXID3hOPgYM4/aOkcwU8BQ9P9NkIJ/Hh7vptj6ajnvZzjQaDH6s iFXGGU0xV8zN9AvkoK7hucxo8m4fy8VEAK+YAc6G+UNvyzg80BS6nVerjwd+r5SIimW0 Ffp8BTOOhn2oSgyJrv8onnougpkCb3bDVLpGEYmPchAcG1o5YlzQDNhEPS0iY3ECzxW7 BBEDF0Wq8o+8LQH9NObsYc9EWeFiqJ+E+9z37M5uUPk7S9gbpXJKQGVIeid2gqY34zVn AYXuPJFeZILfkMnTi4a9LaG6AyuIzGElg3UHseA3Czq/kTQRXMgzVntxWeXBTO4KG186 sqDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763764489; x=1764369289; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fL7AO/YbZegwLET4orHpyrj5KMZ/eiSlht4bCLj4XfI=; b=f4ZrgM2Ve4OLwgMEsuHB7lFr8CDBVcjPwN4knUOMMhrCBRXoq7BypcCoOlkd2DgCjY lHZVc3L2mj8HvEQMOjAeTTNhYJSF5MhMBcmNhSyPrIyY6Jea0H9EfbvIkfY9sCVwD61m ozTSXkGGRhC6p06En7iooVeFYJ8Chu20nMArABtUKyYEYx66T5Xo4XEqJAbNQPqfyFZI o3hiUIJvUuMN4yOfU+SwJuw5poxFSp23WLRiX+8mQR3n9i5AbGeHS3x7yKQ7VtlBBfVG nrGoCBnFM8yIGne0R/+gMMamDmAYvR8thSK9OZ37FIxOBGtx5fvTU7d3mCrsSOKsFtj4 jOfQ== X-Forwarded-Encrypted: i=1; AJvYcCWWk4A9kEbqOBiz0rOOJlruP3cxFccVqy2v6AGPXshW/VasdlCtPH8p0q3X/AHQ47gB0UHdbCpMYZojKH0=@vger.kernel.org X-Gm-Message-State: AOJu0YwaNYTpDXIX/hvP2DlSzhoAy2DgwbfGHXTqngZao0BPFio1CjJ9 DVM9oSFkocVEHcacGV/6Nz8VdMyvLLGv6mQvAWbkbRjLyC1ECZRq17X8yRxBfFFD2xmMHMG6QIW +Wp7sdw== X-Google-Smtp-Source: AGHT+IFx38F9ERfpPh0lVhU0L2PRJHoxe79c5A/zraSF90gTXT2UYGC9P0VIoAeDIru6h3DDh0xdhuRVZb8= X-Received: from pjty8.prod.google.com ([2002:a17:90a:ca88:b0:340:c06f:96e7]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2d0c:b0:32e:389b:8762 with SMTP id 98e67ed59e1d1-34733d845bemr3846543a91.0.1763764488614; Fri, 21 Nov 2025 14:34:48 -0800 (PST) Reply-To: Sean Christopherson Date: Fri, 21 Nov 2025 14:34:40 -0800 In-Reply-To: <20251121223444.355422-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251121223444.355422-1-seanjc@google.com> X-Mailer: git-send-email 2.52.0.rc2.455.g230fcf2819-goog Message-ID: <20251121223444.355422-2-seanjc@google.com> Subject: [PATCH v3 1/5] KVM: Use vCPU specific memslots in __kvm_vcpu_map() From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Fred Griffoul Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When establishing a "host access map", lookup the gfn in the vCPU specific memslots, as the intent is that the mapping will be established for the current vCPU context. Specifically, using __kvm_vcpu_map() in x86's SMM context should create mappings based on the SMM memslots, not the non-SMM memslots. Luckily, the bug is benign as x86 is the only architecture with multiple memslot address spaces, and all of x86's usage is limited to non-SMM. The calls in (or reachable by) {svm,vmx}_enter_smm() are made before enter_smm() sets HF_SMM_MASK, and the calls in {svm,vmx}_leave_smm() are made after emulator_leave_smm() clears HF_SMM_MASK. Note, kvm_vcpu_unmap() uses the vCPU specific memslots, only the map() side of things is broken. Fixes: 357a18ad230f ("KVM: Kill kvm_map_gfn() / kvm_unmap_gfn() and gfn_to_= pfn_cache") Signed-off-by: Sean Christopherson --- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 9eca084bdcbe..afe13451ce7f 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -3118,7 +3118,7 @@ int __kvm_vcpu_map(struct kvm_vcpu *vcpu, gfn_t gfn, = struct kvm_host_map *map, bool writable) { struct kvm_follow_pfn kfp =3D { - .slot =3D gfn_to_memslot(vcpu->kvm, gfn), + .slot =3D kvm_vcpu_gfn_to_memslot(vcpu, gfn), .gfn =3D gfn, .flags =3D writable ? FOLL_WRITE : 0, .refcounted_page =3D &map->pinned_page, --=20 2.52.0.rc2.455.g230fcf2819-goog From nobody Tue Dec 2 01:06:24 2025 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D48A030594D for ; Fri, 21 Nov 2025 22:34:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763764492; cv=none; b=DjsTQ7ogt9zNmHFotwBI5jE5iozDZ00S4J2BSwJtB3/ZVwxLvu8KZ18v0Z/VIeT8c9dolpDyHtoKbo2PhP57XM3PvmCLDxqjdqa33M/iDQaHDyeVSuZKnuOtCh/Rty1YJYmyJAqq94+R32zmXYIqfBD5vWwyHC9+AwoMuTQozMs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763764492; c=relaxed/simple; bh=e7RsKRdyXzqO8wbi+wGlXN2nJr4pNMDA7BM2zx30F3k=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Zg8ZN4C7J4eA7BQFme9yBkXtgHPrDNYZiNIfeGCNvMOORdSek2pn8Fcu8BhJlWUSmUZh3ioV2vpk3meLg31V+8Ow6x96KmZsloVD2ur3qAnHk0royUap2cTxaj75JGHmxnJlbmVPjR2jWdoPtBbxzgpAsjDaAAFRX8AWPdF3frk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QV8haDhH; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QV8haDhH" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-3437863d0easo4413085a91.0 for ; Fri, 21 Nov 2025 14:34:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763764490; x=1764369290; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=gYfQkN9u3Ku3wBXo81BUiJiwGWW8HyZzPi7J/C1YrKM=; b=QV8haDhHD7JsqWAb1z9mCVdTnCOB2VASdXY+Kfbds9JPhzUm/wT7VD+E0WiHqmiJO1 QSTo9GQkIYlT4kzTpyAiQl1UvEzsGCYwsMbQLH+09KwJDI8RNULY58JZN+9IY1EOc2eB pCU2i+JNP1XJdk0BFxzeecheVZ/LY0zM6b1y33kkfwre0NtTVD6dFYNx0fvK6hCPXpuW xvDP+NGITmXlM5k7Ew76ND0FYsOE16OowaSMpdkkpe0C5tfXTHA7cHJ0wdqaZDPT1M/T zh2qMwOfFxQ3UZDxI6vw9LbKJDtPDx3wK8LPNc1Q2BwnoDBv7Q20sxn9FODidkd1LsI8 3L0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763764490; x=1764369290; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gYfQkN9u3Ku3wBXo81BUiJiwGWW8HyZzPi7J/C1YrKM=; b=JqDiEvq8ELhZw42Rl5Si1S1z3LCI/vt+IfMRDF9U6oAXGscByeJOejAMG+vo528o2i sNZzk7QezZcISyuFqFOXLkJFppLvcHgbO9tu5cv2ccrgZ7P2W8XGx2mHCWENRld64gTP f3K0dx0L60nCsgmlZe0B83qAlMYirk8svXAHTbraPtkZIFaItIoOmezPUcj8QIKAKhNS Ip3ja4LwP+UqPMR2qjQNl9j9Nnkne16z8e0xnRtkpuajcrFRCGadzHuu+Dd1jDddlMKx M6WCQL9GoVnUwAYqwR8b0Seja2fMpOd8+WgXKKc/XgpEBKpoD/Z8B1zXE4y6BHSy9CGY CFuA== X-Forwarded-Encrypted: i=1; AJvYcCXzdNLi5zehA4tnYNuvJ9o2rpxyKez8huOK/w5FL5HM23NgTKOT9br5eJ1gdzp3QGlYygxsnlsZ2QY3kIE=@vger.kernel.org X-Gm-Message-State: AOJu0YzV4+aCWYluZ66UqAWFuCu4qxsOB6id1ucQCc7E8FuNxBgSJgRc qmTPGzM8ZslZwhBicBs5kSbEYEhaCnC+fTYZ50R0sOefPHhAxZAhGb4jRI+eEgZTsZC5z9r3tAl Pwyf8Dw== X-Google-Smtp-Source: AGHT+IEXbv9Rr9ebIprQdREDYFBXea2fQri7goRi056aI0TCciVMQ60b3yFhHrSpldN7RkxINC1QgCbQAYU= X-Received: from pjuk6.prod.google.com ([2002:a17:90a:d086:b0:339:ee5f:ec32]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:270d:b0:340:2a16:94be with SMTP id 98e67ed59e1d1-34733e5524amr4367353a91.4.1763764490156; Fri, 21 Nov 2025 14:34:50 -0800 (PST) Reply-To: Sean Christopherson Date: Fri, 21 Nov 2025 14:34:41 -0800 In-Reply-To: <20251121223444.355422-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251121223444.355422-1-seanjc@google.com> X-Mailer: git-send-email 2.52.0.rc2.455.g230fcf2819-goog Message-ID: <20251121223444.355422-3-seanjc@google.com> Subject: [PATCH v3 2/5] KVM: x86: Mark vmcs12 pages as dirty if and only if they're mapped From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Fred Griffoul Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Mark vmcs12 pages as dirty (in KVM's dirty log bitmap) if and only if the page is mapped, i.e. if the page is actually "active" in vmcs02. For some pages, KVM simply disables the associated VMCS control if the vmcs12 page is unreachable, i.e. it's possible for nested VM-Enter to succeed with a "bad" vmcs12 page. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/nested.c | 15 +++------------ include/linux/kvm_host.h | 9 ++++++++- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c index 40777278eabb..d4ef33578747 100644 --- a/arch/x86/kvm/vmx/nested.c +++ b/arch/x86/kvm/vmx/nested.c @@ -3983,23 +3983,14 @@ static void vmcs12_save_pending_event(struct kvm_vc= pu *vcpu, =20 void nested_mark_vmcs12_pages_dirty(struct kvm_vcpu *vcpu) { - struct vmcs12 *vmcs12 =3D get_vmcs12(vcpu); - gfn_t gfn; + struct vcpu_vmx *vmx =3D to_vmx(vcpu); =20 /* * Don't need to mark the APIC access page dirty; it is never * written to by the CPU during APIC virtualization. */ - - if (nested_cpu_has(vmcs12, CPU_BASED_TPR_SHADOW)) { - gfn =3D vmcs12->virtual_apic_page_addr >> PAGE_SHIFT; - kvm_vcpu_mark_page_dirty(vcpu, gfn); - } - - if (nested_cpu_has_posted_intr(vmcs12)) { - gfn =3D vmcs12->posted_intr_desc_addr >> PAGE_SHIFT; - kvm_vcpu_mark_page_dirty(vcpu, gfn); - } + kvm_vcpu_map_mark_dirty(vcpu, &vmx->nested.virtual_apic_map); + kvm_vcpu_map_mark_dirty(vcpu, &vmx->nested.pi_desc_map); } =20 static int vmx_complete_nested_posted_interrupt(struct kvm_vcpu *vcpu) diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index d93f75b05ae2..536d05e2726f 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -1381,6 +1381,7 @@ bool kvm_vcpu_is_visible_gfn(struct kvm_vcpu *vcpu, g= fn_t gfn); unsigned long kvm_host_page_size(struct kvm_vcpu *vcpu, gfn_t gfn); void mark_page_dirty_in_slot(struct kvm *kvm, const struct kvm_memory_slot= *memslot, gfn_t gfn); void mark_page_dirty(struct kvm *kvm, gfn_t gfn); +void kvm_vcpu_mark_page_dirty(struct kvm_vcpu *vcpu, gfn_t gfn); =20 int __kvm_vcpu_map(struct kvm_vcpu *vcpu, gpa_t gpa, struct kvm_host_map *= map, bool writable); @@ -1398,6 +1399,13 @@ static inline int kvm_vcpu_map_readonly(struct kvm_v= cpu *vcpu, gpa_t gpa, return __kvm_vcpu_map(vcpu, gpa, map, false); } =20 +static inline void kvm_vcpu_map_mark_dirty(struct kvm_vcpu *vcpu, + struct kvm_host_map *map) +{ + if (kvm_vcpu_mapped(map)) + kvm_vcpu_mark_page_dirty(vcpu, map->gfn); +} + unsigned long kvm_vcpu_gfn_to_hva(struct kvm_vcpu *vcpu, gfn_t gfn); unsigned long kvm_vcpu_gfn_to_hva_prot(struct kvm_vcpu *vcpu, gfn_t gfn, b= ool *writable); int kvm_vcpu_read_guest_page(struct kvm_vcpu *vcpu, gfn_t gfn, void *data,= int offset, @@ -1410,7 +1418,6 @@ int kvm_vcpu_write_guest_page(struct kvm_vcpu *vcpu, = gfn_t gfn, const void *data int offset, int len); int kvm_vcpu_write_guest(struct kvm_vcpu *vcpu, gpa_t gpa, const void *dat= a, unsigned long len); -void kvm_vcpu_mark_page_dirty(struct kvm_vcpu *vcpu, gfn_t gfn); =20 /** * kvm_gpc_init - initialize gfn_to_pfn_cache. --=20 2.52.0.rc2.455.g230fcf2819-goog From nobody Tue Dec 2 01:06:24 2025 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33265303C91 for ; Fri, 21 Nov 2025 22:34:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763764498; cv=none; b=s8OrD3n+ktD9Y9+QsHW38G0EWfCs2eIS4XOgV8bPxyzYDymcmo45keZmEemeyauSsis6FMOfuUEqYSoFrmZyaPKQd0UioQdHR4kISam2WYDjnJgjiBrw8lvJZKu3aa3ja2K4E/kmonedZ7Pp6xo4J1QbSmzse/CvnbrPKmFko9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763764498; c=relaxed/simple; bh=7Xe3qDH6ZKzsQpPuowUY9HUcV1Hk4sOsCTpbpwGJBT0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=X526P43qeOtRN1lKeirArV3KUIrUGPySMecn1DOXs1o3jNl6BeZ9oPOeD7yxKtne4QPyrmrUNm7EKhNmSjd4zY9ScS7XdR+y9JZZCy13H0gTVNCbjKyUDJwc212NcCCi6U3Gpp/wdX6QWk957NqsI9GbTGUeyQoow+H0T9aoIuo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=TURhejT1; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TURhejT1" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-297f3710070so62395445ad.2 for ; Fri, 21 Nov 2025 14:34:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763764492; x=1764369292; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=1mfMySPMjnmJsOaOUb/BM+KRAPsIyAYo55wsBBcQK4Q=; b=TURhejT1dvyi7bFcfoIg4SGIYf/svS9dS0ve13WBZBtR7K/nCel45Ckni8MCRtGiU1 jOQhsOt4xpDvjnibUthGDitnKOrYG1a1xZCUttPkuim+MzBlwthjW0synzOPE2Y8D8sl jWLj9xzy3f1QlQ7bI3o9POo/+HuhWhunBPxLab2DML+iHuSZl1WBOsmbngjgWld77ZT+ OB+iUvKih4nKPWKY37ju1NP81H96nV7oOR2XCNgRLu5VHDIpTNx5CBvaw0fhMmSlrqkN CP1Uw1iFOZCb2gp174xFAHTmDVtRHGA4PqbZ1/r46MiMhlQUlBox9ixp0Sp5EgpdKXs8 g99w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763764492; x=1764369292; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1mfMySPMjnmJsOaOUb/BM+KRAPsIyAYo55wsBBcQK4Q=; b=ZPbLRwAumLOOAmSH/nVaX163TC5ogBvfR8JRUn7U/8xhoDXBkR81lmTRUQQ8WIOSU7 OD5WgdAc60OSHkXtCcl+EqQJWrut7mDJFau5VR349vj0WlEeGtTluf9dYUrPtSybClT3 ryV5cbnbO0tpmWUK3EZgTgo2SmKSeaKwZStsq3DsMUZmzdnUDhVyrEYYqtUd3WE17dFp FpCKGVTybgd+pueIM4340ft49pR3Qj4h8G5FYvDGTXwo9noxhNeHUPdKSy5Ufz3i2fPZ pu26d0s5mz1LG281fb1GiVO9AtrMzzAyD0QSUCVspbw4UHg5KrKssOERxPd816CQek9J fYlA== X-Forwarded-Encrypted: i=1; AJvYcCVJp59/+7F0aeSdi3qUaWBJgkW2XSfkhw6J2fUBzDYhmLSsRl6MbxtUmwtjXVvS22MXf8sl6rJLaUvAHCE=@vger.kernel.org X-Gm-Message-State: AOJu0YxvTbG5UBwa+VZRoTFgJCi/SU3ufJk9HHiEyOahav5ngj7xi0FM UICvXSP2bMKGUJuY5D7wNPgy4A63S+zR5hQMdoIoyKyYhZoSuCSTvY+zxX0GlpF9RnCD6UwQ85b FFIvuoA== X-Google-Smtp-Source: AGHT+IFj9RuRV1UAsJsdC2BoWHM8pJJQOrksLgBpTc07xLXfaxVjVM2sIZK/7aS0zyKbjdcsJJO13/uH/RU= X-Received: from plot21.prod.google.com ([2002:a17:902:8c95:b0:298:321b:1fa8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f706:b0:297:c889:ba37 with SMTP id d9443c01a7336-29b6c6a4a1fmr45042745ad.41.1763764491941; Fri, 21 Nov 2025 14:34:51 -0800 (PST) Reply-To: Sean Christopherson Date: Fri, 21 Nov 2025 14:34:42 -0800 In-Reply-To: <20251121223444.355422-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251121223444.355422-1-seanjc@google.com> X-Mailer: git-send-email 2.52.0.rc2.455.g230fcf2819-goog Message-ID: <20251121223444.355422-4-seanjc@google.com> Subject: [PATCH v3 3/5] KVM: nVMX: Precisely mark vAPIC and PID maps dirty when delivering nested PI From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Fred Griffoul Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Explicitly mark the vmcs12 vAPIC and PI descriptor pages as dirty when delivering a nested posted interrupt instead of marking all vmcs12 pages as dirty. This will allow marking the APIC access page (and any future vmcs12 pages) as dirty in nested_mark_vmcs12_pages_dirty() without over- dirtying in the nested PI case. Manually marking the vAPIC and PID pages as dirty also makes the flow a bit more self-documenting, e.g. it's not obvious at first glance that vmx->nested.pi_desc is actually a host kernel mapping of a vmcs12 page. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/nested.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c index d4ef33578747..d0cf99903971 100644 --- a/arch/x86/kvm/vmx/nested.c +++ b/arch/x86/kvm/vmx/nested.c @@ -4027,7 +4027,8 @@ static int vmx_complete_nested_posted_interrupt(struc= t kvm_vcpu *vcpu) } } =20 - nested_mark_vmcs12_pages_dirty(vcpu); + kvm_vcpu_map_mark_dirty(vcpu, &vmx->nested.virtual_apic_map); + kvm_vcpu_map_mark_dirty(vcpu, &vmx->nested.pi_desc_map); return 0; =20 mmio_needed: --=20 2.52.0.rc2.455.g230fcf2819-goog From nobody Tue Dec 2 01:06:24 2025 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B0AC2FFDD9 for ; Fri, 21 Nov 2025 22:34:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763764501; cv=none; b=NuCPTn6d7O0ou5UNyzQ4jWjzEQ/m3I5DuJRKM5ZpfYq2xUtVFDVX522/DJxXxx7RiabHm7ESMPAewFL0+0vooUtcDx0UHNKuw6/1PDcBeg4ZiKA98m/YJck82JJUWYz9pxbXDXmaSU0MMnJGRNbOrLRsFjXfQ/LCAbSkQVhj/Pc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763764501; c=relaxed/simple; bh=yz0/RGPQhgUuawce+VsL4GeCp7piSee5icPYDy8cV6c=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=lfZqxbl3h52o8uzKys/hmQjVVMPXhGYOBLa0ZrvzHECIsxOGivu/vTJu1h9CLmefVF15HXxgrNzuSekekv0cWubCu/Uk5h7lfXJ3Mz3/YeZo/ZIXRpREgAkt91s0fQFXV+QXfdeCNmFji+oBOaxEjjds/kySfsFvHw6vQ1nWxsg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=pSuv5mXO; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pSuv5mXO" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-3418ad76023so5536344a91.0 for ; Fri, 21 Nov 2025 14:34:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763764494; x=1764369294; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=InBo93G5HI4PVLH9iAiwY8b0qujoTNU9yFW4BKVHb7c=; b=pSuv5mXOF9dHdZsdTevp90hvORKV5rqBdjKHc6BF0y9t2Ka/AEVrxzBjqIOIB0zppO XesYZxa0Hw/1wiz/QErAGtR3euTqw06fYINsuU6Sj1qXwSi/3lbTfSfKUZ3LaDF7g/7z EEZ+pWbAohf4E4QQL3ydd6qi6vCAgcbHeoyuTqu38cs5l5P8ta/NYEAs1O1ONzVkTx0L VkK/9xFpLIW7e7sYVZ2vP9q2D5ZVwh48yiJ241DkoFQ9iPg+5Ji5frUltyvwsU3I61kv IeiSGdM0n2X5KywZ5FfD1dXD4NfsHZfiTPa4+lSwWNT5dFhpzsEWZ+ATE10PJ6sr6cQm GquQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763764494; x=1764369294; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=InBo93G5HI4PVLH9iAiwY8b0qujoTNU9yFW4BKVHb7c=; b=m9NoyM8kCIKUZBojyRLO9PVCl0vX+e8hmHG0m1zxPGRAABrg+ZG7n/EH3BelmOwgBE 0tZ8SfRsWvuIFFCm/pI2tjKUtdonFa/bKPJSmAf584Y/y0N06XJPtCol5rCJdnOa+JtW DiY2XPKUi45qMTUV5Iywf4F1s5dFbc9imNuYPWN/N//O4S4MNK4/lup4yYs/7eyHxFp5 83Qsx49bcI/DgIgcf6UHkic4IYqyAyZPrTdPZQCC32Zh+NYZ0aupNZs7NYH8JidYAxQk h04nDnRzSP3q4aa72zwoAK1EQs+AUT37RgCvB4aoQG3/MFldK5mY4tKoOtmCBpj2N3sc MY3Q== X-Forwarded-Encrypted: i=1; AJvYcCVzr78n+NqHaahFiGnXJDzKs8Vz8KRXQMSpqePYKpXwSe3OS70ZNgLTi/Ln0T/2v0DgD4LahE0jkLxi/ok=@vger.kernel.org X-Gm-Message-State: AOJu0YwJ+lHdLaTETWf2hrGKWF6+hUNV5CfD+lLulS75dbH6y+gnwG6K IAQcz5KYB6Qhj9eiApgmhoW9w6x9U3y8R4kErONBw4ysDvpcd4zhIX3D3b6YRH49sZ5aka3SJNd bkFw1xw== X-Google-Smtp-Source: AGHT+IG/fkRkERFnKO9mGUfex1cS5KDldCvz0Sp1ylkSk1r8aqWB94jzs/m2QrXXVQ0EDvIltYU6m1G5OK0= X-Received: from pjbmi9.prod.google.com ([2002:a17:90b:4b49:b0:343:65be:4db2]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1c85:b0:32e:38b0:15f4 with SMTP id 98e67ed59e1d1-34733e46dc6mr5204222a91.7.1763764493765; Fri, 21 Nov 2025 14:34:53 -0800 (PST) Reply-To: Sean Christopherson Date: Fri, 21 Nov 2025 14:34:43 -0800 In-Reply-To: <20251121223444.355422-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251121223444.355422-1-seanjc@google.com> X-Mailer: git-send-email 2.52.0.rc2.455.g230fcf2819-goog Message-ID: <20251121223444.355422-5-seanjc@google.com> Subject: [PATCH v3 4/5] KVM: VMX: Move nested_mark_vmcs12_pages_dirty() to vmx.c, and rename From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Fred Griffoul Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move nested_mark_vmcs12_pages_dirty() to vmx.c now that it's only used in the VM-Exit path, and add "all" to its name to document that its purpose is to mark all (mapped-out-of-band) vmcs12 pages as dirty. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/nested.c | 13 ------------- arch/x86/kvm/vmx/vmx.c | 14 +++++++++++++- 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c index d0cf99903971..97554eda440c 100644 --- a/arch/x86/kvm/vmx/nested.c +++ b/arch/x86/kvm/vmx/nested.c @@ -3980,19 +3980,6 @@ static void vmcs12_save_pending_event(struct kvm_vcp= u *vcpu, } } =20 - -void nested_mark_vmcs12_pages_dirty(struct kvm_vcpu *vcpu) -{ - struct vcpu_vmx *vmx =3D to_vmx(vcpu); - - /* - * Don't need to mark the APIC access page dirty; it is never - * written to by the CPU during APIC virtualization. - */ - kvm_vcpu_map_mark_dirty(vcpu, &vmx->nested.virtual_apic_map); - kvm_vcpu_map_mark_dirty(vcpu, &vmx->nested.pi_desc_map); -} - static int vmx_complete_nested_posted_interrupt(struct kvm_vcpu *vcpu) { struct vcpu_vmx *vmx =3D to_vmx(vcpu); diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 4cbe8c84b636..cc38d08935e8 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -6378,6 +6378,18 @@ static void vmx_flush_pml_buffer(struct kvm_vcpu *vc= pu) vmcs_write16(GUEST_PML_INDEX, PML_HEAD_INDEX); } =20 +static void nested_vmx_mark_all_vmcs12_pages_dirty(struct kvm_vcpu *vcpu) +{ + struct vcpu_vmx *vmx =3D to_vmx(vcpu); + + /* + * Don't need to mark the APIC access page dirty; it is never + * written to by the CPU during APIC virtualization. + */ + kvm_vcpu_map_mark_dirty(vcpu, &vmx->nested.virtual_apic_map); + kvm_vcpu_map_mark_dirty(vcpu, &vmx->nested.pi_desc_map); +} + static void vmx_dump_sel(char *name, uint32_t sel) { pr_err("%s sel=3D0x%04x, attr=3D0x%05x, limit=3D0x%08x, base=3D0x%016lx\n= ", @@ -6655,7 +6667,7 @@ static int __vmx_handle_exit(struct kvm_vcpu *vcpu, f= astpath_t exit_fastpath) * Mark them dirty on every exit from L2 to prevent them from * getting out of sync with dirty tracking. */ - nested_mark_vmcs12_pages_dirty(vcpu); + nested_vmx_mark_all_vmcs12_pages_dirty(vcpu); =20 /* * Synthesize a triple fault if L2 state is invalid. In normal --=20 2.52.0.rc2.455.g230fcf2819-goog From nobody Tue Dec 2 01:06:24 2025 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4201130C37A for ; Fri, 21 Nov 2025 22:34:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763764503; cv=none; b=aU4zqVeuEoJFck5ZqJsT69UNRXieMQCR0JcDt4dcj/WR1oeXF68w5g5Ie11oK9B8uTuDE5RVpUi/blJFmNVg/ZKq32QkKNHcSmLdlueXzAvZ4WRS5yBTra7b0COupp1ko7kkGCfL5OKzP0mj8AsBQEnvTYPCtTzfOznR19AVgsk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763764503; c=relaxed/simple; bh=lsT+viZWqqRjn+PYwPpLEA611TTfzuqAF66ioLEfSpQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=U6yYtwiagjIFtkmItVwPjrTgGB2ScUivxAp93Ss4QRTN2v+mizv/CDFJWsYVeM73/xWkqeZYPpzqamGrHpGOrfF9X0AGFRpY33Dw2UZ16Yqt++akJ1w8jzvR/rPBQds/DYN856AEBIgMWn+ypqO4b8DLgjXBebb1c3tA8A7W6EM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=NXLZFeaV; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NXLZFeaV" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-34378c914b4so8418563a91.1 for ; Fri, 21 Nov 2025 14:34:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763764495; x=1764369295; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=FYb4mnjND8uyAYDZTY5jZv6bxtxo+QaDoqsrMNdwfeo=; b=NXLZFeaVw62Dmfs8/WSI3J/igoV5XcFIhPp4d4/2q84vBWoCdcVhT+x3ZGBcPkflii lqKoXDRQcTsZD9+m3Yq2qdOFitiX0vN2Fk0gqCCzYvMLtrzBHNYbSdpKFsrBHEVOtaKH Qj4cBAKWq8sUsPOPNc3bH8HbI2JtqcUqKIgMl8/JN3vsgEpSnQkDiyb/AILlwM/5PTXj bIwJFJpsE3VNA8VageyLf+u+C+UJw76x18Bq4D1x6kWe1zudSWyssMLH6B2RLaMglJqe U1EvsqlnKakJYkT20FErvHl9SP6gWqtaaa8CkucpwR8Z0CvDEe2PWlX+jO+8kM0V5bcq Yjfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763764495; x=1764369295; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FYb4mnjND8uyAYDZTY5jZv6bxtxo+QaDoqsrMNdwfeo=; b=QDLaOvvnjlCRbNjWTUFa5oB+DjEkNPikJCoBhVJ76lNVyUse5MO4RdtEuRGSAHPdMT ertJYp0lwPgc4nJ5rR9uznPVcNWq/jmIhqaQJOlAVz/p9C90KckIBp70P5tpLHLXKoTI 7xUW79nfupCsHfvtc3oaqn1KCQ8Jok040DRjbH98ChhNCE1KEkvaZMmUb8+xBuwr7TgV 5z8fJ5x+Eqgb47J8C//ycZxDXQ9JmkzTA59PfPX1xDGKhq2Qt2pFsoZjzYEw0TGWJ1sY VX6PMLIvEnDsz5E9R9LGPsiPTMqitDWwjibTLIQInZ54m9Ug+QEkkpIkQcuIQN/cJdLB b9Hw== X-Forwarded-Encrypted: i=1; AJvYcCVDJns9XajxnTw4UmAJut03qf9xGJRufz/AfRhSajAspvVwrQobUdZOrLyNtB2waR8nTPPTYrH7t3Gsg4U=@vger.kernel.org X-Gm-Message-State: AOJu0YwAGqmxnoFeIh9cjfopVEN8mZAeQ+uge6mMozI2xFLh2FMgf050 shbl+qEMIrm2hWM2SusPbjC2B6s2qnRBh+c9322pARTCHaY1a1yw0NZ/NUHeR0EaVrIglOd9D/9 8QJeiBw== X-Google-Smtp-Source: AGHT+IEQYvT+Zfk13DHjigZ5Eleetu/W6Uzwhp2vloqyzZ4LXM/6l8ZEnBMwrRp+I5s+uD9g9xfA2IZUjhc= X-Received: from pjbsk6.prod.google.com ([2002:a17:90b:2dc6:b0:341:7640:eb1e]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:384f:b0:340:ac7c:6387 with SMTP id 98e67ed59e1d1-34733e2d4a5mr5255149a91.7.1763764495318; Fri, 21 Nov 2025 14:34:55 -0800 (PST) Reply-To: Sean Christopherson Date: Fri, 21 Nov 2025 14:34:44 -0800 In-Reply-To: <20251121223444.355422-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251121223444.355422-1-seanjc@google.com> X-Mailer: git-send-email 2.52.0.rc2.455.g230fcf2819-goog Message-ID: <20251121223444.355422-6-seanjc@google.com> Subject: [PATCH v3 5/5] KVM: nVMX: Mark APIC access page dirty when syncing vmcs12 pages From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Fred Griffoul Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Fred Griffoul For consistency with commit 7afe79f5734a ("KVM: nVMX: Mark vmcs12's APIC access page dirty when unmapping"), which marks the page dirty during unmap operations, also mark it dirty during vmcs12 page synchronization. Signed-off-by: Fred Griffoul [sean: use kvm_vcpu_map_mark_dirty()] Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index cc38d08935e8..72ac42fdf3b1 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -6382,10 +6382,7 @@ static void nested_vmx_mark_all_vmcs12_pages_dirty(s= truct kvm_vcpu *vcpu) { struct vcpu_vmx *vmx =3D to_vmx(vcpu); =20 - /* - * Don't need to mark the APIC access page dirty; it is never - * written to by the CPU during APIC virtualization. - */ + kvm_vcpu_map_mark_dirty(vcpu, &vmx->nested.apic_access_page_map); kvm_vcpu_map_mark_dirty(vcpu, &vmx->nested.virtual_apic_map); kvm_vcpu_map_mark_dirty(vcpu, &vmx->nested.pi_desc_map); } --=20 2.52.0.rc2.455.g230fcf2819-goog