From nobody Tue Dec 2 01:26:14 2025 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA5F3275106 for ; Fri, 21 Nov 2025 20:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763758113; cv=none; b=bptyC3J3Irc5ixHutN2XP1Oa9wVmaLoqT5TtQ/UT0l3/czWdp4TsPJbKg+WoZVC+S6nivLpbnfgFXmoCdmJbCS6UUKfDSpp7Wn44YMDnAbdkQ7NgpTyrgEr4fy9PaiQtoqvCW8WGfs1XR194rSEK9OnKLoLPVoxa4ozk0rDrda4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763758113; c=relaxed/simple; bh=hpyXCaLd7ew/dcqvDFl4C3niWWixFynCHD8DMr1j4Ek=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rZm2UjwMZwz1f+GkZ02o1YLeKgSfzQQkxYJO93YIBbR4ggc03rz7I8nOR9O7rgTz/jUXvvFDmhuEM1HeMYkORcsir8PE3Ea4lKk5g8XKbp+cc+Q4bFnszNFyawKeEUIiu+69i8zS2Ma5RKYe/rA8B5bqjosR5RmSrErvQ0hHajQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=wSqyYPRo; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="wSqyYPRo" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1763758108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2BYEOKG5IPmbsqL2nPCG6aN8j59rRcYF/PmqlgakoQc=; b=wSqyYPRoWggxPTvnvUqepo9+zsJHVUpK3CsYmxnFBn8WSB2RUYwFJKUkCkpKcy8N5nKL0Z +laumH67fdbrvgch2yhFaNGDOG5Aa1Mv6cpk83GDOtIBChW196HqAZro1BVurZSVwieDfC CaQTKJ6slkSg4hLpQ72+07fJeTBM8/E= From: Yosry Ahmed To: Paolo Bonzini Cc: Sean Christopherson , Jim Mattson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yosry Ahmed Subject: [PATCH v3 1/4] KVM: SVM: Allow KVM_SET_NESTED_STATE to clear GIF when SVME==0 Date: Fri, 21 Nov 2025 20:48:00 +0000 Message-ID: <20251121204803.991707-2-yosry.ahmed@linux.dev> In-Reply-To: <20251121204803.991707-1-yosry.ahmed@linux.dev> References: <20251121204803.991707-1-yosry.ahmed@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Jim Mattson GIF=3D=3D0 together with EFER.SVME=3D=3D0 is a valid architectural state. Don't return -EINVAL for KVM_SET_NESTED_STATE when this combination is specified. Fixes: cc440cdad5b7 ("KVM: nSVM: implement KVM_GET_NESTED_STATE and KVM_SET= _NESTED_STATE") Signed-off-by: Jim Mattson Reviewed-by: Yosry Ahmed Signed-off-by: Yosry Ahmed --- arch/x86/kvm/svm/nested.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c index c81005b24522..3e4bd8d69788 100644 --- a/arch/x86/kvm/svm/nested.c +++ b/arch/x86/kvm/svm/nested.c @@ -1784,8 +1784,8 @@ static int svm_set_nested_state(struct kvm_vcpu *vcpu, * EFER.SVME, but EFER.SVME still has to be 1 for VMRUN to succeed. */ if (!(vcpu->arch.efer & EFER_SVME)) { - /* GIF=3D1 and no guest mode are required if SVME=3D0. */ - if (kvm_state->flags !=3D KVM_STATE_NESTED_GIF_SET) + /* GUEST_MODE must be clear when SVME=3D=3D0 */ + if (kvm_state->flags & KVM_STATE_NESTED_GUEST_MODE) return -EINVAL; } =20 --=20 2.52.0.rc2.455.g230fcf2819-goog