From nobody Tue Dec 2 01:25:10 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B35352939 for ; Fri, 21 Nov 2025 17:45:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763747156; cv=none; b=Z0ux8jcSIYK6K6NKRk9ZKKzmodOfNKU09uUuINXXoULcJjeAoVUkN6QWjj9TtOuxgmaEh9ioNPZOXV1+SlpMD2Nq+P5Aag613hl0PV4p+mk2h21jfexvIMiZrHqjMQQxeh7EdbxigfiavGHMyk99qSNndM3MW95upEwYSA4TNw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763747156; c=relaxed/simple; bh=vxt6YkT2AJM7gpYvCrWhvWBDfSnksKr0pxtwsqtUlrA=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rU56iibTrlKqZ6j+SdX3mMHW7QD/tf/PKFjLZ0zHFsqU3tL0kOxySk2taTd/PyKudBu+9L8h5dCrHMnc2EaVsLNji0SG9X8l47h7yc6ZHxk9aYv79Vh8Z+qbCWCLWAADcDGwhft43RxyceJKOki2qkOykX1zeM0JLJTBXCfsqZ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YzPjBQ8a; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=BeM8Oakh; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YzPjBQ8a"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="BeM8Oakh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763747153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=stUTEue8FT2h1CDBsUSOzIXkuLJSdaVPkM2CKd/Olvo=; b=YzPjBQ8aVgWE7PxfYqfoBSPAeIZdkDvxkQzTe77qfwXgqSdDXGe/uzlg++E2+Ci1y0/jfW 2rx/cXrYBmGC8i0/rvV9sn5eWZMj3aYX2wuPCDhVVBrXifef0ip2yKOy0Zk6WQpz4CFlOZ PzhzqoGfo3755nZwnaQAUWbDSzHHiR0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-326-jxFsUHD4NP-tg4LNb7kFLw-1; Fri, 21 Nov 2025 12:45:51 -0500 X-MC-Unique: jxFsUHD4NP-tg4LNb7kFLw-1 X-Mimecast-MFC-AGG-ID: jxFsUHD4NP-tg4LNb7kFLw_1763747150 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-477c49f273fso5741335e9.3 for ; Fri, 21 Nov 2025 09:45:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1763747150; x=1764351950; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=stUTEue8FT2h1CDBsUSOzIXkuLJSdaVPkM2CKd/Olvo=; b=BeM8OakhNkZLPZC+zkuvRoCIx/TDcYUMMULL+0UmS9Akdi+N9WJWqpIZsySKKA83Z7 rXeP4/h3U6tYdd1XCAx/9pVmIDF8glf6+tWmUWbdBY6LEdITN0EC+MRjM2Ttfz6slEM2 Ya81b8IzIsWgAngN+HjEVqMNU29ETSeX3zrcYVywmHhASypzZAj7of2bufhAAeZjq4bU mQ7YW2CcygYI+CgCcY8lPAZyBi+M8xbSxNY7p9l0rWLQc1fVpt3BOeu9ZnMCGoFtKQrV puF1heiHcJbp9BLXVbP8hotrnooCVykCuzMuIChGx6+qZBbw2Vdd3ipjOy7hlEjndWwk AXSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763747150; x=1764351950; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=stUTEue8FT2h1CDBsUSOzIXkuLJSdaVPkM2CKd/Olvo=; b=LQopzBf5oWFF3n4YlO3xHNWnZTm0I2OrOPYZIjGzhyaIzIp5PkTguZiwyGtqBS9v7I raX2u9uj8koLqaShFWLHh18znPxPgMQ9j3x4Y+WYrQKmldIeIpsDKM7uMCU2g8ilSaRp fR0M8/OmaNRsZU2DSDCNYe707/KwXjatA4HKyNpLYPjQjtoUFlXi51qB0NnZuY2tKPFP BTfctQfk7aFfXWZJDrJPW3mKaegQ1eDkwAaz3cRdVKjWRanzuaGTRDaLqedGBzne0T9S QD9IObgr12eAyg9tOXSyan3ZuvxZXarcSgW7DlS+LrfM3wPu3m8pka+N2VRQlXjECDuy 3JEw== X-Forwarded-Encrypted: i=1; AJvYcCUDRG6vhd93Q04nwSU//YcQnrVjGyi7B+H3ucKeIBndR+y0ZQWQlA+G2VhPsdfOdnsWJVPQpyDGaTtoCsE=@vger.kernel.org X-Gm-Message-State: AOJu0YyDOd+GBcx7iREx+FXOmfwpd6zcuye4GEdD0mCUGeuMc1CBH6qS mf8dLwaN7fKAq5AY9Qv2UBPY/nlGllquMRbRTkB1d62xWVYuGjA6u5m0AY5G6M/FdgvAPQe/h9S fpw/HBZoTRfWz8GIiJoX8Y3b3hsGx4c2sPVagcckmhJ+1wRv8+G8yOIlRAnR/WlzWjQ== X-Gm-Gg: ASbGncsbzshD8Phcgh/WEZ8F+0ETUBXGTEoafl4H6WpkNxgLwkdRpp5ZHQCiYyQVBgv 5pfVv1Ju2Rx3NXsUU8EaNZKgauaEverlmzVc31WcvuOtx34o4Gb88vpJ4+aqL8U/KBQPxmdK3+b fSrMdmaJgNPx+4vKjocThycBvilPMyLOwm5hI8o9BV3RqJEoMkUZ3fuI2tPMum3VPu2fR4bVFz1 /nSRSrFRLDF4sujFiXB13Sg6ULiXysAqJO+kFtyp3Gtll5Yn3B+hQIXlGr9/BdhHf2EQ9LQ5s53 BXDmlgyItxuwKaJ/DGH7rab+TIXNSWqoqquUltk9NVgnZRXqW0taEsd5VRl+mV0g0lQOZVJCsfo BKMAGhUPVFY7ZDZ3a+p4bdMDO X-Received: by 2002:a05:6000:2881:b0:429:bc56:cd37 with SMTP id ffacd0b85a97d-42cc1ac9ce9mr3485051f8f.6.1763747149722; Fri, 21 Nov 2025 09:45:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGpqCYrgceE1yQxRUQgFRs4ztxop0bpE/tG9aVbffduYMdGlSTjfpT7+d4XAocdRAomj/wX/g== X-Received: by 2002:a05:6000:2881:b0:429:bc56:cd37 with SMTP id ffacd0b85a97d-42cc1ac9ce9mr3485028f8f.6.1763747149258; Fri, 21 Nov 2025 09:45:49 -0800 (PST) Received: from costa-tp.bos2.lab ([2a00:a041:e294:5000:b694:8e49:4f51:966d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7ec454csm11529567f8f.0.2025.11.21.09.45.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 09:45:48 -0800 (PST) From: Costa Shulyupin To: Steven Rostedt , Tomas Glozar , Costa Shulyupin , Crystal Wood , Wander Lairson Costa , Ivan Pravdin , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 7/8] tools/rtla: Consolidate -P/--priority option parsing Date: Fri, 21 Nov 2025 19:45:03 +0200 Message-ID: <20251121174504.519230-8-costa.shul@redhat.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251121174504.519230-1-costa.shul@redhat.com> References: <20251121174504.519230-1-costa.shul@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Each rtla tool duplicates parsing of -P/--priority. Migrate the option parsing from individual tools to the common_parse_options(). Signed-off-by: Costa Shulyupin --- tools/tracing/rtla/src/common.c | 8 +++++++- tools/tracing/rtla/src/osnoise_hist.c | 9 +-------- tools/tracing/rtla/src/osnoise_top.c | 9 +-------- tools/tracing/rtla/src/timerlat_hist.c | 9 +-------- tools/tracing/rtla/src/timerlat_top.c | 9 +-------- 5 files changed, 11 insertions(+), 33 deletions(-) diff --git a/tools/tracing/rtla/src/common.c b/tools/tracing/rtla/src/commo= n.c index 6a1675eba96e..dd67c6b47eaa 100644 --- a/tools/tracing/rtla/src/common.c +++ b/tools/tracing/rtla/src/common.c @@ -62,11 +62,12 @@ int common_parse_options(int argc, char **argv, struct = common_params *common) {"debug", no_argument, 0, 'D'}, {"duration", required_argument, 0, 'd'}, {"event", required_argument, 0, 'e'}, + {"priority", required_argument, 0, 'P'}, {0, 0, 0, 0} }; =20 opterr =3D 0; - c =3D getopt_long(argc, argv, "c:C::Dd:e:", long_options, NULL); + c =3D getopt_long(argc, argv, "c:C::Dd:e:P:", long_options, NULL); =20 switch (c) { case 'c': @@ -95,6 +96,11 @@ int common_parse_options(int argc, char **argv, struct c= ommon_params *common) tevent->next =3D common->events; common->events =3D tevent; break; + case 'P': + if (parse_prio(optarg, &common->sched_param) =3D=3D -1) + fatal("Invalid -P priority"); + common->set_sched =3D 1; + break; default: optind =3D saved_state; return 0; diff --git a/tools/tracing/rtla/src/osnoise_hist.c b/tools/tracing/rtla/src= /osnoise_hist.c index c4013f50e803..6ed5f5594960 100644 --- a/tools/tracing/rtla/src/osnoise_hist.c +++ b/tools/tracing/rtla/src/osnoise_hist.c @@ -493,7 +493,6 @@ static struct common_params {"house-keeping", required_argument, 0, 'H'}, {"help", no_argument, 0, 'h'}, {"period", required_argument, 0, 'p'}, - {"priority", required_argument, 0, 'P'}, {"runtime", required_argument, 0, 'r'}, {"stop", required_argument, 0, 's'}, {"stop-total", required_argument, 0, 'S'}, @@ -515,7 +514,7 @@ static struct common_params if (common_parse_options(argc, argv, ¶ms->common)) continue; =20 - c =3D getopt_long(argc, argv, "a:b:E:hH:p:P:r:s:S:t::T:01234:5:6:7:", + c =3D getopt_long(argc, argv, "a:b:E:hH:p:r:s:S:t::T:01234:5:6:7:", long_options, NULL); =20 /* detect the end of the options. */ @@ -562,12 +561,6 @@ static struct common_params if (params->period > 10000000) fatal("Period longer than 10 s"); break; - case 'P': - retval =3D parse_prio(optarg, ¶ms->common.sched_param); - if (retval =3D=3D -1) - fatal("Invalid -P priority"); - params->common.set_sched =3D 1; - break; case 'r': params->runtime =3D get_llong_from_str(optarg); if (params->runtime < 100) diff --git a/tools/tracing/rtla/src/osnoise_top.c b/tools/tracing/rtla/src/= osnoise_top.c index 846d25ee4885..d2dfad960440 100644 --- a/tools/tracing/rtla/src/osnoise_top.c +++ b/tools/tracing/rtla/src/osnoise_top.c @@ -348,7 +348,6 @@ struct common_params *osnoise_top_parse_args(int argc, = char **argv) {"house-keeping", required_argument, 0, 'H'}, {"help", no_argument, 0, 'h'}, {"period", required_argument, 0, 'p'}, - {"priority", required_argument, 0, 'P'}, {"quiet", no_argument, 0, 'q'}, {"runtime", required_argument, 0, 'r'}, {"stop", required_argument, 0, 's'}, @@ -367,7 +366,7 @@ struct common_params *osnoise_top_parse_args(int argc, = char **argv) if (common_parse_options(argc, argv, ¶ms->common)) continue; =20 - c =3D getopt_long(argc, argv, "a:hH:p:P:qr:s:S:t::T:0:1:2:3:", + c =3D getopt_long(argc, argv, "a:hH:p:qr:s:S:t::T:0:1:2:3:", long_options, NULL); =20 /* Detect the end of the options. */ @@ -402,12 +401,6 @@ struct common_params *osnoise_top_parse_args(int argc,= char **argv) if (params->period > 10000000) fatal("Period longer than 10 s"); break; - case 'P': - retval =3D parse_prio(optarg, ¶ms->common.sched_param); - if (retval =3D=3D -1) - fatal("Invalid -P priority"); - params->common.set_sched =3D 1; - break; case 'q': params->common.quiet =3D 1; break; diff --git a/tools/tracing/rtla/src/timerlat_hist.c b/tools/tracing/rtla/sr= c/timerlat_hist.c index 4744f84a452e..e7ba083b5eb4 100644 --- a/tools/tracing/rtla/src/timerlat_hist.c +++ b/tools/tracing/rtla/src/timerlat_hist.c @@ -802,7 +802,6 @@ static struct common_params {"irq", required_argument, 0, 'i'}, {"nano", no_argument, 0, 'n'}, {"period", required_argument, 0, 'p'}, - {"priority", required_argument, 0, 'P'}, {"stack", required_argument, 0, 's'}, {"thread", required_argument, 0, 'T'}, {"trace", optional_argument, 0, 't'}, @@ -831,7 +830,7 @@ static struct common_params if (common_parse_options(argc, argv, ¶ms->common)) continue; =20 - c =3D getopt_long(argc, argv, "a:b:E:hH:i:knp:P:s:t::T:uU0123456:7:8:9\1= \2:\3:", + c =3D getopt_long(argc, argv, "a:b:E:hH:i:knp:s:t::T:uU0123456:7:8:9\1\2= :\3:", long_options, NULL); =20 /* detect the end of the options. */ @@ -890,12 +889,6 @@ static struct common_params if (params->timerlat_period_us > 1000000) fatal("Period longer than 1 s"); break; - case 'P': - retval =3D parse_prio(optarg, ¶ms->common.sched_param); - if (retval =3D=3D -1) - fatal("Invalid -P priority"); - params->common.set_sched =3D 1; - break; case 's': params->print_stack =3D get_llong_from_str(optarg); break; diff --git a/tools/tracing/rtla/src/timerlat_top.c b/tools/tracing/rtla/src= /timerlat_top.c index b77e5b6550a1..8250bea4b2fd 100644 --- a/tools/tracing/rtla/src/timerlat_top.c +++ b/tools/tracing/rtla/src/timerlat_top.c @@ -570,7 +570,6 @@ static struct common_params {"irq", required_argument, 0, 'i'}, {"nano", no_argument, 0, 'n'}, {"period", required_argument, 0, 'p'}, - {"priority", required_argument, 0, 'P'}, {"quiet", no_argument, 0, 'q'}, {"stack", required_argument, 0, 's'}, {"thread", required_argument, 0, 'T'}, @@ -595,7 +594,7 @@ static struct common_params if (common_parse_options(argc, argv, ¶ms->common)) continue; =20 - c =3D getopt_long(argc, argv, "a:hH:i:knp:P:qs:t::T:uU0:1:2:345:6:7:", + c =3D getopt_long(argc, argv, "a:hH:i:knp:qs:t::T:uU0:1:2:345:6:7:", long_options, NULL); =20 /* detect the end of the options. */ @@ -656,12 +655,6 @@ static struct common_params if (params->timerlat_period_us > 1000000) fatal("Period longer than 1 s"); break; - case 'P': - retval =3D parse_prio(optarg, ¶ms->common.sched_param); - if (retval =3D=3D -1) - fatal("Invalid -P priority"); - params->common.set_sched =3D 1; - break; case 'q': params->common.quiet =3D 1; break; --=20 2.51.1