From nobody Tue Dec 2 01:48:41 2025 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE6E12C08DF for ; Fri, 21 Nov 2025 14:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763736818; cv=none; b=jwGhOlPOJBmHLtm9UVFOnYOYO6mwxnZ6CQTfMLk2na6WxAnKlb1y5OJ1u9hj0a4TBlkl4ZEeFia84b19SGSrUWWEXfffR99mOcqHFDg6t018ZpQEmnLNJsje09F6CPmpRc3aWctxIP41Nyi39+N5vl35qLTIU/bEOdgbVZnSRTE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763736818; c=relaxed/simple; bh=Tl+vYFYrEF3vFgi4Z0sqB1CoRFc95UCaLAAb0/k1ZbM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=i0rpZDTdJxI2AfjoT1Y9ycy5Aj9CdPt2Fhkg9sOoEzfVmXWobjI6dFoG0dy4NysyPr71pAp+PPqpOH9CUDRvqmKfnZ5dy7Qbb0UwUv0lHYGO/90N/2LGKnP91CPuzgMxSMSKP/LWpoveLuyQxxbS0LDpVA9NFUSuqGauaLjehTw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b8onUAm0; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b8onUAm0" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2953ad5517dso27186405ad.0 for ; Fri, 21 Nov 2025 06:53:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763736811; x=1764341611; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=peo9T+HChxcH8m7niIk4iKeYpL4OnJbw1rxueSVVfHY=; b=b8onUAm025IaW9Cbg3AKX9hOBSQLP/DXIZtKALWyIetJkSFE/G/lkEheR+aIIZ/sOL PTprsrJ3VTk60eWIMiVje0whSHgeHzWctCHQM53SrpQcXRs+Pv3U2a5T0qep6uqraLrl O6vnnXYSoCnU0yiT1n+uXUbGnjnBZD3cZ5OseUKzooSbuE4xNhsC8OvVX0qDEEstvL5H s/j7lvuK+LjO4jFuJFR2wgyktAKKolgAmnkQat1yhlMA7uiDtui45MH/SBpcwh6gbp2T GhVnMUAqvbOERm6LKOrb1lcasIQMhCSNo2bIm97/1XCVG6y5uTgwFrMZQdznGKcYXW97 5DJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763736811; x=1764341611; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=peo9T+HChxcH8m7niIk4iKeYpL4OnJbw1rxueSVVfHY=; b=niWLfPaK5bcjaZKqGK/zA1FfKfwSN3I0yQSjfXOjT8qghYDf3/rJu0GcmZrNY1WsR/ DjuyAf9rzR4lYa8QZ/HDfGie0pElUcofe0ZIH41xNa4DHen2MFLV10gZ1zexgySe2K5q QVWagsmHhQSLp8k6Pc4SVwyDtHmv536745UBvBGrOh6NcJrCJ3OYVbwfB+LxKOwnjvqT yoDKMM2uuow6+rOu7ugw67eHTg2sJc2BWYZyRFhjYx8VAdpoeualP1loZ7PE9T0jWcpG 7iXlg/KyAAVQ5YcNNAFMA5OvjuTAL52xX5mFslcKe8KB1PsIT/x0RXhivO1se2hihy88 2HGQ== X-Gm-Message-State: AOJu0YwK7pagq9l3bYdjsFEJcVvuursX/+9Spqi6vSMvYd4xKUnj6NpN ggfZinzV5Y0uqxjnrPZTmnVmFgNRO97LkGNDPWerqkqJZc1RTOZn92gkWU7O4HF8 X-Gm-Gg: ASbGncuuaGbsq2oS/8HU2U1jrSynsrfOIAqBTxyZRUqcxl6etwb2Jso+de7IYpeF5Vr sPfdMFgQl0pgsXjyQuHhAN7Al9nGSKHptAJwiaFExVgp0rZYKimKEBVFpPy6XNoX5aGXLtILTX5 7nI/3VIyQIaAoUOE6n7jP/Y7xXQG8smFHFz0VOT90XKGKu2/rCT4cJpz92is+gU4AJiX8fhPxI8 jgC8Hkc2awSPkQ0qgpHQzFkQ6Wio1DpC+ysAoajTSWW8Kd57U7l66RvZTwvTe+Z9JFyJo7/fY/z f+ZltFa01czi8c1B2B9JHlFiaM+9pY9qMG92YqN50+0MQLUoRYjSxQKLZGySgiUUzxIQ19i9RsV PjUZE2VqGPMJxzPR1svuO6vPdyBcK/XlH3336pxrlt1bmB+LLFjwQGoRrJc5LlyS/uZjw0ZEjEH dPAqxSvennhNw= X-Google-Smtp-Source: AGHT+IF/BMIuRT+ea/pbIu7n1/+c+YEFoKjxloUbKtmryJ5wmQeEYVMysbcrZQ9QrWvZp7qQ8bbEUQ== X-Received: by 2002:a17:902:d489:b0:298:970:b24a with SMTP id d9443c01a7336-29b6bfa1944mr31867685ad.58.1763736810398; Fri, 21 Nov 2025 06:53:30 -0800 (PST) Received: from localhost ([240b:4000:bb:1700:7b36:494d:5625:5a1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b25defasm58866415ad.49.2025.11.21.06.53.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Nov 2025 06:53:30 -0800 (PST) From: Lai Jiangshan To: linux-kernel@vger.kernel.org Cc: Tejun Heo , ying chen , Lai Jiangshan , Lai Jiangshan Subject: [PATCH V3 1/7] workqueue: Factor out assign_rescuer_work() Date: Fri, 21 Nov 2025 22:57:14 +0800 Message-Id: <20251121145720.342467-2-jiangshanlai@gmail.com> X-Mailer: git-send-email 2.19.1.6.gb485710b In-Reply-To: <20251121145720.342467-1-jiangshanlai@gmail.com> References: <20251121145720.342467-1-jiangshanlai@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lai Jiangshan Move the code to assign work to rescuer and assign_rescuer_work(). Signed-off-by: Lai Jiangshan --- kernel/workqueue.c | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 19bc7ea931d8..c60584a39fc9 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -3439,6 +3439,23 @@ static int worker_thread(void *__worker) goto woke_up; } =20 +static bool assign_rescuer_work(struct pool_workqueue *pwq, struct worker = *rescuer) +{ + struct worker_pool *pool =3D pwq->pool; + struct work_struct *work, *n; + + /* + * Slurp in all works issued via this workqueue and + * process'em. + */ + list_for_each_entry_safe(work, n, &pool->worklist, entry) { + if (get_work_pwq(work) =3D=3D pwq && assign_work(work, rescuer, &n)) + pwq->stats[PWQ_STAT_RESCUED]++; + } + + return !list_empty(&rescuer->scheduled); +} + /** * rescuer_thread - the rescuer thread function * @__rescuer: self @@ -3493,7 +3510,6 @@ static int rescuer_thread(void *__rescuer) struct pool_workqueue *pwq =3D list_first_entry(&wq->maydays, struct pool_workqueue, mayday_node); struct worker_pool *pool =3D pwq->pool; - struct work_struct *work, *n; =20 __set_current_state(TASK_RUNNING); list_del_init(&pwq->mayday_node); @@ -3504,18 +3520,9 @@ static int rescuer_thread(void *__rescuer) =20 raw_spin_lock_irq(&pool->lock); =20 - /* - * Slurp in all works issued via this workqueue and - * process'em. - */ WARN_ON_ONCE(!list_empty(&rescuer->scheduled)); - list_for_each_entry_safe(work, n, &pool->worklist, entry) { - if (get_work_pwq(work) =3D=3D pwq && - assign_work(work, rescuer, &n)) - pwq->stats[PWQ_STAT_RESCUED]++; - } =20 - if (!list_empty(&rescuer->scheduled)) { + if (assign_rescuer_work(pwq, rescuer)) { process_scheduled_works(rescuer); =20 /* --=20 2.19.1.6.gb485710b