From nobody Tue Dec 2 02:03:29 2025 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D3533446A8 for ; Fri, 21 Nov 2025 10:03:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763719423; cv=none; b=FZo7SU/5loj3XugnqHDianyQnGMrFZxRhCxvOTN3JeP5YA0m94R8hrMBhjl7KF9vlGQ2SVqrtUpkgbFGogBvL6JtI7XRhWvkuSoqwSefGq9k7Vdy1D0ay/uzlQ9xz676aSGGxNybUb2MYNu18bFSbPZZKqazqaKWWMPpuxcFAtg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763719423; c=relaxed/simple; bh=GRcyPx6pS8Mo2Z6rJM/Yng60btmO1CA3xmrlBHaPA9U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E9RAXN6Vcu9HK1tbIchG/Rx7DkErwkkXm9G2FS/ZViRfg/vzMB+XCaYwj9dlv162bcoUniNaMXDwF1d2BMQjds/7A8Mfgxmsom93PxhKuj+t66E2hJ/Wl7WmCcwtsTQdWaK8gvtNl+rJlUY8M+yCTWbc5Kx5437Xx+l+gC61hmQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ygk8prVb; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ygk8prVb" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-376466f1280so21267711fa.0 for ; Fri, 21 Nov 2025 02:03:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763719418; x=1764324218; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1r4XBHNsj/0gz9zuqPrs6Ple3BrfMasT4Ktn9PEtMI8=; b=Ygk8prVbRid8bb2LA0izUa5Ust40C2inmPMvjyNY6nijV5vOlcqNkwS16csicUwpor Kwonh63APJqy6ibvkFIQEeqWTXmsCB8+4ofbWmsdlh+b+WYXmYXziyRfVNCu+qfVAOWL 1gcszf26VlAGC78sd4R/WrHOkWZru1VZqLMODQOVfd6kYaWLYr2thcEWgQi0yg9ko209 Bzk17dykuamwmZdGDcnNszoTrthzVifjuPe/tsSuZ7AKkw+t8UfkO/otQ7Kj0EFmOt+s w74Gtr7aiYgSuRWNz0LFCuC4Avb2I3wCWIWPWnkHLmUJ5Bc9UBzQpMrVUBoORRmtVui9 faeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763719418; x=1764324218; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1r4XBHNsj/0gz9zuqPrs6Ple3BrfMasT4Ktn9PEtMI8=; b=CYM5+O8vtgX7EOHtbw/OfbmhZ8GP/uvGeg8+OVuFFArJ2psLgohFGJxOTVWtAxsGN6 LoyapSfd6zrx6fxCUs/pE1zs4H05JsXWTJf9KTGjMZrXqFCaJuygve1zAACyC9ZqLlkv MIxDvbKUnXyoBuo/y8xDFVk4MOASV7MKgQjSyQZu/A4SQVJJWEBnyhb7IoAbJZBx2LPj n+KGY9rHoeHpeAaMn5aZEHLvuNlGpqPKVeVjk4emMGZVcYs0rRG8G1RuMrG20R6AScC2 RQ4xV52cHJpHom7shXRRZW/4PpxxWhSoKVsgQhbWTXq/irIMWxnHPj3qHnztKM297E0Y BQwA== X-Forwarded-Encrypted: i=1; AJvYcCWbIHe/NUP4UJOT9g/dwILX23UORFUt12w7766LBxOCUoIOlH5CF0M2n7a7fouktMwwwEEibFc2MIZm6EQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwTnd/4tG6lKt3E2FWH/zaeWq70sALHDO0mSc3kMPgcmO3YRGar 8TYfsN3imCIZlS+QNYNkpbYvAE02KvDt/W22ytSw8T5xn9UfFHYZnWlMohTUvofjcmM= X-Gm-Gg: ASbGncvLB8zTN2dxbzEliv34pkoYI9tQLteFeR9YVCH7y1R8f/MBdGYqUzNeOeoPozg EXLMe5zX2xashUYVpRlroFBDJsEe27R9XFoiUiTfhbWt0dpgQw/gyt1pvgdZNwIX4RgmvM32wSI eyOhRt1aHTn0p6PER4OY3ftlLr3JtqFjxdbiZsi+i/rnZJm3b7kdaHbnCVHr3IRyE4KOLUabpyG bYB9hhjgxz5mdSU4oLoyWRbMdu4SWoQ9TV3dk5/73CVNMDn3gTnpkBODyZfYHcnj7qrhdC0KWrr OMqYRcyh0ZlL4qlB8v9QEbW18L0YpdgKeexSRkhgrhwIg9kZ8Rl+UO3RXzklWUOBPQpjElIC4yP Fp89I3i4NmuefQBkHXW62Wg5c7z+tPLdr5YwFYhcBIqet99gs2qsGW0kITX8/uYBl901C9NNSqH UDrsbitE8svot95cT2qoAZ41Gi35UPh/NbXLVY/F1XM2rF1Mt8kBca7XpgGZN6 X-Google-Smtp-Source: AGHT+IFbZZlXsiqOlBDMPpDiOi/DBvwW1/TF85Ozxcxz75C1hy7utq5/v9TflE/lo+Wt4oJLXdanFA== X-Received: by 2002:a05:651c:1448:b0:37b:9977:7e62 with SMTP id 38308e7fff4ca-37cd9262cecmr4943401fa.31.1763719418410; Fri, 21 Nov 2025 02:03:38 -0800 (PST) Received: from uffe-tuxpro14.. (h-178-174-189-39.A498.priv.bahnhof.se. [178.174.189.39]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-37cc6b597b2sm11056181fa.12.2025.11.21.02.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 02:03:37 -0800 (PST) From: Ulf Hansson To: "Rafael J . Wysocki" , linux-pm@vger.kernel.org Cc: Vincent Guittot , Peter Zijlstra , Kevin Hilman , Pavel Machek , Len Brown , Daniel Lezcano , Maulik Shah , Prasad Sodagudi , Dhruva Gole , Deepti Jaggi , Ulf Hansson , linux-kernel@vger.kernel.org Subject: [PATCH v3 1/6] PM: QoS: Introduce a CPU system wakeup QoS limit Date: Fri, 21 Nov 2025 11:03:07 +0100 Message-ID: <20251121100315.316300-2-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251121100315.316300-1-ulf.hansson@linaro.org> References: <20251121100315.316300-1-ulf.hansson@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some platforms supports multiple low power states for CPUs that can be used when entering system-wide suspend. Currently we are always selecting the deepest possible state for the CPUs, which can break the system wakeup latency constraint that may be required for a use case. Let's take the first step towards addressing this problem, by introducing an interface for user space, that allows us to specify the CPU system wakeup QoS limit. Subsequent changes will start taking into account the new QoS limit. Signed-off-by: Ulf Hansson Reviewed-by: Dhruva Gole --- Changes in v3: - Add Kconfig for the new interface (Rafael). - Updated commit message. Changes in v2: - Renamings to reflect the QoS are limited to CPUs. - Move code inside "CONFIG_CPU_IDLE". --- include/linux/pm_qos.h | 9 ++++ kernel/power/Kconfig | 4 ++ kernel/power/qos.c | 106 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 119 insertions(+) diff --git a/include/linux/pm_qos.h b/include/linux/pm_qos.h index 4a69d4af3ff8..6cea4455f867 100644 --- a/include/linux/pm_qos.h +++ b/include/linux/pm_qos.h @@ -162,6 +162,15 @@ static inline void cpu_latency_qos_update_request(stru= ct pm_qos_request *req, static inline void cpu_latency_qos_remove_request(struct pm_qos_request *r= eq) {} #endif =20 +#ifdef CONFIG_PM_QOS_CPU_SYSTEM_WAKEUP +s32 cpu_wakeup_latency_qos_limit(void); +#else +static inline s32 cpu_wakeup_latency_qos_limit(void) +{ + return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT; +} +#endif + #ifdef CONFIG_PM enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev, s32 mask); enum pm_qos_flags_status dev_pm_qos_flags(struct device *dev, s32 mask); diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig index 54a623680019..839e2dbb889e 100644 --- a/kernel/power/Kconfig +++ b/kernel/power/Kconfig @@ -202,6 +202,10 @@ config PM_WAKELOCKS_GC depends on PM_WAKELOCKS default y =20 +config PM_QOS_CPU_SYSTEM_WAKEUP + bool "User space interface for CPU system wakeup QoS" + depends on CPU_IDLE + config PM bool "Device power management core functionality" help diff --git a/kernel/power/qos.c b/kernel/power/qos.c index 4244b069442e..f7d8064e9adc 100644 --- a/kernel/power/qos.c +++ b/kernel/power/qos.c @@ -415,6 +415,105 @@ static struct miscdevice cpu_latency_qos_miscdev =3D { .fops =3D &cpu_latency_qos_fops, }; =20 +#ifdef CONFIG_PM_QOS_CPU_SYSTEM_WAKEUP +/* The CPU system wakeup latency QoS. */ +static struct pm_qos_constraints cpu_wakeup_latency_constraints =3D { + .list =3D PLIST_HEAD_INIT(cpu_wakeup_latency_constraints.list), + .target_value =3D PM_QOS_RESUME_LATENCY_NO_CONSTRAINT, + .default_value =3D PM_QOS_RESUME_LATENCY_NO_CONSTRAINT, + .no_constraint_value =3D PM_QOS_RESUME_LATENCY_NO_CONSTRAINT, + .type =3D PM_QOS_MIN, +}; + +/** + * cpu_wakeup_latency_qos_limit - Current CPU system wakeup latency QoS li= mit. + * + * Returns the current CPU system wakeup latency QoS limit that may have b= een + * requested by user space. + */ +s32 cpu_wakeup_latency_qos_limit(void) +{ + return pm_qos_read_value(&cpu_wakeup_latency_constraints); +} + +static int cpu_wakeup_latency_qos_open(struct inode *inode, struct file *f= ilp) +{ + struct pm_qos_request *req; + + req =3D kzalloc(sizeof(*req), GFP_KERNEL); + if (!req) + return -ENOMEM; + + req->qos =3D &cpu_wakeup_latency_constraints; + pm_qos_update_target(req->qos, &req->node, PM_QOS_ADD_REQ, + PM_QOS_RESUME_LATENCY_NO_CONSTRAINT); + filp->private_data =3D req; + + return 0; +} + +static int cpu_wakeup_latency_qos_release(struct inode *inode, + struct file *filp) +{ + struct pm_qos_request *req =3D filp->private_data; + + filp->private_data =3D NULL; + pm_qos_update_target(req->qos, &req->node, PM_QOS_REMOVE_REQ, + PM_QOS_RESUME_LATENCY_NO_CONSTRAINT); + kfree(req); + + return 0; +} + +static ssize_t cpu_wakeup_latency_qos_read(struct file *filp, char __user = *buf, + size_t count, loff_t *f_pos) +{ + s32 value =3D pm_qos_read_value(&cpu_wakeup_latency_constraints); + + return simple_read_from_buffer(buf, count, f_pos, &value, sizeof(s32)); +} + +static ssize_t cpu_wakeup_latency_qos_write(struct file *filp, + const char __user *buf, + size_t count, loff_t *f_pos) +{ + struct pm_qos_request *req =3D filp->private_data; + s32 value; + + if (count =3D=3D sizeof(s32)) { + if (copy_from_user(&value, buf, sizeof(s32))) + return -EFAULT; + } else { + int ret; + + ret =3D kstrtos32_from_user(buf, count, 16, &value); + if (ret) + return ret; + } + + if (value < 0) + return -EINVAL; + + pm_qos_update_target(req->qos, &req->node, PM_QOS_UPDATE_REQ, value); + + return count; +} + +static const struct file_operations cpu_wakeup_latency_qos_fops =3D { + .open =3D cpu_wakeup_latency_qos_open, + .release =3D cpu_wakeup_latency_qos_release, + .read =3D cpu_wakeup_latency_qos_read, + .write =3D cpu_wakeup_latency_qos_write, + .llseek =3D noop_llseek, +}; + +static struct miscdevice cpu_wakeup_latency_qos_miscdev =3D { + .minor =3D MISC_DYNAMIC_MINOR, + .name =3D "cpu_wakeup_latency", + .fops =3D &cpu_wakeup_latency_qos_fops, +}; +#endif /* CONFIG_PM_QOS_CPU_SYSTEM_WAKEUP */ + static int __init cpu_latency_qos_init(void) { int ret; @@ -424,6 +523,13 @@ static int __init cpu_latency_qos_init(void) pr_err("%s: %s setup failed\n", __func__, cpu_latency_qos_miscdev.name); =20 +#ifdef CONFIG_PM_QOS_CPU_SYSTEM_WAKEUP + ret =3D misc_register(&cpu_wakeup_latency_qos_miscdev); + if (ret < 0) + pr_err("%s: %s setup failed\n", __func__, + cpu_wakeup_latency_qos_miscdev.name); +#endif + return ret; } late_initcall(cpu_latency_qos_init); --=20 2.43.0