From nobody Tue Dec 2 02:03:02 2025 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB7402F291A for ; Fri, 21 Nov 2025 09:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763718260; cv=none; b=ErVF9l5eF235EPl9vYWJnFX0Y1X6hHvtB32Dz9mDA2i459oVHUt8m2owJNLyDm+W1SVm1asdM0ekkHPtY0JUkG6KnY0teowPB//M1ncI2u8HGu2C4Lxp4tcb5dqvOV5xSn761I3x93jp1G75vPvqluBv+/pZVD28Smid8dvvaKk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763718260; c=relaxed/simple; bh=k98YOoMaE6uxbfnH674TNtciLhlbCB7KPo23axNmR+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jnhm3G4ompkXK4If3j2rT+AbT8ZEdWG70jTLwuitNdgkeOhBKk20p2l2fcgoKXefCj1rDcbSGWAKtl9moewYQKBKCqePXtEg/g6r34y2gGYCyU5Z9gNxEJTSL04DgobjsKECFAKk3FbqdzriherIUG6deyXeI+Z97XQvXDxQV+g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IeoRAh5k; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IeoRAh5k" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-7bc248dc16aso1425629b3a.0 for ; Fri, 21 Nov 2025 01:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763718257; x=1764323057; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ViWHsxO/UANnvPPe7gIpM9Rg1HONabQOB3jUU84+K6k=; b=IeoRAh5kco0TPMAu+Hfr9LCEDoitJ2t0Ic0h/q0kZ30+FWJrf6873svjpIqWz+iCeU csxxm65NqDup5yS75dJvgfkocw6Lw7be8gVHMGeQP10f2FovCIrhPAp9XY4VOiFoR1vY 4fdIeVwluR1sKtHCPNyU5Rir4eBhdySIoBh65jr6rhriGYo1xvz6zTFhLuDqSeWqv+bO pKHBb57Dau5TyCBAmIB+t1VOAnF0HoA5ETyG8d7z/+yufuGS+XqP+kH7BOhiJafi5HOV nrA+5yzNjaqYMjLTKFcckuNX89jc3UY77o9mvMJjnh6f/Z2GBZSsZxp0RvkawxHd95Ja 3qXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763718257; x=1764323057; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ViWHsxO/UANnvPPe7gIpM9Rg1HONabQOB3jUU84+K6k=; b=KWDKqXyIf7LK3FeguBdgUcEFjiWMxidRoCelNApbmAyq1NjUw3GT/Hplz0MYm34rau RUrslPGFUibEVj/GgQCUQaB8i6fBf+3e6imSnKeiRevbOv4SDgnwB+TWyIS4vMUQPhrB yGU8HUWimLnSEW+g8D4sWYkkQ6C6yL3doDTHtaArkl1sGlqm3IsdMElrcdxIomXRUqQ6 xAb81lNllUpcWITxo3yP8eyqHb1KYKJywdQoAw9XVa4mCZzaTPIM8XDBfwfeNumKQp0x 0nlIXP8ygT3DqTw9bZuSCIb8xGXZiwS+bdIeyJvVI+nOBlDmoQ60T9ynbobBUYhBJ1bT J49Q== X-Forwarded-Encrypted: i=1; AJvYcCXuM1vYduCLrYsis2k8LDZx6q+3g4cQAvnkssvpUVlNzGjXdVr3G6ASB/OA7He7LqjRoFGMgiJufOYGgKs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8ZvpXBl3NyZ4NmyRqsrAtWJnXqQpxe23xUJfODACDfgmEb5yt EDtUayPN4Lpam8np2A+ri9RLVSv9KlmBsa99h/VaOojoj1Z0N7ibvH9H X-Gm-Gg: ASbGncvtf1EA6ZoLQoT5sr9HT+EwbnuU6ifMMABefIfT7qB8eY5a8C4S5RdNpo5z2oa N/6J9U+2PtZuA+edBlkI4u+gkPaCL4b4t6Y38kqm/xq/dAoD6dkZtlIxSB4EGdqqIXHtS5jozqX TgqdMZDnb6GphYPgzgVv5QjSCFjpIuqWx5jw9OJriHVctQ00p1HXi1HjWw8kisEdQYJ0L2p7IXk vQG5+Pzc0KFfnGtxd4kyabW9uDKPk0PdG4BrJSLUVoXno2HeUf8kdvt3a9wY08roPymGD/6desu P8llCLXWIwwegp4upvuD1wwv6LNZkB/5Z1BpZMh1GzYATQ8anbPn2i3JChm7+5w/U1N9I6auNZa t6FSaj84s0+Ec0mmWz4QXC63gvolCCXsUIjjZ6NXwpJSx8qTR+5C4/cra9/RNkWm+CIapefXWXO Tmy/d5LW3phG6TaDV3y24ZhCK2jtA6k3XltOkxisqK8jo= X-Google-Smtp-Source: AGHT+IEBVg8xenpQZC2zUyxsYRjmmWsvyuM65CCQfvuZWskDwPwgrGBlf27FiKxaCLQQWiTQytaG+Q== X-Received: by 2002:a05:701b:2702:b0:11b:a892:80a5 with SMTP id a92af1059eb24-11c9d711be5mr337609c88.13.1763718257235; Fri, 21 Nov 2025 01:44:17 -0800 (PST) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-11c93db4a23sm22430736c88.2.2025.11.21.01.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 01:44:16 -0800 (PST) From: "Vishal Moola (Oracle)" To: Andrew Morton Cc: Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Vishal Moola (Oracle)" , SeongJae Park Subject: [PATCH v4 2/4] mm/vmalloc: Add a helper to optimize vmalloc allocation gfps Date: Fri, 21 Nov 2025 01:44:03 -0800 Message-ID: <20251121094405.40628-3-vishal.moola@gmail.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251121094405.40628-1-vishal.moola@gmail.com> References: <20251121094405.40628-1-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" vm_area_alloc_pages() attempts to use different gfp flags as a way to optimize allocations. This has been done inline which makes things harder to read. Add a helper function to make the code more readable. Signed-off-by: Vishal Moola (Oracle) Reviewed-by: "Uladzislau Rezki (Sony)" Acked-by: SeongJae Park --- mm/vmalloc.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index c97c874b6666..185add3f5606 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3614,6 +3614,17 @@ void *vmap_pfn(unsigned long *pfns, unsigned int cou= nt, pgprot_t prot) EXPORT_SYMBOL_GPL(vmap_pfn); #endif /* CONFIG_VMAP_PFN */ =20 +/* + * Helper for vmalloc to adjust the gfp flags for certain allocations. + */ +static inline gfp_t vmalloc_gfp_adjust(gfp_t flags, const bool large) +{ + flags |=3D __GFP_NOWARN; + if (large) + flags &=3D ~__GFP_NOFAIL; + return flags; +} + static inline unsigned int vm_area_alloc_pages(gfp_t gfp, int nid, unsigned int order, unsigned int nr_pages, struct page **pages) @@ -3852,9 +3863,9 @@ static void *__vmalloc_area_node(struct vm_struct *ar= ea, gfp_t gfp_mask, * Please note, the __vmalloc_node_range_noprof() falls-back * to order-0 pages if high-order attempt is unsuccessful. */ - area->nr_pages =3D vm_area_alloc_pages((page_order ? - gfp_mask & ~__GFP_NOFAIL : gfp_mask) | __GFP_NOWARN, - node, page_order, nr_small_pages, area->pages); + area->nr_pages =3D vm_area_alloc_pages( + vmalloc_gfp_adjust(gfp_mask, page_order), node, + page_order, nr_small_pages, area->pages); =20 atomic_long_add(area->nr_pages, &nr_vmalloc_pages); /* All pages of vm should be charged to same memcg, so use first one. */ --=20 2.51.1