From nobody Tue Dec 2 01:28:35 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 302132FD67F for ; Fri, 21 Nov 2025 06:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763705666; cv=none; b=mBmAUl2BZ0/I0wVTzqxR2hT3jfAn6g3LNkiJN6mXg5wXV+FY1NcpKtcobT/b8YIGNxQoxncT7a45P5N62pf+XrtopSjlETEUI8GsmOxJWtIduq6OUL313kBnkU4hCppXba2D8XTKpLDh3WtoiImSS4+ABP4GrpwGBYJJTM6cD/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763705666; c=relaxed/simple; bh=PJa9N6pG9T7YlDiO61NYTxL4Oy6CYEY/kLLyweJj/QE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=gzwJVctGuvYmM/NAYoiT9aS+kDosZPx9xjCipfAb6xtA2z2gk2JNdwze4zg2/qy4UqC3uW/Ji6nTbzuWY72cHA/h89gM/G2VTC1AF0LK+sOZIUWOZGb8hgq0FQ7RIG6c4buh0zzAGnr9Q2uWfJTmSD8XOOk9Ni4X2QHtlSSaZik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Bm9UrMaE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Yio/N7zR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Bm9UrMaE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Yio/N7zR" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AKKAXiU1987797 for ; Fri, 21 Nov 2025 06:14:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=sakgNXUS7Vn2+wk1MevlkKIijlFznlQ492J XMPqHxMg=; b=Bm9UrMaEkcvmKJY40RHzpG/xcsox1dB/SRgsEgnt1gc6MSVoK1j jFXSUSjGxc2FU8xrh2k4KCgVIaQ8yJbAFF9RKeax2oq+bwFO2Dv0FW7QO9jmugDX +RMWRAOdjfBbYy4sQZtVoQTfbYnNPiigtjD2DlZxRFS0jN5NT8Sv4g0S8LZmvjZe RShOkIky3IpBzurGEppDUq+VGuGZGLVa0QeeIQK05BerJ8G1gQFHzcJmCXY74nPu ZW0tvOT12YYly+9MSI8tVUGEpiVXB2Z/gMkN/9WOS99X04O0q2GyAZoJ0knyP3IM oAzjbjxNbzuKm8ayY9+qqBa2B+iz/LwYiHg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aj1vab4tm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Nov 2025 06:14:22 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b969f3f5c13so1655707a12.0 for ; Thu, 20 Nov 2025 22:14:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763705662; x=1764310462; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=sakgNXUS7Vn2+wk1MevlkKIijlFznlQ492JXMPqHxMg=; b=Yio/N7zRISOkniD+keceNQ6QFzvO4MlJAlVjGP1Rmu+Sw8IM9VTKISaz7mH++4z1Dv 38WRXm05I1rfadfO913Gkua8SiRWwJYNZMu2NTu0RrRpd4Bx8QOsiRChEV1rCWLbDf7g /h5cOzA1hwE4/W/V2PWrTkxEQRrrVjtxuuB6JwyHqvXRJQuuYOGoGExuYu8WyJ9bkn+S RRrcmbaG2jnUQBpaFRPygd7fXaHoCNYTBrNE3Ih9xRbm2ccZmCaVs2wBKGnAVKX0tmpa h2Av33rRdxtdKnxImqflWaDREWZF/odQbaJF3lIjWOwlK3HLJ1h9cEpVs4TPSa26GwkE Oksg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763705662; x=1764310462; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sakgNXUS7Vn2+wk1MevlkKIijlFznlQ492JXMPqHxMg=; b=aFbUuPkJqeR5tB5Gl76um+GLqLIx9FqGcSG7Er0C0TARwVBOEgMOu6ZqALjnqEzx54 14stkvt9W37Npc1J9MDhH/kDi5sexyK6Xo7kko4hBCub68pxXFE1SLV98H05nfzAaGr1 CrDywv6oBITAxRaNSdrbUFjc8R7g23te62cdbODWTVVVpFU7eE5xNegjEPvFCfwDhTHe U6DtKLCdi4GjuGJJ031mBUWbjoqWKUWefW3A967tHvy/FtYB5gqlhn36ND5Ny8SetvIe sm+e1ONB1P5zgUUVSSQfGTelU37YN4Kcns+ajI/QQOLNiBBDeLMIC2rq1jGhvvlAzUt2 BX7Q== X-Forwarded-Encrypted: i=1; AJvYcCUK5Otf4KCD9YUxQqSJ5T+hXYaLYHm/jGoiC9Od2Ir6RXSC3M2XvMMUS9OMtK9tAiw7BNVa8riH1sB+unQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxdm6sHg+YF4feCEcsSFXzaP6DuecDHgA1kl8F2AN1uF7yp7EXR gjZBZcr7NgRB50PA7jarKa5j12147l66LhRmzkSzvHqNBBRi+6aRt66p7YhM2RPSlQ58QDp4HEy Yo1S2KiiE5/oNJ3ThsaP1iI4hfYGYI9mqFzBOGDFV81SeKPGnLWcXK6rkX8OlV8CNYDGaGjtJfq g= X-Gm-Gg: ASbGncviuNw7uZN5UpJgwDcsR0KfXqgkBlAHF4K4pLOYCGJpE6y3AlFyvlIAVIuzozr Vd6SYaU0JxbPDmwLDZ3ktqnPsZAtmtMQ/lywtJ+FQOmkCkjMvgzx3e4vZrlYqqRfzuIyJ9+0hj0 vWVqJOtPpWj6qSx8kJFIcIWAJVptlgdrHQES8mNxTcGUc0EeIGXcEdgh66Nr1K2hwm0L+LNUWca r44E9r1q0AvAfhJryF6E/cZ6BDZzl10MaKd3fSQFm4/Ikr42k8HXFIptEmascR2McH6INnqzKun Zjj+G1a3NKj7BZQnHqM/U6lpxguANh60OhUlG/lIadmjEO+YIl7ngmPezVOi0tSn0Y2nw49DWPB 984rgCJBMs8wXT7K5Ymq1haYvIJ1F4to+aphnXy/v X-Received: by 2002:a05:6a20:3d06:b0:35f:fafa:a198 with SMTP id adf61e73a8af0-3614eb3a094mr2088561637.10.1763705661489; Thu, 20 Nov 2025 22:14:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IGEfnV66467SnQmVQE5B6nqIn9rGSkn8UJDhvkh1aS26VUn4BzACrIVhW1vYwqCEI0hJ8kM7Q== X-Received: by 2002:a05:6a20:3d06:b0:35f:fafa:a198 with SMTP id adf61e73a8af0-3614eb3a094mr2088524637.10.1763705660945; Thu, 20 Nov 2025 22:14:20 -0800 (PST) Received: from hu-nainmeht-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bd7604dec63sm4360655a12.17.2025.11.20.22.14.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 22:14:20 -0800 (PST) From: Naina Mehta To: wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Naina Mehta , Aaron Plattner Subject: [PATCH] watchdog: sbsa: Update the W_IIDR Implementer bit mask to 0xFFF Date: Fri, 21 Nov 2025 11:44:11 +0530 Message-Id: <20251121061411.4185792-1-naina.mehta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIxMDA0NyBTYWx0ZWRfXym27JftgQM3n xEXzHNj+nxDXuMQTfz/b8CndRKQA2n70wcoTv6jPPArhT1HDwFIsQlwlNLWJ9Ke8x0AhW0XaSRL r/E3T0IoERN+YOz+2OH9C/nbU4Bc6oJrPlPFc4n6hC4bfPHFYF57oscz/cHHIvI8UQ2TISZ6BNr MwJaEKx93AIfillS8ery0XN6uCHTmAAhlB+1iNFRhPGs7/QMQ0nw8p9D/DKM0NuC76gtDN9I7Dz UnNtksC2TAi2ZQEZEyZhnXfhExFBhmvepunWGRCKoms2K2T1/paq44dkHsKjueAYh5Q27vHyqde +tgOpLMvymjdSm5dVueMhPQL8so8QOuhcDRZKRmYRn6GRjqhLenpso9eofTcnv2EVW4HfwHRDvG GFquIvtgNBIgFQ2QWaG6dq2M9JHcwQ== X-Authority-Analysis: v=2.4 cv=Vpwuwu2n c=1 sm=1 tr=0 ts=6920033e cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Ikd4Dj_1AAAA:8 a=c8hZkOuhMWBtbjM8IJoA:9 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-ORIG-GUID: TtSW0zbF93z5d9IYh1RH0XFgkrQFsSoo X-Proofpoint-GUID: TtSW0zbF93z5d9IYh1RH0XFgkrQFsSoo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-21_02,2025-11-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 bulkscore=0 phishscore=0 priorityscore=1501 malwarescore=0 spamscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511210047 Content-Type: text/plain; charset="utf-8" The implementer mask defined in the driver [1] captures bits 0-10, whereas section C.4.2 of BSA specification [2] indicates that bits 0-11 of the W_IIDR register represent the implementer JEP106 code. Update the SBSA_GWDT_IMPL_MASK corresponding to bits 0-11, while at it update SBSA_GWDT_VERSION_MASK mask to use GENMASK. [1] #define SBSA_GWDT_IMPL_MASK 0x7FF [2] Implementer, bits [11:0] Contains the JEP106 code of the company that implemented the Generic Watchdog: Bits[11:8] The JEP106 continuation code of the implementer. Bit[7] Always 0 Bits [6:0] The JEP106 identity code of the implementer. Signed-off-by: Naina Mehta Acked-by: Aaron Plattner Reviewed-by: Guenter Roeck --- * Link to RFC: https://lore.kernel.org/all/20251104063937.839138-1-naina.me= hta@oss.qualcomm.com/ drivers/watchdog/sbsa_gwdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c index 6ce1bfb39064..f7cdc277eb3f 100644 --- a/drivers/watchdog/sbsa_gwdt.c +++ b/drivers/watchdog/sbsa_gwdt.c @@ -72,10 +72,10 @@ #define SBSA_GWDT_WCS_WS0 BIT(1) #define SBSA_GWDT_WCS_WS1 BIT(2) =20 -#define SBSA_GWDT_VERSION_MASK 0xF +#define SBSA_GWDT_VERSION_MASK GENMASK(3, 0) #define SBSA_GWDT_VERSION_SHIFT 16 =20 -#define SBSA_GWDT_IMPL_MASK 0x7FF +#define SBSA_GWDT_IMPL_MASK GENMASK(11, 0) #define SBSA_GWDT_IMPL_SHIFT 0 #define SBSA_GWDT_IMPL_MEDIATEK 0x426 =20 --=20 2.34.1