From nobody Tue Dec 2 01:51:41 2025 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F18B53A7 for ; Fri, 21 Nov 2025 00:04:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763683479; cv=none; b=cgsuoYJczBztCJBREyKQsr679TQLHiylVMpFwVcimBPDzsnXZCm9z/N7zZ72I0YtfdixRNy0Sxkd04Y0Ub3SkCQr6Y8t+GN2Adr+j3cNm61f74WQJmLv0E+u2Ija2c5mda/JFxZuRiPlosETxVfi6FGmhMjgJtUbOpouwUwx878= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763683479; c=relaxed/simple; bh=2AXrSv9Whw8ZnmYI11LonZo2zoxqHUg4PkT1bewu+LY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tbosW4zuj8DuJ70W9J07Im+cSNX3sSUkjMJlG4WnwOs7iQR8LQUEK4UaLUSDp4BEn8xDdmaEleTZnzLwdYYT4Tlr4M2zc/QzGuGcJjdvhmai+x+LOzrNXaUxYP9v6I8nqygr5pZHlX8bKA9750O8iX/jvVI7X8cQ7uP1wPityJE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VePy7+KN; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VePy7+KN" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7baf61be569so1693385b3a.3 for ; Thu, 20 Nov 2025 16:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763683477; x=1764288277; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FSsLiiSTL2av7klPupKbRan+kIsIZbAf1eXJiOEAwnc=; b=VePy7+KNE7vd6Gsm2JDK/Z4LToX2hxktSsuldlzbGOmJZYYHMI5OLZQmbjPtZ8FHfH Da14lZVEv5iSIilF8IlFIm8XY5fRdFXz/dV3jZiBlEJYiw7SKQVndUhIt5heuLwG5hf+ JeepQH3SY7JYmyStmtF8lbzaMhxoY0ItX8JCcxrnpvYc+yqWD2EGHp8j6Dd670/QV/Ik alyh67o5i0kBHkUozS5M3zxoNu3UYwPJWrjrhvGFrJvbAAZF9QeMQyS3vWe6DeeMan/b OMYQBzZDOig6/W0IMROzARSWsioACHsJLwyEvw+E7FkYeEjJq7InnQ0SO0hC6fQxWOwK GKAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763683477; x=1764288277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FSsLiiSTL2av7klPupKbRan+kIsIZbAf1eXJiOEAwnc=; b=ZOgBnbjjrGD/fzM3JnjYVo70vLZjqTIKrA0NG0cLeaIy6YmkFYvBDA2ceBHte/5Kb/ uMMupRIn36WjjAMCwr5ariAhwukH86ouxfGNxKGX6G9jEV/CXR7L8RqE2WozmGb+5yyu yjFkAfVa5KU4PcmpQVFhnWPJ5GeaLFFkWmcTYj+h49unYm5jAk919Y+uj40dINeBJXXU 2AtbTU62GUanwIYOo/tChEWO5WRHxUYJhJMZkeEhqV3FNJFLr+vUE3RGMpXsvnAnY8aE 60y+D2s/fOcuF9lne2ZQbjtzrnCPDyMzOkjYDQTmz5/braO35qYaVktUH2PdUec57Nth As8A== X-Forwarded-Encrypted: i=1; AJvYcCUvvDQX2U9V8GSFIcdEt9KBDpyFQIo6GH5898rg4ZQJV1A+WCdlMXHWAfljJ+H0smzQQJ80y3XmrefJdns=@vger.kernel.org X-Gm-Message-State: AOJu0Yzz8W9xr7Sx7Ivrt7s0thlY5aauVvNCKxFArWPY+stmgrgKS5K0 Lno0b75pJDJnBcWuo5NAdh7yKI89Zj5oxC7LF/UdSgkQIwWufziT7L9Z X-Gm-Gg: ASbGncsGeFMK+pGXsWVUiRyx4FQqhpTqUrW8IIEd3Lw4XQwNWcpHHPMa/Eb/efFlvcl Drb/yQe8MIitxmz7zFQ5URxzi5SCS+YEw9jPIaZvJyOMCEODpdOXOw32h7ogYEzRAYSdYarV9ri J5aQzUGg28ssHwnQ8fO/ZwlyYEhZuMRHWGR5trkrKCReHOb971E/8ARnkhTYQyyqNoSKdue07Wi bTBE02yCrlbZEKKMCWsEZe2NoVnUmGYsTKh7sxJGJXyAJiOMnaKalYh/YvVs85oralCg69aSGeb zaRwmfXRH4fgy79pKykaPmFRQbIKlF2t0Yq8khl/kh9fjfSveRSgXENxIeWgWsugerpwfBj5DE0 NhTLkB37ddMmI0LHy1KNypiQdgeaj50C+pUEMgrLAj4k3UnsS/MD75GNAyU61DKHNgBHM2NSdYL R5ZKKFQGj2JJs= X-Google-Smtp-Source: AGHT+IHEEykjr6frs/VgM0X+yEhuXraBfQZb1stxpNE6IIjwHd7vKqpUhN1IDF8q8RL/oojJYuO/FA== X-Received: by 2002:a05:7022:a92:b0:11b:1cae:a0fa with SMTP id a92af1059eb24-11c9d55469dmr197846c88.0.1763683476748; Thu, 20 Nov 2025 16:04:36 -0800 (PST) Received: from fedora ([172.59.162.202]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11c93e6dbc8sm15035710c88.10.2025.11.20.16.04.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 16:04:36 -0800 (PST) From: Alex Tran To: jikos@kernel.org, bentiss@kernel.org, shuah@kernel.org Cc: linux-input@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Tran Subject: [PATCH v2] selftests: hid: tests: test_wacom_generic: add tests for display devices and opaque devices Date: Thu, 20 Nov 2025 16:04:27 -0800 Message-ID: <20251121000427.401283-1-alex.t.tran@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251117014721.3142490-1-alex.t.tran@gmail.com> References: <20251117014721.3142490-1-alex.t.tran@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Verify Wacom devices set INPUT_PROP_DIRECT on display devices and INPUT_PROP_POINTER on opaque devices. Moved test_prop_pointer into TestOpaqueTablet. Created a DirectTabletTest mixin class for=20 test_prop_direct that can be inherited by display tablet test classes. Used DirectTabletTest for TestDTH2452Tablet case. Signed-off-by: Alex Tran --- Changes in v2: - Removed the tests from the BaseTest class - Removed disabling tests for certain subclasses - Moved test_prop_pointer under TestOpaqueTablet - Created DirectTabletTest mixin class - Moved test_prop_direct under TestDTH2452Tablet .../selftests/hid/tests/test_wacom_generic.py | 30 +++++++++++-------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/tools/testing/selftests/hid/tests/test_wacom_generic.py b/tool= s/testing/selftests/hid/tests/test_wacom_generic.py index 2d6d04f0f..9d0b0802d 100644 --- a/tools/testing/selftests/hid/tests/test_wacom_generic.py +++ b/tools/testing/selftests/hid/tests/test_wacom_generic.py @@ -598,18 +598,6 @@ class BaseTest: if unit_set: assert required[usage].contains(field) =20 - def test_prop_direct(self): - """ - Todo: Verify that INPUT_PROP_DIRECT is set on display devices. - """ - pass - - def test_prop_pointer(self): - """ - Todo: Verify that INPUT_PROP_POINTER is set on opaque devices. - """ - pass - =20 class PenTabletTest(BaseTest.TestTablet): def assertName(self, uhdev): @@ -677,6 +665,13 @@ class TestOpaqueTablet(PenTabletTest): uhdev.event(130, 240, pressure=3D0), [], auto_syn=3DFalse, str= ict=3DTrue ) =20 + def test_prop_pointer(self): + """ + Verify that INPUT_PROP_POINTER is set on opaque devices. + """ + evdev =3D self.uhdev.get_evdev() + assert libevdev.INPUT_PROP_POINTER in evdev.properties + =20 class TestOpaqueCTLTablet(TestOpaqueTablet): def create_device(self): @@ -862,7 +857,16 @@ class TestPTHX60_Pen(TestOpaqueCTLTablet): ) =20 =20 -class TestDTH2452Tablet(test_multitouch.BaseTest.TestMultitouch, TouchTabl= etTest): +class DirectTabletTest(): + def test_prop_direct(self): + """ + Verify that INPUT_PROP_DIRECT is set on display devices. + """ + evdev =3D self.uhdev.get_evdev() + assert libevdev.INPUT_PROP_DIRECT in evdev.properties + + +class TestDTH2452Tablet(test_multitouch.BaseTest.TestMultitouch, TouchTabl= etTest, DirectTabletTest): ContactIds =3D namedtuple("ContactIds", "contact_id, tracking_id, slot= _num") =20 def create_device(self): --=20 2.51.0