From nobody Tue Dec 2 01:36:12 2025 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8A052F3620 for ; Fri, 21 Nov 2025 18:51:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763751072; cv=none; b=Y48dfp4y1P2JvHyxLuJZ2K4YqaP3YqRv7bU/WFGQVHXRd1K6XGgk29h9AsEHH+VkygjHTphQGchDxdabifGrgEvn2HxeZGaGaNTlKyC5ScgF9Gb7ciaYfD9N7GG31eNxEATThOfbT6stquiUo9drXk9OoaE1hFAOaTeIamhFtyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763751072; c=relaxed/simple; bh=NKFHmcfiCk2EwIkTHkKYjnx6rN1uKn1am+sBKF+oi8Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Dzz6XDy4KgDTMqjd9/46YO8nHZI+CG5w5z2tAY1DAigDlF8nmsUaQfqgheVGpOJJgjXx/JHRvVPfcbaLbsegoOiTmo0LsUD5KxCC2VaS4OeS1XWF74Rf6UUt7TPwTPJzz6MNKRJmHV6eSNt3O4StSDTPSW4S40w+RmPXz4XPvUU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=gnToBzky; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="gnToBzky" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-42b3ac40ae4so1378487f8f.0 for ; Fri, 21 Nov 2025 10:51:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763751069; x=1764355869; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UFSdbuEHlkMgMI9LKgp25jd/vaPmbZhF8IKFWk4+qQQ=; b=gnToBzkyuSErRs5sXo3yPsyaP6GkPTMAlDlDR3BKdtIRiSlrx0F+4yroi7MSEMS08C J9xfVwc6cXq2gePZRdz3OZJas8v9elkzFlbWF+QbCrZfQCvuRWJngkwrfAgFGMXwUsDY lSRMl5lyg55fXG2Vpu2J07WLl1CbrrVsqAMbhW480aTqkNTEUNEsolybH3HtGTpYoJDq 9BjNX/9Nt9egBNryHUdm0BXG4AEtg82DXnDEbT9+TwumglkSj80DMpdaS7lvkwTCdp8U N/UPTo14yoavNB9SFBDH6lHwDVVW+dqtjrm3cVyvH4yVSSKddhn0eqlAb/y/3MGCLQe7 pv2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763751069; x=1764355869; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UFSdbuEHlkMgMI9LKgp25jd/vaPmbZhF8IKFWk4+qQQ=; b=tUn5EGRg1dCyBlCQkmWFKd9msNZOHpOkU3tXYJfQO0bwPZfWkGbwY8ExcUjdcls8sF 0jJk0FYXsqS8WU99y2nK5T8QbMkc084midq/8fckJ1Z3d3tzI7FDi19Krv9IKYhqVX8R HQ8XJHVbDvG+fU8j4o4P2Q416Z3cUU21Uh1uSejbnvMhwf7lqedb/Ac/8N2bplN8Md2g gmgmcVvDr4cDzeDK/nqtCLU6w2YmBlLjYbMT8lLNkDvmaUW5tMA9/dK/paJkjlwVPozG YvdAq7GCxpA292GzrkrrcaEXcEcv7/SN7As5v2+90ppC972uUWuL3eeaaxy/UXIJV/mn gyUw== X-Gm-Message-State: AOJu0YwssC1fxZdXdwscKWCpQnmkNJMPoXgnvxCrc+CcVvjboBIPnuLT D7XwRuVUIzPCv3e+kNc8H8Shoyl0SO+zT3p9vSgUKv925rkuOeEQQmR0ZUGquz78ltI= X-Gm-Gg: ASbGncsRpPKF+1Fx/+X5qaEOHvzLd/dnkxBZ3wqyMsF2Li8flTuh2A0f4LbGt/ce9B/ V4DVS8HJWWkRL8vHd+iNT+/z5Fnafo+2axT5n2FyNYcmc1uv7Q5BrieuL033jTmsylfJVrinane qV9+RKvgVCOCqLOGd5RnDUrELIPW7OaUpLBrW2TkzvY4KJPryPZg+MQlGRUkqvAcRan1OJ1Zlbz uf6xsQ18km2w9KdVvFc2rHsWCzV9SMhOnOi6XfSfh0sb41NraiGK5stv5sKJzQ4BUzE+OgBiSTh FQY9AVYto8VO37rOIAamlufVAVl6PuwJgxpux2qBrXZEc1Kbgl/0Z6BAZ4lr3b77GNGxqY1dv+N W/GWHsdi02vKByZ4HaU7CPvtcRCn4kMo0gBsVV09rzwNyBWTKPTpeSROTa2g7v3X/3Vt6/MKTsX f4vrnY24W8SgslJCtXDlhGf7bJl/r4sCiPY/s= X-Google-Smtp-Source: AGHT+IE3ueb1gfvZpdP1O8B6KsMhh0NreYclj90YAJqPRO3t3jMYj6PAYTHfKHARsU3VdjyGtVHkhA== X-Received: by 2002:a05:6000:601:b0:42b:4219:269 with SMTP id ffacd0b85a97d-42cc1d0cf4amr3499114f8f.41.1763751068837; Fri, 21 Nov 2025 10:51:08 -0800 (PST) Received: from [127.0.0.1] (99.36.160.45.gramnet.com.br. [45.160.36.99]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd8baesm12473639f8f.39.2025.11.21.10.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 10:51:08 -0800 (PST) From: Marcos Paulo de Souza Date: Fri, 21 Nov 2025 15:50:35 -0300 Subject: [PATCH v2 3/4] printk: Use console_is_usable on console_unblank Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251121-printk-cleanup-part2-v2-3-57b8b78647f4@suse.com> References: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> In-Reply-To: <20251121-printk-cleanup-part2-v2-0-57b8b78647f4@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1763751050; l=1461; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=NKFHmcfiCk2EwIkTHkKYjnx6rN1uKn1am+sBKF+oi8Q=; b=t+kTGkkizl6U6aR6PW2Gu87Sum27bEEzl8ibey1pJbKk6zu1jVjEcA/kU+oc6YLo7Px6+PkCp QGPAFvKM1ClA+rzBQGG0BnUK0kRud59IVkxx67TxhQX137mqpi913XJ X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= The macro for_each_console_srcu iterates over all registered consoles. It's implied that all registered consoles have CON_ENABLED flag set, making the check for the flag unnecessary. Call console_is_usable function to fully verify if the given console is usable before calling the ->unblank callback. Signed-off-by: Marcos Paulo de Souza Reviewed-by: Petr Mladek --- kernel/printk/printk.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index cb79d1d2e6e5..fed98a18e830 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -3374,12 +3374,10 @@ void console_unblank(void) */ cookie =3D console_srcu_read_lock(); for_each_console_srcu(c) { - short flags =3D console_srcu_read_flags(c); - - if (flags & CON_SUSPENDED) + if (!console_is_usable(c, console_srcu_read_flags(c), true)) continue; =20 - if ((flags & CON_ENABLED) && c->unblank) { + if (c->unblank) { found_unblank =3D true; break; } @@ -3416,12 +3414,10 @@ void console_unblank(void) =20 cookie =3D console_srcu_read_lock(); for_each_console_srcu(c) { - short flags =3D console_srcu_read_flags(c); - - if (flags & CON_SUSPENDED) + if (!console_is_usable(c, console_srcu_read_flags(c), true)) continue; =20 - if ((flags & CON_ENABLED) && c->unblank) + if (c->unblank) c->unblank(); } console_srcu_read_unlock(cookie); --=20 2.51.1