From nobody Tue Dec 2 02:03:03 2025 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50ECF3321D3 for ; Fri, 21 Nov 2025 11:26:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763724397; cv=none; b=fd8fDWRM0Iq6cr0IcFVW84ZizgUpZbDihlZ+TMipEXX/CVZAHCJvtS+Dz7/eX4qdIMLI7CTd66UwL9fmXsXY4IJTpbG502BahAR6uMkVodZgym0HJMG+UFAtIB9MIoG3PH2vqSN/y7cSJ275+upcR+SQ33yfSrBgXvHASoxBU1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763724397; c=relaxed/simple; bh=lVkterAId0pZtiHs0zzpoVow0duEjuPv9au7v95C+hs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Liysi6uFF0DeTKZeA/psEN89oSSmgZZyVEaHDdaBh/ovEx0CFLFA2QDt+kZygRrf9iXuCYJi0mFEwanjHWyYraQS0juH5G2aOmxRu29pkw8r1mHoC67u5kJHc3FVu0mgdZsjKuyDWlrlRkcbOlybX72/N8nbAqYGriD7ak09UZE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.210.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-7c6d13986f8so1243540a34.0 for ; Fri, 21 Nov 2025 03:26:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763724395; x=1764329195; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SdjZB7D08cpEMTpXxqr4wUEPbtOidnkNlVo7PKpUQyg=; b=YL3ksDZs9mAeUMQtl8UN7YD00hLxITbGCAaBBhqSNJYAosvPXKebcZoDyOJztCoKKJ U6IxtNkGhiVlL7L6y5+52yDxgpzIfiJrcoh4r2yJTk5ZWWxRsL8U3I8+mwNJaRRjZfBT +5Ponvn1w9JHIKwGVu0JY5oZUFl73mzaxldORUtdqIpH1hrLYmqMigNillNLxje73M7h iBfLjnSHkcQAMpmJVO+4osoIttTyOmJTzp+XkFLBdGHlTEuLysfG0dMWIgTYd7rjdBv4 QZ9MiiFj55IbFzsM4+gT9BiqdZlkXhWSZ1yfQ/hAx7LMRAbEKc12kvfaApleRt2CijIr hC7g== X-Forwarded-Encrypted: i=1; AJvYcCWzV9MCEucNLsx/BZ9g0B6y+ZsA6zXPsZI7Y9RzpxiSvAmrjPLHyLa6BSNmG0n0tWOhbLzg8SbBKSrrUNo=@vger.kernel.org X-Gm-Message-State: AOJu0YxIBP/UK0oxNmTEt6pcvMyUKabsL8mINFfq2VMrbc81LdtuNN/H NbjZ0ETMNPnSlo7/mcFNkk9bs559IM2NrcEodEfciClwybFVfC8jdWgq X-Gm-Gg: ASbGncsFEoVdwmugTnUSr+CzJaRYvtDrEUWyLQ5HAYBqk/ku0sLgPJIVT6Dnop396bA +pQ1UTNmTT020m10H0yDRrB02M1mKvlswjFlfU0qpytYRNgZvmJJNDpOTndG5952Ic0A41EWws8 rOhq+TlZ8AaJ0Mu4iD+yc1hC8ZAnCaV+jO9P1xnrzeB+Mv8UzEP2UzOAIypy8mTCvAzBF3kUGvf L9CIBuJ7Y6u5v09zsXNyEtDJqzKFPEkoK64ES3g561CZwqLfqyF34j231bwT/bZ1LYBNUDenB25 AUftuIYgY4g2ZqUOtCjipr90GpvouuiUthr9yzDgsDNt0Tz4yufGW62g3P63YYoLHBGpl0MCFql WONOTlcqNNWV3xDdIYPIrzDMv3rVPQiulj5zEVVDpiDTaP7gvvSV/qvsajxdIhX2Lau078isUKc OaY/35qRKmBmwPUQ== X-Google-Smtp-Source: AGHT+IEwjUrwzMg7kt3g2ZGackcxWJ302wAVa0D7l6yCytkbxJYXnQqTOhQNiO7tRLNJYvD3venRrw== X-Received: by 2002:a05:6830:4108:b0:7c7:68d8:f70f with SMTP id 46e09a7af769-7c7989f089fmr1115747a34.3.1763724395410; Fri, 21 Nov 2025 03:26:35 -0800 (PST) Received: from localhost ([2a03:2880:10ff:4::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7c78d305ccasm2094895a34.4.2025.11.21.03.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 03:26:35 -0800 (PST) From: Breno Leitao Date: Fri, 21 Nov 2025 03:26:07 -0800 Subject: [PATCH RFC net-next 1/2] netconsole: extract message fragmentation into write_msg_target() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251121-nbcon-v1-1-503d17b2b4af@debian.org> References: <20251121-nbcon-v1-0-503d17b2b4af@debian.org> In-Reply-To: <20251121-nbcon-v1-0-503d17b2b4af@debian.org> To: Breno Leitao , Jakub Kicinski , horms@kernel.org, efault@gmx.de, john.ogness@linutronix.de, pmladek@suse.com Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, calvin@wbinvd.org, asml.silence@gmail.com, kernel-team@meta.com, gustavold@gmail.com, asantostc@gmail.com X-Mailer: b4 0.15-dev-a6db3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2210; i=leitao@debian.org; h=from:subject:message-id; bh=lVkterAId0pZtiHs0zzpoVow0duEjuPv9au7v95C+hs=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpIExod16+IHaeSvyyS5/zJbZ2JeyEy3IOiZVzt oS9NdEqC4iJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaSBMaAAKCRA1o5Of/Hh3 bZaCD/9sCHn7CuOXs5nhOaYQLAkb8jk5FeMhmT9BnoUmmv/PGQTX83UDsg5cyJJ5Ffn2efvM77F r8DQ32WPtc2qZdpDfOCFm9uLebGntqI09g0jB8qnXHbUDBksI3fGq7NKPZoKm1bTHx25SasYFPx yBDE++L5Jc2sJkoJx/1K1RH2mYTV/U+8R/8R6S9Yl+iUlswfxhTSorh19Rd2zN8+xuP52PIA2Pp Xb+z1YC2Q+PWYe9aqcNFzxZyim+/Gs4mk/4lhHzjYX3T6CnxfXMdRqCWnpXHZSjRP5TssgQJsea meR+1pyJYF1L0j2vkqfFZIIQSvPj05DjXVAMdrHFFcEjMTjo7dqNZEGZ6Zpj5jTf9KAJILaRLSi lPN9o9LmCTq+d2FeJSxZ3wWXYeIINYhq0grbYbYiqRCI3zXufmuAAE2SWaARwXCH4A/RPmOwCqW PUsy5rdBfNq84CkVEymagUuufxUOl6Ae+0nMTh8sweOKalDY2AfTZbbAwVGWpjtW+b+E0sVXa8i p+Aidz95efXIOcHQ5I9im9UM/81C213hekx6+zV+UA6ak3r5wSujCNZa7aDNs2Y+YxtsD1fMjV8 xfL3LuuFsVtZzDAOe21vV3fskAQF7Jia2USi++ZjDOGPVngqrKdCbqJN7ZUJLTe6ON37S0OO4gg s1prPw4GSWTVYjA== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D Refactor the message fragmentation logic in write_msg() by extracting it into a separate write_msg_target() helper function. This makes the code more maintainable and prepares for future reuse in nbcon support for non-extended consoles. The helper function takes a target, message, and length, then handles splitting the message into MAX_PRINT_CHUNK-sized fragments for sending via send_udp(). No functional change intended. Signed-off-by: Breno Leitao Reviewed-by: Petr Mladek --- drivers/net/netconsole.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index bb6e03a92956..f4b1706fb081 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -1559,6 +1559,20 @@ static void append_release(char *buf) scnprintf(buf, MAX_PRINT_CHUNK, "%s,", release); } =20 +static void write_msg_target(struct netconsole_target *nt, const char *msg, + unsigned int len) +{ + const char *tmp =3D msg; + int frag, left =3D len; + + while (left > 0) { + frag =3D min(left, MAX_PRINT_CHUNK); + send_udp(nt, tmp, frag); + tmp +=3D frag; + left -=3D frag; + } +} + static void send_fragmented_body(struct netconsole_target *nt, const char *msgbody, int header_len, int msgbody_len, int extradata_len) @@ -1728,10 +1742,8 @@ static void write_ext_msg(struct console *con, const= char *msg, =20 static void write_msg(struct console *con, const char *msg, unsigned int l= en) { - int frag, left; - unsigned long flags; struct netconsole_target *nt; - const char *tmp; + unsigned long flags; =20 if (oops_only && !oops_in_progress) return; @@ -1748,13 +1760,7 @@ static void write_msg(struct console *con, const cha= r *msg, unsigned int len) * at least one target if we die inside here, instead * of unnecessarily keeping all targets in lock-step. */ - tmp =3D msg; - for (left =3D len; left;) { - frag =3D min(left, MAX_PRINT_CHUNK); - send_udp(nt, tmp, frag); - tmp +=3D frag; - left -=3D frag; - } + write_msg_target(nt, msg, len); } } spin_unlock_irqrestore(&target_list_lock, flags); --=20 2.47.3