From nobody Tue Dec 2 01:51:39 2025 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D248332EC5 for ; Fri, 21 Nov 2025 15:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763737634; cv=none; b=OcXHrrJ+h4PVlkgO2vY+f+MlEkK0WC8UrIZMIN7aIATQ9l6b3aZxZkjxR1Zl9xTEo98hEu4mJOIiJ5JU181FlBGWOfMkr2fBZbe4R2ug9SXTQelL88Ddson1dHtJVPZkkXM7AplNccNjzqyUsnh+/nxzJ/H8UT9QWbeouIbg9QM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763737634; c=relaxed/simple; bh=6+fNHOwf5B3Mr/H+++1aDzYmBahYT1JXyEW9NioMyYc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=SjujuhRuVL5sZIGwDgyRvjrXqXhJe297URzRutKzRgxjk5SR6aUjFq3+OJRtj7KbsCBd/z+dtjhNEFbF0nu6KlRZxo49CRqAcEaJEiw+FRwAlB1KTHYP1wCZ0oWXe6MTe8fBeD0pGzymzdk+N1F4liN3jbQ68F4ly5EIktGBFvA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=CVvaN8qn; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="CVvaN8qn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1763737632; x=1795273632; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=6+fNHOwf5B3Mr/H+++1aDzYmBahYT1JXyEW9NioMyYc=; b=CVvaN8qnHztyY+vgNUl3ZaEdp5HRSulVT2+dadm7XOaIAhWUxZuo5YVa hEvgiUoFvzG9gdE4P385pMEdIsP87dD7LfJou8LtrZtgKJ0QexkzZoXvq nSAFtwB9JAbKiVQyjCaWSTzyNXg06pylU/I7UdwhDdebIh8ZShp7wt4Cl BjDAVWjCU21TCq/rQTYF8498kpbr0JLhmF9bROCbR/xOlJjoF7e0NRGrX XV9e4WTVf2JFTzgNtLGmLfjMPX1X1ejouvLJqrCmx2CbrRFizbULgNfk5 sreFreseB7xkJJRL3mBwl6d90liKbdfKs1/oFnwkwlLdI4qY28W/7Xyww A==; X-CSE-ConnectionGUID: f+FH760WRD6H6erujY1rjg== X-CSE-MsgGUID: MX79BasPTICOUlTHpgwyyA== X-IronPort-AV: E=Sophos;i="6.20,216,1758610800"; d="scan'208";a="216838769" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2025 08:07:10 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.87.151) by chn-vm-ex3.mchp-main.com (10.10.87.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.29; Fri, 21 Nov 2025 08:06:45 -0700 Received: from [127.0.0.1] (10.10.85.11) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Fri, 21 Nov 2025 08:06:37 -0700 From: Ludovic Desroches Date: Fri, 21 Nov 2025 16:04:39 +0100 Subject: [PATCH 7/8] drm/atmel-hlcdc: use drmm_universal_plane_alloc() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251121-lcd_cleanup_mainline-v1-7-2587e6fe4d67@microchip.com> References: <20251121-lcd_cleanup_mainline-v1-0-2587e6fe4d67@microchip.com> In-Reply-To: <20251121-lcd_cleanup_mainline-v1-0-2587e6fe4d67@microchip.com> To: Manikandan Muralidharan , "Dharma Balasubiramani" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea CC: , , , Ludovic Desroches X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2406; i=ludovic.desroches@microchip.com; h=from:subject:message-id; bh=6+fNHOwf5B3Mr/H+++1aDzYmBahYT1JXyEW9NioMyYc=; b=owEBbQKS/ZANAwAKAT455hP3e2QtAcsmYgBpIH/WgEXyc8uLNun0CUk9KwvC9R+kGfXdvvIqB 69iTO4Y6FGJAjMEAAEKAB0WIQQAMEvJiWmsW41tNU0+OeYT93tkLQUCaSB/1gAKCRA+OeYT93tk LebkEACuIxE1e0eQkRC4jb4H0E5QKRV+eEqX2xtt6KjJ3o/x/eJbRO4BFcODojFL/QLWJy6P9de 3tjyLPR9v5DaH7S2dDxbTkijvCaZ2Qp1EbhBSX0ABAOQibt7/SN7BDrqk7W6cOIp/VpRQfTt/WG sx4/8EYny35PO12JefX12jRHKcVOt7//m4I8+VQJGF2Tqe7+Pq+y+uaShau2kqHU1gybDKkW2ai TocpkF7R3oRqMk/mO1s0v5XrN0jxNxx60WukhF4o/ndb12Ut414KE0XRdKA177JagF8Xm+gaAZR skUHKd6sveMQMuFs4bsks/oxWwGMqv3Mg8GirvH+2pNgw+0vhYYyqhZUGjK3KoT0So80XuIvnNM P/3ZzFvjD5hiVSnpzDCa5ub3f1ISZRn1EYXhFNPdXO5w0nYGaDEbW4lvK/e+0Toaalb+3bxIfdO pxdbYJgoOet2o+JydjTCk/Sr///nh8U+w+WmZ14SiytCs7jx1viElEcqKySXnuUVueIIJw5mwuB VIDr1bg/v1b+5Cdj6eAevAhtzJ75BWnIEAQpoQFDSK+o7sSTYDZ6CtQs8kNiilNL/C3vs7Anx4S BGbR/KBZutlaANS3az071hDy91UHcIeUYpDqOlIXyfINJ+3/RH371C8xgJkLYjd1iqEpvx4Sau7 yab9EM5J9ttKPhQ== X-Developer-Key: i=ludovic.desroches@microchip.com; a=openpgp; fpr=665BAA7297BE089A28B77696E332995F09DCC11A Use the drmm_universal_plane_alloc() helper to simplify the code. Using it, we no longer need to register the destroy callback for drm_plane_funcs. Signed-off-by: Ludovic Desroches Reviewed-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/= drm/atmel-hlcdc/atmel_hlcdc_plane.c index 92132be9823f1e705d266f9547702ea9530bd043..c1f3aaae29fb9f6b947f81e2fb4= e7a61e10ac5d9 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c @@ -1225,7 +1225,6 @@ static void atmel_hlcdc_plane_atomic_destroy_state(st= ruct drm_plane *p, static const struct drm_plane_funcs layer_plane_funcs =3D { .update_plane =3D drm_atomic_helper_update_plane, .disable_plane =3D drm_atomic_helper_disable_plane, - .destroy =3D drm_plane_cleanup, .reset =3D atmel_hlcdc_plane_reset, .atomic_duplicate_state =3D atmel_hlcdc_plane_atomic_duplicate_state, .atomic_destroy_state =3D atmel_hlcdc_plane_atomic_destroy_state, @@ -1239,12 +1238,6 @@ static int atmel_hlcdc_plane_create(struct drm_devic= e *dev, enum drm_plane_type type; int ret; =20 - plane =3D devm_kzalloc(dev->dev, sizeof(*plane), GFP_KERNEL); - if (!plane) - return -ENOMEM; - - atmel_hlcdc_layer_init(&plane->layer, desc, dc->hlcdc->regmap); - if (desc->type =3D=3D ATMEL_HLCDC_BASE_LAYER) type =3D DRM_PLANE_TYPE_PRIMARY; else if (desc->type =3D=3D ATMEL_HLCDC_CURSOR_LAYER) @@ -1252,13 +1245,13 @@ static int atmel_hlcdc_plane_create(struct drm_devi= ce *dev, else type =3D DRM_PLANE_TYPE_OVERLAY; =20 - ret =3D drm_universal_plane_init(dev, &plane->base, 0, - &layer_plane_funcs, - desc->formats->formats, - desc->formats->nformats, - NULL, type, NULL); - if (ret) - return ret; + plane =3D drmm_universal_plane_alloc(dev, struct atmel_hlcdc_plane, base,= 0, + &layer_plane_funcs, desc->formats->formats, + desc->formats->nformats, NULL, type, NULL); + if (IS_ERR(plane)) + return PTR_ERR(plane); + + atmel_hlcdc_layer_init(&plane->layer, desc, dc->hlcdc->regmap); =20 drm_plane_helper_add(&plane->base, &atmel_hlcdc_layer_plane_helper_funcs); --=20 2.51.0