From nobody Tue Dec 2 01:51:36 2025 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B7932D94A9 for ; Fri, 21 Nov 2025 15:07:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763737622; cv=none; b=NKtrejxxYPsETc2ozlYMtRRXZ3hlTjpLGmECAyuZcT8Ph3w1nM4wlxP7vxFoZMfDiXIGSBHmGkmJtO+4rnZaeNaVqewpDT1OJf6oxNxEwfjRLP4JrxLJkaNn3MBSaQGaGzPd17JwUCdk7lX9klFhbpWxRsC0pqL6RqAjX9/G0Ik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763737622; c=relaxed/simple; bh=H4lz9IzPucH+8/psNxpuZMlk/rvyrt76Wj+dwW/qyMk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=IsddfAnM0W2OZqQCL5JYZaNFgGzh39HB6Lm1azDZuIx6sysll6AsQalZbOLnyhku7pCKjaAWa0pZqZoiVnLoxfhaE+VIdP+itw0YpVvZ5Qzq+UKfwC2c2EUaadqOZvBLRT3fLA1bbyTObbHficJFa1TYFfQOy5AG3Fit9RCcyK8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=IKm8E4Rg; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="IKm8E4Rg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1763737620; x=1795273620; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=H4lz9IzPucH+8/psNxpuZMlk/rvyrt76Wj+dwW/qyMk=; b=IKm8E4Rg6HKqA5H9PX5KYXHwcpshNcwlU+lshxXSLKaa7iV32MOI/idL Auua0G1YH1G78tpU3W+WmW9HT739+qCXO4kKqRDD35QPY2azLkhu72cuD YUm6msiQht6W22yAVtmp3NdNLFPfGfP7H3ht8UoT0Wg20acm+VDqw5H3Q sgXM792eK0Z+m3OSDzZgBbqDZjCWJVkvS30/CC8WNXkh8hDj6kvF2sT0f xgFUz/iUQUi3sWCp2mmmUG1JFHTKwVtLjbgWWeBDl1HWMtMc//XNUTypt fKYzgKWkOnJo2LKW+lgOL7IiUpMW4RvXEj/5Yr6iP1ko/M1pGCyiWMIXs A==; X-CSE-ConnectionGUID: ZsY1rJHWSEWAtJuR27K+Sw== X-CSE-MsgGUID: FAbZxFmwRbawMQ6bpWHzsA== X-IronPort-AV: E=Sophos;i="6.20,216,1758610800"; d="scan'208";a="280874265" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2025 08:06:58 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.87.151) by chn-vm-ex4.mchp-main.com (10.10.87.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.29; Fri, 21 Nov 2025 08:06:36 -0700 Received: from [127.0.0.1] (10.10.85.11) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Fri, 21 Nov 2025 08:06:33 -0700 From: Ludovic Desroches Date: Fri, 21 Nov 2025 16:04:38 +0100 Subject: [PATCH 6/8] drm/atmel-hlcdc: use drmm_crtc_alloc_with_planes() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251121-lcd_cleanup_mainline-v1-6-2587e6fe4d67@microchip.com> References: <20251121-lcd_cleanup_mainline-v1-0-2587e6fe4d67@microchip.com> In-Reply-To: <20251121-lcd_cleanup_mainline-v1-0-2587e6fe4d67@microchip.com> To: Manikandan Muralidharan , "Dharma Balasubiramani" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea CC: , , , Ludovic Desroches X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2868; i=ludovic.desroches@microchip.com; h=from:subject:message-id; bh=H4lz9IzPucH+8/psNxpuZMlk/rvyrt76Wj+dwW/qyMk=; b=owEBbQKS/ZANAwAKAT455hP3e2QtAcsmYgBpIH/WvQ+yKU/V0bCvhBe3QkiKGab/zxKSO67yQ V2J4Nrv9HSJAjMEAAEKAB0WIQQAMEvJiWmsW41tNU0+OeYT93tkLQUCaSB/1gAKCRA+OeYT93tk LXvLEACMR3bqdjvPH6YVQa6f9eIZI3LVryIGJh4oyiS12BRH7kz0saV4kiMJnupWYgf3nTomHrh HAcjC4DVLNpxXVbcAIWzA3NkzyF+/csAMT80dDc9dW62SXTzS5leuZuxVQlR+zUNqEpHJstSDkO Fnn4uNR6CkW0DFa015qMR9S5VyOqF2iY8oMYpNgl/H+vxeG1v0oS/5ERHR6IHnZPsvLCQNOfpUF JzmtVDqbpevkm/+trp+c6MTxEz0jzIObXPVyZB4M1Yz99Bi3TEhgC63hdnwB7/EmASzoOsFyMU9 9h4F8qQDIHgYGkQVFJMGfcgvByTW8Wgo50pXQIMEB8BXnfd54NnZXee6iKnPPvTBsIZckeYLPhs YEuP/tvVmHDaTRdBZib6l6rr/RTNvMZi495cAvLfe7n0bDgpetCq46mfrhjEFUoRACmXvlRh0hk QKOOzK8EohrpJpiJpBsOsemQdlcXLb/H4rmKzMFRGQnlQkF/sZm0XijEbXaO8AlQUBfWBnh0CMh 2MJYUVfsQ4safYE3saagxy1ppn7864Zsg/9F3p2ovYXeraEC7+ZNNBqpB2GlPlGw6Gx/+QkG1Nd k/t8yizkSZp376OmP3HGuxNNFrrc1HWzVFEPN+f5iDYjunPMTtpD+TCfz2OdYW2tET4n32viH+C VFbZTapwgb4FlEw== X-Developer-Key: i=ludovic.desroches@microchip.com; a=openpgp; fpr=665BAA7297BE089A28B77696E332995F09DCC11A Use drmm_crtc_alloc_with_planes() to simplify the code. As we no longer have to take care about cleanup, we can get rid of atmel_hlcdc_crtc_destroy(). Signed-off-by: Ludovic Desroches Reviewed-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 32 +++++-----------------= ---- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/d= rm/atmel-hlcdc/atmel_hlcdc_crtc.c index e0efc7309b1b256520eff29462431476f8589255..b075f291847f9eb91e07b784438= 2871f38ed5f81 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c @@ -509,14 +509,6 @@ static const struct drm_crtc_helper_funcs lcdc_crtc_he= lper_funcs =3D { .atomic_disable =3D atmel_hlcdc_crtc_atomic_disable, }; =20 -static void atmel_hlcdc_crtc_destroy(struct drm_crtc *c) -{ - struct atmel_hlcdc_crtc *crtc =3D drm_crtc_to_atmel_hlcdc_crtc(c); - - drm_crtc_cleanup(c); - kfree(crtc); -} - static void atmel_hlcdc_crtc_finish_page_flip(struct atmel_hlcdc_crtc *crt= c) { struct drm_device *dev =3D crtc->base.dev; @@ -607,7 +599,6 @@ static void atmel_hlcdc_crtc_disable_vblank(struct drm_= crtc *c) static const struct drm_crtc_funcs atmel_hlcdc_crtc_funcs =3D { .page_flip =3D drm_atomic_helper_page_flip, .set_config =3D drm_atomic_helper_set_config, - .destroy =3D atmel_hlcdc_crtc_destroy, .reset =3D atmel_hlcdc_crtc_reset, .atomic_duplicate_state =3D atmel_hlcdc_crtc_duplicate_state, .atomic_destroy_state =3D atmel_hlcdc_crtc_destroy_state, @@ -620,15 +611,8 @@ int atmel_hlcdc_crtc_create(struct drm_device *dev) struct atmel_hlcdc_plane *primary =3D NULL, *cursor =3D NULL; struct atmel_hlcdc_dc *dc =3D dev->dev_private; struct atmel_hlcdc_crtc *crtc; - int ret; int i; =20 - crtc =3D kzalloc(sizeof(*crtc), GFP_KERNEL); - if (!crtc) - return -ENOMEM; - - crtc->dc =3D dc; - for (i =3D 0; i < ATMEL_HLCDC_MAX_LAYERS; i++) { if (!dc->layers[i]) continue; @@ -646,13 +630,13 @@ int atmel_hlcdc_crtc_create(struct drm_device *dev) break; } } + crtc =3D drmm_crtc_alloc_with_planes(dev, struct atmel_hlcdc_crtc, base, + &primary->base, &cursor->base, &atmel_hlcdc_crtc_funcs, + NULL); + if (IS_ERR(crtc)) + return PTR_ERR(crtc); =20 - ret =3D drm_crtc_init_with_planes(dev, &crtc->base, &primary->base, - &cursor->base, &atmel_hlcdc_crtc_funcs, - NULL); - if (ret < 0) - goto fail; - + crtc->dc =3D dc; crtc->id =3D drm_crtc_index(&crtc->base); =20 for (i =3D 0; i < ATMEL_HLCDC_MAX_LAYERS; i++) { @@ -674,8 +658,4 @@ int atmel_hlcdc_crtc_create(struct drm_device *dev) dc->crtc =3D &crtc->base; =20 return 0; - -fail: - atmel_hlcdc_crtc_destroy(&crtc->base); - return ret; } --=20 2.51.0