From nobody Tue Dec 2 01:51:38 2025 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B6092D6400 for ; Fri, 21 Nov 2025 15:06:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763737591; cv=none; b=eHFqwuVy9PRwq9i+8RdcSF9f/XWR+5o4TNQ2L9+WAnKvz545fhFUwnri1IDBquD9934SSD/SQ99iFIG4IaP4o6uJr7ynbafGoomEq0hAhHL1cO1pTdPfI6Y5GrGN/Ct8Yk2UWiyKasI9OHP8ERE/+Xe8Jlp0uN/3HexPOuKT8GE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763737591; c=relaxed/simple; bh=B5OMjTtB3KvSOSitHSwKvJyc6OwPvRdH+hvUZpIHPnI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=hZLNGawZLqYwch9WrIJBjvTYCg+DxfHtwRyRBQ+ooX7GHan03hxf5qakMjfLn075hqFige2ib99owbfvxBHJOWN9zq5bo6EFb25EhgK4KX40gSXhHbRtLmhdj+tavHG6Ep0nx9it7RBqosnB0Z+hZ4V+A8gMqyEAth8sbUolvzg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=t1ebvH7r; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="t1ebvH7r" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1763737589; x=1795273589; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=B5OMjTtB3KvSOSitHSwKvJyc6OwPvRdH+hvUZpIHPnI=; b=t1ebvH7rIDnVhPA+OFtXIsltr4rxo2iZ78AmJpzTdpac2bXwAdjFvHWg 2rtIGfWeB9PaLXTC+ZpXl71pd7KHfaU18HUNx267tvu38PRlyXuJVWTgA owL8VfSAdZCyKyTDjpRqrTHkW17j7kuGSO+w/lnBVYNicqOtRn9I5qefc jADcdE+Gm0ksG8pmJNKmo6YWd0RMC8UdFdB7/lCa0PxIR7I24mqDkEWay GlVKpBHMqnv7015Nc2rOI/7neuxPxxdZnlgRnMAYkgJHgTqIctTUKuv3T ry94Mg4lvLOlts5kYpTvS8uJPlo7lkR5zRrYnaDEnBEqFvL9xWLR3qcDz w==; X-CSE-ConnectionGUID: Ubo8wtofT1S9f5fCNZ+Rrw== X-CSE-MsgGUID: g4LF2+ioTUiA4vtG7Q8JpA== X-IronPort-AV: E=Sophos;i="6.20,216,1758610800"; d="scan'208";a="56053150" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Nov 2025 08:06:25 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58; Fri, 21 Nov 2025 08:06:21 -0700 Received: from [127.0.0.1] (10.10.85.11) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Fri, 21 Nov 2025 08:06:17 -0700 From: Ludovic Desroches Date: Fri, 21 Nov 2025 16:04:35 +0100 Subject: [PATCH 3/8] drm/atmel-hlcdc: use drmm_simple_encoder_alloc() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251121-lcd_cleanup_mainline-v1-3-2587e6fe4d67@microchip.com> References: <20251121-lcd_cleanup_mainline-v1-0-2587e6fe4d67@microchip.com> In-Reply-To: <20251121-lcd_cleanup_mainline-v1-0-2587e6fe4d67@microchip.com> To: Manikandan Muralidharan , "Dharma Balasubiramani" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea CC: , , , Ludovic Desroches X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2109; i=ludovic.desroches@microchip.com; h=from:subject:message-id; bh=B5OMjTtB3KvSOSitHSwKvJyc6OwPvRdH+hvUZpIHPnI=; b=owEBbQKS/ZANAwAKAT455hP3e2QtAcsmYgBpIH/WAcQuo7Hgt4L59frM6s6uPhpepMvIVGwjA wngCTtUKpSJAjMEAAEKAB0WIQQAMEvJiWmsW41tNU0+OeYT93tkLQUCaSB/1gAKCRA+OeYT93tk LbjmD/0U/W8SnPLpZ3AacgQf/X++EdIxaLPSqNaRprjSPoBQYv3cwL/inKrefkFcq5nP7RGIF6z 2N9u2TaEbXxjmmkhlWiZCjCS+M0drepYHLRPgfacVB++6MZwD1eP2n+WS0wS34bNPSrAv2Y282P 49kr6YeXe81iexpbzUj4SjB0gEFupC8b0gcF2Xv69qfh6DhZ9xYlsGJ44liLSHSwaTmAmklPN76 6MLyX8yZCaUDRTWr3g7/aFA3dIeSojg+g53lFn9UkpJ30WhBUR3xnimUV1YpQUetprbueOSwOxL rnoczMML1Wue7kpJ4aFIFk+JsAXD3UCq9unihXIA1DN3vO92S5MOexHDZR17biWPL4ct8XfqMnG /7D+WPdos5i/V03gP0PA3qbxSdGAm2JwWS1xPd1ZbbHRRY4rIy3b/ImGoKYfvzJMAW+LlIS+rau qVreRuxCUkgeYkCWW1Gl9eC1nraap29z2n5KFWhjAgH2AMNKNMdaK/wXpS8wHJE84QOkMiOvm2h G+w6a1wGT4tqeW2C4zLsR9zZAA+JKA5Gd8AG88h7Z7JPCuW3reQbbJhGPiEW0tEqGNPI48/epcS PKtjBc6FFuxAzRluPil0rlUrgVNYuOVeHXwjv+fHhilfXdKN/HWKNXlnzdmCU+ltarb2rmPvvlg QskfThUnRSANNGg== X-Developer-Key: i=ludovic.desroches@microchip.com; a=openpgp; fpr=665BAA7297BE089A28B77696E332995F09DCC11A Simplify the code using drmm_simple_encoder_alloc to handle allocation and initialization at once. Signed-off-by: Ludovic Desroches Reviewed-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 27 ++++++++------------= ---- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu= /drm/atmel-hlcdc/atmel_hlcdc_output.c index 0b8a86afb0965ca3085dd5524983a0072199ec0b..1f43e0feeedae54321a17efc266= 654e72e8b9d8e 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c @@ -73,22 +73,19 @@ static int atmel_hlcdc_attach_endpoint(struct drm_devic= e *dev, int endpoint) struct drm_bridge *bridge; int ret; =20 - ep =3D of_graph_get_endpoint_by_regs(dev->dev->of_node, 0, endpoint); - if (!ep) - return -ENODEV; - ret =3D drm_of_find_panel_or_bridge(dev->dev->of_node, 0, endpoint, &panel, &bridge); - if (ret) { - of_node_put(ep); + if (ret) return ret; - } =20 - output =3D devm_kzalloc(dev->dev, sizeof(*output), GFP_KERNEL); - if (!output) { - of_node_put(ep); - return -ENOMEM; - } + output =3D drmm_simple_encoder_alloc(dev, struct atmel_hlcdc_rgb_output, + encoder, DRM_MODE_ENCODER_NONE); + if (IS_ERR(output)) + return PTR_ERR(output); + + ep =3D of_graph_get_endpoint_by_regs(dev->dev->of_node, 0, endpoint); + if (!ep) + return -ENODEV; =20 output->bus_fmt =3D atmel_hlcdc_of_bus_fmt(ep); of_node_put(ep); @@ -97,10 +94,6 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device= *dev, int endpoint) return -EINVAL; } =20 - ret =3D drm_simple_encoder_init(dev, &output->encoder, - DRM_MODE_ENCODER_NONE); - if (ret) - return ret; =20 output->encoder.possible_crtcs =3D 0x1; =20 @@ -120,8 +113,6 @@ static int atmel_hlcdc_attach_endpoint(struct drm_devic= e *dev, int endpoint) drm_panel_bridge_remove(bridge); } =20 - drm_encoder_cleanup(&output->encoder); - return ret; } =20 --=20 2.51.0