From nobody Tue Dec 2 02:03:05 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 493DB34B417 for ; Fri, 21 Nov 2025 11:01:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763722919; cv=none; b=BpTqSosv0T0jYqp88nRv/zFW796MBzen8pli11RCzLIuNIEaQ3Tr92O1X+3z0psJYT+oE/mV2ByLckGM1xAQTXNzI6KUDbxNjeGeb+cx78eslI+VT8PWIla1aNGvRP/77ToU8qYHb89TSY2lA6RBR6ksAy9BC6zKVaWOYfv3mfI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763722919; c=relaxed/simple; bh=UqFfKH9OQZ2/b4o5VCHbeXo4Mslpo8i6J1vh9DY1woc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZK+snN/DA/Vib0leYrQlvz09dU+2gqtJ2L8+CbYyadAFZGaOFPAtOsil2d1EFF7JnNv1CmCnxB4VdMqQRByt+Zzh2GhIpmWfpmIpiFsRQ7PEQRsx63UxznO85IylSdQpBKp9lpaSpc0nM/NoHe+vC+i3lDVzJduxJAN2Sp0BA2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MmM115u6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RAW0TW08; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MmM115u6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RAW0TW08" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AL5SUp32757556 for ; Fri, 21 Nov 2025 11:01:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TxCwmKSgjjNw13n9fGKA0+T8D45i0tXimnQWF4HRz2g=; b=MmM115u6Ax2YZ09J ImgNd+vp2INJTy5BY/6aFzyQxcU7j9zApMVFBwqLTE3Tx4/D2Nfsp+xeRO8+iDS2 VEWVf7UntSY2XjI/gGiV7pWZI6zt+K5udT+BkBwvQbYwLPqKgj7gbvQi7Iu/Vfci NQIpOCqNqZ035Cd5oEL6jY/o0YAdj4uajBAr6CniLmrJWtIXS0WohNfA79HV/FtF 0M3ajDz/CsijM9xXYvX/AslhJ/XperAn9ZpIUVzuzUhOk2Vi4Pbz72JHcDvi64yE sDuWtH3JiZmlLU7qBCuT4JDyHJzS+KP5boX9P56wX1DQIU8HjsjpEDNKKrmzU86W zQU7kQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ajhy615av-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Nov 2025 11:01:56 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3438b1220bcso2307342a91.2 for ; Fri, 21 Nov 2025 03:01:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763722916; x=1764327716; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TxCwmKSgjjNw13n9fGKA0+T8D45i0tXimnQWF4HRz2g=; b=RAW0TW080HXmRVEwKBWmCav88Q9kACR4QXqiotBLuqR8z3IOCn3GK65HufxMR6ReLd Kn4VYONBWKtj29UIJQQvzDSGhhKcBvERbSazaalN0p/gOSekFJBQqsIHnOuq32jQ4OTT RTTow+JFtYqM7xbZl6IDXnRxBSlbrIG5MVwr+Gu7Luy9DFdkyLWwHxJeHpN7AKG360gK 5kxu6+q6/OUvSLDWtDVLHx7o/nN8Zc1LywIy3U0kOzKOt76vqKBg5E57CqbCIk8rVwd4 RrUl+bNi5b7zdZaX+cQ0t1dV9dOhdCFwW8uUZhnYxes71BkIuSrra+wnH7KrjelBoG/I QWhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763722916; x=1764327716; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TxCwmKSgjjNw13n9fGKA0+T8D45i0tXimnQWF4HRz2g=; b=VAT2Y5fhlrK9jU0PV+RVKh+NTZPD4yBvFsYzpj6b713AB2lF3Vn4GLgdPuGzgrR138 l8o3QwXCPR21dMm1dRu7btDd5F0wYRR93fuaMMgMkb1OyFvAs0cFeHp/eQbSMskwurCi 9sr11axNqq5X7+gb53DcnzEzFPvA7dyYZIzTgLOoPvcuzWS+ANGyH2WqMM6yzNu1aqR6 rsZewCktrF2k6GIm9+2UBhQt6gdNvndwl31MyI41DoM7waEis05gDKOh5RmXeXElewgQ fR/FJCQea+fv5iHN6eIuYamaQ6JEPmV3DCVrWkTv6kVlzYWJ7VUK/0HdwDKckkcttHmE VkWg== X-Forwarded-Encrypted: i=1; AJvYcCWmlgV43mvYcPhWi9zheq2h5NZ2a/k3XXWLhYYOSf02aNKpqK6TNlCseMEKZDtsMOaRGHvNerUhWeRVVTw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywe0w4m0WFzaW7/JHLAp/OMzF2T5Q6omKfGYYUi4cPzx6ZwN18h kzSZoNxXGFE9npl0hC4HIR+fgcmBQMXX2B9GpY4MndSfmk1iRP3olGkLDqHotKo+glFlX+19c2g juIIb1+XCBS3Iq2FEAF9HawQxhunoMNcL9aQzM1GFN/7700C0KdcWoObBPTmexRljQmc= X-Gm-Gg: ASbGncvAxnNdCjnJg0wl2ALcUcqGsOG+Eh/JGZQUmuB+vlC2e4u0EwXD4+jQq0lkvk9 qOuciSzA6Dj+T3lyC6bSi665uZ01uNeV842jrfAZg77Z4M5h1eqASnZY0KPOf4EpkM+helc6yoT VHNgvZw6t0+1e74BozN/52LBvKEt4x6cLRl7iJIc5G3V6Qcg+sMdoNFaMSP7HIpuPvctLy0HC+2 zwW0BnTH9pN4mdKvfEODC9LS7KkUkr2PilHOPlyoOQsQzhngTqOVDkyEgzveCkeXQGNkSvie3Vc kf+cL5RfchM+d0pDMRgAmmbSJOn5i0dLoghTP57EUd7PNMkg7hmRSebLShc/lUR+jG8a1uMoYnH ItUCH1HqimPdXqwduGa3W7Q3upREucW+Ven/V X-Received: by 2002:a17:90b:1d8e:b0:340:bc27:97bd with SMTP id 98e67ed59e1d1-34733e6ca89mr2344639a91.9.1763722915441; Fri, 21 Nov 2025 03:01:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHAU6fbd4UxdagtjFdeI2dmaV9rageThqIRRP4Uav4AtmbuVsJdn1nDo65ZeIRX/2x0AU6DnA== X-Received: by 2002:a17:90b:1d8e:b0:340:bc27:97bd with SMTP id 98e67ed59e1d1-34733e6ca89mr2344579a91.9.1763722914733; Fri, 21 Nov 2025 03:01:54 -0800 (PST) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34727d5208csm5191165a91.15.2025.11.21.03.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 03:01:54 -0800 (PST) From: Mukesh Ojha Date: Fri, 21 Nov 2025 16:31:10 +0530 Subject: [PATCH v8 08/14] firmware: qcom_scm: Add a prep version of auth_and_reset function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251121-kvm_rproc_v8-v8-8-8e8e9fb0eca0@oss.qualcomm.com> References: <20251121-kvm_rproc_v8-v8-0-8e8e9fb0eca0@oss.qualcomm.com> In-Reply-To: <20251121-kvm_rproc_v8-v8-0-8e8e9fb0eca0@oss.qualcomm.com> To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha X-Mailer: b4 0.14-dev-f7c49 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763722879; l=4464; i=mukesh.ojha@oss.qualcomm.com; s=20250708; h=from:subject:message-id; bh=UqFfKH9OQZ2/b4o5VCHbeXo4Mslpo8i6J1vh9DY1woc=; b=/o8Qqz1ez1O2tJ0tSsDVKo5DEBeDJX5QdQsu0WqNFMhFto83aKEJFMHfxcLiefKgjNnPcw0Bf si6feT076I0DmwytTosjLJW8EKRZIMvpdMBz2ofYVUZRzLAbVONy2OZ X-Developer-Key: i=mukesh.ojha@oss.qualcomm.com; a=ed25519; pk=eX8dr/7d4HJz/HEXZIpe3c+Ukopa/wZmxH+5YV3gdNc= X-Authority-Analysis: v=2.4 cv=Lb0xKzfi c=1 sm=1 tr=0 ts=692046a4 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=XGel9bHSJmg9pP0w-tEA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: O2mAGoBVWzCGRKNKQNMmgNxuvKUC4kLf X-Proofpoint-GUID: O2mAGoBVWzCGRKNKQNMmgNxuvKUC4kLf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIxMDA4NCBTYWx0ZWRfX3jl5g5p4XreS BE2Mmobfx30qB1id6Xcj5xgWBH9Qw3KHL/ntvFMfyo9GVinNcAWjllvbBnHyx9oOsQgKDQ2s0gI VYo8Q8o4rhxBcphgPRJawRFnwhL68MsHXes9JwkluHHtETh5q1lO6003D8Jv+uStiKr5AQFjj3g t8bYTZSS0uNEDXiCs6P8h77qg9fBidA5nSPZF9J8YO+CP0SHdj06Acoh/syCLYXH9YhHzr5GQHD 9SVAb/MUJcrtlBpilNLepI6zb5AwDBdyl7TUF/ps14ZEUPPlthKeBhqz9yF3ADn5F51WbKfkkoW YxfSSwsZnvBhg9Q56g/ZD1QWSrmzNkpPtyN4txdUSd2U1El1MT6+zh6PEOO8bA0MdrjQbZmbxCC fKD5Ph5RR3nhM0EtViQ7WvidkgzswA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-21_03,2025-11-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 impostorscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511210084 For memory passed to TrustZone (TZ), it must either be part of a pool registered with TZ or explicitly registered via SHMbridge SMC calls. When Gunyah hypervisor is present, PAS SMC calls from Linux running at EL1 are trapped by Gunyah running @ EL2, which handles SHMbridge creation for both metadata and remoteproc carveout memory before invoking the calls to TZ. On SoCs running with a non-Gunyah-based hypervisor, Linux must take responsibility for creating the SHM bridge before invoking PAS SMC calls. For the auth_and_reset() call, the remoteproc carveout memory must first be registered with TZ via a SHMbridge SMC call and once authentication and reset are complete, the SHMbridge memory can be deregistered. Introduce qcom_scm_pas_prepare_and_auth_reset(), which sets up the SHM bridge over the remoteproc carveout memory when Linux operates at EL2. This behavior is indicated by a new field added to the PAS context data structure. The function then invokes the auth_and_reset SMC call. Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom/qcom_scm.c | 48 ++++++++++++++++++++++++++++++= ++++ include/linux/firmware/qcom/qcom_scm.h | 2 ++ 2 files changed, 50 insertions(+) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_= scm.c index 5fa974683ee0..fdb736d839db 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -765,6 +765,54 @@ int qcom_scm_pas_auth_and_reset(u32 pas_id) } EXPORT_SYMBOL_GPL(qcom_scm_pas_auth_and_reset); =20 +/** + * qcom_scm_pas_prepare_and_auth_reset() - Prepare, authenticate, and rese= t the + * remote processor + * + * @ctx: Context saved during call to qcom_scm_pas_context_init() + * + * This function performs the necessary steps to prepare a PAS subsystem, + * authenticate it using the provided metadata, and initiate a reset seque= nce. + * + * It should be used when Linux is in control setting up the IOMMU hardware + * for remote subsystem during secure firmware loading processes. The prep= aration + * step sets up a shmbridge over the firmware memory before TrustZone acce= sses the + * firmware memory region for authentication. The authentication step veri= fies + * the integrity and authenticity of the firmware or configuration using s= ecure + * metadata. Finally, the reset step ensures the subsystem starts in a cle= an and + * sane state. + * + * Return: 0 on success, negative errno on failure. + */ +int qcom_scm_pas_prepare_and_auth_reset(struct qcom_scm_pas_context *ctx) +{ + u64 handle; + int ret; + + if (!ctx->has_iommu) + return qcom_scm_pas_auth_and_reset(ctx->pas_id); + + /* + * When Linux running @ EL1, Gunyah hypervisor running @ EL2 traps the + * auth_and_reset call and create an shmbridge on the remote subsystem + * memory region and then invokes a call to TrustZone to authenticate. + * When Linux runs @ EL2 Linux must create the shmbridge itself and then + * subsequently call TrustZone for authenticate and reset. + */ + ret =3D qcom_tzmem_shm_bridge_create(ctx->mem_phys, ctx->mem_size, &handl= e); + if (ret) { + dev_err(__scm->dev, "Failed to create shmbridge for PAS ID (%u): %d\n", + ctx->pas_id, ret); + return ret; + } + + ret =3D qcom_scm_pas_auth_and_reset(ctx->pas_id); + qcom_tzmem_shm_bridge_delete(handle); + + return ret; +} +EXPORT_SYMBOL_GPL(qcom_scm_pas_prepare_and_auth_reset); + /** * qcom_scm_pas_shutdown() - Shut down the remote processor * @pas_id: peripheral authentication service id diff --git a/include/linux/firmware/qcom/qcom_scm.h b/include/linux/firmwar= e/qcom/qcom_scm.h index b10b1aeb32c6..ccb8b2e42237 100644 --- a/include/linux/firmware/qcom/qcom_scm.h +++ b/include/linux/firmware/qcom/qcom_scm.h @@ -74,6 +74,7 @@ struct qcom_scm_pas_context { void *ptr; dma_addr_t phys; ssize_t size; + bool has_iommu; }; =20 struct qcom_scm_pas_context *devm_qcom_scm_pas_context_init(struct device = *dev, @@ -87,6 +88,7 @@ int qcom_scm_pas_mem_setup(u32 pas_id, phys_addr_t addr, = phys_addr_t size); int qcom_scm_pas_auth_and_reset(u32 pas_id); int qcom_scm_pas_shutdown(u32 pas_id); bool qcom_scm_pas_supported(u32 pas_id); +int qcom_scm_pas_prepare_and_auth_reset(struct qcom_scm_pas_context *ctx); =20 int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val); int qcom_scm_io_writel(phys_addr_t addr, unsigned int val); --=20 2.50.1