From nobody Tue Dec 2 02:03:31 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BD9A34AB0D for ; Fri, 21 Nov 2025 11:01:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763722912; cv=none; b=m41vMgDGaVwM293GkNZWQ3oHy0r07jxW7ediSBjed9I+mR+oyDxlrSgab8SP6uFG0rbjRmqa8v7xJE+zXU1vep5acZLoDRFoDZDDBcvBEKYyFLNIA3PLyu2ZteTRaNMffX1NYpASuX1Vy9/kamYKW6q80aCruCVkPDIL2kjJadg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763722912; c=relaxed/simple; bh=P5U69w3P3RrrInJBdhiNdtUqS2lstsgQFpknD6yetgU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G/RJatbcbhpRRTE43yj76p91EAdyE5/3//273OlryteVhaenX8ukWJcwcbMQkR4lmwzRXctMIPmFhUCluVB12pcT5tSAI0UWdCsx1epoWDIChRRYmuIPIMYHazjs9VgM4CqsAmPv50yzXzV/c8i9IBtTsqMiKwQkYasS63bm3N0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CUIByRGX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BNLx2LlY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CUIByRGX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BNLx2LlY" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AL6ddgx1988099 for ; Fri, 21 Nov 2025 11:01:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 61/nTwA+YQVb/JWlGA+DXWSLg2PoQYRQMIcGlSkuVqw=; b=CUIByRGXvzHAS/6p AdBowdjNUzTQuoP5UxLdAitx8ro9jDA5CbKL/p2LvgwN5Iuze0zBWZ6OaK2RcZK6 bJvROzhUbUFn9Y3F6P3AfMxkZXlDK621h3ot4K4iyteztzhHSNu+YC0CIjXC7quK 8YjEcxcw/yDUAmLinOL7hCEFyd1T7YXF4xS83/8DO2gpYknPS8LOPYPKxwRsF1gh YFrKZYVyPswi3Wl+nUm3F0OGkQQpPv/5S9400AremwoQ+U8GJHwaXVHst7a4W2PV zMYhe4MLmo5My5vctgD3h2eC8iLTiujgJ2ggran2B3MLTC6vhbMYFJlhsInMzi9q BupfYw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aj1vac5pu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Nov 2025 11:01:48 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3437b43eec4so3288164a91.3 for ; Fri, 21 Nov 2025 03:01:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763722908; x=1764327708; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=61/nTwA+YQVb/JWlGA+DXWSLg2PoQYRQMIcGlSkuVqw=; b=BNLx2LlYIAX7gDnnih244FXUl0OZY0fYC2gERvShlhU2sOpdtaH/gFvrtT5ft8nUAC bdwjX6RrPYelW+IAvsHBLORlhuBarA0oiqPZlgxMq7EWJBCoDemcFmojgeQbQ1eXydDA 4/1QPMBnxFdOKWkV2Eow3n4Z6mFaJgOuuIqaY5yr9qhnGJGrDCLtUav2z1f6iY9uXOgx 3e/L60D6rpRmGagX/Lht/IvFvzFML2UEwooErYtBGonH+8pQjpoBSsZ7HllUtidphJef QsTFgKpIbbU0fBl7CzI/nkvsBgZeP8JGWCzsTHBbRmbSxe57Df2/HWre/Z7/7Kx6aVkj 3Huw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763722908; x=1764327708; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=61/nTwA+YQVb/JWlGA+DXWSLg2PoQYRQMIcGlSkuVqw=; b=aFaf563cJ7/iPbHRERvTnUz8Xnu5zM7IQtdQGKcw4DLadsx/RR+9wwDHm5sJlWPbWu 9jxwJqt4rVpO6L0KUs16gw/3MXyo96Q2kmD1uIFSgkTzzzP5xINlhRS8b4rwVz25Edz0 z+D7mTqzxr7ndPUEfQRWVpplR08Kboc1vQltUc9AbjRRllJ1TXYQI6nysuS+e70e90cP 6I8Ew0YnhDeojtghuMY9EgG3icsBYF/Y5JBbwO4522t59ivFxu1R8Q+pzo7yuQS4/ApU n6/amHZKm72teJGJjqZ4LsoR85rvidXBjK9zzzmjFORK6Jsss+k80c5qZBeNPP5rIdtL UxJg== X-Forwarded-Encrypted: i=1; AJvYcCV/YATOXRS8iKRuwTJY0kLNXrIZnqz9GAxy2h4Cb78/h5m83cMtxqa3KbmKZLaLvw4yWY+WNBv3dNpo5z8=@vger.kernel.org X-Gm-Message-State: AOJu0YzU7LPcmq/sUfP/4S2E7GTwhMuto+q5DOHPFx8YxaC1d8Ilax8m narQOnKb7sOnSrsSFlC2hOQnMB6T6A/62QkchdjIUqOyJGXts1h7CTABTRDAHcy5eXDtUHlcRD+ O0AN3y0zQrIBfpXIQSFRTkGDkIWQjAnOKpOnbK07zwHw/QYf2RsPqHuymVyKZ/wQC0gc= X-Gm-Gg: ASbGncsjXN22a25+t5CD20DbUlY6GF6c5x8wZi9gzZqONXRc79m3dp1R/GLgdIe56tH jV2h/XHGVEBUuxAU5RAUQM1mxuyT8eYtkzN2Zc8QHcBta63Gtnc13OPy0GFYX6+EUEY/oZuk291 7Imm4RFmJwzk4xuK3YC5lV2jtGKBvbfQxHJb7/l5x/iiE9fQX5WEZd24eJ4sm2r47/Flw3Oi9Bj VkhPjd9VvyJBOVg3ouveWwFVwi6/2UvM/3timfinPvk/Q5KqX+u9o5TlOxUCPDvUWtFdn2u1tEo uu+MsPKK9jKmd+8ohq16wMXKCH1glDsrmk7yQe33b2RsMf3RJKhrKvtir44uOwkstw1oUac44Bf QQuSOtxSTCCX+tErnnGfFU/qBJKM/px9+H5Kg X-Received: by 2002:a17:90b:53c3:b0:33b:b020:597a with SMTP id 98e67ed59e1d1-34733d68a15mr2167218a91.0.1763722907521; Fri, 21 Nov 2025 03:01:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IGhwcsgFYAkuaeX0Zh217forQYkU3Jj9NGxholJIUBIfCbw9zp0qKi5euy1gzSyvFRI4byGvw== X-Received: by 2002:a17:90b:53c3:b0:33b:b020:597a with SMTP id 98e67ed59e1d1-34733d68a15mr2167183a91.0.1763722906934; Fri, 21 Nov 2025 03:01:46 -0800 (PST) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34727d5208csm5191165a91.15.2025.11.21.03.01.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 03:01:46 -0800 (PST) From: Mukesh Ojha Date: Fri, 21 Nov 2025 16:31:08 +0530 Subject: [PATCH v8 06/14] soc: qcom: mdtloader: Add PAS context aware qcom_mdt_pas_load() function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251121-kvm_rproc_v8-v8-6-8e8e9fb0eca0@oss.qualcomm.com> References: <20251121-kvm_rproc_v8-v8-0-8e8e9fb0eca0@oss.qualcomm.com> In-Reply-To: <20251121-kvm_rproc_v8-v8-0-8e8e9fb0eca0@oss.qualcomm.com> To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Mukesh Ojha X-Mailer: b4 0.14-dev-f7c49 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763722879; l=5691; i=mukesh.ojha@oss.qualcomm.com; s=20250708; h=from:subject:message-id; bh=P5U69w3P3RrrInJBdhiNdtUqS2lstsgQFpknD6yetgU=; b=3UfxfR13JpcREfNzQtqKDrslo/BrquSvaAzCRe+OnPp3IVDUMQDoh0IUydt8hsbjSP9FcsnEe YPuRkYXMTQODyVS6NK49iJZd80rpKpAiSWsUZ16lSAmqvXtRHclT9ig X-Developer-Key: i=mukesh.ojha@oss.qualcomm.com; a=ed25519; pk=eX8dr/7d4HJz/HEXZIpe3c+Ukopa/wZmxH+5YV3gdNc= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIxMDA4NCBTYWx0ZWRfXwhJreylYkB2i J5S2wExjWSr3OIZGjo3zzpg+hWxhZ+UvArtk7tfhsGBkVFyD6yZcAFDKjLiOMwqCqf3KJ3bEG1h P2E/IaCWCdvxQlsbiG3XTukKds91Tz7VZeRKAvHsdPcbFmTjC0KW926/YP3Wp00vhdmGHdDOs+I wUVyw1oI1KsziCCR5C9HecwRjLY9Yk8d7aEHK1pVuI6fXK1j1lEbFv3trBzWXHj6CNiitEoZ7WN Otd1askH6374eR0DR9eToomiMk/MVRaxeeg9lvyyrEI0jV/V64xgYXC/CtiETLFrMTBVPwuEVwC 4rK977sD0Qs4nC0lnaprDxLIhjMH0qLoPbk9bV4F2FJdOgbKeogxoYHlq0cjSco5aZr4mPYjeIr qe4FvY1O5eJXcyXaCRY69aubgMe6iw== X-Authority-Analysis: v=2.4 cv=Vpwuwu2n c=1 sm=1 tr=0 ts=6920469c cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=lkfLrt0I0aiTJqoH1swA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: 6BL4EpbThOf95dj5bebiCedeZGKFvrAl X-Proofpoint-GUID: 6BL4EpbThOf95dj5bebiCedeZGKFvrAl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-21_03,2025-11-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 bulkscore=0 phishscore=0 priorityscore=1501 malwarescore=0 spamscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511210084 Introduce a new PAS context-aware function, qcom_mdt_pas_load(), for remote processor drivers. This function utilizes the PAS context pointer returned from qcom_scm_pas_ctx_init() to perform firmware metadata verification and memory setup via SMC calls. The qcom_mdt_pas_load() and qcom_mdt_load() functions are largely similar, but the former is designed for clients using the PAS context-based data structure. Over time, all users of qcom_mdt_load() can be migrated to use qcom_mdt_pas_load() for consistency and improved abstraction. As the remoteproc PAS driver (qcom_q6v5_pas) has already adopted the PAS context-based approach, update it to use qcom_mdt_pas_load(). Reviewed-by: Konrad Dybcio Signed-off-by: Mukesh Ojha --- drivers/remoteproc/qcom_q6v5_pas.c | 24 +++++------------------- drivers/soc/qcom/mdt_loader.c | 31 +++++++++++++++++++++++++++++++ include/linux/soc/qcom/mdt_loader.h | 10 ++++++++++ 3 files changed, 46 insertions(+), 19 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q= 6v5_pas.c index 729e7b9bc183..9feee2cb1883 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -239,15 +239,9 @@ static int qcom_pas_load(struct rproc *rproc, const st= ruct firmware *fw) return ret; } =20 - ret =3D qcom_mdt_pas_init(pas->dev, pas->dtb_firmware, pas->dtb_firmware= _name, - pas->dtb_pas_id, pas->dtb_mem_phys, - pas->dtb_pas_ctx); - if (ret) - goto release_dtb_firmware; - - ret =3D qcom_mdt_load_no_init(pas->dev, pas->dtb_firmware, pas->dtb_firm= ware_name, - pas->dtb_mem_region, pas->dtb_mem_phys, - pas->dtb_mem_size, &pas->dtb_mem_reloc); + ret =3D qcom_mdt_pas_load(pas->dtb_pas_ctx, pas->dtb_firmware, + pas->dtb_firmware_name, pas->dtb_mem_region, + &pas->dtb_mem_reloc); if (ret) goto release_dtb_metadata; } @@ -256,8 +250,6 @@ static int qcom_pas_load(struct rproc *rproc, const str= uct firmware *fw) =20 release_dtb_metadata: qcom_scm_pas_metadata_release(pas->dtb_pas_ctx); - -release_dtb_firmware: release_firmware(pas->dtb_firmware); =20 return ret; @@ -305,14 +297,8 @@ static int qcom_pas_start(struct rproc *rproc) } } =20 - ret =3D qcom_mdt_pas_init(pas->dev, pas->firmware, rproc->firmware, pas->= pas_id, - pas->mem_phys, pas->pas_ctx); - if (ret) - goto disable_px_supply; - - ret =3D qcom_mdt_load_no_init(pas->dev, pas->firmware, rproc->firmware, - pas->mem_region, pas->mem_phys, pas->mem_size, - &pas->mem_reloc); + ret =3D qcom_mdt_pas_load(pas->pas_ctx, pas->firmware, rproc->firmware, + pas->mem_region, &pas->mem_reloc); if (ret) goto release_pas_metadata; =20 diff --git a/drivers/soc/qcom/mdt_loader.c b/drivers/soc/qcom/mdt_loader.c index b125140100db..50c6a3c6b2a3 100644 --- a/drivers/soc/qcom/mdt_loader.c +++ b/drivers/soc/qcom/mdt_loader.c @@ -478,5 +478,36 @@ int qcom_mdt_load(struct device *dev, const struct fir= mware *fw, } EXPORT_SYMBOL_GPL(qcom_mdt_load); =20 +/** + * qcom_mdt_pas_load - Loads and authenticates the metadata of the firmware + * (typically contained in the .mdt file), followed by loading the actual + * firmware segments (e.g., .bXX files). Authentication of the segments do= ne + * by a separate call. + * + * The PAS context must be initialized using qcom_scm_pas_context_init() + * prior to invoking this function. + * + * @ctx: Pointer to the PAS (Peripheral Authentication Service) con= text + * @fw: Firmware object representing the .mdt file + * @firmware: Name of the firmware used to construct segment file names + * @mem_region: Memory region allocated for loading the firmware + * @reloc_base: Physical address adjusted after relocation + * + * Return: 0 on success or a negative error code on failure. + */ +int qcom_mdt_pas_load(struct qcom_scm_pas_context *ctx, const struct firmw= are *fw, + const char *firmware, void *mem_region, phys_addr_t *reloc_base) +{ + int ret; + + ret =3D qcom_mdt_pas_init(ctx->dev, fw, firmware, ctx->pas_id, ctx->mem_p= hys, ctx); + if (ret) + return ret; + + return qcom_mdt_load_no_init(ctx->dev, fw, firmware, mem_region, ctx->mem= _phys, + ctx->mem_size, reloc_base); +} +EXPORT_SYMBOL_GPL(qcom_mdt_pas_load); + MODULE_DESCRIPTION("Firmware parser for Qualcomm MDT format"); MODULE_LICENSE("GPL v2"); diff --git a/include/linux/soc/qcom/mdt_loader.h b/include/linux/soc/qcom/m= dt_loader.h index 07c278841816..7d57746fbbfa 100644 --- a/include/linux/soc/qcom/mdt_loader.h +++ b/include/linux/soc/qcom/mdt_loader.h @@ -23,6 +23,9 @@ int qcom_mdt_load(struct device *dev, const struct firmwa= re *fw, phys_addr_t mem_phys, size_t mem_size, phys_addr_t *reloc_base); =20 +int qcom_mdt_pas_load(struct qcom_scm_pas_context *ctx, const struct firmw= are *fw, + const char *firmware, void *mem_region, phys_addr_t *reloc_base); + int qcom_mdt_load_no_init(struct device *dev, const struct firmware *fw, const char *fw_name, void *mem_region, phys_addr_t mem_phys, size_t mem_size, @@ -52,6 +55,13 @@ static inline int qcom_mdt_load(struct device *dev, cons= t struct firmware *fw, return -ENODEV; } =20 +static inline int qcom_mdt_pas_load(struct qcom_scm_pas_context *ctx, + const struct firmware *fw, const char *firmware, + void *mem_region, phys_addr_t *reloc_base) +{ + return -ENODEV; +} + static inline int qcom_mdt_load_no_init(struct device *dev, const struct firmware *fw, const char *fw_name, void *mem_region, --=20 2.50.1