From nobody Tue Dec 2 02:05:06 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2620310627 for ; Thu, 20 Nov 2025 23:26:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763681196; cv=none; b=CBV4JhnqLgdOVBxYBHxRULDRO4spRHxIRwU0tVhckVlthNuYNjjCIecDfnXT8kvmJeJ6Rsso7K4aAf3ZWidX8rmLnVtkGydzsWRxbRFdgeeguUY7EKkoAqryHUE4eySyUN6gUqV9LmYlaunITW+o55vMKO3EAFeCgcQlZSCfoeo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763681196; c=relaxed/simple; bh=iGs7BanQHddMZMGfKDEryE+zQ05RBV6r6JyCAjO90ng=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=rkcbBNmtT1FFpx5l3+tghsFoiATHHxuvSh0aVdY/B4aX5kPwzg4IFkVHOIukGhIjyjqM7naA4ZNfOns861QUbro+z+UB+0vErrMrdHKApMhxUni5sKBHtxXblTmv+lzxBpQbzXocMrhVG4r+oCqQtL3G4mXqh2XinHv2omHzVX0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vPD40Bze; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vPD40Bze" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADD24C19425; Thu, 20 Nov 2025 23:26:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763681196; bh=iGs7BanQHddMZMGfKDEryE+zQ05RBV6r6JyCAjO90ng=; h=Date:From:To:Cc:Subject:References:From; b=vPD40BzenR6nKT+4f97wD8DNHbnZntxVilvpSEYDhW7IuNwYvc/aBcydw+zp5TcT4 73Xk0dHo3qVOyqL46mQ/4cXiiodDM4PuPwINb5MIPMXuNCVPVQn3tKnjbADJV6XpkC 6KjND/qUqO0gLfnYeb5+8NJWPnu3iHMZ7P6tHvQhrstdJhZJuBNUWHUUCtRjPd74xK oTybvV4jSzkxSFXyUme0Dlh/RXSVuVR64B9jew9U4Pulu9z7hsI4JZG8tIhs362PXl f4yub/lKw8mKXNnLUswc80LJs2qwWdUJirX5S9m94epWPlcNftHAgfjuedZ6nltD3k UOC89Ada499Yg== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1vME3R-000000041xB-3EFZ; Thu, 20 Nov 2025 18:27:09 -0500 Message-ID: <20251120232709.626030604@kernel.org> User-Agent: quilt/0.68 Date: Thu, 20 Nov 2025 18:23:37 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Tomas Glozar , John Kacur , Ivan Pravdin Subject: [for-next][PATCH 14/16] rtla: Fix -a overriding -t argument References: <20251120232323.271532418@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ivan Pravdin When running rtla as `rtla -t custom_file.txt -a 100` -a options override trace output filename specified by -t option. Running the command above will create _trace.txt file instead of custom_file.txt. Fix this by making sure that -a option does not override trace output filename even if it's passed after trace output filename is specified. Fixes: 173a3b014827 ("rtla/timerlat: Add the automatic trace option") Signed-off-by: Ivan Pravdin Reviewed-by: Tomas Glozar Link: https://lore.kernel.org/r/b6ae60424050b2c1c8709e18759adead6012b971.17= 62186418.git.ipravdin.official@gmail.com [ use capital letter in subject, as required by tracing subsystem ] Signed-off-by: Tomas Glozar --- tools/tracing/rtla/src/osnoise_hist.c | 3 ++- tools/tracing/rtla/src/osnoise_top.c | 3 ++- tools/tracing/rtla/src/timerlat_hist.c | 3 ++- tools/tracing/rtla/src/timerlat_top.c | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/tracing/rtla/src/osnoise_hist.c b/tools/tracing/rtla/src= /osnoise_hist.c index 1d06ea47b663..ff8c231e47c4 100644 --- a/tools/tracing/rtla/src/osnoise_hist.c +++ b/tools/tracing/rtla/src/osnoise_hist.c @@ -534,7 +534,8 @@ static struct common_params params->threshold =3D 1; =20 /* set trace */ - trace_output =3D "osnoise_trace.txt"; + if (!trace_output) + trace_output =3D "osnoise_trace.txt"; =20 break; case 'b': diff --git a/tools/tracing/rtla/src/osnoise_top.c b/tools/tracing/rtla/src/= osnoise_top.c index cac60e4c267e..04c699bdd736 100644 --- a/tools/tracing/rtla/src/osnoise_top.c +++ b/tools/tracing/rtla/src/osnoise_top.c @@ -386,7 +386,8 @@ struct common_params *osnoise_top_parse_args(int argc, = char **argv) params->threshold =3D 1; =20 /* set trace */ - trace_output =3D "osnoise_trace.txt"; + if (!trace_output) + trace_output =3D "osnoise_trace.txt"; =20 break; case 'c': diff --git a/tools/tracing/rtla/src/timerlat_hist.c b/tools/tracing/rtla/sr= c/timerlat_hist.c index 961aa969c003..1fb471a787b7 100644 --- a/tools/tracing/rtla/src/timerlat_hist.c +++ b/tools/tracing/rtla/src/timerlat_hist.c @@ -853,7 +853,8 @@ static struct common_params params->print_stack =3D auto_thresh; =20 /* set trace */ - trace_output =3D "timerlat_trace.txt"; + if (!trace_output) + trace_output =3D "timerlat_trace.txt"; =20 break; case 'c': diff --git a/tools/tracing/rtla/src/timerlat_top.c b/tools/tracing/rtla/src= /timerlat_top.c index 213356a5be52..fec113ce370e 100644 --- a/tools/tracing/rtla/src/timerlat_top.c +++ b/tools/tracing/rtla/src/timerlat_top.c @@ -617,7 +617,8 @@ static struct common_params params->print_stack =3D auto_thresh; =20 /* set trace */ - trace_output =3D "timerlat_trace.txt"; + if (!trace_output) + trace_output =3D "timerlat_trace.txt"; =20 break; case '5': --=20 2.51.0