From nobody Tue Dec 2 02:05:04 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AA293081A1 for ; Thu, 20 Nov 2025 23:26:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763681195; cv=none; b=YlAJnsUWE4rnfVX3K5gPoeHzv9AlehnWmXrFHc9m3EcT/Cx2FBzsLvlJznD4SLc4vxsqm/lBzc4tEfedSGDUeZIG9BApyJ5sUzaYpW1zszTp3f0hr86IapZIjId2RjnP2AjxwHJ3o0gfQ2hstmrU28VdRgVGQBVTlU2zcqUOUts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763681195; c=relaxed/simple; bh=s7XD0yiEzgz9Cw3XnWy2aO8u7Vltpi7RlbW/tIXPRZE=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=Yz2aT+5sdlmVV8ffKK4W6B2ITTrodyzzyV4prcK/v0dzLAnAv8ArxN7DCy2dbv070W+gD3zZPbTRfdUV9EJz46dFKmLt2p4MmK1Hp4sXQlhCZmQHOBi5o5tjjDwhrv6IdHcQgbHtID79Urh6gZPoYFIkjHfmvdMLwKYTyxOlR4o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HWD13E1J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HWD13E1J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42BE8C4AF09; Thu, 20 Nov 2025 23:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763681195; bh=s7XD0yiEzgz9Cw3XnWy2aO8u7Vltpi7RlbW/tIXPRZE=; h=Date:From:To:Cc:Subject:References:From; b=HWD13E1JRsPLpQcaDGu/j+kZSs8H7MDImxa6rRztthDXNfldOL6ry7hXFyI9/pVVK HuCWcPNAuyd1lS7pWNzFl16VXrWXA0+fmn9bJp7XHrAnKvCNb1ByALeFqVJ93g5fOi KVfrxqjXplHlbBd8s3y1MGqxyiG7FUvn2R2uQFkaRh8LRZychu55pHk3bM+9ppL0EU 8zWMgj4fDadrUPfSLR0P7PN9HaUh8wy2+wc6PtwSy7HWZzKvjGPyPnlSKAWUmF6Yec 1D15LDEB7ZvXCumLgk3LKfJaX7egKIThkCgLfO+Yy7FGM0Fpp2TMz8jVr6mjnoh1Wq MM8lpbgDxmM0w== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1vME3Q-000000041tA-1mFG; Thu, 20 Nov 2025 18:27:08 -0500 Message-ID: <20251120232708.273880490@kernel.org> User-Agent: quilt/0.68 Date: Thu, 20 Nov 2025 18:23:29 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Tomas Glozar , John Kacur , Wander Lairson Costa Subject: [for-next][PATCH 06/16] rtla/tests: Extend action tests to 5s References: <20251120232323.271532418@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tomas Glozar In non-BPF mode, it takes up to 1 second for RTLA to notice that tracing has been stopped. That means that action tests cannot have a 1 second duration, as the SIGALRM will be racing with the threshold overflow. Previously, non-BPF mode actions were buggy and always executed the action, even when stopping on duration or SIGINT, preventing this issue from manifesting. Now that this has been fixed, the tests have become flaky, and this has to be adjusted. Fixes: 4e26f84abfb ("rtla/tests: Add tests for actions") Fixes: 05b7e10687c ("tools/rtla: Add remaining support for osnoise actions") Reviewed-by: Wander Lairson Costa Link: https://lore.kernel.org/r/20251007095341.186923-2-tglozar@redhat.com Signed-off-by: Tomas Glozar --- tools/tracing/rtla/tests/osnoise.t | 4 ++-- tools/tracing/rtla/tests/timerlat.t | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/tracing/rtla/tests/osnoise.t b/tools/tracing/rtla/tests/= osnoise.t index e3c89d45a6bb..08196443fef1 100644 --- a/tools/tracing/rtla/tests/osnoise.t +++ b/tools/tracing/rtla/tests/osnoise.t @@ -39,9 +39,9 @@ check "hist stop at failed action" \ check "top stop at failed action" \ "timerlat top -T 2 --on-threshold shell,command=3D'echo -n abc; false' --= on-threshold shell,command=3D'echo -n defgh'" 2 "^abc" "defgh" check "hist with continue" \ - "osnoise hist -S 2 -d 1s --on-threshold shell,command=3D'echo TestOutput'= --on-threshold continue" 0 "^TestOutput$" + "osnoise hist -S 2 -d 5s --on-threshold shell,command=3D'echo TestOutput'= --on-threshold continue" 0 "^TestOutput$" check "top with continue" \ - "osnoise top -q -S 2 -d 1s --on-threshold shell,command=3D'echo TestOutpu= t' --on-threshold continue" 0 "^TestOutput$" + "osnoise top -q -S 2 -d 5s --on-threshold shell,command=3D'echo TestOutpu= t' --on-threshold continue" 0 "^TestOutput$" check "hist with trace output at end" \ "osnoise hist -d 1s --on-end trace" 0 "^ Saving trace to osnoise_trace.t= xt$" check "top with trace output at end" \ diff --git a/tools/tracing/rtla/tests/timerlat.t b/tools/tracing/rtla/tests= /timerlat.t index b5d1e7260a9b..b550a6ae2445 100644 --- a/tools/tracing/rtla/tests/timerlat.t +++ b/tools/tracing/rtla/tests/timerlat.t @@ -60,9 +60,9 @@ check "hist stop at failed action" \ check "top stop at failed action" \ "timerlat top -T 2 --on-threshold shell,command=3D'echo -n 1; false' --on= -threshold shell,command=3D'echo -n 2'" 2 "^1ALL" check "hist with continue" \ - "timerlat hist -T 2 -d 1s --on-threshold shell,command=3D'echo TestOutput= ' --on-threshold continue" 0 "^TestOutput$" + "timerlat hist -T 2 -d 5s --on-threshold shell,command=3D'echo TestOutput= ' --on-threshold continue" 0 "^TestOutput$" check "top with continue" \ - "timerlat top -q -T 2 -d 1s --on-threshold shell,command=3D'echo TestOutp= ut' --on-threshold continue" 0 "^TestOutput$" + "timerlat top -q -T 2 -d 5s --on-threshold shell,command=3D'echo TestOutp= ut' --on-threshold continue" 0 "^TestOutput$" check "hist with trace output at end" \ "timerlat hist -d 1s --on-end trace" 0 "^ Saving trace to timerlat_trace= .txt$" check "top with trace output at end" \ --=20 2.51.0