From nobody Tue Dec 2 02:05:49 2025 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 844871EB5FD for ; Thu, 20 Nov 2025 18:46:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763664386; cv=none; b=bm5f73t2JU7W0aSFAfX+IMpuzAFxmGWGW9wceCjK3CehD7AOZN42xLbW5MvA2yAbJqoIbccq6ot2FkAqlUHQc7ImZjNRxVP2wbaliahEebvdYJmPFq/mhPWN0/63dsrvJkM8ohKxgFU/NrVwprRj8G65C/Z8qPm3Kx2hoPuU1pA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763664386; c=relaxed/simple; bh=WIwRUSH7l4qlGCKFZPYl8/u8vLgqjJN71XMPndirieA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=B1kBG0jZ4RcaXYO+0SvrWkwvZyDDGlROjY42BOQ7fOKzxaWVSSteGTnf1RzmYOm8eWkaBEtEgSeArtR+ALUXOuFHmjAtunQzTVaeFz8A8waoMBlLO4+gFFgjygbikwjZ3PqsIqkNxVgkQh2dFq+QCz5+nitC6QdAn39f8oKiWqo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ee.vjti.ac.in; spf=none smtp.mailfrom=ee.vjti.ac.in; dkim=pass (1024-bit key) header.d=vjti.ac.in header.i=@vjti.ac.in header.b=b3GWxKoI; arc=none smtp.client-ip=209.85.210.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ee.vjti.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ee.vjti.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=vjti.ac.in header.i=@vjti.ac.in header.b="b3GWxKoI" Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-7bc0cd6a13aso824456b3a.0 for ; Thu, 20 Nov 2025 10:46:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vjti.ac.in; s=google; t=1763664384; x=1764269184; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DECYox+CapSATqMptNWT/nLrZzGas6t+p+j6f8U0w64=; b=b3GWxKoIDaPv+u4eHM2QtDJj3tF5KP4yE3l2CW5mXquqjh/9BNOEqCkRHAAMywvFfD YsI+20wlfvszBRyV1KYrkDYZ/8jQwC+fWeZQdYSAfQMMWrOD5ZFj3XWUDbmCYfXK0S+7 l+UAZX4sj8ShNkh7ZgNppKZtntNoN8cXRdet0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763664384; x=1764269184; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DECYox+CapSATqMptNWT/nLrZzGas6t+p+j6f8U0w64=; b=BWL507idCc+s/UnTSkO8YQ6nZ1HFxqL/w6jXoJYG73fMR9mcca7kzx7L+HrFrznyWH lxDFT9zu9wGR+De6MaiPsfgyCcB+psdGVBIgm7W53QLPVYadjZ15C8d/aPrMKsFAAxJF E7rWC4BGkGhz7Ibd0pw6LG4UsuzP6zVxs/WD+mzYlGfEdqeiJr1r+hpV/EpUfOUXkyI6 g02dJfjwJimRQos/WeoXtNzoKthioSIqMiNoRrEXsLBqtwrZoA/mor4NN8rQ6pgTm7tV r0A/ycRZnItc8CGMN0C9Gh8MJ37EHJahfyVvWyR0XBFMxxQbnbFamwkzUUFtnJ11bLil ABXA== X-Forwarded-Encrypted: i=1; AJvYcCWyutU1xNP1R0R/V3hWqj6NIDaxd0uQTYhQ9zSMXp2Oy0SiYw0N/ZZpkDtCL89+0E7kq6/mdfvTSqZSLW4=@vger.kernel.org X-Gm-Message-State: AOJu0YyJlg9JRBHKl6CvmXp6zrOGA/VXScYbiWGb80qGKZeQLk2QBX+N lhLB+FcjrmvDMPfod4DaxuOw9NAAIQCmjj3paJH5k50GJOO50XvIFSOwT1aPvE2U1MI= X-Gm-Gg: ASbGncvE7bwduwJIaGwcnskOrH+pJ7rINVNJk1TNAoE+JEpOfGMtscToMA4YbkjRiw+ gslOBZB5g96XmrhtKaVsivf8x+7fzQqMa8b3HFnlbePG0K9wPlBHyno2vRNWoOmETIZQXcN+8Vw NE+n8HAKEo24hJXmdE+H2uXCq9mdcLwUnISeTsLAi1/oaZqzedwCff0hnA6zpjRVN9yWALOxe/m SIdptk688RSJy63lfAv7UtOQ6mTWNjoZkVKju5olSY0MNMlsSOO64b+mkss9KmdVjPLFx7a/B+K u3mYHdWTQ7VBim7LCUJuHi8jn69+TXX7gDcBelA8ivWX0xBUSqiBdsxwpiGEPpO5meYblS4H/4I zOlfUKBzop1g/Hu6hO+xP2Dy18VhWXbFC+dng2eyAlgg0IBykAmQw0j//SgTl+eTkdOt1OgAaxM LPlVZiLb/Fpax5zn4JVHQAy426QNIF6gudmOcqaDWa1A76cXxJpqsu2xU= X-Google-Smtp-Source: AGHT+IHYPJDcnzHOf+yWRwdg9QPX8Vu/d+tWBeV5wmp+wzw4tQt7hYjMbzzdxhsRpJSxJlxFF8PFgA== X-Received: by 2002:a05:6a00:23d5:b0:7a2:7f45:5898 with SMTP id d2e1a72fcca58-7c41d71b660mr3815269b3a.3.1763664383889; Thu, 20 Nov 2025 10:46:23 -0800 (PST) Received: from ranegod-HP-ENVY-x360-Convertible-13-bd0xxx.. ([2409:40c0:5f:c291:79a8:a36:eba6:e322]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f095c237sm3562119b3a.45.2025.11.20.10.46.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 10:46:23 -0800 (PST) From: ssrane_b23@ee.vjti.ac.in X-Google-Original-From: ssranevjti@gmail.com To: slava@dubeyko.com, glaubitz@physik.fu-berlin.de, frank.li@vivo.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, david.hunter.linux@gmail.com, khalid@kernel.org, willy@infradead.org, Shaurya Rane , syzbot+905d785c4923bea2c1db@syzkaller.appspotmail.com Subject: [PATCH v2] hfsplus: fix uninit-value in hfsplus_cat_build_record Date: Fri, 21 Nov 2025 00:16:10 +0530 Message-Id: <20251120184610.28563-1-ssranevjti@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shaurya Rane The root cause is in hfsplus_cat_build_record(), which builds catalog entries using the union hfsplus_cat_entry. This union contains three members with significantly different sizes: struct hfsplus_cat_folder folder; (88 bytes) struct hfsplus_cat_file file; (248 bytes) struct hfsplus_cat_thread thread; (520 bytes) The function was only zeroing the specific member being used (folder or file), not the entire union. This left significant uninitialized data: For folders: 520 - 88 =3D 432 bytes uninitialized For files: 520 - 248 =3D 272 bytes uninitialized This uninitialized data was then written to disk via hfs_brec_insert(), read back through the loop device, and eventually copied to userspace via filemap_read(), resulting in a leak of kernel stack memory. Fix this by zeroing the entire union before initializing the specific member. This ensures no uninitialized bytes remain. Reported-by: syzbot+905d785c4923bea2c1db@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D905d785c4923bea2c1db Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Shaurya Rane --- Changes in v2: - Corrected format of Fixes tag=20 - Removed extra blank line before Signed-off-by fs/hfsplus/catalog.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/hfsplus/catalog.c b/fs/hfsplus/catalog.c index 02c1eee4a4b8..4d42e7139f3b 100644 --- a/fs/hfsplus/catalog.c +++ b/fs/hfsplus/catalog.c @@ -111,7 +111,8 @@ static int hfsplus_cat_build_record(hfsplus_cat_entry *= entry, struct hfsplus_cat_folder *folder; =20 folder =3D &entry->folder; - memset(folder, 0, sizeof(*folder)); + /* Zero the entire union to avoid leaking uninitialized data */ + memset(entry, 0, sizeof(*entry)); folder->type =3D cpu_to_be16(HFSPLUS_FOLDER); if (test_bit(HFSPLUS_SB_HFSX, &sbi->flags)) folder->flags |=3D cpu_to_be16(HFSPLUS_HAS_FOLDER_COUNT); @@ -130,7 +131,8 @@ static int hfsplus_cat_build_record(hfsplus_cat_entry *= entry, struct hfsplus_cat_file *file; =20 file =3D &entry->file; - memset(file, 0, sizeof(*file)); + /* Zero the entire union to avoid leaking uninitialized data */ + memset(entry, 0, sizeof(*entry)); file->type =3D cpu_to_be16(HFSPLUS_FILE); file->flags =3D cpu_to_be16(HFSPLUS_FILE_THREAD_EXISTS); file->id =3D cpu_to_be32(cnid); --=20 2.34.1