From nobody Tue Dec 2 01:51:16 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 488B618DF80 for ; Thu, 20 Nov 2025 16:13:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763655189; cv=none; b=GAIRfEOfIeuhq76mmhPICzc4p88r3WEsWWEtlZcRK9RfGoMg3wDxubjqb6LkQFeJgcddP3IVXOzNieNVbuij38fwp78hoeqZXgDNRb3Qd8OpCfGgL+O0W0UeyuOzvHNogVcRCyM8xDGjGHuWwbEEDgXIXjO6ChyQ2t8hApD/A4k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763655189; c=relaxed/simple; bh=sQ267wARUqddnqyPimuaqPdCIwHTbOBLDyP6nUn1yk4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZVzmKoFt7RVP6Wyp4LZMX1Seskwvy2ha4crGDUjtWX11Ustr6NnEXNIlAbUB0FJbcTaXGzx7plSVWmXb0OMnJjH4KWXHigBFVVyIOhJYRgkzKOER+V5s+Aqm8lpnztjFL2cjYnqy2GA/rXbkZ/QU+ejK22CiEvsOZaALLO2inDk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VhhQziU6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z08DH0jA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VhhQziU6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z08DH0jA" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AKC14ID3407874 for ; Thu, 20 Nov 2025 16:13:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=XbSptmgDmD9ndHXKCNaN1I+/PRPUWSex8jF bdSENe4s=; b=VhhQziU6Y77eDLrQpYbZ0cPV46sDG/nQL9NVb8NNLnlg+tl/bab g2J1cuhbeDiNY/CUOw2wuoZbM13xNb7Len7Q+PEyEU1Nj1VzlphZRYK93/vdcp4x k0L6KdzDnrooDnB8SZP+EoQjU9A7t6wlrFkb1X7ivvlfcgfSag02u75O/OIoG7o7 bGP6l2oQFkvQlcWwjdNw26faYVVdCa3vUcCcC/+lFW/6s2nF3MPt8vaTx0hkbATO GPYl5+hwGmqjKIXSKzyl9dpz986kL2aH2pjpl7sgb3fIrOJk6E6oG5PvlpOyL8dn sZYGs5EtEfXeBiU4JkjOHzWIHfojRkLuzBw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ahm813e5g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Nov 2025 16:13:07 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-298535ef0ccso11987125ad.3 for ; Thu, 20 Nov 2025 08:13:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763655186; x=1764259986; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XbSptmgDmD9ndHXKCNaN1I+/PRPUWSex8jFbdSENe4s=; b=Z08DH0jAt79DZ+sPRW0pp5XO/vrQar9Odd/AYjs/pn5VpC+4NTm460g5sY3cuzyd1q xbCwN3RZNDwd6Xk4UT/PhPKriRMadq/Q5XbS1TC40oHNnYYU65H7CXeMQ89OkyinXNN1 Oj7E77FUK5f3V945bcYvGQm7OLAlkQomSnKkik9Q20q6SiA19iKpDX6ZHEG1NKsB7RrQ 6LKrOWa7NgxSNlLDPgoHB+DeSPAOpCRTd8O6R98Oc9MCQcGnf9p1rjc3ezqgD2x5zmi7 qfpsdlawfGMczafW0uTcLNJ8FX2PX67Z6rIP7D8qdNkfq8/LdL7eUOC/MuHz924zqByF v6rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763655186; x=1764259986; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XbSptmgDmD9ndHXKCNaN1I+/PRPUWSex8jFbdSENe4s=; b=AnMqKNhvgb0a5hgtuL+LnVXepXvkEu9wpY1KgfEBImd6VvM0DqHxPmUzvvjZwZLSmn 0bz6exEmZMxP29m6+bE84cQRdwQEgzHRCypCahcc7UNsN2lsDIXfpfVFifOVSL3ZElyx TgDZQJqWCNR2vWBOtDhG9KLHqXNTD7/lZXNIzv9/npZPbTdkKhTCwOblYH26rm16bKkb zZPanwNa5KJJzuS2mLFuoy7By+KtmJjyiRO11ATNCDzGPknz0SgflijTi7UfC7WqB62f O/Kw7gyuKnEAivDXckEEKB9Td8BTsC+crAlR4jC1pmXUA5wi4ev4TfqIvCNn0Q5DyePj Hacw== X-Forwarded-Encrypted: i=1; AJvYcCXCSWXmEn4a8t/USosoXzygVjoCcbTLOpMUrHeTcjJ7H1N/uip56+BV/eRm54+miN4MmYZ9qKHU8IonVTI=@vger.kernel.org X-Gm-Message-State: AOJu0YxpHsI4HXlqVOA0M7wSIUgm0L/DY3Ilcuhf6G6plVotJWj2SP72 Ayn567zMmL0rtJ0qkTJJDAc2o/yahYzPB5BfUSyqpbtVOJ9v0m9sISDjQg6DbPB5UEHjirDSAPv iD4wmpMqWRBbyJ+HDGH7romwE3LO9Tx2QpAAznYcNQMKP7G0VtdHqx+ZcVwJZcNl7RXpp6ohjHq A= X-Gm-Gg: ASbGncufc3TK17ZtEW2xVhy9MQ/fkk0NsrQz2V5EkOpaekbypVoazYQ5LBQj4TPhXmB cuP508eONIn9oeQvQaZxZcANgbi18Ry1JQFTNAQxaBJW2UIMhdFj94II0Dk6c62IhmiojhVUVii QCw/9dhggzha2xy5awuJzmC+xgPaD2nG+k9vMHWJc8tmCLcG6AgueoxhKQXZ0Og9joSNoIDidxt s/X2xrI3kIGTSMEnT2UJXmZnmdhHsui2Cu/UmJyy0rNtKpR5/lSJKnXFmLecBS3LBcuKtpOB53/ NuTB3LcjUevKmbdda16wLwOgu9nVMUcX7UrRT5zSE+/c1Sx++WpjjKndh17vKod/eUCgVUDlrC0 = X-Received: by 2002:a17:903:1aad:b0:295:56da:62a4 with SMTP id d9443c01a7336-29b5b115d6amr44746115ad.45.1763655186187; Thu, 20 Nov 2025 08:13:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IHJ4ZNaz+21dC23fVjAQqwdsCDkRESBRnJDV8hjtYfF3+tWY/w1+LgeCNPsOpDHIXUZkyyeWA== X-Received: by 2002:a17:903:1aad:b0:295:56da:62a4 with SMTP id d9443c01a7336-29b5b115d6amr44745695ad.45.1763655185712; Thu, 20 Nov 2025 08:13:05 -0800 (PST) Received: from work.. ([117.193.198.182]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b2809b6sm31060135ad.76.2025.11.20.08.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 08:13:04 -0800 (PST) From: Manivannan Sadhasivam X-Google-Original-From: Manivannan Sadhasivam To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Konrad Dybcio Subject: [PATCH v2] PCI: Add quirk to disable ASPM L1 for Sandisk SN740 NVMe SSDs Date: Thu, 20 Nov 2025 21:42:53 +0530 Message-ID: <20251120161253.189580-1-mani@kernel.org> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: Dru1LZ4JjR--RRk9xSbpwXbXFx2i6P7F X-Proofpoint-GUID: Dru1LZ4JjR--RRk9xSbpwXbXFx2i6P7F X-Authority-Analysis: v=2.4 cv=SJ5PlevH c=1 sm=1 tr=0 ts=691f3e13 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=UMbGOA4G/0oMlBJKcU414A==:17 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=2IMlpjGaS-uQoPmQIEoA:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIwMDEwNyBTYWx0ZWRfX32XRa3XcrSPf 2eBAoUgBKRQ7Kz2l6xOJVS6j8o3DEsvYc3PaTIZpn5krxosRkJNCxI3TGZVO90QjTmxU+QHuNrJ 4P7H7QD/ZYqUmBR7A5K20PwYbXs4M5VLqJ4l5a0nTjulmRMKWAxGwoNYKNlquH81/n/njYYHk4N Y/SxpWuFpjf5KvYbQsSuGpYXgbXPsWItG/mMUwRDEFKPvXPgHL/3m4x/NIZcVEwxgFpYJTTbqOQ w/mXgziINOK6GESixrTMGdJ+uW6ddv1d4p8AwgvyzYfJFWjn+9oFxg6vjSV2ys/+fHxdPABkyyu 9Nj9xOyNgzH1PVeUtaD514OXABdaqlAdFAlYVVC/RX/+wCwR+98OtvI89WAdW53IUMIrg21loKr vqYC/Mxv6/F48xDPYD3lGM0hXeULXg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-20_06,2025-11-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 adultscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511200107 Content-Type: text/plain; charset="utf-8" The Sandisk SN740 NVMe SSDs cause below AER errors on the upstream Root Port of PCIe controller in Microsoft Surface Laptop 7, when ASPM L1 is enabled: pcieport 0006:00:00.0: AER: Correctable error message received from 0006:= 01:00.0 nvme 0006:01:00.0: PCIe Bus Error: severity=3DCorrectable, type=3DPhysica= l Layer, (Receiver ID) nvme 0006:01:00.0: device [15b7:5015] error status/mask=3D00000001/0000= e000 nvme 0006:01:00.0: [ 0] RxErr Hence, add a quirk to disable L1 by removing the ASPM_L1 CAP for this SSD. Reported-by: Konrad Dybcio Signed-off-by: Manivannan Sadhasivam Tested-by: Konrad Dybcio # X1E80100 Romulus --- Changes in v2: * Fixed the laptop name * Rebased on top of v6.18-rc6 for pcie_aspm_remove_cap() drivers/pci/quirks.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index b9c252aa6fe0..adc54533df7f 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -2527,6 +2527,17 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_FREESCALE, 0x= 0451, quirk_disable_aspm_l0s DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_PASEMI, 0xa002, quirk_disable_aspm_= l0s_l1); DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_HUAWEI, 0x1105, quirk_disable_aspm_= l0s_l1); =20 +static void quirk_disable_aspm_l1(struct pci_dev *dev) +{ + pcie_aspm_remove_cap(dev, PCI_EXP_LNKCAP_ASPM_L1); +} + +/* + * Sandisk SN740 NVMe SSDs cause AER timeout errors on the upstream PCIe R= oot + * Port when ASPM L1 is enabled. + */ +DECLARE_PCI_FIXUP_HEADER(0x15b7, 0x5015, quirk_disable_aspm_l1); + /* * Some Pericom PCIe-to-PCI bridges in reverse mode need the PCIe Retrain * Link bit cleared after starting the link retrain process to allow this --=20 2.48.1