From nobody Tue Dec 2 01:51:20 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 623FD2FF151 for ; Thu, 20 Nov 2025 15:46:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763653580; cv=none; b=c8fl1uJcqjbLs3jjW71eFr+fwHe5/uI+2i82udB4knI+LfhIUMuVb9dFV6qojvy/jI+a17cJHInbmnp5IcTSj169Y5bsEH6Ay4uXjx0hmscySLBTXVEro/QKXWBNzuCMRDxUZySs5AuEFpSbHpeSCeBFHiFr0lI4rm3tp0D40Wk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763653580; c=relaxed/simple; bh=DHkHcDpfFBr1qhVfsx+SKCEt4NV8Sh+Ih+xsw/yHQHQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=msy0t8FVmlLsmwPCDW6vN5GUSEVmtG2AFkNX3JFUyk013IkbEB0ZN+hZtH2UGJAEXCMfyJl0bagOAS4KChf9bELq44JsUvNKpjGeDCCDP5Gxvrj9zXWiPakv5M2+No7/uP892UgW3RxuhsiXXXuI3i9RDXDkL1eVMDP4wR/Q4Z8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mCVQr8ki; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FTA+S23T; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mCVQr8ki"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FTA+S23T" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AKCD8VK3543746 for ; Thu, 20 Nov 2025 15:46:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=3IfPR70dqtf7v8/t2p0F5dqViUagK7eelWP mfqM0ez8=; b=mCVQr8kiZ/atses/M91hPUXVRKPCk795UEFjfEiK4luheeSabqF lALfefDGqfquCKBnxhxhwpEpLWiqSBJ71rA/+pK9RPQC2SYHwtcHTPDPMzPgFMgc 6dEa0wjsVOm8r9Y3rhJT5Q69uKh3hcLhEQN/oGecSYawRoAKF+gdTErN9+3X+KYP HdE81ZWKwGEPE95DHs646a/6Jkpg9fsrYqocaLgbgq5EGz+j8DdmEPfDdRGzyA0G SchV99vOh72q+Agqc0Wj45xky/oidEGDFrdkaDp/Z6JeqBZuiDeY9yYlUjIDfeOQ TQSrGtvKXsXSeLMLLZGUipQ+FqfYW5SuE6g== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ahh8t3y8q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Nov 2025 15:46:17 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-340ad9349b3so2168233a91.1 for ; Thu, 20 Nov 2025 07:46:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763653576; x=1764258376; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3IfPR70dqtf7v8/t2p0F5dqViUagK7eelWPmfqM0ez8=; b=FTA+S23TFS7laZe4ay9Rro773vwDZNy/vs93lmyv0aT/0ryliyYIh9YgitBz0YT46P nJypV79IYLXreLBqNIOB6C7rTbeb0AeKlQlUOdkASB4s6IpLasG60aDjO9tat8pna+cS YLBOc4XbsV0wrw9llCs3Zd1LbKDGdLMPgcy+7xy8LFLWsquLjUkhM2ZZOFW9UcvS9CMv IzTcoHJqhJ7bAwJlNI9ujV5h0R9bmoa9Ea+o9aOVvLVXgUgn3RWiUKuJOtXdIDwupc2E 6wM8e0uNIygI+5OzWM8+fen2q3KGpmeqURqf3QG6TzAgaFY1rbXBtUm1tc6Nu7AUj5gk TmvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763653576; x=1764258376; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3IfPR70dqtf7v8/t2p0F5dqViUagK7eelWPmfqM0ez8=; b=PV0IutikzJzhjbXS4PzgjM35l2/b3HpQDQlNAfCkxK7N9tULEIPlYJUXdTP7i2Qn+u JPLaVemDK2Az1DG2yRPsYdYSH+KZQPyLk8sXXMmOKHXV6mkjD2n5fvBy2KhNCilE3x8J kTeYCsm7sB2PJZuPavKiM8+LKkHtndcwkmP5MNdrVdPwk+Bp5ADpHQGLU1UY0ii9gjpN AFUa8y7lrv71lNkshXdX9jIf0kcAzDK4zAPsxAhRHUUrKDzdx2ZP0KVMMSFuMJM3Ldw/ IfRQpBGJ05CwMDl/CU7baPxYtI7iDaMJrPxsZpe3Egyy29m1jS8ZYKYjVJXYAk8kVAzj qM9A== X-Forwarded-Encrypted: i=1; AJvYcCW8qBBrKRVnrq0WZpStRzkOkxpbVXk/ZJIQHIZpK1Gq6cSZYJpCBfEgwEJpXsUnJkKmWvgLfNP9L7utYdk=@vger.kernel.org X-Gm-Message-State: AOJu0YyAA7u3HHs3YCzFiiJs9wqP4BVqLAIEZG4wF5zDMR2L3HfgNcZa hE4jCa2XcMBZ1DGTUTe+2E21SoNQdYcEonZC3mgsNkwZqKUOw+IcWEIllXqH/BFbeL0lUBUDkxW i48QqdiM502zAOWnKEncfdRS804dAFv5F9mNutVoCXzPKc/DNsWavFpNsNDy9n1ZcJZ/xLVYPfc g= X-Gm-Gg: ASbGncvJqXQuTBUBl7wX/Scdm0tUbVdN35GAqcgMHe5t6evv1uY+2+cGZXXIZR57rc+ 11hb/0o4xsbhelVMV6KIcDWcUILQtVL/AcC6wxhznYz3kCIyvjEmm4KQSTD8pUJXysRvp5ZhSP8 hikftB2bc0CobtuXI1dGOtooB617OdYjgrKY3PqhQtI4zjy2LwuFtjw6B+rb++v9mpI1fOptTU2 ksxHNk0ACKgB5W5AzfNUhKGE8HXmE8JQ9gKjZtkcIPS9X6u3+MAk1FYfu3/fQMjiJJOrBLdNANC BtE8HsmyxU5jZEtQfJKqMPVSKJsXEu311LCR7JX7xY8kdst4QgcJMhWTxtdH+qKGd8z30h+/DHE = X-Received: by 2002:a05:6a20:7d9f:b0:358:dc7d:a2cc with SMTP id adf61e73a8af0-3613ca60193mr4176133637.17.1763653576439; Thu, 20 Nov 2025 07:46:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IF2Ojcmi6mZMJXTVeV2/Uxavpxw1QUt3or9RFWrZvT7ZI78gfu3KRgIKf2eN/pT8RWR86Jllw== X-Received: by 2002:a05:6a20:7d9f:b0:358:dc7d:a2cc with SMTP id adf61e73a8af0-3613ca60193mr4176093637.17.1763653575899; Thu, 20 Nov 2025 07:46:15 -0800 (PST) Received: from work.. ([117.193.198.182]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f0867558sm3196454b3a.46.2025.11.20.07.46.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 07:46:15 -0800 (PST) From: Manivannan Sadhasivam X-Google-Original-From: Manivannan Sadhasivam To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Konrad Dybcio Subject: [PATCH] PCI: Add quirk to disable ASPM L1 for Sandisk SN740 NVMe SSDs Date: Thu, 20 Nov 2025 21:16:01 +0530 Message-ID: <20251120154601.116806-1-mani@kernel.org> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=F59at6hN c=1 sm=1 tr=0 ts=691f37c9 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=UMbGOA4G/0oMlBJKcU414A==:17 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=tmzfovdghLGN2_Oi6P8A:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: yfYccwNdeLj-2SLmkyuS6cJO7NcDMP3t X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIwMDEwMyBTYWx0ZWRfX4LQoJSxlKAN1 Esw9BiDdYqoe86SHx02HPWNsUB7nCpXFoWsAOmCUVXqOjq3+pfxFc1wmjXgHmyLzRI6mESwZxjP ilH1RLXIXgbBc4YLOjVp+bfNBF2/mmhXSnaH2Xsg0EgShJyYAo0Eba0VM+UdMwuP4rHq5CHovTG GK0wxnODNo9YcKH27wA6ch7n8U2HqGXU9o+ukJGr9pgYf6qFYrbM67hNPDmY1HO2ZR7Z+fFgu4W 0tS7WJmmzMJWlTRjbfy1TTb4/3rxFbS8TEzulQsl4X2ooypyP6rpCULIxDO2lZPse237vKZ/yqL j6lC826tiKKgIbzN7cwSl+lskI34Tjmdd0Y1wst/1T9Csiav34WPnn7ylFuT5M73mecrAzofwjY V5TItA8PfC8De47k9174FM0+yK2jIA== X-Proofpoint-ORIG-GUID: yfYccwNdeLj-2SLmkyuS6cJO7NcDMP3t X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-20_06,2025-11-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 phishscore=0 spamscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511200103 Content-Type: text/plain; charset="utf-8" The Sandisk SN740 NVMe SSDs cause below AER errors on the upstream Root Port of PCIe controller in Lenovo Thinkpad T14s laptop when ASPM L1 is enabled: pcieport 0006:00:00.0: AER: Correctable error message received from 0006:= 01:00.0 nvme 0006:01:00.0: PCIe Bus Error: severity=3DCorrectable, type=3DPhysica= l Layer, (Receiver ID) nvme 0006:01:00.0: device [15b7:5015] error status/mask=3D00000001/0000= e000 nvme 0006:01:00.0: [ 0] RxErr Hence, add a quirk to disable L1 state for this SSD. Reported-by: Konrad Dybcio Signed-off-by: Manivannan Sadhasivam --- drivers/pci/quirks.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 214ed060ca1b..a6f88c5ba2f4 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -2525,6 +2525,18 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev= *dev) */ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, quirk_disable_aspm_= l0s_l1); =20 +static void quirk_disable_aspm_l1(struct pci_dev *dev) +{ + pci_info(dev, "Disabling ASPM L1\n"); + pci_disable_link_state(dev, PCIE_LINK_STATE_L1); +} + +/* + * Sandisk SN740 NVMe SSDs cause AER timeout errors on the upstream PCIe R= oot + * Port when ASPM L1 is enabled. + */ +DECLARE_PCI_FIXUP_FINAL(0x15b7, 0x5015, quirk_disable_aspm_l1); + /* * Some Pericom PCIe-to-PCI bridges in reverse mode need the PCIe Retrain * Link bit cleared after starting the link retrain process to allow this --=20 2.48.1