From nobody Tue Dec 2 01:51:36 2025 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A914E344050; Thu, 20 Nov 2025 13:44:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763646295; cv=fail; b=oWXS6ui5Lg2qOg4+hMsICOV+8hOMtyLQUVBLLrtses40/u6JaSlbRQoD/lSbtiBCa4JniITwxZ7hH1Y/eYoyuXx7JPqkmYFO7jhb74IHzdYuIzCjLcEyF/NVo5xQATauLG4Mj0SxR7EPG+OoTwStGcmfybJzai/QSVrf+WMH3oU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763646295; c=relaxed/simple; bh=Rc+/s6CFxw9Wjn6J0Wyxi834tMhhByNJ2JxV102kjy8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=A1N9sHrkm448/zNB04ftmNQ8m+8Js2LTmt4IO+P8rpYuFRQI5SgInjDO67OyUkwlp8sgB2fXk19Wdk6X5hyK36Dq0bSC1xs/saF6k6P6a3VG1Bq/UdnBqq19SwwOXeTNHBVE1nki2z/dyQ3r7ARvDtiInJ5U7wnLvqNhanKEYR4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=fB7IXoR2; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=yFxWhksc; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="fB7IXoR2"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="yFxWhksc" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AK4kGsR255784; Thu, 20 Nov 2025 07:44:50 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=AaJLJdKJfHJOO4MP61aLWPJJW+5zJVTBW+9qks8+3rg=; b= fB7IXoR291LKwzNpXD2apQYoIR3zhXR1p/oONv8AA2rH8geGJzDSzuMMSBBpoxKW G4sU4Ihyvt3eBH3OPU/YevBAFiZsgdWmtArTeqgr5Mpj1GuBJNzwWT+Dzvgx12bd mjOhuY0OGpk3nb0ZhVWK2L1ros/6vZr7y0dPGPAgu6iKJxvvoNJxhLa4eQ5uoUPD sGuhZsv2LCgCaU1P2yprY543Nn9ZwXGL9PmNQ57wyQwvoLoN9zAADbUAJ7bBYUDb wr9PIwjQoQ8CKXpp+MJMgCLckv19rm3pCUtRgaMQs2K6fL3q32pdIURtzBJWr8D1 FzBHA17+hzO+VSsI63twVg== Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11022121.outbound.protection.outlook.com [52.101.48.121]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4ah1bmaf4c-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 20 Nov 2025 07:44:50 -0600 (CST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LcnLkHT/GvzYjrvnKXZjGH61XD1ynx88kg5DkMfWha9Pr2R/m3xxjoPEQNLBKt5BGDJIIzP7H2nYTRBmBCL17GI4J5cai1fDiTBXqFK4t6+7xkHkTiluBvhM7drXPIkgQcy31nzI4flhqUuSd1Gb2vIu1W8UpBntkm5y0utjecnWT6h2pWDAhnA4HF9gyFcPKP+u007ka3bSxgaSIajI4t75hYtC3oVzr/KjV9VbfWTvC9MzPnE40Lk0kApe9npK/GYilXscmSaWE/cHIr93pJPoiHE+5TZsguaIaC6j2LKfWl8pXmSLvzirr+3vvTfX7+3kd9nhMm8abzIkCaJqGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AaJLJdKJfHJOO4MP61aLWPJJW+5zJVTBW+9qks8+3rg=; b=l+udwV3hfbQbFXs6VJVERrqIjeH4rMbhgICrlOX0CGtekQ1lZcVcMpU02JBSwxoomaMXgYDMzdHxMs7JuL8hl3G6VKzbYpujVSyp9x0YWdHQbxTbagFTAX/nnBayGu/EhI7/9Ng5J64uee35lsZPojpt6JGfZ9wsLc9BY3AYaY5yh+3WJS6cTbckk+uuq1OLLuXETkVZDbi21sWwColZKxXLv+08EAjFjtQnlyDeaSsEH3O8rrTLpUeQJlrk6Pb9mzq58A1UIoeYK6rI0v5gTTlo5JNFosN/fuj3dIxJKLXrbDmK31Mun5VJHtNMdP1lexIsk2kKTkFeIJLFJPRZTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AaJLJdKJfHJOO4MP61aLWPJJW+5zJVTBW+9qks8+3rg=; b=yFxWhksc3Jw8VO5gUyqs7ha96jA7dQa/AKKqxlv6BZL+FM5blzis6X55zIv2S4xOmPXbZGnpWrTke1m4fn5ju9AZ6d6354ie21vPXtvZQbQSR3vsSqZF7vm1B7iMIeHYVCFk/VulNAbLCUjnX2cUUyERmR6oE5i7V8TxBzmiIIA= Received: from SJ0PR03CA0164.namprd03.prod.outlook.com (2603:10b6:a03:338::19) by MN0PR19MB6142.namprd19.prod.outlook.com (2603:10b6:208:3ce::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.22; Thu, 20 Nov 2025 13:44:41 +0000 Received: from MWH0EPF000971E2.namprd02.prod.outlook.com (2603:10b6:a03:338:cafe::27) by SJ0PR03CA0164.outlook.office365.com (2603:10b6:a03:338::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Thu, 20 Nov 2025 13:44:38 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by MWH0EPF000971E2.mail.protection.outlook.com (10.167.243.69) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 13:44:39 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 8E34640654B; Thu, 20 Nov 2025 13:44:37 +0000 (UTC) Received: from ediswws06.ad.cirrus.com (ediswws06.ad.cirrus.com [198.90.208.24]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 7D6B782025A; Thu, 20 Nov 2025 13:44:37 +0000 (UTC) From: Richard Fitzgerald To: broonie@kernel.org Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 1/4] ASoC: soc.h: Add SOC_ENUM_EXT_ACC() to allow setting access flags Date: Thu, 20 Nov 2025 13:44:34 +0000 Message-ID: <20251120134437.1179191-2-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251120134437.1179191-1-rf@opensource.cirrus.com> References: <20251120134437.1179191-1-rf@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000971E2:EE_|MN0PR19MB6142:EE_ X-MS-Office365-Filtering-Correlation-Id: 24740472-f881-4e9c-7230-08de283af3bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|61400799027|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8Taw4d8+KZZq/HNNP82WZOW5QuloRoRLIARZvgIkECL6KumW51CZaRZZuiNe?= =?us-ascii?Q?wyw4PGSgnQfUetSOOXb2J2r/prsr3j/PHE72Fr3XyoZ9HmS53zs3bC4z4Ohe?= =?us-ascii?Q?l5rj7yawQyc4REU9ghaD61bslg2iEu0STeg6Hxd8n9I/YENDjQIaezEcZ3Zs?= =?us-ascii?Q?6Ik/q6E2Zoo6doD7nB3zHAhZ7/NDw004HCJ44c96wsIAE0+GEc+aqiEOvDX5?= =?us-ascii?Q?h2diHcyi5eHC3XUkbWrZV0GLiIdIQpp4ssc0tbncRnIuCyxXhSm2Wx6T6zDP?= =?us-ascii?Q?Mxp/Bgpnqrq6cyF2DhQcd/FH9EEZS4SI8YoyiOzXw4t/yrLx5OOnauGwLW2Q?= =?us-ascii?Q?+7dCIueu2Fj5IB0OzFzaUtWZ81OPJriyhkYR0/9vQUTvAQnSCWevAULc48xW?= =?us-ascii?Q?0YgYuixSZ9Vkzbvrrg2y8cIW5jZIMZGGx783Qv+7jc7hOSnvl4Pqbjn2RxpU?= =?us-ascii?Q?DILbTGgN8Sahd5S6gVGx1byifExlZJFPCHlj5XDyXSC1mEswQinoVxU9TNsd?= =?us-ascii?Q?FocJpKdvjZgSrUonv3nxg5FgVgKbmrGTOZsJCeyOfFDJi4guUUTB4evJ5Ojc?= =?us-ascii?Q?m+zP/wCzUILRCg/Sx+vmSiMz2NE3FWQSpRIV4awAlkOhXf+lGzXkbvnqFi6+?= =?us-ascii?Q?6TsnjFUbsakuFJQq4lUmM+RfzwZ/vzK4+2a6mKXkGCV44oHdQzn/F9V+/ZRH?= =?us-ascii?Q?OzL4hJxC8wzCna+wETB3sHSNa6+OmedY92HslakRWfXCTIiiZj7q84mVS689?= =?us-ascii?Q?+GtTXjNLot1VoAuAontaksZfA8GPszc3ngE1A/lGGT0k6ZRT4e2bebadXeRv?= =?us-ascii?Q?fmIhr3NPZvxR/+4udqzomQvPbrGaaQha7enI+PJghDobfqSvEdiXdAsSppsL?= =?us-ascii?Q?O1jQwlB8lhumqXCDzhi5xUZw8JqlEdEgLjN9qqVV/BZon+J5kSQtkP2m3LNi?= =?us-ascii?Q?ikQ/cIWv6CTQskHSxq3uDDBCZSbfVr7JoR0q/bz4r4f4BFqMhjXSi76QXVst?= =?us-ascii?Q?158zxs/3F9nreOXsWHthkSEeUzzzycxNENFVrgsHAkwZB5R3W7FUT8aqEsyA?= =?us-ascii?Q?5U6KWffRVUT9ZR1Gj0E2zZVbXUzZ8Ry8GvZSl68crU9WIY23ccZb0JKls1d9?= =?us-ascii?Q?i5liRJDhS/dchx+IuyYKp1yHJkCGqZBJFl8Vo3lC9a+I+qRtdVYi1UTP+jCM?= =?us-ascii?Q?oEgSrRPgGvveKoeqgCN5BAHlN+ZOhQBW2Fx7NEVInLHSVLEDxu665P5eYW61?= =?us-ascii?Q?pQWk8AUQTP5K8s4SnzoFftvxkCuJOw0FOhZozHdy5NMw+WoseY1cXeOTCxCC?= =?us-ascii?Q?sJQZ8yeD0QteXeSo8cLMqJYF2mafwMl+vM/reOUDMQZurjWsNGjjdhkhKp3i?= =?us-ascii?Q?n5fVh24ycRJQSU0ubBJpcvRS/Wvv8YY3+Xh+GtIzh0eNonDGZPLqsKz6Hvvp?= =?us-ascii?Q?1q8Q638pHqd4I+J1YMWD2QmhBqbsSz3iv5h1ePHkcgnsPTeHGE9kCOt30cVw?= =?us-ascii?Q?Gxovf8STqRp2xrGV3V2H6uP39352F9YRk6Jv51vdvBFXZYUPh143wkeSHYk5?= =?us-ascii?Q?6rVq1UzohPhitNeQuY0=3D?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(61400799027)(376014);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 13:44:39.2274 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24740472-f881-4e9c-7230-08de283af3bc X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-MWH0EPF000971E2.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR19MB6142 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIwMDA4OSBTYWx0ZWRfX5/rl6TWBogWP Ak22EZNq34b3K5GkwkWQKrpAwAc1Hv9rcemaAmnowgshQiRXI9afuPcwq3fczAh0nGzTjfm/WsF 4dMmgmJvNmmxbRKm47QaPmDgF09TVwB/JEHHyLhXY1Ikn5bBFT9f5k794d1Rv4MN8rJiMq906VC //KKDQQpYr03/UmLoZy5e58FT5Qk/FJ+h9QY/KI9BL1N033NAazqnfDg3JuPobNneMCnlVl9NOF Mu+0EhU5mfDTH9oq/ggA5bdzVo7IjG7z+4DI59EEkzLO//32qcQVbm4Gd4vlmG5idEO6JqFjeLk YPQqhd/N3jPXsOESDfzQvkYlaBw1UGvw0xQKeHqJ0IDlVkBF7GwMLNcCnOAxnqaXpHfcXqIyS/w CQh6TJ+BV7hMTCnzKJRuzf+ZAZEchQ== X-Authority-Analysis: v=2.4 cv=XcmEDY55 c=1 sm=1 tr=0 ts=691f1b52 cx=c_pps a=jtibSCz00SxEcFhpBRTXcg==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=6UeiqGixMTsA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=w1d2syhTAAAA:8 a=1CAcU0HOnAuBGusv8tIA:9 X-Proofpoint-GUID: 0i_V7-KIwiM_mRjDpnQDO8eEG9Q_v2SO X-Proofpoint-ORIG-GUID: 0i_V7-KIwiM_mRjDpnQDO8eEG9Q_v2SO X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Add a macro SOC_ENUM_EXT_ACC() to allow the access permission flags to be set. This is the same as SOC_ENUM_EXT() but with an extra argument for the access flags. This will be used by the cs35l56.c driver to create a read-only volatile enum. It's preferable to avoid custom control macros in codec drivers. Code maintenance is easier if all control macros are defined together in soc.h. This commit only creates this one macro that is actually going to be used. There's no point cluttering soc.h with unused macros - that just adds a maintenance burden. People can add equivalents for the other macros if they need them. Signed-off-by: Richard Fitzgerald --- include/sound/soc.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/sound/soc.h b/include/sound/soc.h index 37dc6f6fc63f..b1b6b6a497da 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -319,6 +319,13 @@ struct platform_device; #define SOC_VALUE_ENUM_EXT(xname, xenum, xhandler_get, xhandler_put) \ SOC_ENUM_EXT(xname, xenum, xhandler_get, xhandler_put) =20 +#define SOC_ENUM_EXT_ACC(xname, xenum, xhandler_get, xhandler_put, xaccess= ) \ +{ .iface =3D SNDRV_CTL_ELEM_IFACE_MIXER, .name =3D xname, \ + .access =3D xaccess, \ + .info =3D snd_soc_info_enum_double, \ + .get =3D xhandler_get, .put =3D xhandler_put, \ + .private_value =3D (unsigned long)&xenum } + #define SND_SOC_BYTES(xname, xbase, xregs) \ { .iface =3D SNDRV_CTL_ELEM_IFACE_MIXER, .name =3D xname, \ .info =3D snd_soc_bytes_info, .get =3D snd_soc_bytes_get, \ --=20 2.47.3 From nobody Tue Dec 2 01:51:36 2025 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97A30341061; Thu, 20 Nov 2025 13:44:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763646287; cv=fail; b=lThQJPm1cF68JVIeewl987c2afJB0TAf8TIk7BO4CfSNd90CcRKO9TZO3ep59pn7tqK9dJIxcY7vSwdhwu7V2IoynYgezKEdY04ErIV6GSWnVI9h+VUIntku4u+mQiEGuie0eIy5sDkROrjbQjzQwp9MIfjOclyJzx7BechIKdw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763646287; c=relaxed/simple; bh=hdOpCkGzmp6pOwm/ziw0nuyj5Jtt7QdQSaOkevLayPQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MsqKb7NfCwT9EbyvZfLQPZSyGcHDPa0hSC2M2JMmogYuNd2nWCQpEFBxHJ097RzD4o1lpRDHRC3c8oOsd8jIOQvYkbXd+mIOd9zlC1b0xmWgARy3CO564X3ruTUt3TEgAPKAKwa4Ox0Zr2YU8LVeD0wZ8AK7EwAVqz8LsAV9oB8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=Si8hMGO8; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=RoQTzIYg; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="Si8hMGO8"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="RoQTzIYg" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AK3soDC262792; Thu, 20 Nov 2025 07:44:43 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=/sotpVrywc4pCQVg9bkQjwPiX8nXUhLIt0Yb9Dfm6sc=; b= Si8hMGO8csDPplasDc4HU+hyjrnZETAjI5Du2B4qaVG2iR1KZD7JUmqjnyZtARxP jBkMOHBmUTXMhO2vWwA7YeEnqPVnFwU7jYgg4IKlLnaU5e5Aj0MHK8yj5iG8VCQ8 KzHa7xCb4XievMRmGain7jfg52+jn+s6phrHknsmEaklGJO4iQvmPKvxBKNKFya4 UbLxpkn1WpvlLd5EWkYdhR2CMqRhZGqKMKzUmLfot+PVS/qL4kmEGkT0GyAiwrVM yK4CEAaxvQ+RzTZE0sWUPgKzwLm/IHi2xel4lL/mhV5LueFNrzUmjS0+tPBryMqD 6Zi067yznMn4Eehnjyw2nA== Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11022111.outbound.protection.outlook.com [40.107.209.111]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4aeqt1eg5d-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 20 Nov 2025 07:44:43 -0600 (CST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OqPXHyWurcGXO5k/3tb+YPAYkkx91iimExr/9cJ4s5buymQ9dxenB5ZM/+F7YXprPGRzMbNV6Uzvsijfjygg8f1CAtVEJaHkigz6dEcLJSVvdRbNMWIFGgXjtdyNk9tfYPu5qtoM9vLU69kL5ofRPJmjNpfFEwpGGwj5y3jxbab58+wBTWtIPAYmxHWP9lVKMpL0myGVseYW6gECAWessmRcquDHo3GVtHf6vtv+CCGW9rR31dr6P9kt3YkzOAwB7QqExIhDr9KBK82gavthXPzKCgw6QQVhOWHO6xTaVfnzVPFZVV0oa+cTn4rtyqQpYAaK0qgWwDyPizegA4Ge2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/sotpVrywc4pCQVg9bkQjwPiX8nXUhLIt0Yb9Dfm6sc=; b=lU534nbgGP2lFJN0KvJXFcy2TNreLCkXDBRmnjPfQlaWsTCRxbdzaNe1JuN3Vv1R1ikt61OIiCgECEvOhEm7aRoQDtqp1rGCFdsffuyFfZBL/eiyRvl1TXkb7zGeefRmy2Si3OmX1orLrMpHRNRqU3dPQ2Ih6vS8z3HSj/d2Jejbh4eOHoImYkl7b4Jff/tnlbaByRFix0aoCLiuveZN16xJuKKUW+wKygYYLt7SxOuk4erTZ8JbIB+r6Rtl8X03YDSn38ZvqN01gO7Zhm8zWmoACPGb5O2Srxud8i4u39fH9kML6yHEkdokkYLAy10bT86NKW6enamrkEVhRUteeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/sotpVrywc4pCQVg9bkQjwPiX8nXUhLIt0Yb9Dfm6sc=; b=RoQTzIYgDMLthokK7XBJ4SQwO7aNDrzHND0UVMLGWXoWHPhdbXr/GQ261PkS8Pgkgv99VKe981kyrMa6PRNxE+LJHph9KhaLa26oPgbSjRo5Zh579WlguOxZ0RpFnteVTSnhL7d/B5/ZSVzYjAZ+e1oy9ePR0YVNPQXgitEYY6k= Received: from BN0PR10CA0023.namprd10.prod.outlook.com (2603:10b6:408:143::20) by LV3PR19MB8420.namprd19.prod.outlook.com (2603:10b6:408:20f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Thu, 20 Nov 2025 13:44:39 +0000 Received: from BL6PEPF0001AB4A.namprd04.prod.outlook.com (2603:10b6:408:143:cafe::24) by BN0PR10CA0023.outlook.office365.com (2603:10b6:408:143::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Thu, 20 Nov 2025 13:44:35 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BL6PEPF0001AB4A.mail.protection.outlook.com (10.167.242.68) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 13:44:38 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 9714A406552; Thu, 20 Nov 2025 13:44:37 +0000 (UTC) Received: from ediswws06.ad.cirrus.com (ediswws06.ad.cirrus.com [198.90.208.24]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 8AF48820247; Thu, 20 Nov 2025 13:44:37 +0000 (UTC) From: Richard Fitzgerald To: broonie@kernel.org Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 2/4] ASoC: soc.h: Add SND_SOC_BYTES_E_ACC() to allow setting access flags Date: Thu, 20 Nov 2025 13:44:35 +0000 Message-ID: <20251120134437.1179191-3-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251120134437.1179191-1-rf@opensource.cirrus.com> References: <20251120134437.1179191-1-rf@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB4A:EE_|LV3PR19MB8420:EE_ X-MS-Office365-Filtering-Correlation-Id: 65cff45c-c325-4a7c-53db-08de283af360 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|61400799027|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+B4LKTAwhXwIZ2x7sdC2M/F7bS8LBogYfmu9l9wXgd3JvuK7H1OYXSHSz7dJ?= =?us-ascii?Q?oQ2qX+vXu6PPKN5VgLu+kfAmATeokl6/W8bz5Vs2tAghWah7l4APVKbGqXgI?= =?us-ascii?Q?gHDxNVviIfeJwAC9siOOFVYc3GSOf0p5xnhVpmfNoZEl5GciHg1J7WQa3xBA?= =?us-ascii?Q?D/p9fViVrudoeluo0gfLaJjfRT5wByhEYD40wzJyupboDXM089GElQc9CYfe?= =?us-ascii?Q?Dn8O7u0n/eSTYkSVxKI0FJys02eV1dm2tSgh/cDkZbv2RnxwEprv8FbEOrqU?= =?us-ascii?Q?SgnqrplDuZsSVl+B2BEuO8iuZVitA08kjEQ51GBPkQXg0yTfTllE9RI4IOXw?= =?us-ascii?Q?P7Lxfm7eZiear6LRWL1Q6ndWz8DJTriZ3wSR5CKpudi1azT2l7tn6g5qgv/C?= =?us-ascii?Q?a/nbAlVd6/3lPag1iAO/vUHRLtrATz0E4LAjlwBP5aDbjBAxBztoSr3BAEdA?= =?us-ascii?Q?3XPDJ0SFA71J+IFQ/+ON0L3vBqgURUvpWFUJ42nxncAUMc+IU6rKf3kNjE74?= =?us-ascii?Q?Q+K/wom/hbaeEBtVONTAkRa7ZQGpCjUsiJo8Hj1+f8uURWdWkKxgaIKpOxob?= =?us-ascii?Q?T0mYUI+vBb/L/V5skxYxbJZTXBkWaNd4BwUkk/Bu3NmyWQUvtzdgQWl5Vw53?= =?us-ascii?Q?v9Aqc/CwMLuiZTs6yDYijNvFz8yiRgxbV+JwFolydGlJ29Rrk3VURJHDzzd+?= =?us-ascii?Q?nEmfjsJXNDqRjx6MgKNN7DbtCm354eIAlKd9jMQ9v8tXmErm1XhV2km/mrxf?= =?us-ascii?Q?oYtB3XYV0AolVBlOxjM+YvuO2GwESzg98Kj518FhhpdTw3maEgcE7K7j3Kzn?= =?us-ascii?Q?ANPrmmmTvzXlAQaoIiNsjnjjwCb0C6/46iu7PDIPg+qDMJGrrahTpJ/mvb4J?= =?us-ascii?Q?tfgMKfYpEO/2JDWyW3dVtJJ+K62kEn/hByf5CXV5+TAxp0u1hMJAiyiB0E9P?= =?us-ascii?Q?vwclT1DkXTngxIHQoZWXAsN4dsttuBK9aTicnWubTJ20kokeCsSFMZnyTbs9?= =?us-ascii?Q?9h2cxpC/7bNwTqNwnpGUGfk8VFhE5FeidrU60qhRygOGHXZAv2O58pM0ggCE?= =?us-ascii?Q?4TUFVx3vcYYFrPYirkyct8tH1ettxThUdkxr7LroVxoh/wBGuqo9scHDPkhe?= =?us-ascii?Q?XRrv5ZCd/G8JloYzelLUslZ1+lkd1b7E8NdueflOBzC02oLsxY6bz7w9sVH5?= =?us-ascii?Q?vlE1cWvKgAYPmeGvpMzpY82bAEpZp+MdlM3LDbJMkCNoP+xPgIFPTV1IvWDN?= =?us-ascii?Q?Hn3B5O3ZzZHF0eAmkkxLVuC6BMEMFDMQzX4UiCXCyd0Csdh1NBuOsDXxwozW?= =?us-ascii?Q?yrwIkAlRuEsF4MseVqugeY1TKHcWJhXCx2gzixkolGmQ+BWSYyCfHPQ+augt?= =?us-ascii?Q?Aro6l+NrYsuytx9KP6R/PbI/3PzIkjzqTIxTXLZEFMu/JwU3p3f4qDiztp0e?= =?us-ascii?Q?a2v8Ijdr5ydeutUqReH48Zf3dl+BH3UaGyoCs410nj/+f/15IfcCRwyj9QUG?= =?us-ascii?Q?B/3tl4CcxOIlrlMQJSCRsBjWs6jUdS/fZqpcuWPeesYfV7iJUbNsJHfVtdBL?= =?us-ascii?Q?LRrSHNMvxbw3A8KfTiA=3D?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(61400799027)(82310400026);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 13:44:38.7460 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 65cff45c-c325-4a7c-53db-08de283af360 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BL6PEPF0001AB4A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR19MB8420 X-Authority-Analysis: v=2.4 cv=OOEqHCaB c=1 sm=1 tr=0 ts=691f1b4b cx=c_pps a=J7ZdHMUHR0uI/sEcOv84ig==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=6UeiqGixMTsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=w1d2syhTAAAA:8 a=1CAcU0HOnAuBGusv8tIA:9 X-Proofpoint-GUID: SxIZgtGR7v0iRIIQxHeX__KeRR6gZC7J X-Proofpoint-ORIG-GUID: SxIZgtGR7v0iRIIQxHeX__KeRR6gZC7J X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIwMDA4OCBTYWx0ZWRfX3kLugr7cX0Q9 qZUBQqtJg8O0zjh6CtCTEz4rkfUOlgJ71gJNDtZ6Ro0thptaqWrOeViSA5pqTqOUaPCnYxJkkbo uf0or63AxaiuzYkWzzWB3B26nRgG7UzOclm2FfVLONgrebm4QdLHMFbAVE9JNhBFc8aXN4GvA0e 5o8fqZwoGyUYV0G4ZAk/lzbDy2f7rdu2Pqv4KNh5yRL7/1P98XI+Ug9CA95z/S8tI76t/A+5HRn o8v4nDy4a9xlyEgUtrUSpDkfNqG5koLFbN7FsmKHjxn4Omj08yzAcqYJPZXidf7xVqwYN0Z3MUw t28OLvM1OBOzn4wmtBer4j1xsejpiHUuvPZ888ahJWhhXf4Bx8t2Ojwf+kG1RcMVEGLUHuvWJpB knVnOUrQvtVoAw88hr0O7O9ZDKbFQA== X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Add a macro SND_SOC_BYTES_E_ACC() to allow the access permission flags to be set. This is the same as SND_SOC_BYTES_E() but with an extra argument for the access flags. This will be used by the cs35l56.c driver to create a read-only volatile byte control. It's preferable to avoid custom control macros in codec drivers. Code maintenance is easier if all control macros are defined together in soc.h. This commit only creates this one macro that is actually going to be used. There's no point cluttering soc.h with unused macros - that just adds a maintenance burden. People can add equivalents for the other macros if they need them. Signed-off-by: Richard Fitzgerald --- include/sound/soc.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/sound/soc.h b/include/sound/soc.h index b1b6b6a497da..aa0fe6b80293 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -338,6 +338,13 @@ struct platform_device; .put =3D xhandler_put, .private_value =3D \ ((unsigned long)&(struct soc_bytes) \ {.base =3D xbase, .num_regs =3D xregs }) } +#define SND_SOC_BYTES_E_ACC(xname, xbase, xregs, xhandler_get, xhandler_pu= t, xaccess) \ +{ .iface =3D SNDRV_CTL_ELEM_IFACE_MIXER, .name =3D xname, \ + .access =3D xaccess, \ + .info =3D snd_soc_bytes_info, .get =3D xhandler_get, \ + .put =3D xhandler_put, .private_value =3D \ + ((unsigned long)&(struct soc_bytes) \ + {.base =3D xbase, .num_regs =3D xregs }) } =20 #define SND_SOC_BYTES_MASK(xname, xbase, xregs, xmask) \ { .iface =3D SNDRV_CTL_ELEM_IFACE_MIXER, .name =3D xname, \ --=20 2.47.3 From nobody Tue Dec 2 01:51:36 2025 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 979AC33A003; Thu, 20 Nov 2025 13:44:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763646288; cv=fail; b=g4QnmDQGExh0n/uzogXHIsowLWVsZXKOeB6veC6rp1451DFpeoZIjPzoeZGTP4IBoTfc9sHGGNpti7XiOiChpElh69JVWBDwqNmcNtlWXbLzuTY5YFxDcf5xqvp2Vn6KAxYikZ++NofA9km5I0loXC+OBIQIDldlu5mgfBCa8Do= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763646288; c=relaxed/simple; bh=ptRMx/I10pc6A6Ms9gIv9flDyHtwOMmBLfUT0IqJL6A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uHSD5366o8VCRHFg94QTjI/R3FXQW0HGQJYOvVvgFAi4N3ALPbjxgHB0J9bRoQ21Sz7t3eUOJxGwFfRvBul1oiWOnqztP5g9eP9rFUcZx1oxxR8mLPV6iI2Iz3C1BOGsXkPIcBRNUAcjh/BOPXn2Ts8i19aB8seOnXpNGu3i5Ps= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=YwwOyqmu; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=KPLW6v0J; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="YwwOyqmu"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="KPLW6v0J" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AK609YW460858; Thu, 20 Nov 2025 07:44:43 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=zh4gkiMCArJ9SB7Tm0hC8HkyXtkuVnNxaERfq2L78Mc=; b= YwwOyqmueXglDjKPN4fQpws+P2ma+zdtQQUPzBqn4UwX6pQqhV99EvrO7gR4c2xF mP+DNgkzzp1jGu0/tD6jaKhoOjf87fZ8LHviQS0G5YQ6rnV85seWghqwvliASLlX YeVUW+1mIcqDDwZDSHtrNL3kdgE1TdHBVPwd86Tnu7wTbpqlFtGy4wvCHWJwpKPk Nn41HVM/VcLFTR7K8nJvy6s9zA7SJC4d2NCNqamDfB5wt0UZ7sHYUK4ALoMGR//s +2l54uiv0eH8j26PYlv30N+rFox/1bbhHjObu2kqvlpM2STGg/iSCkx1jy6OFaOZ 1SqGsdlXj4JlLbYHFmT7lw== Received: from ph7pr06cu001.outbound.protection.outlook.com (mail-westus3azon11020087.outbound.protection.outlook.com [52.101.201.87]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4aeqt1eg5e-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 20 Nov 2025 07:44:43 -0600 (CST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=l4VsMapZBLYiu74qGvG1crUwqrHZQee6laBRDPPYNWWEOAGrLnJCtZpMaw6nFdM9dQN4yMK19A/DxRCf35TtUgeYbAY2LU2bDcP9gLO/oXAgWbFi7l1qPDCV04dly6N+NMl54PXsCDf0zUtIPKKllf1GsoLKBtTQqkjFS01Z4Sp4xorbcjkCbyqf8ibima9vhqBrdNBXWdOGuLz4jVD2SbomZ0HMHAkk9wkjesg1Jp3l7T2nusJ0Lk7+JosFWNQHqOv+K+VKMvDgmhdqxeiuCyEg5y7gWpxlbMlsi4QS9mSfbpLd9Lc2Z4DVqjvuKlROJMTJVeh9mzq6VIU6/wqsug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zh4gkiMCArJ9SB7Tm0hC8HkyXtkuVnNxaERfq2L78Mc=; b=AIaIoawrj4nzVfpKqvTLeU3KrZgJhcDj0QsLqPUvC8kY6280V3rAl+2sL/tm3OXd09WE64FnvZcMY9VmueOSRPBP9J/C/BlJl60pS1KHNvS2tWXx6LJjPWzv8/pyZOyzszTKnf9/rAKKxfXMCUh6XTxYFkwyfJWBDc+QmGYJKEc4XagwpdKUXDafBcmuINw9Dv13JPp/WrqL/bb4rHmvP3tzoo6qd9CKgWu3zcWdv4T+UTg7HyePjElBmWhlBFF+YgvqoOMwxmnnXx8xs9AaujV6EItMgHsYSuMtJuq/V4nuhsiTYGAAb2kXLPG400QQPVIwJlvTj6qYuMfQNTKsNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zh4gkiMCArJ9SB7Tm0hC8HkyXtkuVnNxaERfq2L78Mc=; b=KPLW6v0JYbHMlGLXrQPS+3FZKrw3cRBtPUYxyYCt9lOEk6edHS3nYg18hzlVq9jGkKopLWNWeibcV2PHcbZPMRMNcgYDDEzfXLdJBo4NmMuBMf762qFq41Pd7to9IjKZHGXvjHpvlfazbwHYCBRP/Pm6bDraY9/Sg/drYadTaFU= Received: from SJ0PR03CA0175.namprd03.prod.outlook.com (2603:10b6:a03:338::30) by SJ2PR19MB7529.namprd19.prod.outlook.com (2603:10b6:a03:4cc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.17; Thu, 20 Nov 2025 13:44:40 +0000 Received: from MWH0EPF000971E2.namprd02.prod.outlook.com (2603:10b6:a03:338:cafe::a7) by SJ0PR03CA0175.outlook.office365.com (2603:10b6:a03:338::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Thu, 20 Nov 2025 13:44:38 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by MWH0EPF000971E2.mail.protection.outlook.com (10.167.243.69) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 13:44:39 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id AD34E406555; Thu, 20 Nov 2025 13:44:37 +0000 (UTC) Received: from ediswws06.ad.cirrus.com (ediswws06.ad.cirrus.com [198.90.208.24]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 8E92582026B; Thu, 20 Nov 2025 13:44:37 +0000 (UTC) From: Richard Fitzgerald To: broonie@kernel.org Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 3/4] ASoC: cs35l56: Use SOC_ENUM_EXT_ACC() for CAL_SET_STATUS control Date: Thu, 20 Nov 2025 13:44:36 +0000 Message-ID: <20251120134437.1179191-4-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251120134437.1179191-1-rf@opensource.cirrus.com> References: <20251120134437.1179191-1-rf@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000971E2:EE_|SJ2PR19MB7529:EE_ X-MS-Office365-Filtering-Correlation-Id: 16bacaa5-27c2-4a29-44b3-08de283af3c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aXFPoGCvXP/0NsuQlVkTUGrxDuTgNUjayc/ppjT8oKE0kYiFofUm33Sh+H9d?= =?us-ascii?Q?6F4WnROTixmNm+fw6RoQbqE4WAtnlQUi8aFkbXGtdKsJE+2hfZMsHkaZOaE8?= =?us-ascii?Q?JreC0XIwzH2IrwG0bAQ4gEEIJXm9PFTLPXZpiWka5FeU3ylLCKaTyDq3jzex?= =?us-ascii?Q?QWz/Nz5i0YA+HG2+/kmMmyQoD7uYVdc13kmIRq5QsAaTLfERdQR6INgLP82U?= =?us-ascii?Q?YccjWEwqrePKwSHb1Qs0DxM7Iz/WTNdbnos4fITwZwlTMOCx+pkcuYQCbIwL?= =?us-ascii?Q?d3E0hz0QpDqqvP6fru7EnCUKCzCg5EMKaCV4jOjiz8SHwznTG5fXNVLSAFr6?= =?us-ascii?Q?MxQN/Nhy2iqlOOVrGeUG6jPYQEB6xCx0FZkNbV5e8ucXVHlOnCyI63tOzX24?= =?us-ascii?Q?SZBixDhsZxA6RDNrIrc1RFI03UuSd3VDyNQsMM+BP1LYcHiM5p7yHElcGU86?= =?us-ascii?Q?Cf16rL6SlqOIA7nY09QEDEdwwFnqkslHF9EHoDtdTJB225RjyvUmXTUbDUdW?= =?us-ascii?Q?HNxxmP6yRCcrsk51yr4m2Biy8HdGQE2ZF4Wywufj8X2hfZ7+RurJJFzg8Ay6?= =?us-ascii?Q?60Cw1e4lYI9XOG2Nwrca1HLPkM+6UkbpKZ/omRq+yD9lUuX5p0ST+X78OvM9?= =?us-ascii?Q?0M8YjHCToLKfwFENXh8dc0DdR/CeYR1RH1M+jXObBUQvf8VuYoQKiiPYscfX?= =?us-ascii?Q?PtmDvo+J/v1w1f3APPSA+iSO5xcFgHUox13xGt0umfnHM5MEES69+C+Y13mf?= =?us-ascii?Q?4dC7iqlh6JthPxthg3Jl+E8IMoaGEcz+8bFVkqSSrd61r/McdKA9MoBggTVF?= =?us-ascii?Q?t+R7oUclZKpBzbngIcbL42oomo31cF1aT9UZPNv3FqEzSdDIIcdJh1z7yrQm?= =?us-ascii?Q?1OTM+cwOCLzO3w/YwheP/bx0DEiDx1A5vZK/HZ6vFzcSuTp1hDK031VgFCxR?= =?us-ascii?Q?Y6ilGo511ImEsMI1CYYWLEiFTVoR8SoPkNcdbs70lel9iIbLJUIgevTi+uRM?= =?us-ascii?Q?lJqVL8FJrBHnY5vnIrGC7qNQBz/bmeXok/84VG3Ui5Nlt9drR7pXUsuUoZAE?= =?us-ascii?Q?PYnvKg3vT22rajzfsaMrPSCQPXPXqXSyK1UCNeY90B9TVyxeQ/RTameHZFMm?= =?us-ascii?Q?JlTiNTJIZBwmE4NSvU6M23Qd8BwVmv3tBTIjXXlFV40K01UzdwQP8zFFE4gD?= =?us-ascii?Q?7x7ASYilCiVM5nqS5BlimA+y9t5KLGntbk09c9siqgosPpUqKGHWRCl3Se8l?= =?us-ascii?Q?0F+2qe8eCfBAkoyfasI/be4+YgcFUJtEQhgziH+jgmI6n96hFpHNGtOLSsfc?= =?us-ascii?Q?TgZB4cdBEQsjco6drypnhFtf5cTdwGxizF2SSXMNaTwefzuFrTCnke2NAK5S?= =?us-ascii?Q?SnBHETVLSlGBTJjUSD7vxrB0Gr6XJ9EjtomqMt2S+e/f4BCviriea6iJCZr8?= =?us-ascii?Q?los5XCVrYXg2XGiIJLkaG+xlm+w2Tqo6pCG3Chw322A5U8fhvUo0H1VXnr1M?= =?us-ascii?Q?RudEEFvfxlPwyPPeOAWSRK3yPoB0xXomHdcZvl+M0fqT6ff30J4u9ixTcUBz?= =?us-ascii?Q?dLOf0er6LLo/9Il/HzQ=3D?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(61400799027)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 13:44:39.2852 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16bacaa5-27c2-4a29-44b3-08de283af3c5 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-MWH0EPF000971E2.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR19MB7529 X-Authority-Analysis: v=2.4 cv=OOEqHCaB c=1 sm=1 tr=0 ts=691f1b4b cx=c_pps a=M3VJd0sitle1370pw5NXFA==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=6UeiqGixMTsA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=w1d2syhTAAAA:8 a=8K60sZ1CEUfmsYt1aJoA:9 X-Proofpoint-GUID: 2xMDdUI1HiDid8MMcYUa-W96ed_9IPu9 X-Proofpoint-ORIG-GUID: 2xMDdUI1HiDid8MMcYUa-W96ed_9IPu9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIwMDA4OCBTYWx0ZWRfX2gJIzRMQ88fJ MDkLIy1r8I0NJAZ4c0ncmCF8/dObI8FJLmAeDPJSlZ5pCQswW0f0PLCAx0FYLiWk77Y/Tb1DepX lUoCkoOGiCUHc7K7WADEfQv+hY2V04c0MU7gGWXQlioXrEu8qx/Rl/uIgvPuxGX9z+MtcVtn8aq X85/5skoIE4dsRmhyTTTykmIe7GcQw+9WGnLnHIR6O22mwJlqnq6ppG6OGPNkol3LuYkcb9uuyr wOvKph1FxWaQP0yuYtcpfLNCx5Mw7D+hNgY5vZasEuUEKx6ByJSE4nkSo6J/5YoZ9LUpTaiHBZa 0neUr0N3y1RG19OGvqHbn9iAP2OnSdg9S37xmTdgNN5MS6DL+FvbUX0WOGk+Ilj+UaKMz4ArPrH ZXmkQvRZxkBNipZJfKofjEDIjG39hQ== X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Use the new SOC_ENUM_EXT_ACC() macro instead of SOC_ENUM_EXT() to define the CAL_SET_STATUS control, so that it is marked as read-only and volatile. This avoids userland code expecting to be able to write to it and then getting an unexpected EPERM error, or assuming that its value can never change. Signed-off-by: Richard Fitzgerald --- sound/soc/codecs/cs35l56.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c index 802658720510..f5fd20c8cce1 100644 --- a/sound/soc/codecs/cs35l56.c +++ b/sound/soc/codecs/cs35l56.c @@ -95,8 +95,9 @@ static const struct snd_kcontrol_new cs35l56_controls[] = =3D { SOC_SINGLE_EXT("Posture Number", CS35L56_MAIN_POSTURE_NUMBER, 0, 255, 0, cs35l56_dspwait_get_volsw, cs35l56_dspwait_put_volsw), - SOC_ENUM_EXT("CAL_SET_STATUS", cs35l56_cal_set_status_enum, - cs35l56_cal_set_status_ctl_get, NULL), + SOC_ENUM_EXT_ACC("CAL_SET_STATUS", cs35l56_cal_set_status_enum, + cs35l56_cal_set_status_ctl_get, NULL, + SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE), }; =20 static const struct snd_kcontrol_new cs35l63_controls[] =3D { @@ -116,8 +117,9 @@ static const struct snd_kcontrol_new cs35l63_controls[]= =3D { SOC_SINGLE_EXT("Posture Number", CS35L63_MAIN_POSTURE_NUMBER, 0, 255, 0, cs35l56_dspwait_get_volsw, cs35l56_dspwait_put_volsw), - SOC_ENUM_EXT("CAL_SET_STATUS", cs35l56_cal_set_status_enum, - cs35l56_cal_set_status_ctl_get, NULL), + SOC_ENUM_EXT_ACC("CAL_SET_STATUS", cs35l56_cal_set_status_enum, + cs35l56_cal_set_status_ctl_get, NULL, + SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE), }; =20 static SOC_VALUE_ENUM_SINGLE_DECL(cs35l56_asp1tx1_enum, --=20 2.47.3 From nobody Tue Dec 2 01:51:36 2025 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A37E342CA5; Thu, 20 Nov 2025 13:44:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763646291; cv=fail; b=Vq7qeLHlgiU34zDcdbqGpYmEfC5eepkjpT7AX6og2ckezbgaVHu7KQBtK02Gy1o2vvYeu6+4TismQap+m0EvR9FcHvY42rSGjtBthCmcV3FeKm3Uv/6LHgXF+YrEFFppGw+v1LgFuCjUQDFMdpxryoMT82i+cln+RBGXWoKsYtk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763646291; c=relaxed/simple; bh=wJGApETpNrSiJl71v0/ce1fJq4DDayZu0Uu46pvocco=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=N4zFobvgT/s62cxt15xT2s+eKnjJp4hkKEHtX/NXd9Li9LVxlleW3mUB7pIyPoutam214dDU/hdxBZzdGAaYZd3VmDsSDOM0xXRrUa0De6bUJKKKdDmSd1Tmgca182L0NYadC4pdUqX5n72crIlblR039+kXlLpzhqHdqD9nYvs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=YTJLLI4R; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=UjhkMg7F; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="YTJLLI4R"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="UjhkMg7F" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AKCpaS81058789; Thu, 20 Nov 2025 07:44:45 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=cJV+HjH7Z8YaqOpPAlwGOe7qmvncEKh/zeIFNWGdhn0=; b= YTJLLI4R5vbLjUzEIZK+WQVDgQU0L/umFui8+T7NUzh58ntwvo97gMPRuhmcaBsP pvxpmx3fNwcr+oeZZn72a3hVxB408ExFKTf2TGOJrW2L1SxEXRpMSS1Ls8CRjmOj OnyTrA10guxXlZpIDwfn2b2a8giY0ELLOjRsknzWEJofawwaUUiniD8CfVCzC4nW xjXT4aqVvBIerckOvVLTenyPwPXADshE0N6+J50S/hP+OYWbUAbXv0sN962YPT0y P5xMXri4mwfZsbct81YXeiNjTMgVHLLBKV3ddtLw4pps9UkH/A6FsvXfBXZ8OiN5 NxNTIHHiXWltBX1LfuJDaQ== Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11020124.outbound.protection.outlook.com [52.101.46.124]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4ah1bmaf4b-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 20 Nov 2025 07:44:44 -0600 (CST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WtXYjkIOIK0iqdQXixLnNPH8vSeo4Dk5imUJpQVir5tErR9d5cuoSNi/qH5VeoJ1CMX2DoqZT4E+XRinskfSMAVCEwUzwAiA5LucqeUsm3RvmpdkRl+mBnt12iuwXIJsYKPwuCHt/F5K5k8j8oT35gHE68FgQ16+9bL9GegBA8x1RUhBEmkctr7eE38CTzMUpdRma1cWddDBgyVL03pxNu5BaQzJw8xdiGy9MXKSidtHVB48tunj7J7Tgs3ZfaZ5/sxaGEkMBMKrLmwryj5ExTWTnu361zU/UBzqZeTYd09paKA3Zo+zMTCzVVkPuMsZKZEmjizf/Y7Iu5cD0D062Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cJV+HjH7Z8YaqOpPAlwGOe7qmvncEKh/zeIFNWGdhn0=; b=WKD8olOqcv3mfc+5jX90oY6Tkp6wRKuLzIxMjWpf4TXNsac0G8hy9MTfapDAGCIz7Be1kyhLBzoW9HpjWgLA5yl+XsO4uHpV5AYCtiVnJoE4PYZ8QwpZlm6xTbt1nAlAm9o73vbwvB2cVojGSBbIId5gGyvJkGNxPnsNcpU41XdneWPhX94Gy9LGz2/8ZKeXCfzFG0xFn1Wvk+NcMLhk6oeU/sxBaVmeXDuXUxZdkxxQWHkY6WiFfBw7rZYK4KkCsXB/uDXTuj4g0AOkA+pcNzReUMLVd1EyyEVoM4gsp53sanWXLUD6mrGE4vKnDLdV0UwDanIZ33/gXusoKH3NUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cJV+HjH7Z8YaqOpPAlwGOe7qmvncEKh/zeIFNWGdhn0=; b=UjhkMg7FAr6d8PuIkcsFcSiOvqAWFqg9jGxB3aNiGpU2Kv23Wu6ezKFpxgGlZ7tJ0UmK0h4tYsnPqgtYGbuwqMBe2jQXHwm+UHenXJunu02ePesWY86EEBjaMMKHeiQiZvguQePaWotrdXwsSgiEwfJGg6EoI5KfAY/xMMgEShY= Received: from SJ0PR03CA0232.namprd03.prod.outlook.com (2603:10b6:a03:39f::27) by CO1PR19MB5016.namprd19.prod.outlook.com (2603:10b6:303:d6::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.11; Thu, 20 Nov 2025 13:44:39 +0000 Received: from SJ5PEPF00000206.namprd05.prod.outlook.com (2603:10b6:a03:39f:cafe::41) by SJ0PR03CA0232.outlook.office365.com (2603:10b6:a03:39f::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Thu, 20 Nov 2025 13:44:37 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SJ5PEPF00000206.mail.protection.outlook.com (10.167.244.39) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 13:44:39 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id A15DF406553; Thu, 20 Nov 2025 13:44:37 +0000 (UTC) Received: from ediswws06.ad.cirrus.com (ediswws06.ad.cirrus.com [198.90.208.24]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 9B267820247; Thu, 20 Nov 2025 13:44:37 +0000 (UTC) From: Richard Fitzgerald To: broonie@kernel.org Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 4/4] ASoC: cs35l56: Use SND_SOC_BYTES_E_ACC() for CAL_DATA_RB control Date: Thu, 20 Nov 2025 13:44:37 +0000 Message-ID: <20251120134437.1179191-5-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251120134437.1179191-1-rf@opensource.cirrus.com> References: <20251120134437.1179191-1-rf@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000206:EE_|CO1PR19MB5016:EE_ X-MS-Office365-Filtering-Correlation-Id: bd14a742-dbd9-4113-3852-08de283af39b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|61400799027; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?JIqIIUN4+XBsS+OjGpuW9eMuFWcLNnTE25IssoKCnp+5aVeEfsbc7wfPM+eC?= =?us-ascii?Q?pRJ+3GuU+jAzAZlpJxNgZ+acJJ/Jg7e2AwTiI4lRoXQyHbvAcEVtZV6qGJPH?= =?us-ascii?Q?Ew7I+UIVFVzMfCrfQmnaXxh587V51eepUx+Tkm5BWQK1wSnmpyuIunuvQSI0?= =?us-ascii?Q?jY2qRqXoXiYsJSeIVe0lpiu9POP76XO2KGyQ23Tibwg2KvJ1GgxaVKlbXbBz?= =?us-ascii?Q?24X+K/kidb/lCWyR8x+B0uKB2zhCQsvU5msW8pEEi+Qa1GKv9TKznbfbM5SS?= =?us-ascii?Q?gbLlqVwXjMe80AGZY2trn1Un1m8hBJY23kd5U78Kl9jQCvHb8HXol7kQ+j6C?= =?us-ascii?Q?Z8rz0C386KzZdCe4iHDP4820zXQEEvZVR04jjVirii5SqWnJYCHW7XThrNxj?= =?us-ascii?Q?P5w5xittJLXXt7LPjKiuDazdN+cXCHbLqWXDgY2OYOQLjuSVETaKfbaubgit?= =?us-ascii?Q?Da0XdqL7c1JpI7nIbMACrIB9y4odEg6dOC+hiwzhacILlQ28vCgb0s4G87F7?= =?us-ascii?Q?TxiK7U06iQ9CfNSUPkowBrBot6XIafgCFl8okVAbR/K79Me4cIuMOqmUDGBR?= =?us-ascii?Q?YFvB/AlREEAxQkkKuijjIl/QU/4pPuDy4smV7XO0/OR4zFGp6emw1mnhChHw?= =?us-ascii?Q?Aa5O8tDbzZwBOSSN7NbVcoUFHveP7eyRBEzzzSmk6mzUchMG483AJQTnrTrG?= =?us-ascii?Q?l7YZpJw5QzrIqlV+YwNEycSH9vEVTnuE/5D9gkK/rFBJBT7IaehMs69CAj/v?= =?us-ascii?Q?0MUdwI56rkbCdAog65tQaZmnvCHvSG2Srgv2Pq8WeFAljvMO5S+uAujASHxQ?= =?us-ascii?Q?i+NQl/aQAJyxwH+U+eV7Eu5De2Pv3S97Qvza9ZYAZ18Mh5sXF5QJO8IPeBRc?= =?us-ascii?Q?J3+VggueKLMd3aewQ7wbpDxBxt+V5Vvbvfg0sJeSO6EZ2GdeUNATTiF7k2vl?= =?us-ascii?Q?/8TWFSHALuu/00wBuCoVZUHZbNmg3iksbmilXRiIhE4Z+cg7bM8KDE14wMlV?= =?us-ascii?Q?qeMVPjWkwDxzIEevHmrn89J0XRjEfbdWRu8RWdS5FU0ngM5JNWXmA84wiG5w?= =?us-ascii?Q?VF1kD93glxQoFWDmnRwEfqAVPQqFeXWxO+shH+hlPTCHkFt9CW5jBpAVUo8g?= =?us-ascii?Q?4a3VGj96yjJNvjNCfFw9hXhHEJnwL5N+B7QlyP+qgjogtOylMzw2PNusmbxG?= =?us-ascii?Q?NNW8xttXrsofhPsHUEPeJ4u6YTcllHHOLXNgKbZurTpQAU8+a/vGcqeUmiMG?= =?us-ascii?Q?p/7q3dESWqv6vqxs+zdu+TpVdXfmx75TmghCCRZyzxk6abslcPaomFHMJBqM?= =?us-ascii?Q?aqYEYGACejn6u1sDdcUoybEVSeouF7znndveVU//7DD+JbL5laeUWMGyTIHE?= =?us-ascii?Q?in+ZZuD6rOFefEc7naULBZ3YBENCf98lbw/q+voV3YqaJBn0DXVRf0T8Rx1/?= =?us-ascii?Q?CQbgw0/SaLbKosFQWiORsIXpcynq9iETg4+za/pOu3CFi1V5N+FW1fvrTVTr?= =?us-ascii?Q?CtP3LNLz2Aa+ZmqT376rbSTbNZChSZ2HK6FHNWR5xaaMG8iKyu6iPgimxqn9?= =?us-ascii?Q?cntRJK35LJv+VuGJNp4=3D?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(61400799027);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 13:44:39.0042 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd14a742-dbd9-4113-3852-08de283af39b X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SJ5PEPF00000206.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR19MB5016 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIwMDA4OSBTYWx0ZWRfXyJMG/0AyYbDU i5W+84tmJySO4ygIPeaIUb8nT7Oiq7Qc8JTVdudsAE3+PCFfec92CCTIE7BOpZja6dylDIxuokn /PmDj6+ihMl3ncWWCK01jhlf1+VlYbXXOVg9vmXpzldrWguxA1LC/+4n8HSzRbhwyeFXKGNRdG1 ime7H+AdBDfoltIz8QNkXukLvHCYrWonBASqBQwH5j/+UsAL3LHxVLbtVS962fnl9wc5NJoistz TuAErk703KLnSW15n9jrzy7NiJ9o0hYgbqjfVLSyuSTMleYIQaw5+dPlO7C1i9SHddhkvich0w1 4nHFyv0eWYWjW5wFn529Jg8bIew8Ih1RKdvcJrHtNKTQohP8eDDMXKzmdArOJ/MUcBivwHhXAA3 aAb4Sbd5qiZEykDByB1EQYWH0knAig== X-Authority-Analysis: v=2.4 cv=XcmEDY55 c=1 sm=1 tr=0 ts=691f1b4d cx=c_pps a=KzuZNAusUQo1wHVwqbxTLg==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=6UeiqGixMTsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=w1d2syhTAAAA:8 a=8K60sZ1CEUfmsYt1aJoA:9 X-Proofpoint-GUID: 6iWIxqH0MZY6cbAzK--UrtyDLC82TsoW X-Proofpoint-ORIG-GUID: 6iWIxqH0MZY6cbAzK--UrtyDLC82TsoW X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Use the new SND_SOC_BYTES_E_ACC() macro instead of SND_SOC_BYTES_E() to define the CAL_DATA_RB control, so that it is marked as read-only and volatile. This avoids userland code expecting to be able to write to it and then getting an unexpected EPERM error, or assuming that its value can never change. Signed-off-by: Richard Fitzgerald --- sound/soc/codecs/cs35l56.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c index f5fd20c8cce1..d8a3babce0f6 100644 --- a/sound/soc/codecs/cs35l56.c +++ b/sound/soc/codecs/cs35l56.c @@ -1099,8 +1099,9 @@ static int cs35l56_cal_data_ctl_set(struct snd_kcontr= ol *kcontrol, static const struct snd_kcontrol_new cs35l56_cal_data_restore_controls[] = =3D { SND_SOC_BYTES_E("CAL_DATA", 0, sizeof(struct cirrus_amp_cal_data) / sizeo= f(u32), cs35l56_cal_data_ctl_get, cs35l56_cal_data_ctl_set), - SND_SOC_BYTES_E("CAL_DATA_RB", 0, sizeof(struct cirrus_amp_cal_data) / si= zeof(u32), - cs35l56_cal_data_rb_ctl_get, NULL), + SND_SOC_BYTES_E_ACC("CAL_DATA_RB", 0, sizeof(struct cirrus_amp_cal_data) = / sizeof(u32), + cs35l56_cal_data_rb_ctl_get, NULL, + SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE), }; =20 static int cs35l56_set_fw_suffix(struct cs35l56_private *cs35l56) --=20 2.47.3