From nobody Tue Dec 2 02:06:43 2025 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011029.outbound.protection.outlook.com [52.101.62.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35E49327219 for ; Thu, 20 Nov 2025 12:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640880; cv=fail; b=mwm06yt0RnFweeNPXWMofv8iwVMP7pVgXh1gIxCijNWrSM5EC92cJxEJV7kg6Wql/4DFCoLX7QgtroWDGd1xH7RwPfMS2ZeUQdIJmHz+FrG1GxGW1nYz2byZiUxd2QmRP+ilwhepZhUPvpJVtqHiRgEes8bhw0FrRXx/DSOWJEM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640880; c=relaxed/simple; bh=xsjBXSgJmn3O8lBjCOGmtBBfLyNC29OSzCyI/+uVl1A=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q1c8B1MWhWh1PBboV7G6jtHxznsHZfyR+tXFXpNTloXn+xT/kW90L2fGkwaX/SIY6JyB9ILum0bfNRorRX98KfuaOI2l9/YW/89GGea6I27X0AvtJIUf4u213QHm6C8zGK6HBZ4k9RovUmojyiFZNc+Q9FgUsuEjhVhLkDm4ugY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=oNbgGHQU; arc=fail smtp.client-ip=52.101.62.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="oNbgGHQU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=V0B8wMVLDolAX52OTOxOF7TsLXqy3GGp6X+Ym/NLDPB1DObdSSPLIh+Bhi9c+/eevr2khkXncWxmhIIyT5WmHePeRbwBcMqy5iZ3dYzT4yv98kZ+QFnVOaUoJUp5XzDtpQ+QX0AoiG1xJbtpk9zzKV/1jR98brV4pJSZ2tUWJeMOc4O0YyFKl3mUhTI9ZbLnO+ZWEJAhpdewTrrT+9ZdlXAXQkfL3oHjXGrruXe+lkSwg+5Y0LqaaK0DKXQEkkh0L6+bwNenIbmaS0/w2r7qRO7xKmioSTTKYR162HvHj2i0t5e+xsjlIllBGBewlX/IffKrZAgTal12TBv5H8g3vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zdUWSt9N/J9J/AG/RN6TgfIA3S3IcfHRjK4jOK5hVB0=; b=DGbhfabOf40bUye6LCBvd8EJmuvpPXEdg2C09OQSJ7lXR9csTI5xGOqxaWOKVz4MwMP4HIhG6qGECeSujk0J2dtfVbxQe7XSmAIjzbd1Hausazz/qdhuK5tq0jqkUBMu4VlItcYM/COsjgdY6WtHAVhFk5hQ72nTojzU/1/omzgt5bwlt45FVkz1iYNxMF4yf1f7js8M53+zl7i/HvrTay9rgmNQmU4SgHJcPwWtLZoz+JKmMf1k+It9rlYK9nYFpUlYiXjrESalnlLVuJLTYtoZ9Wy/z+6azN8LBE0hCipVPZu5rU/WhXjyGrNzdw7YoryE98x5q0HVJaiPrKyl9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=suse.de smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zdUWSt9N/J9J/AG/RN6TgfIA3S3IcfHRjK4jOK5hVB0=; b=oNbgGHQU+QAU8fre55QrF2qyGi+7mZCCA5iLQt9mzvs8yqyyha8jwh/bpPLf36j2TSj/sIIMxW2J2Fsxh0Ymqwxs+MfeLoGA7bjnE2n3/Iauvbe34NznXXwgJP9/zQUNV8Pl1nh1iKwqGXYxdUdR8H7jrp7dFw9HY6sN3Yr+kx4= Received: from CH0PR03CA0383.namprd03.prod.outlook.com (2603:10b6:610:119::18) by DS4PR10MB997623.namprd10.prod.outlook.com (2603:10b6:8:318::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.19; Thu, 20 Nov 2025 12:14:33 +0000 Received: from DS3PEPF0000C37C.namprd04.prod.outlook.com (2603:10b6:610:119:cafe::48) by CH0PR03CA0383.outlook.office365.com (2603:10b6:610:119::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.11 via Frontend Transport; Thu, 20 Nov 2025 12:14:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by DS3PEPF0000C37C.mail.protection.outlook.com (10.167.23.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 12:14:32 +0000 Received: from DLEE204.ent.ti.com (157.170.170.84) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 06:14:30 -0600 Received: from DLEE203.ent.ti.com (157.170.170.78) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 06:14:30 -0600 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE203.ent.ti.com (157.170.170.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 20 Nov 2025 06:14:30 -0600 Received: from hkshenoy.dhcp.ti.com (hkshenoy.dhcp.ti.com [172.24.235.208]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 5AKCEHDu3636470; Thu, 20 Nov 2025 06:14:24 -0600 From: Harikrishna Shenoy To: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH RESEND v9 1/6] drm/bridge: cadence: cdns-mhdp8546-core: Set the mhdp connector earlier in atomic_enable() Date: Thu, 20 Nov 2025 17:44:11 +0530 Message-ID: <20251120121416.660781-2-h-shenoy@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251120121416.660781-1-h-shenoy@ti.com> References: <20251120121416.660781-1-h-shenoy@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37C:EE_|DS4PR10MB997623:EE_ X-MS-Office365-Filtering-Correlation-Id: f4cbb4ba-1fed-45ff-7725-08de282e5d31 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|7416014|376014|36860700013|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?HvR25vdgMxRWlydI4TegL8FxLIrwLNUYLOoCZga/T158nHqV/N/9wC9jtnlM?= =?us-ascii?Q?t0Ab/bXAIQVXaJkTD3s7a4KLxOpH5XuLD6nchuxbO8PuPpNe3AOWlxYvcjHk?= =?us-ascii?Q?+5MdI8P2F8W+Lr0ScT9eAYv7rlKYLD6YJnP5ICxb4GfpkNacfLXmsYslGBnW?= =?us-ascii?Q?HC6ggoJ4xDdUylWochP6LNWQwv3VsD08+99+HQVFwEiSxD9ymwYX+RxP1+7I?= =?us-ascii?Q?6KfiKHXpg4KAywLgCfIGD5s4SDr/itQNFGdikj5Rt9PMc+UbtCPd9iDW/vgW?= =?us-ascii?Q?CM3uKb/8UXNKhfnREWLZBN3wp1LyU8k1WUwaI9sgH9CRalqz/nELA2SzsUj+?= =?us-ascii?Q?e/A3KxisOElGsKcdFgGb0foFg9ePy02rscIClD4KuzMv3qm0cPs/cJIIRnQ7?= =?us-ascii?Q?NuyG/03yPkFUucc7PIK8YeoDIfO+HGZ+tG+tAT88nL9QCYeoUIvh18aTZYvc?= =?us-ascii?Q?mmw+OFCLl9WrPRRa8/jMfp6HZ9gn6OFFTQgH4He21hojFBQh8KsBtItFDPXl?= =?us-ascii?Q?xPoepWUus2EjQhb+5qX11ZJV0AQRG8n3IgqR8GdBVFPSt6Ax5zEZA6+2mlb3?= =?us-ascii?Q?eYduX4NBQxEjs2y/F23pbwDpVdN4CEOZaZfElmSo0GYZirwldTdmLBcbMUy3?= =?us-ascii?Q?CksH+ISRuBD2WI9LfKuUw4h8TYaxSf8a4hXw93WKn9ia83FQW52StfxlwXjY?= =?us-ascii?Q?iB4VOWu5s56+8nu3YS/+wcw/+tVZuDVKxgtiMArzDqWseZx10rtJXnfWDe4D?= =?us-ascii?Q?9e/aZvn1t8cG2JbBl6AnOcbhT4tjscXwYeB21fAO9Bea9w4lzAfN/cIQ1ngx?= =?us-ascii?Q?9bMu/5huRy9ewqtg6LTc8tRgK5QPeBX3KYxvnnzycQjCsB0n4OSWpHYRNJFv?= =?us-ascii?Q?4iIXFhmyrwJQ923CaaShbhcujtfCBMuhCZrPld8AwIdLzqCzRA2ildBmKLZK?= =?us-ascii?Q?BKjDjUlVEOyS8QEan5Ng+LFCIGA3NGxTI73KV1YsZjPpUaIiXKo2ZHEq73zG?= =?us-ascii?Q?cV3HEzdXt47WqtdqIg051ttgO7tYGHrGgbyirwB7IdIlpccUthrJyZxEL6HD?= =?us-ascii?Q?jritKKtJ9QOyuh8NqHxGewE/R7RaHz5L4IyP7EAKP4V4i4lGiJxn1gPGh1ea?= =?us-ascii?Q?+5u8MdP43hpHqfHdmkvkNaXqaeZDGQskP5Heei21ZTiuHf8fO4p9ba6kbTKY?= =?us-ascii?Q?qi1PGk3if9+YHex/+x9Y1oJdi4Wy0nzn0yZr2+P7pk0T+XYnEt2n1f326gbp?= =?us-ascii?Q?SFhgCIQZgYOgPhNySkgnLxVrYk8QDmjG7s058ZZBavFcozrLHutgr2BxXRI9?= =?us-ascii?Q?VfjqjO715W9daSscxlTsO8yRF6xxxdciRGGTY0CMJsAf7Jc+XPU02USvO1C5?= =?us-ascii?Q?3nheg2cqS8o/MlQ0YJ5PPI6szp479OAYQM/zEcV96QnUMTK5GlHnMQwyItin?= =?us-ascii?Q?s7dbB+QkVNN0LoBYuShNt7jHA+yi6q7/d73votR40jDT45tJWqm2sxWAzuNF?= =?us-ascii?Q?pjiRbSl2lJ4aZmHo0IW/tzUbtphaYCJUVOz6oiZWicBNELSgv9y7sM2JfjB4?= =?us-ascii?Q?A8G1F4Q/DXtuYbSBrejofi98zzuc8rmhVweFrCT5?= X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(7416014)(376014)(36860700013)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 12:14:32.9602 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4cbb4ba-1fed-45ff-7725-08de282e5d31 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR10MB997623 Content-Type: text/plain; charset="utf-8" From: Jayesh Choudhary In case if we get errors in cdns_mhdp_link_up() or cdns_mhdp_reg_read() in atomic_enable, we will go to cdns_mhdp_modeset_retry_fn() and will hit NULL pointer while trying to access the mutex. We need the connector to be set before that. Unlike in legacy cases with flag !DRM_BRIDGE_ATTACH_NO_CONNECTOR, we do not have connector initialised in bridge_attach(), so add the mhdp->connector_ptr in device structure to handle both cases with DRM_BRIDGE_ATTACH_NO_CONNECTOR and !DRM_BRIDGE_ATTACH_NO_CONNECTOR, set it in atomic_enable() earlier to avoid possible NULL pointer dereference in recovery paths like modeset_retry_fn() with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag set. Fixes: c932ced6b585 ("drm/tidss: Update encoder/bridge chain connect model") Signed-off-by: Jayesh Choudhary Signed-off-by: Harikrishna Shenoy --- .../drm/bridge/cadence/cdns-mhdp8546-core.c | 29 ++++++++++--------- .../drm/bridge/cadence/cdns-mhdp8546-core.h | 1 + .../drm/bridge/cadence/cdns-mhdp8546-hdcp.c | 26 ++++++++++++----- 3 files changed, 34 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/= gpu/drm/bridge/cadence/cdns-mhdp8546-core.c index 38726ae1bf150..f3076e9cdabbe 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c @@ -740,7 +740,7 @@ static void cdns_mhdp_fw_cb(const struct firmware *fw, = void *context) bridge_attached =3D mhdp->bridge_attached; spin_unlock(&mhdp->start_lock); if (bridge_attached) { - if (mhdp->connector.dev) + if (mhdp->connector_ptr && mhdp->connector_ptr->dev) drm_kms_helper_hotplug_event(mhdp->bridge.dev); else drm_bridge_hpd_notify(&mhdp->bridge, cdns_mhdp_detect(mhdp)); @@ -1636,6 +1636,7 @@ static int cdns_mhdp_connector_init(struct cdns_mhdp_= device *mhdp) return ret; } =20 + mhdp->connector_ptr =3D conn; drm_connector_helper_add(conn, &cdns_mhdp_conn_helper_funcs); =20 ret =3D drm_display_info_set_bus_formats(&conn->display_info, @@ -1915,17 +1916,25 @@ static void cdns_mhdp_atomic_enable(struct drm_brid= ge *bridge, struct cdns_mhdp_device *mhdp =3D bridge_to_mhdp(bridge); struct cdns_mhdp_bridge_state *mhdp_state; struct drm_crtc_state *crtc_state; - struct drm_connector *connector; struct drm_connector_state *conn_state; struct drm_bridge_state *new_state; const struct drm_display_mode *mode; u32 resp; - int ret; + int ret =3D 0; =20 dev_dbg(mhdp->dev, "bridge enable\n"); =20 mutex_lock(&mhdp->link_mutex); =20 + mhdp->connector_ptr =3D drm_atomic_get_new_connector_for_encoder(state, + bridge->encoder); + if (WARN_ON(!mhdp->connector_ptr)) + goto out; + + conn_state =3D drm_atomic_get_new_connector_state(state, mhdp->connector_= ptr); + if (WARN_ON(!conn_state)) + goto out; + if (mhdp->plugged && !mhdp->link_up) { ret =3D cdns_mhdp_link_up(mhdp); if (ret < 0) @@ -1945,15 +1954,6 @@ static void cdns_mhdp_atomic_enable(struct drm_bridg= e *bridge, cdns_mhdp_reg_write(mhdp, CDNS_DPTX_CAR, resp | CDNS_VIF_CLK_EN | CDNS_VIF_CLK_RSTN); =20 - connector =3D drm_atomic_get_new_connector_for_encoder(state, - bridge->encoder); - if (WARN_ON(!connector)) - goto out; - - conn_state =3D drm_atomic_get_new_connector_state(state, connector); - if (WARN_ON(!conn_state)) - goto out; - if (mhdp->hdcp_supported && mhdp->hw_state =3D=3D MHDP_HW_READY && conn_state->content_protection =3D=3D @@ -2030,6 +2030,7 @@ static void cdns_mhdp_atomic_disable(struct drm_bridg= e *bridge, if (mhdp->info && mhdp->info->ops && mhdp->info->ops->disable) mhdp->info->ops->disable(mhdp); =20 + mhdp->connector_ptr =3D NULL; mutex_unlock(&mhdp->link_mutex); } =20 @@ -2296,7 +2297,7 @@ static void cdns_mhdp_modeset_retry_fn(struct work_st= ruct *work) =20 mhdp =3D container_of(work, typeof(*mhdp), modeset_retry_work); =20 - conn =3D &mhdp->connector; + conn =3D mhdp->connector_ptr; =20 /* Grab the locks before changing connector property */ mutex_lock(&conn->dev->mode_config.mutex); @@ -2373,7 +2374,7 @@ static void cdns_mhdp_hpd_work(struct work_struct *wo= rk) int ret; =20 ret =3D cdns_mhdp_update_link_status(mhdp); - if (mhdp->connector.dev) { + if (mhdp->connector_ptr && mhdp->connector_ptr->dev) { if (ret < 0) schedule_work(&mhdp->modeset_retry_work); else diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h b/drivers/= gpu/drm/bridge/cadence/cdns-mhdp8546-core.h index bad2fc0c73066..a76775c768956 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h @@ -376,6 +376,7 @@ struct cdns_mhdp_device { struct mutex link_mutex; =20 struct drm_connector connector; + struct drm_connector *connector_ptr; struct drm_bridge bridge; =20 struct cdns_mhdp_link link; diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c b/drivers/= gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c index 42248f179b69d..5ac2fad2f0078 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c @@ -393,8 +393,10 @@ static int _cdns_mhdp_hdcp_disable(struct cdns_mhdp_de= vice *mhdp) { int ret; =20 - dev_dbg(mhdp->dev, "[%s:%d] HDCP is being disabled...\n", - mhdp->connector.name, mhdp->connector.base.id); + if (mhdp->connector_ptr) { + dev_dbg(mhdp->dev, "[%s:%d] HDCP is being disabled...\n", + mhdp->connector_ptr->name, mhdp->connector_ptr->base.id); + } =20 ret =3D cdns_mhdp_hdcp_set_config(mhdp, 0, false); =20 @@ -443,9 +445,11 @@ static int cdns_mhdp_hdcp_check_link(struct cdns_mhdp_= device *mhdp) if (!ret && hdcp_port_status & HDCP_PORT_STS_AUTH) goto out; =20 - dev_err(mhdp->dev, - "[%s:%d] HDCP link failed, retrying authentication\n", - mhdp->connector.name, mhdp->connector.base.id); + if (mhdp->connector_ptr) { + dev_err(mhdp->dev, + "[%s:%d] HDCP link failed, retrying authentication\n", + mhdp->connector_ptr->name, mhdp->connector_ptr->base.id); + } =20 ret =3D _cdns_mhdp_hdcp_disable(mhdp); if (ret) { @@ -487,13 +491,19 @@ static void cdns_mhdp_hdcp_prop_work(struct work_stru= ct *work) struct cdns_mhdp_device *mhdp =3D container_of(hdcp, struct cdns_mhdp_device, hdcp); - struct drm_device *dev =3D mhdp->connector.dev; + struct drm_device *dev =3D NULL; struct drm_connector_state *state; =20 + if (mhdp->connector_ptr) + dev =3D mhdp->connector_ptr->dev; + + if (!dev) + return; + drm_modeset_lock(&dev->mode_config.connection_mutex, NULL); mutex_lock(&mhdp->hdcp.mutex); - if (mhdp->hdcp.value !=3D DRM_MODE_CONTENT_PROTECTION_UNDESIRED) { - state =3D mhdp->connector.state; + if (mhdp->connector_ptr && mhdp->hdcp.value !=3D DRM_MODE_CONTENT_PROTECT= ION_UNDESIRED) { + state =3D mhdp->connector_ptr->state; state->content_protection =3D mhdp->hdcp.value; } mutex_unlock(&mhdp->hdcp.mutex); --=20 2.34.1 From nobody Tue Dec 2 02:06:43 2025 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011069.outbound.protection.outlook.com [52.101.62.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D24D3328FE for ; Thu, 20 Nov 2025 12:14:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.69 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640892; cv=fail; b=tK2oKi0WjjbcryYW07ZE7Gu0xBm0K0/+7kOIgQ+3WDlJttfWsdZuX8zRl81HW4cDLYS1fjuu1XDJRlbRj81CkmL/qdSLNw/w4xog8snOQtQAzZvKwEqayECgzUjb+wU/nX2d7QIHZ0BAYChsilDo1uFiUk0IPuLZrvd9EZhm46I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640892; c=relaxed/simple; bh=k7k8FLQnnDeqwnBW+5zNabCISdgPJewL5Ku/DEJdGGQ=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=URMCQMv4lxsyS5sGJeyafTq9nKmbJ6COv+fwQnP+wzMy5Ru2z1irb6XsrFs9ZveRajrQHvthUuNTqOoweegNhATg5upYe5QRKTLHKgmg8jKrt4NmhntVSQ/eVlJnEtsovMkfNfOze9XkVhgYY7w4YnG7IABx7iUUNH3v1+R92m0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Y2cDCWug; arc=fail smtp.client-ip=52.101.62.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Y2cDCWug" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NRgtswEj3Zk/Unt9jhXj2fDOEjKeopOBYeFe//R69H9rTOG2U2HUe+fJ2L9QKo9EwBa7l++FP58Y3i4ReSn7JNDAoo0bv2ofiQIiiE8kWnmB7SQh+6+f0JECoKv/1S7oYO4OzfhXqyLKzT7V/0Ad/hP0KlrS60IgCnweFyFjDg/Zz/PgKgm76rZyMj7+Tj1KBhj9MwyVAWXNBF83UhIhdzu9NtUEML5oTCKJDLz6oj9rED6x7w1OIYcj9FKF8J03tG8CxdKFvxZJW6lIVp2OSlBYLL1EryUe85nnPRE5qnx1zuqpwXoUo2gtWE6hG0+ch+8YahFJoRmfaWnmNUWqyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/w7uSbPkb3gfr4l2WgN5S8ZDOsgdsLVoLIIrA1/OHfE=; b=kDvlO5TI35I/oV7PTAjnZ0kRwThikGRkqsip77eUixTvUTksYCmKONAAC7z7//erfPlxscr+4Y1KkWc4P36XfDDwBeswKTd4q1QYYZ4Oh+P6LJ6jI67kNnpEZJ5KNZXb4Wy6cMGH4WrSZU6GwCeOUsQefBWIIjccXmaXYomwpdXkBksiDhi6APFG+uJRjQM5w5+12j2K3taX6heOhH5MUEdHmSA5lzMzncaph0QxqMWm7BL/m5G+bkWvmHhU72yLj42M8Ev1awYAW4pL7/La92bhs3nY75dEaY6uZCF2Vv9+uQ2g9Me2bAyXsvMOe90yM0c+VniCTV0E9Fpo5PMIBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=suse.de smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/w7uSbPkb3gfr4l2WgN5S8ZDOsgdsLVoLIIrA1/OHfE=; b=Y2cDCWug6RfxBDBcC5R5xY9zrXJDPT9/Rpp5G2QQLoyS7WZutdsEpIuvIuXkx+HWEBZMLUPtKRV4xEYwl8VW5P3M5CWfBf4ejO4vP3AcOoP7G3UaEoPhV1lgK2sHpS7Oe1wKmytdjdJn9l/GnLUp4CQmuNY+3uV3vYk0IaWEkj0= Received: from BL0PR0102CA0041.prod.exchangelabs.com (2603:10b6:208:25::18) by PH7PR10MB6311.namprd10.prod.outlook.com (2603:10b6:510:1b2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Thu, 20 Nov 2025 12:14:41 +0000 Received: from BL02EPF0002992D.namprd02.prod.outlook.com (2603:10b6:208:25:cafe::63) by BL0PR0102CA0041.outlook.office365.com (2603:10b6:208:25::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.11 via Frontend Transport; Thu, 20 Nov 2025 12:17:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by BL02EPF0002992D.mail.protection.outlook.com (10.167.249.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 12:14:39 +0000 Received: from DLEE202.ent.ti.com (157.170.170.77) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 06:14:37 -0600 Received: from DLEE209.ent.ti.com (157.170.170.98) by DLEE202.ent.ti.com (157.170.170.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 06:14:37 -0600 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE209.ent.ti.com (157.170.170.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 20 Nov 2025 06:14:37 -0600 Received: from hkshenoy.dhcp.ti.com (hkshenoy.dhcp.ti.com [172.24.235.208]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 5AKCEHDv3636470; Thu, 20 Nov 2025 06:14:30 -0600 From: Harikrishna Shenoy To: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH RESEND v9 2/6] drm/bridge: cadence: cdns-mhdp8546-core: Add mode_valid hook to drm_bridge_funcs Date: Thu, 20 Nov 2025 17:44:12 +0530 Message-ID: <20251120121416.660781-3-h-shenoy@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251120121416.660781-1-h-shenoy@ti.com> References: <20251120121416.660781-1-h-shenoy@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0002992D:EE_|PH7PR10MB6311:EE_ X-MS-Office365-Filtering-Correlation-Id: 3db14eca-c474-40c2-1659-08de282e6137 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|36860700013|82310400026|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4v3API5N0kIorB8kTmNnSoZ8ModQ+1ritEzwkbSI0AtvE1hML3LeXKX0lq0W?= =?us-ascii?Q?9ANQpLS4uDiMU7aZ9N8jIvzpBySSxwJ68UOjlSmhA1raWDp8I+JyunafUalT?= =?us-ascii?Q?X9ExXdofD9id9Y4O/0Z6zXCFssU5bSj6cLRh5FhZrRJflRXLHUV7L/jdKbPz?= =?us-ascii?Q?y8RKmvgy0ZqSYuUYmdqg4x+pXW7P0Np1cmzeRH9uJH7tQWPU2vFSIq+N7xfS?= =?us-ascii?Q?sFziXD8SJ5fRwwCE+JcgJV3dSbKJcBhuZ00MQZdb+n614171W3qXyNlnPEKa?= =?us-ascii?Q?9PEwYbgtKsflewq3nGQTMUIXcK3dF42FMaj3gRoq4eaCeRqMrfhKWYL9qRCR?= =?us-ascii?Q?z54p0v5I1oFYDtJyj+EI9bYluQt3kiFXBmjvd6Vx64H2na8cBaUP/4YolFoD?= =?us-ascii?Q?8KVlMpNn2MBLzqVQS7IlotWCshdtYGqsX0Mk62faTe9BQLkNqWZgrwopGnYE?= =?us-ascii?Q?iP3nA3hIGA9/mfXgG2j05jx3551rGcqWBZOxYVuVqz30etsokIaflk6FPGE9?= =?us-ascii?Q?xzoqvRfFVMSDZGViioER1U/Q1B2sMXha8221YeUszsHaRd3dEdamXSq+UeGz?= =?us-ascii?Q?FndBjB3Zpnoozy/AOw3knQgrw1Po6uXzEaBXnIFCFv4rBY9A2f214LwwXpV8?= =?us-ascii?Q?cKi/xQCAQ+zYQXZxRqVzr/4yYcQqjNw6OLI5R5TlLjRtttQlQaRBVhDPf3+f?= =?us-ascii?Q?F1fUSl0edResjxDOAFe/d8J2iBATtsouMWl3hrJYlBLTrZ46dHlD+5eqkTl6?= =?us-ascii?Q?DCqDOkjv6fninby8LM+Eo2tIhaRuMwjJ+swNhBoCdDHpN1S+7/kPTxJtRMvM?= =?us-ascii?Q?ybph/0N0WdAyoZNf57uRE2hFsRtyXY5h9LI/LgPZewjv8iJPUs/HL+RasrZD?= =?us-ascii?Q?hTKwDm+yPcmg/Po/P8T4gWYk4QrAgZN5pteLw3vbB3DgQLGWuVg7Bq3Tx1bW?= =?us-ascii?Q?gn8wDtvmTiS3QiuPfNwLMqGAuUu6yEIV7ZaYJeXzONHq14kViWWsXj8aRTeO?= =?us-ascii?Q?An4GCaNPs4CLRUnzgtzV62oBIaESp46Vir4+uwmscMYUvBmL0o+axjbMatEF?= =?us-ascii?Q?IUfuQNQlOL8ofuRNcaMfdZiduAMOgtwqhq70zfmtI32b1dG4lrCiJB7XhPse?= =?us-ascii?Q?BxI/3CDikRvovA/uaORV8nW0jBqJufFw4hOIZQKPwqAAZ5nlVlWJBxye62+0?= =?us-ascii?Q?wwIquOa4gLxnkXLYyEOExwZpgNMHRT4833FLPxnMhomYXLzhZ7K1kJJJ6m3+?= =?us-ascii?Q?0ECEwqqM4zqy6vhBvvyo0ioaz9BAIlTKSbYEHkYKtToSmtAhCyKcAJ9bTfwq?= =?us-ascii?Q?1ymlCqTxBA2IvCFfK3DPtYviBxblb0b6YJa7aJTH6huSIcF/ppD29HtSGmqU?= =?us-ascii?Q?yYTSKNF7SK5SFjQlrKBees976slj0Co2O4K4bf7fsdCA+TgA9PnIpCoe6zTz?= =?us-ascii?Q?2BeI2w2Tf3COztaWgp+HSAssFavkduiSESR43CzqALmnNxZsfdINgj9g1O5c?= =?us-ascii?Q?dWcT2Utkb+JfdvIhh5keVdwTTanUa4QJLTIDLUKbxsD47DPjRu3ZjoOuDVVw?= =?us-ascii?Q?epsu7GTbKAainZZOlz690vK5mrcKPXCQRH6OjQ9j?= X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(36860700013)(82310400026)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 12:14:39.6625 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3db14eca-c474-40c2-1659-08de282e6137 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0002992D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6311 Content-Type: text/plain; charset="utf-8" From: Jayesh Choudhary Add cdns_mhdp_bridge_mode_valid() to check if specific mode is valid for this bridge or not. In the legacy usecase with !DRM_BRIDGE_ATTACH_NO_CONNECTOR we were using the hook from drm_connector_helper_funcs but with DRM_BRIDGE_ATTACH_NO_CONNECTOR we need to have mode_valid() in drm_bridge_funcs. Fixes: c932ced6b585 ("drm/tidss: Update encoder/bridge chain connect model") Reviewed-by: Tomi Valkeinen Signed-off-by: Jayesh Choudhary Signed-off-by: Harikrishna Shenoy --- .../drm/bridge/cadence/cdns-mhdp8546-core.c | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/= gpu/drm/bridge/cadence/cdns-mhdp8546-core.c index f3076e9cdabbe..7178a01e4d4d8 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c @@ -2162,6 +2162,25 @@ static const struct drm_edid *cdns_mhdp_bridge_edid_= read(struct drm_bridge *brid return cdns_mhdp_edid_read(mhdp, connector); } =20 +static enum drm_mode_status +cdns_mhdp_bridge_mode_valid(struct drm_bridge *bridge, + const struct drm_display_info *info, + const struct drm_display_mode *mode) +{ + struct cdns_mhdp_device *mhdp =3D bridge_to_mhdp(bridge); + + mutex_lock(&mhdp->link_mutex); + + if (!cdns_mhdp_bandwidth_ok(mhdp, mode, mhdp->link.num_lanes, + mhdp->link.rate)) { + mutex_unlock(&mhdp->link_mutex); + return MODE_CLOCK_HIGH; + } + + mutex_unlock(&mhdp->link_mutex); + return MODE_OK; +} + static const struct drm_bridge_funcs cdns_mhdp_bridge_funcs =3D { .atomic_enable =3D cdns_mhdp_atomic_enable, .atomic_disable =3D cdns_mhdp_atomic_disable, @@ -2176,6 +2195,7 @@ static const struct drm_bridge_funcs cdns_mhdp_bridge= _funcs =3D { .edid_read =3D cdns_mhdp_bridge_edid_read, .hpd_enable =3D cdns_mhdp_bridge_hpd_enable, .hpd_disable =3D cdns_mhdp_bridge_hpd_disable, + .mode_valid =3D cdns_mhdp_bridge_mode_valid, }; =20 static bool cdns_mhdp_detect_hpd(struct cdns_mhdp_device *mhdp, bool *hpd_= pulse) --=20 2.34.1 From nobody Tue Dec 2 02:06:43 2025 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011067.outbound.protection.outlook.com [40.93.194.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E0AD32FA3C for ; Thu, 20 Nov 2025 12:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640895; cv=fail; b=KRRxRk7fP6qBgLZOP/ykNt56tLjIBfLrN+fXMsoJeLIKmbjPZF9iyoZcJQpiumgTEYKWAmVLdVNLAnWU5zwhV6J5o29CRZdqdfeJzZ1rlUB7sjsz7HmWmtUJSx7VzIupov3lArJO/GJbaOa0sgrawXTzm17PWQN9nY3CM6S0uug= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640895; c=relaxed/simple; bh=D2k1pyB0+80JA1rTr4QMHa7h+dJWcqcP3iVYzqSGUos=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RP26VMuAB4RqnnofIP1IpOiIuL3I9wuO3uzhawb5UegLon9Lsurred2gRnNOGCjfuTeT4tztUnNY0Y8mgDKcadO++AWWf7ZgzEiVdyXgpK3KNuGk1Dl5JPYUwyN22a7f6m0VHNnnz5PSofYGyGqKFOA18RdLTXTQ67j/me4k9Cw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=NadxFfIN; arc=fail smtp.client-ip=40.93.194.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="NadxFfIN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rKi4AmJ/P69f7CwXt57wMy7hQprrCM/kjXqpp03QTLxOeK7BjUVJW8dGJDd8QYKj4Wgi7q+GyFefC5i7EMhpMgvJq2qud1UNWxYEZ7jRd70TZDV6xjfg25c594VAwII5ziAeZb2n/QNe2ZJRTYlkFyjDTjOpCmaWLzHEVM3qelYSy4SOEVc6GubqVtaXFA19fz/IZKBto8VffYifS2RngxtWLZmGu/riFt8Df1RWSYP0b63ynmfUyGnXuJ8YW1uZ4017R0QWG0tbUxOeVw/ZMXd6zpg1JTVUhhW7EyzNGdGvORUPwVACkNYENK0SNO9XuPabJKvebDbIm7uDveDi/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2A/X2cKJPzIUynJOP0tfMCoreJ4+oBhLtpm3lBxDwiY=; b=uP0d5ZyTOP3RCfWS8i1VpQ9Fp/X9q0o4Gc3vWRPN0+95en0Ck+zt+qTxp1g/XT40tmtWCQqXehcouVzIfMnpBIWmnMQ3DmE04eCAhnoxGqANJSlN1bFq8G3N6V04k6GCZGqg/lelR7VIOp3oMve5ViEHZ8dbs84vIOdS1Nlij6aIIBqXVnAH8Cg7GzkvgQmyuKqgRR9iGd8j9PDPzIiJ5Bb7eC4mjvP2xapJH7w1kAE9j/pVZeypnS/S1nl917qtUIZkEiQySo9E+LMtXrCx1g465sxo2Vh42g2Ha8oQLcf3sBLsrQf4n5t32KqY0En+CzNvGt1OXeIgzbLyhJ6jJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=suse.de smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2A/X2cKJPzIUynJOP0tfMCoreJ4+oBhLtpm3lBxDwiY=; b=NadxFfIN9UyPbGAR33mW/PGm/6LFZ3q4R+0ZqHnRa4XvE/uBuT9mXmHET50LTccCP18REX8cKPoANN+jGZ9YMBo11QT47zriHO96a693ej+s0CN8koDNkE/uFSy32Z1bzAILkwGFso0OQ9pT11PFiJjcgZAxNJWb+9IDpUEzns8= Received: from MN2PR19CA0040.namprd19.prod.outlook.com (2603:10b6:208:19b::17) by CO6PR10MB5569.namprd10.prod.outlook.com (2603:10b6:303:144::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Thu, 20 Nov 2025 12:14:49 +0000 Received: from BL02EPF00029927.namprd02.prod.outlook.com (2603:10b6:208:19b:cafe::55) by MN2PR19CA0040.outlook.office365.com (2603:10b6:208:19b::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Thu, 20 Nov 2025 12:14:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by BL02EPF00029927.mail.protection.outlook.com (10.167.249.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 12:14:47 +0000 Received: from DLEE205.ent.ti.com (157.170.170.85) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 06:14:43 -0600 Received: from DLEE208.ent.ti.com (157.170.170.97) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 06:14:43 -0600 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE208.ent.ti.com (157.170.170.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 20 Nov 2025 06:14:43 -0600 Received: from hkshenoy.dhcp.ti.com (hkshenoy.dhcp.ti.com [172.24.235.208]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 5AKCEHDw3636470; Thu, 20 Nov 2025 06:14:37 -0600 From: Harikrishna Shenoy To: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH RESEND v9 3/6] drm/bridge: cadence: cdns-mhdp8546-core: Handle HDCP state in bridge atomic check Date: Thu, 20 Nov 2025 17:44:13 +0530 Message-ID: <20251120121416.660781-4-h-shenoy@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251120121416.660781-1-h-shenoy@ti.com> References: <20251120121416.660781-1-h-shenoy@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00029927:EE_|CO6PR10MB5569:EE_ X-MS-Office365-Filtering-Correlation-Id: 4eb4c586-439f-4a50-edd5-08de282e660a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|82310400026|36860700013|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?t34yp0US0yZYxdw5lKaMxXaTw0/w4LpN4UsX6zIjPZiaKeTCf48Rm/9aC34f?= =?us-ascii?Q?ZbVOB7NIOgLVqkKmMBc99H4b5PLvBWgfEEAyrYG5+5PE9A8MUrKfKZ4DFgog?= =?us-ascii?Q?JxTfuteXRjXxDK7jjuZs1EOOpLT+IAwyMT6XpqzwDMsNebvTh876UJnmzjaI?= =?us-ascii?Q?BOkc34tzViTExHUqJc5+YWClE0HfdLirKTagol0elT6Qp9PPQRPEVHUqkQxb?= =?us-ascii?Q?a1AhHzZN0ltWs8e0bbuAvs9uMTn3pIUk+dNM2gbI5gKahV+VpfhRl6MTgRoI?= =?us-ascii?Q?VdandyegPnyhnlMBjFiebIQfqxY/M4k+6valXaZw+rcWZ7r3rd20VeCQUh2f?= =?us-ascii?Q?7WvwxcEWw0k6p/0c3cfOtGpoqWclyJpbCUheQHWy7thCfNTSxlF+TjerYBlD?= =?us-ascii?Q?UATBBUsgzZwcQLLDTfNUVhFqsP2AQna75xnBp0iZpxVxeTGYk2PJxGXvJMps?= =?us-ascii?Q?OiLbCccSMa3NQ4AVk5fF95duWuo/xPx6PvR/roMKasG9+5dlut54unVCi4By?= =?us-ascii?Q?EL8WJ4dTVn9j3HTJ1M+7Xq1bE6OAY17XGcWW9x3TL+IstEWpL9USsIQI10dM?= =?us-ascii?Q?V80y6JwI06m4Hhu5/QFeEOaQ9u8bKb5uz3LMvdGafeRjHP7CCVxb/f7861CT?= =?us-ascii?Q?wm2/4PYAb58gBLnCKZ7r1jffIm5x7UWtVEQtnFJjSD5cMmBKMn6OsxIScWeK?= =?us-ascii?Q?Pm/1yicf/BeEUfhvoTy4dZvn2GUE+SxFa9kaRbHFwZ49bL4AqwYYDUJJYkKG?= =?us-ascii?Q?QApZNqeqqGhRtH/zJ9PcRqSKvhKpBeNFulKgy7YBT7WNR7W+U923yqXX4roX?= =?us-ascii?Q?e2591mY6eL742D9dJPmKUFA1vSunha1QssBpGwXbehOMxo7wH+LdzApT+48a?= =?us-ascii?Q?rHqS9UQMVSoPGEPt1jfZh7eScyevROKzu4q8o7un/w7XtKBWBXc7LJzNIPFA?= =?us-ascii?Q?rcBa/XIdmi4SCoMC2/OMKMHo1+xCtSoAxW4Y1juDmf3zE+ienw3RNN4OBuPf?= =?us-ascii?Q?mk6WM7FY3dcJ6v9fGuDhU/MBq0T4bJQfa8sq5vjC66ZQ/NsnDo+sIFBkCMt3?= =?us-ascii?Q?OO0xarn3q9/QN2AWZz/m5P8fuISviM2yNyAiuZPevFP7ww74PaQbA9SGW7BV?= =?us-ascii?Q?Ht6hf9HKnfMbZNlAP6dLBLPNJZPQfcCda2Ixaf0jgucAe+YlcZflJcGsGKwM?= =?us-ascii?Q?HtsnNM9VhW49jUsmdAGT2MT6y64v/0PrqIOCvd24TXUbuDVrFW+x56ImtKkQ?= =?us-ascii?Q?Eu+NPNyho9o/SKngD7/N9cZ/xPVPF5OX1p4ELKk30U1RRcFzNOfnj1yzlijM?= =?us-ascii?Q?A/CiaAciz3gE5ueXoI15YxyFjuV/vQPju3aXQuB8KswPxu8ZTwJIbYhgblPh?= =?us-ascii?Q?phgrqJ0ELLoeDQFuL/F7/cZa4n3QMgt5jDKlM8McompatCyJuvBLibi0Oggk?= =?us-ascii?Q?n5YUDp99K/ofSOLWLR3LTby/mkiRekqTnf8F/Z7OhhZFBgmsnC1wMbCBJriz?= =?us-ascii?Q?EMhcvRr0g1WGfTALgN1RHTnCIPK+/ilom40Prcua+07vDvmgE/hiW3Z2ak+Y?= =?us-ascii?Q?AmLYp9fzSBKGrfNMnoMfFjjWbTTJlC4DKw8cFpDL?= X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(82310400026)(36860700013)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 12:14:47.7616 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4eb4c586-439f-4a50-edd5-08de282e660a X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00029927.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5569 Content-Type: text/plain; charset="utf-8" Now that we have DRM_BRIDGE_ATTACH_NO_CONNECTOR framework, handle the HDCP state change inbridge atomic check as well to enable correct functioning for HDCP in both DRM_BRIDGE_ATTACH_NO_CONNECTOR and !DRM_BRIDGE_ATTACH_NO_CONNECTOR case. Fixes: 6a3608eae6d33 ("drm: bridge: cdns-mhdp8546: Enable HDCP") Signed-off-by: Harikrishna Shenoy --- .../drm/bridge/cadence/cdns-mhdp8546-core.c | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/= gpu/drm/bridge/cadence/cdns-mhdp8546-core.c index 7178a01e4d4d8..d944095da4722 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c @@ -2123,6 +2123,10 @@ static int cdns_mhdp_atomic_check(struct drm_bridge = *bridge, { struct cdns_mhdp_device *mhdp =3D bridge_to_mhdp(bridge); const struct drm_display_mode *mode =3D &crtc_state->adjusted_mode; + struct drm_connector_state *old_state, *new_state; + struct drm_atomic_state *state =3D crtc_state->state; + struct drm_connector *conn =3D mhdp->connector_ptr; + u64 old_cp, new_cp; =20 mutex_lock(&mhdp->link_mutex); =20 @@ -2142,6 +2146,25 @@ static int cdns_mhdp_atomic_check(struct drm_bridge = *bridge, if (mhdp->info) bridge_state->input_bus_cfg.flags =3D *mhdp->info->input_bus_flags; =20 + if (conn && mhdp->hdcp_supported) { + old_state =3D drm_atomic_get_old_connector_state(state, conn); + new_state =3D drm_atomic_get_new_connector_state(state, conn); + old_cp =3D old_state->content_protection; + new_cp =3D new_state->content_protection; + + if (old_state->hdcp_content_type !=3D new_state->hdcp_content_type && + new_cp !=3D DRM_MODE_CONTENT_PROTECTION_UNDESIRED) { + new_state->content_protection =3D DRM_MODE_CONTENT_PROTECTION_DESIRED; + crtc_state =3D drm_atomic_get_new_crtc_state(state, new_state->crtc); + crtc_state->mode_changed =3D true; + } + + if (!new_state->crtc) { + if (old_cp =3D=3D DRM_MODE_CONTENT_PROTECTION_ENABLED) + new_state->content_protection =3D DRM_MODE_CONTENT_PROTECTION_DESIRED; + } + } + mutex_unlock(&mhdp->link_mutex); return 0; } --=20 2.34.1 From nobody Tue Dec 2 02:06:43 2025 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012037.outbound.protection.outlook.com [40.107.209.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9AC4333737 for ; Thu, 20 Nov 2025 12:14:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.37 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640900; cv=fail; b=CrkqtVfhx0wFO2s4WTuXl3HsQ5FuKd0aFi2b2M9qYkzLLYEyCrbqZBTQHY+sI86heOg8hXiEq9w9AGyxjitHxQcuBgM0QTYq4uQsOuw+xICEdX3/YgARxgDkPy92O73uLhNdpaIYmPoSvUMZH6Fj3wAuAvI2EtsBkodsCTG9kM0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640900; c=relaxed/simple; bh=j+PBbb7SivAWpS2y55M516TVgktsr0wpXsWxzYWchNE=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=M7XjuO7OMHWypH9eQy79F6OQG3qHHaMqBBy562lM9/pmrg7vrtsgVLAiZ3dyaH1mNLGtMtcNklcpqNUd53O/9EXhMVaQA6qp8hzE9at2iC3ptqC00W4/koPNyoDQFeD4jft2P8cLUmMEOKVkfsowjYV4x66P+TYS1/2ELJaPO+Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=KAZkIZXH; arc=fail smtp.client-ip=40.107.209.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="KAZkIZXH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b8ABE2FwjamV0QJF7P+0xzSyQmvmQckt3O31KSU3/eZU3xLCPra1u0syfDS1M/SatT/IaZqMoZ/tn4gVV3H06R4mIR3clgD7b/hR6ssIugPwFHy2STik+Nt4ZTFMwcCOAM9EbaJnekpFPaTUlU7QIZB/t86fEOitieo2mewH1xYcGfgMy2GTEiF+8GOowJdhoBgsyS+ZzVeuGZuc3yP7vvufjt1nBMRuNiuoSJ3swZugRe+4bMKKi30uzt9/srn8ExHKsqOihOHimyFmeF/BMXoRynICcZFKBNswzixF3v1AqFuSLQYsJwIZDL1EMuaWS6nAkM9qQH/WGaR8LTkW5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ir0OMYdP/MZfn4su09I4GYzEZE7DSHa4fCba9Nq60MQ=; b=d+K1WVvdvNKTK6Bif03hdHsv2vj5lwlGOp4suvz8P74aLKQzWRuBjuZfhs9wKi02+Ugh7+GmD90mmwemGTDTD02uMWRCWxfBBhk2Mj1K6aJ6yUBQSTjYV8uldIYDMitcz5Ot9+CBPVp4HlzXcjZmyI7yFLy06Ie8CyHpRcLuoGPS534JdOPIFmynhnoMRv4RPUrLjTSvzs3r1zgY9z5BVUyRgpDX3PZ6AMVTnQZjTE1u4ZVumiXIckjMBjpoNp+lOSN1ygVA5IZz2jdUHHHTQ9Y7ltPKipc7tVoO7575tSjL0/QBym5v82ADQ7aI4xU1TKHPigu5lO469VHcmOagdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=suse.de smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ir0OMYdP/MZfn4su09I4GYzEZE7DSHa4fCba9Nq60MQ=; b=KAZkIZXHSbRrExwC7pXYNSFJ7hJ08xsBKJ8CvJCErGARlNHkoX5pAIp5G7YB6iGZZGM6rbexmt1O0eXpA1Pa2rxT4jtj0R4OeLVtT0BjNvJdG2P2jti0dbAOsNw97t+st/zOemXhDx3/nKLFMZxVd194XE8Xq2eoDkGm0hApCNw= Received: from BY3PR05CA0008.namprd05.prod.outlook.com (2603:10b6:a03:254::13) by DS4PPF9390CCBA1.namprd10.prod.outlook.com (2603:10b6:f:fc00::d33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Thu, 20 Nov 2025 12:14:53 +0000 Received: from MWH0EPF000989E9.namprd02.prod.outlook.com (2603:10b6:a03:254:cafe::54) by BY3PR05CA0008.outlook.office365.com (2603:10b6:a03:254::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Thu, 20 Nov 2025 12:14:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by MWH0EPF000989E9.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 12:14:51 +0000 Received: from DFLE201.ent.ti.com (10.64.6.59) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 06:14:50 -0600 Received: from DFLE207.ent.ti.com (10.64.6.65) by DFLE201.ent.ti.com (10.64.6.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 06:14:50 -0600 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE207.ent.ti.com (10.64.6.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 20 Nov 2025 06:14:50 -0600 Received: from hkshenoy.dhcp.ti.com (hkshenoy.dhcp.ti.com [172.24.235.208]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 5AKCEHDx3636470; Thu, 20 Nov 2025 06:14:44 -0600 From: Harikrishna Shenoy To: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH RESEND v9 4/6] drm/bridge: cadence: cdns-mhdp8546-core: Remove legacy support for connector initialisation in bridge Date: Thu, 20 Nov 2025 17:44:14 +0530 Message-ID: <20251120121416.660781-5-h-shenoy@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251120121416.660781-1-h-shenoy@ti.com> References: <20251120121416.660781-1-h-shenoy@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E9:EE_|DS4PPF9390CCBA1:EE_ X-MS-Office365-Filtering-Correlation-Id: 7520ccc8-c74e-4efb-e47c-08de282e6882 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|36860700013|82310400026|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QDLZ9KFV3BjZl34OMhtynz4GJxv0sWKhoovA3YxaomBPvSsrgJu+rkB2a3Nj?= =?us-ascii?Q?rIS7/ohkvWHVDzpBYGZe3lm+n0cBbdORdMKCwF2l4FuVJAYY24a6Q8oB3Jxo?= =?us-ascii?Q?kmieHddJOeKQf7DGPQxHmyyrV4pd1OP0pmp0wU6+1BRkhSo73SKqiXD2u4AB?= =?us-ascii?Q?B43URfPk6yJTDKd9geHUFYNayxTVSh5ItZlqZyjEy/RDijlR1HG3T8+FTmXx?= =?us-ascii?Q?D2MG5jEO+1pwr3E3Tr/NA9f2e+m3zLxE1eJOMPOevI+7ErGZZMhR/i5prUzq?= =?us-ascii?Q?BtT6nzGbv6daR43rAJgVTk1N+bqIlbGuaosk7GLF+wfcK0ybyCyO5IDfXNsa?= =?us-ascii?Q?4EId+iqLtnEviRx+vBW2BnZXSy86qKcvDwB2YVoTJR1DgzdQGWpDHpuuVKPF?= =?us-ascii?Q?cdo1lYxUOn+hulMT3HkMBKB50PBaqRAoU5j705fkkbx1Kndbye9fVeoPt7sR?= =?us-ascii?Q?9hL15qo0hpe3fvR6qqFWAe5pIoTIwG4Sswm4fsTXjk8ceYT0aZuxV8BaUZVP?= =?us-ascii?Q?UNqMTBKc+VZqdkhkEzwnkEsKgVdMqDDOQaOJufrTBzh/2sf1TC6taaIydkyG?= =?us-ascii?Q?w1VCCIOyGhkwPq9uyKSg36Mg/SNsvLq2O7ZGCWojVUUZmZzAzkZOzgxpt3F9?= =?us-ascii?Q?PcgkL6sWiCAUneeS4Cz3ImzMsFXlLPfJVbIVYAe6bDrR0mjPBXj/GTqTnh9y?= =?us-ascii?Q?nUNbWtHSye2xJJ1HzIkNUlHDV10MdMqJSUHBg9bewFAI82o26dr2hbUUU4yG?= =?us-ascii?Q?jPF9u9vFsc3eauWUu7Rmw8fpMVQCpfC22tH4YDorat4TfTmfrlKxcNvTK0h3?= =?us-ascii?Q?0CorcJyr2yZPkDPcjdKiM6JSgNh4U8mkIFNGti4swR5mJhkgyJhUb2etRFlm?= =?us-ascii?Q?UGL23SLycp1taj8+HRHRzrwu4tcpcYRQItBaIqfpP7ipWcAoiL950EHt20zh?= =?us-ascii?Q?ZM5EhS6QyE2CUC33fpM9Wvzb3s7JZAsOGiYEHORob3jZZwDEz5/OzUWeVyJJ?= =?us-ascii?Q?CfHh75tz7TV0NFvSUNKBPxqcrGjFXk2/sQA/fVEwBAiakmgMj0XubSLZP3+y?= =?us-ascii?Q?WDqqg2UvVduIFZwAMOlmBEHGsOc2IFCn+R4x5yRTKGsxw53+EPnsxeWYGNSd?= =?us-ascii?Q?da/s1Fb4UXJfpn8CH5FH3LMcEN0Y6cbv1LESsO9eUyeiUu2tqdNGS0PRY8TA?= =?us-ascii?Q?2s+Pp/lVmn19dwoh5cuZHuJSJNdzykbx7IvaGX7hMUPjxNX5qPmcEKVkgASJ?= =?us-ascii?Q?HQb4Bjq34R2FmFWdqTVC4GgYCA1efF3HuokBzg0GNykt6mc9XIyit1dxoraN?= =?us-ascii?Q?Qc9ny26O/CEzW2OQMkCCc4iIV7aOqEz6bo3D3tQhjkxkhWtw/OTqYRdwEW7Q?= =?us-ascii?Q?an5FvUCCU1azdkO5Bmdt4B4Uf2XLpi0GrjACteVTE3BYHctBL2IOmZf7kVcA?= =?us-ascii?Q?8yrJsnSr4Rq/mGOVYC36BOE11RDAvNp5Smi3KHtPR+uAwLhS+plyoiPsb207?= =?us-ascii?Q?5PZrBq/SQNmn049nqrxezBOzISWXlieBcZoMpVkCU1QA6bDuuMApHHSZM1K8?= =?us-ascii?Q?7YuhmWuyHaRwRxyPT2oDEU9uqd7Lrt5v5yKkSF7F?= X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(36860700013)(82310400026)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 12:14:51.9524 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7520ccc8-c74e-4efb-e47c-08de282e6882 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E9.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PPF9390CCBA1 Content-Type: text/plain; charset="utf-8" From: Jayesh Choudhary Now that we have DRM_BRIDGE_ATTACH_NO_CONNECTOR framework, remove the connector initialisation code as that piece of code is not called if DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is used. Only TI K3 platforms consume this driver and tidss (their display controller) has this flag set. So this legacy support can be dropped. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jayesh Choudhary Signed-off-by: Harikrishna Shenoy --- .../drm/bridge/cadence/cdns-mhdp8546-core.c | 188 +----------------- 1 file changed, 10 insertions(+), 178 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/= gpu/drm/bridge/cadence/cdns-mhdp8546-core.c index d944095da4722..816d5d87b45fe 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c @@ -739,12 +739,8 @@ static void cdns_mhdp_fw_cb(const struct firmware *fw,= void *context) spin_lock(&mhdp->start_lock); bridge_attached =3D mhdp->bridge_attached; spin_unlock(&mhdp->start_lock); - if (bridge_attached) { - if (mhdp->connector_ptr && mhdp->connector_ptr->dev) - drm_kms_helper_hotplug_event(mhdp->bridge.dev); - else - drm_bridge_hpd_notify(&mhdp->bridge, cdns_mhdp_detect(mhdp)); - } + if (bridge_attached) + drm_bridge_hpd_notify(&mhdp->bridge, cdns_mhdp_detect(mhdp)); } =20 static int cdns_mhdp_load_firmware(struct cdns_mhdp_device *mhdp) @@ -1444,56 +1440,6 @@ static const struct drm_edid *cdns_mhdp_edid_read(st= ruct cdns_mhdp_device *mhdp, return drm_edid_read_custom(connector, cdns_mhdp_get_edid_block, mhdp); } =20 -static int cdns_mhdp_get_modes(struct drm_connector *connector) -{ - struct cdns_mhdp_device *mhdp =3D connector_to_mhdp(connector); - const struct drm_edid *drm_edid; - int num_modes; - - if (!mhdp->plugged) - return 0; - - drm_edid =3D cdns_mhdp_edid_read(mhdp, connector); - - drm_edid_connector_update(connector, drm_edid); - - if (!drm_edid) { - dev_err(mhdp->dev, "Failed to read EDID\n"); - return 0; - } - - num_modes =3D drm_edid_connector_add_modes(connector); - drm_edid_free(drm_edid); - - /* - * HACK: Warn about unsupported display formats until we deal - * with them correctly. - */ - if (connector->display_info.color_formats && - !(connector->display_info.color_formats & - mhdp->display_fmt.color_format)) - dev_warn(mhdp->dev, - "%s: No supported color_format found (0x%08x)\n", - __func__, connector->display_info.color_formats); - - if (connector->display_info.bpc && - connector->display_info.bpc < mhdp->display_fmt.bpc) - dev_warn(mhdp->dev, "%s: Display bpc only %d < %d\n", - __func__, connector->display_info.bpc, - mhdp->display_fmt.bpc); - - return num_modes; -} - -static int cdns_mhdp_connector_detect(struct drm_connector *conn, - struct drm_modeset_acquire_ctx *ctx, - bool force) -{ - struct cdns_mhdp_device *mhdp =3D connector_to_mhdp(conn); - - return cdns_mhdp_detect(mhdp); -} - static u32 cdns_mhdp_get_bpp(struct cdns_mhdp_display_fmt *fmt) { u32 bpp; @@ -1547,115 +1493,6 @@ bool cdns_mhdp_bandwidth_ok(struct cdns_mhdp_device= *mhdp, return true; } =20 -static -enum drm_mode_status cdns_mhdp_mode_valid(struct drm_connector *conn, - const struct drm_display_mode *mode) -{ - struct cdns_mhdp_device *mhdp =3D connector_to_mhdp(conn); - - mutex_lock(&mhdp->link_mutex); - - if (!cdns_mhdp_bandwidth_ok(mhdp, mode, mhdp->link.num_lanes, - mhdp->link.rate)) { - mutex_unlock(&mhdp->link_mutex); - return MODE_CLOCK_HIGH; - } - - mutex_unlock(&mhdp->link_mutex); - return MODE_OK; -} - -static int cdns_mhdp_connector_atomic_check(struct drm_connector *conn, - struct drm_atomic_state *state) -{ - struct cdns_mhdp_device *mhdp =3D connector_to_mhdp(conn); - struct drm_connector_state *old_state, *new_state; - struct drm_crtc_state *crtc_state; - u64 old_cp, new_cp; - - if (!mhdp->hdcp_supported) - return 0; - - old_state =3D drm_atomic_get_old_connector_state(state, conn); - new_state =3D drm_atomic_get_new_connector_state(state, conn); - old_cp =3D old_state->content_protection; - new_cp =3D new_state->content_protection; - - if (old_state->hdcp_content_type !=3D new_state->hdcp_content_type && - new_cp !=3D DRM_MODE_CONTENT_PROTECTION_UNDESIRED) { - new_state->content_protection =3D DRM_MODE_CONTENT_PROTECTION_DESIRED; - goto mode_changed; - } - - if (!new_state->crtc) { - if (old_cp =3D=3D DRM_MODE_CONTENT_PROTECTION_ENABLED) - new_state->content_protection =3D DRM_MODE_CONTENT_PROTECTION_DESIRED; - return 0; - } - - if (old_cp =3D=3D new_cp || - (old_cp =3D=3D DRM_MODE_CONTENT_PROTECTION_DESIRED && - new_cp =3D=3D DRM_MODE_CONTENT_PROTECTION_ENABLED)) - return 0; - -mode_changed: - crtc_state =3D drm_atomic_get_new_crtc_state(state, new_state->crtc); - crtc_state->mode_changed =3D true; - - return 0; -} - -static const struct drm_connector_helper_funcs cdns_mhdp_conn_helper_funcs= =3D { - .detect_ctx =3D cdns_mhdp_connector_detect, - .get_modes =3D cdns_mhdp_get_modes, - .mode_valid =3D cdns_mhdp_mode_valid, - .atomic_check =3D cdns_mhdp_connector_atomic_check, -}; - -static const struct drm_connector_funcs cdns_mhdp_conn_funcs =3D { - .fill_modes =3D drm_helper_probe_single_connector_modes, - .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, - .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, - .reset =3D drm_atomic_helper_connector_reset, - .destroy =3D drm_connector_cleanup, -}; - -static int cdns_mhdp_connector_init(struct cdns_mhdp_device *mhdp) -{ - u32 bus_format =3D MEDIA_BUS_FMT_RGB121212_1X36; - struct drm_connector *conn =3D &mhdp->connector; - struct drm_bridge *bridge =3D &mhdp->bridge; - int ret; - - conn->polled =3D DRM_CONNECTOR_POLL_HPD; - - ret =3D drm_connector_init(bridge->dev, conn, &cdns_mhdp_conn_funcs, - DRM_MODE_CONNECTOR_DisplayPort); - if (ret) { - dev_err(mhdp->dev, "Failed to initialize connector with drm\n"); - return ret; - } - - mhdp->connector_ptr =3D conn; - drm_connector_helper_add(conn, &cdns_mhdp_conn_helper_funcs); - - ret =3D drm_display_info_set_bus_formats(&conn->display_info, - &bus_format, 1); - if (ret) - return ret; - - ret =3D drm_connector_attach_encoder(conn, bridge->encoder); - if (ret) { - dev_err(mhdp->dev, "Failed to attach connector to encoder\n"); - return ret; - } - - if (mhdp->hdcp_supported) - ret =3D drm_connector_attach_content_protection_property(conn, true); - - return ret; -} - static int cdns_mhdp_attach(struct drm_bridge *bridge, struct drm_encoder *encoder, enum drm_bridge_attach_flags flags) @@ -1672,9 +1509,11 @@ static int cdns_mhdp_attach(struct drm_bridge *bridg= e, return ret; =20 if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) { - ret =3D cdns_mhdp_connector_init(mhdp); - if (ret) - goto aux_unregister; + ret =3D -EINVAL; + dev_err(mhdp->dev, + "Connector initialisation not supported in bridge_attach %d\n", + ret); + goto aux_unregister; } =20 spin_lock(&mhdp->start_lock); @@ -2414,17 +2253,10 @@ static void cdns_mhdp_hpd_work(struct work_struct *= work) struct cdns_mhdp_device *mhdp =3D container_of(work, struct cdns_mhdp_device, hpd_work); - int ret; =20 - ret =3D cdns_mhdp_update_link_status(mhdp); - if (mhdp->connector_ptr && mhdp->connector_ptr->dev) { - if (ret < 0) - schedule_work(&mhdp->modeset_retry_work); - else - drm_kms_helper_hotplug_event(mhdp->bridge.dev); - } else { - drm_bridge_hpd_notify(&mhdp->bridge, cdns_mhdp_detect(mhdp)); - } + cdns_mhdp_update_link_status(mhdp); + + drm_bridge_hpd_notify(&mhdp->bridge, cdns_mhdp_detect(mhdp)); } =20 static int cdns_mhdp_probe(struct platform_device *pdev) --=20 2.34.1 From nobody Tue Dec 2 02:06:43 2025 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012070.outbound.protection.outlook.com [52.101.43.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25FF533438D for ; Thu, 20 Nov 2025 12:15:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640906; cv=fail; b=pCDyOSp7Fyw4G9CKd+noPS8f7e4/kXOB1+tYkrsh8u8v5SmDVB9oHGZ/5ZUpzEoyiV4ujiFrd8jAk8yJf8Sz9guPFq9btuYgB6MacIEsXvjUQ4CYUH8knXysl7D7JnHCBdEPp7zN1lNkpqytvdDL27uUpo2cbc167yCjtxSqQV8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640906; c=relaxed/simple; bh=L5AoO5pXadq35mgHz8qvQtSl2+lYUSYGThNBDCHLp0U=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=b9cxwA2SeF3+Q/ePzeSXySJVxxExeZyajU/8uqSIXWBZYWKmiRqcpTWZEAYYo7oOOOncZluqnp37JF4+XtVpBrLQJY/53PhlXW/uMF3LxhNramivrvIh3fTv6GVss8Y3LD84llwPIpqckoN6PnADrYIkZqy7+MNSPKeQYmfEuT0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=jmCbvV9t; arc=fail smtp.client-ip=52.101.43.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="jmCbvV9t" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PNrN3OZ+OOTMTovmmHBslqrCjuNLto+ZIlT3Zr+TvpH/15w357BVv/zkE1poFdhJ5bMkzlN6A8tjTCfwmFml2PoTkhQzo4J9BGe5HboeaH9e8RPXLbtbLksvEDKWutQlpvMrpZbI6iCRv2jCqoHx+tqSFTPoXJfgPV2ZeXMhDHyBlzCG7LNccX8ZlL4FkRR/RDtxIm7B1NN/+Ex5UovR1MF+xP3xSq5TYiEwZuiwZ+l9LRqggbISxJ8QqiDOyvNC+0YVFHVEB/JEyUobmp8+inyv12o2SbpP5rGxgaVRB9FvYsE+BtDxLXbm4lZRkPV8Ux6d+RTSxd1/8UGTQEefiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WfH7D/FxOe2/RsbcUSJmS6zsrpWA1R4j3g8WDzsspOQ=; b=Qo21FVGWtoIki4zy/TJTueVc9hMzNSs+Kt1H6YLERyYx+4Rfp4dLMFkY10mpbivSS6DY4TBSsBPdgQ5nh//0db7I3UA1uOrgcQdvnqCYkyXjFiC1+BBrT7dOXNFX88jTB+oKcOLuHfoW9PUN+XTtrCxLvinO5/1s7OZh6jcd33Xtd4NQEGfA/7BZtr374cBP/2a89MVf81FfTy4qu7UdKohWJTwEgJu0wP0nTleD4fVHp1ZZNQmWhyz539hxz9RGQ3TXjJeooG+zJFu8mJhBWdxPcW8zFoSgCn3xFyXlrHNq7hDbh1fAtpEcIm57ZYKa5gYWrm9LM1rexVAqwm65fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=suse.de smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WfH7D/FxOe2/RsbcUSJmS6zsrpWA1R4j3g8WDzsspOQ=; b=jmCbvV9t7UvBUMtzRG2rFMMuqeNBGy+vaUw6KzDhygRhw5QShwsfXM3TMAtwqhKltfIeiue9bZ1HCGggKH6OJX5n95hdkn6lLRoto865lVxTAToJA6LHlVlpDVopvvAjDk9+NpygkME3vd2QJ0lAbHh7merv2xY4i+xFA/LatS0= Received: from DS7PR05CA0089.namprd05.prod.outlook.com (2603:10b6:8:56::6) by CY8PR10MB6907.namprd10.prod.outlook.com (2603:10b6:930:86::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.11; Thu, 20 Nov 2025 12:15:00 +0000 Received: from DS3PEPF0000C381.namprd04.prod.outlook.com (2603:10b6:8:56:cafe::4a) by DS7PR05CA0089.outlook.office365.com (2603:10b6:8:56::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9366.4 via Frontend Transport; Thu, 20 Nov 2025 12:14:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by DS3PEPF0000C381.mail.protection.outlook.com (10.167.23.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 12:15:00 +0000 Received: from DLEE207.ent.ti.com (157.170.170.95) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 06:14:57 -0600 Received: from DLEE214.ent.ti.com (157.170.170.117) by DLEE207.ent.ti.com (157.170.170.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 06:14:57 -0600 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE214.ent.ti.com (157.170.170.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 20 Nov 2025 06:14:57 -0600 Received: from hkshenoy.dhcp.ti.com (hkshenoy.dhcp.ti.com [172.24.235.208]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 5AKCEHE03636470; Thu, 20 Nov 2025 06:14:51 -0600 From: Harikrishna Shenoy To: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH RESEND v9 5/6] cadence: cdns-mhdp8546*: Change drm_connector from structure to pointer Date: Thu, 20 Nov 2025 17:44:15 +0530 Message-ID: <20251120121416.660781-6-h-shenoy@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251120121416.660781-1-h-shenoy@ti.com> References: <20251120121416.660781-1-h-shenoy@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C381:EE_|CY8PR10MB6907:EE_ X-MS-Office365-Filtering-Correlation-Id: 1644920f-a861-41e2-9d1f-08de282e6dba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|7416014|376014|82310400026|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?c95zxxJN03Xp8JC5qNKWrOH2fdPjgajxMO0O9/Fa7eDW5lDZZg1dNoSY0G4Z?= =?us-ascii?Q?33/l7lOVSjTwY6bMDgRn6zdKp8X2842TameInOqPiMCLnBNCDRrRjHDYj4Cn?= =?us-ascii?Q?xyp+iLYkZ3JHUNFEMiHZDmGClnE7Olf8uOU2matC/iWYY28Z1/gyzGwfG50+?= =?us-ascii?Q?ZK+sWkHI43fdx+Sv69acs/mUabKKG5hyWyJDmNobJu7o8B6D31TM/9IxW2v4?= =?us-ascii?Q?+9NaZbGQw9pRDj/ssg8vZTo5lFRc6exMgtjY99yDto4wMJPEg4g7zcdTF65R?= =?us-ascii?Q?dJTY5Go0Blv9g4Vkmj/EM81tFgbelOwT48+jMDk9ccLU/oBJmS6mLujTwOUl?= =?us-ascii?Q?UgCH4KzZ8aBsHI+BENN37BlOVQVUoVBw+nVhGGRDqA+m1mKARqY7EGBBhy68?= =?us-ascii?Q?zjlk28Y5uTJebPwvwZ1Vva1HcLFsoJFxToq2EsRZsAT/6Wvnj+zyxxWlQRkN?= =?us-ascii?Q?Qrg5vcDqFrM3TT0FhWvoReL9Wt4JRKDuLz91Swsse71QoLlfsaxyZja9+Kgl?= =?us-ascii?Q?kQOm8zlcadlYmXp/y6ho7v/3w8cHmtTTOYoH80P0G7ZP8bIyEXeMKWw/4mQZ?= =?us-ascii?Q?ijjAzM8V5AR6rDEuLWbQfoxkQsIY31j+LWW+XrwE0+7VCk+5zvLEKMeTn/Xr?= =?us-ascii?Q?mO0FcXiszFLFTotzFpvm62lM5RdIYmmFC8D21h+I+IJ8z9Yfxt5iyIN51EvM?= =?us-ascii?Q?WUa6lR6/vNwOLqxJRD5Tufgvf5IckokL3gvnyRhE1Nk59awKXAfKOmscb3B4?= =?us-ascii?Q?69beltIOlawZcuMpw5UzYI5ocG8P0KwWrKkjE/SAxKgvQd+oi7hTF1hHJuaQ?= =?us-ascii?Q?FcBScroSdQYorlm76L6b/Iq4odHaEMq9pWt6byF6aXCW7XoEABNDlE4wxWA7?= =?us-ascii?Q?3yJCzGJpJDNDqQBw++B+79Qr1MqpP0Kj4SoGWl8puGzjpIqYdBJQlNpyX/s3?= =?us-ascii?Q?X6kSIzgKNjJ4IOPvPL3FhgQ36ISOHq1Z2T374yCXSeNOEKaed01KeIp4/XTt?= =?us-ascii?Q?/L+7c3YAB9ev6RbRcBvj52AMGPlw5JeT806oK1OyGKSL0fiJ2TafXHpyE8MN?= =?us-ascii?Q?FYdq6pgGIr7y+AbOmgQYgbk/UuVWic9rgqQRN7xQjIfXDGI6FdRNRcXCC1ip?= =?us-ascii?Q?4m9t8YrKOj3xugygIIHQppJl+BiRjQYhw1OGqk9pIFxgEJdo6FHQnlC61461?= =?us-ascii?Q?7BalyGDFhAbkKkipz3J9b5tmVPsqpf+Z/IBUUoz0HaRhCzETgSelZfZtZeOq?= =?us-ascii?Q?1R3UjMjdxwRqWyYF3Pzs4fKYjd+SOarV2fVISMmSurO/sv3TD1mLr/1V6Y5o?= =?us-ascii?Q?PesFAOF1DOah0VD2FRHcNUswK/MbfyAfQ2VdpKANdWWApvc3FIv/iGiDZIVm?= =?us-ascii?Q?ybBEQPpYTQ667w5moB6uydZddZnY8i6n4kKf8CCNABtLzzIiyDCM5RHtkPzn?= =?us-ascii?Q?vMETOwLmldxzwaYzUQOm0b+Z5hyVAXJwWx5bJZV9rO7pt1zEvu+n+s4+NARb?= =?us-ascii?Q?qjxcKjRwcso+EgjxspuGPkFxxGCRz9rjfPoI67/o8tMf+4MMsk7oAnRjeinN?= =?us-ascii?Q?j2rtbRr/tMKp4Ha5QfWxpkp9FBBTOMRFcuRAHMmD?= X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(7416014)(376014)(82310400026)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 12:15:00.6985 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1644920f-a861-41e2-9d1f-08de282e6dba X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C381.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6907 Content-Type: text/plain; charset="utf-8" After enabling DRM_BRIDGE_ATTACH_NO_CONNECTOR flag, mhdp->connector is not initialised during bridge_attach(). The connector is however required in few driver calls like cdns_mhdp_hdcp_enable() and cdns_mhdp_modeset_retry_fn().Now that we have dropped the legacy code which became redundant with introduction of DRM_BRIDGE_ATTACH_NO_CONNECTOR usecase in driver,we can cleanly switch to drm_connector pointer instead of structure. Set it in bridge_enable() and clear it in bridge_disable(), and make appropriate changes. This allows us to dynamically set the reference in bridge_enable() when the connector becomes available and clear it in bridge_disable(). This change is necessary to properly integrate with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag set while maintaining all connector-dependent functionality in the driver. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jayesh Choudhary Signed-off-by: Harikrishna Shenoy --- .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 14 +++++++------- .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.h | 3 +-- .../gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c | 16 ++++++++-------- 3 files changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/= gpu/drm/bridge/cadence/cdns-mhdp8546-core.c index 816d5d87b45fe..002b4be3de674 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c @@ -1765,12 +1765,12 @@ static void cdns_mhdp_atomic_enable(struct drm_brid= ge *bridge, =20 mutex_lock(&mhdp->link_mutex); =20 - mhdp->connector_ptr =3D drm_atomic_get_new_connector_for_encoder(state, - bridge->encoder); - if (WARN_ON(!mhdp->connector_ptr)) + mhdp->connector =3D drm_atomic_get_new_connector_for_encoder(state, + bridge->encoder); + if (WARN_ON(!mhdp->connector)) goto out; =20 - conn_state =3D drm_atomic_get_new_connector_state(state, mhdp->connector_= ptr); + conn_state =3D drm_atomic_get_new_connector_state(state, mhdp->connector); if (WARN_ON(!conn_state)) goto out; =20 @@ -1869,7 +1869,7 @@ static void cdns_mhdp_atomic_disable(struct drm_bridg= e *bridge, if (mhdp->info && mhdp->info->ops && mhdp->info->ops->disable) mhdp->info->ops->disable(mhdp); =20 - mhdp->connector_ptr =3D NULL; + mhdp->connector =3D NULL; mutex_unlock(&mhdp->link_mutex); } =20 @@ -1964,7 +1964,7 @@ static int cdns_mhdp_atomic_check(struct drm_bridge *= bridge, const struct drm_display_mode *mode =3D &crtc_state->adjusted_mode; struct drm_connector_state *old_state, *new_state; struct drm_atomic_state *state =3D crtc_state->state; - struct drm_connector *conn =3D mhdp->connector_ptr; + struct drm_connector *conn =3D mhdp->connector; u64 old_cp, new_cp; =20 mutex_lock(&mhdp->link_mutex); @@ -2179,7 +2179,7 @@ static void cdns_mhdp_modeset_retry_fn(struct work_st= ruct *work) =20 mhdp =3D container_of(work, typeof(*mhdp), modeset_retry_work); =20 - conn =3D mhdp->connector_ptr; + conn =3D mhdp->connector; =20 /* Grab the locks before changing connector property */ mutex_lock(&conn->dev->mode_config.mutex); diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h b/drivers/= gpu/drm/bridge/cadence/cdns-mhdp8546-core.h index a76775c768956..b297db53ba283 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.h @@ -375,8 +375,7 @@ struct cdns_mhdp_device { */ struct mutex link_mutex; =20 - struct drm_connector connector; - struct drm_connector *connector_ptr; + struct drm_connector *connector; struct drm_bridge bridge; =20 struct cdns_mhdp_link link; diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c b/drivers/= gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c index 5ac2fad2f0078..1d433ad3fe878 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c @@ -393,9 +393,9 @@ static int _cdns_mhdp_hdcp_disable(struct cdns_mhdp_dev= ice *mhdp) { int ret; =20 - if (mhdp->connector_ptr) { + if (mhdp->connector) { dev_dbg(mhdp->dev, "[%s:%d] HDCP is being disabled...\n", - mhdp->connector_ptr->name, mhdp->connector_ptr->base.id); + mhdp->connector->name, mhdp->connector->base.id); } =20 ret =3D cdns_mhdp_hdcp_set_config(mhdp, 0, false); @@ -445,10 +445,10 @@ static int cdns_mhdp_hdcp_check_link(struct cdns_mhdp= _device *mhdp) if (!ret && hdcp_port_status & HDCP_PORT_STS_AUTH) goto out; =20 - if (mhdp->connector_ptr) { + if (mhdp->connector) { dev_err(mhdp->dev, "[%s:%d] HDCP link failed, retrying authentication\n", - mhdp->connector_ptr->name, mhdp->connector_ptr->base.id); + mhdp->connector->name, mhdp->connector->base.id); } =20 ret =3D _cdns_mhdp_hdcp_disable(mhdp); @@ -494,16 +494,16 @@ static void cdns_mhdp_hdcp_prop_work(struct work_stru= ct *work) struct drm_device *dev =3D NULL; struct drm_connector_state *state; =20 - if (mhdp->connector_ptr) - dev =3D mhdp->connector_ptr->dev; + if (mhdp->connector) + dev =3D mhdp->connector->dev; =20 if (!dev) return; =20 drm_modeset_lock(&dev->mode_config.connection_mutex, NULL); mutex_lock(&mhdp->hdcp.mutex); - if (mhdp->connector_ptr && mhdp->hdcp.value !=3D DRM_MODE_CONTENT_PROTECT= ION_UNDESIRED) { - state =3D mhdp->connector_ptr->state; + if (mhdp->connector && mhdp->hdcp.value !=3D DRM_MODE_CONTENT_PROTECTION_= UNDESIRED) { + state =3D mhdp->connector->state; state->content_protection =3D mhdp->hdcp.value; } mutex_unlock(&mhdp->hdcp.mutex); --=20 2.34.1 From nobody Tue Dec 2 02:06:43 2025 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012008.outbound.protection.outlook.com [52.101.48.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E1D42F5A2B for ; Thu, 20 Nov 2025 12:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.8 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640916; cv=fail; b=HAYOT9HIa13aBW1DXuWxbm47c4xNFQOn0ymYttraWKoMoEjuLso3NlWNoptNQ0TvLDfz5eFvKedJecUniLKu6qrccUw8BfRLkvUDgYZNhswZZdgNLZ2ml2To0l66vYgfhYaQXNoqj65An9P4D6BEVTiXMQ1tlRkEGMDCAKJjqhw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763640916; c=relaxed/simple; bh=YTpjdz1KH6ot2WDVgd++eY1JwNhxTachrQ8MxEXj9mk=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nkfnOyRA2IRVpjj7R5oRlpHwkRFgPAPYx3fiGOvwZooFAU7DK4C5daz6iwHmwK1WD3yLcsClJkiDpCVdfJUIdRFZ6O/iKz33n8opo59ODanoGQ5gRPQOcvtO7XAKyIiKvnO/M6mqEhG1+kxJ2scUMnyR4yz+mO5EpITa/Zm2WTo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=RkOqRpk6; arc=fail smtp.client-ip=52.101.48.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="RkOqRpk6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F1P3EblJ4nckn0snUeCqFS/P5HNW8OFX+X9EDpD3fU2fWpEA/G1sSwMl0ebDboB66jCDvZW3GwzMQnWutl20t068VHmxzbiDKZMgdWzjvLoc4BPMFwcEJFE/PSgC7fPwScNibUUlf82B/jhwQYYmyPuYjQ5TByv2C7sqJH5PwdLsupxIyPQA40UDT0P/5EUdJXlwMhJrV6VH0Wuz0n6rQvxc/porLtwocosYyDmGWsN9PpE+zwTvtkcA/4A9E/pdv6PKHvFMsq3lfwmgm4TXZ0Qp6LzVqeIQy5ZMJVtkjfvtelsstv87h/8tTng7lHBeLfEMeNmKpMxRXKtIo1H+OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zo2yAB64mQbhFoNPbrHpiXafZf3Ft4t6a6E+Q3vDpws=; b=MYvANYXcocWb4GOGUWRZempFuL9lZpcsZ3+jSupgjoUc25+/r2XievgO9U9c7IgSn4xEFxzp2L6DYmJATvMaqEuLoRy420OmQylILIXXCNHWJ2mhs29Ntf21ZKEvIaNbcm4RkbTfZ3nPFo2eRH12dRtZw7wkdk80iNctIqpfRzc5sWL4x1UP1cdL8UdBLz/sWW5LW5BxX+s/9J3RK4P1R0Ulo4fwqeV4tlVhGGguY469PNOpxvTNZdRwY0Q9WJ5+nQypILt/mDwORtZZnWUDI78sDphI8+PlHSjH1nbpPva7BbGb9l9cSoemzY9U0yjwA7IjCU9ehW18IpLkFh+zdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=suse.de smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zo2yAB64mQbhFoNPbrHpiXafZf3Ft4t6a6E+Q3vDpws=; b=RkOqRpk67WC8Vx83HVxoInahR1LMQp0SqWqZ7VVZxzZsiCDrs6MYBUD/HWpNKkm5kFHNJ61ToZT+VBnAmJKSPc+4duQTKsHwMpP3xNql/2hAZczVqQoy9FRplG8p31qdUpO8sw3+KHqOHdTMxIgghu/dgjgr/oa/BNThV64/spE= Received: from MN2PR06CA0014.namprd06.prod.outlook.com (2603:10b6:208:23d::19) by IA1PR10MB7334.namprd10.prod.outlook.com (2603:10b6:208:3fc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Thu, 20 Nov 2025 12:15:11 +0000 Received: from BL02EPF0002992E.namprd02.prod.outlook.com (2603:10b6:208:23d:cafe::51) by MN2PR06CA0014.outlook.office365.com (2603:10b6:208:23d::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.11 via Frontend Transport; Thu, 20 Nov 2025 12:15:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by BL02EPF0002992E.mail.protection.outlook.com (10.167.249.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 12:15:11 +0000 Received: from DLEE205.ent.ti.com (157.170.170.85) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 06:15:04 -0600 Received: from DLEE208.ent.ti.com (157.170.170.97) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 20 Nov 2025 06:15:03 -0600 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE208.ent.ti.com (157.170.170.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 20 Nov 2025 06:15:03 -0600 Received: from hkshenoy.dhcp.ti.com (hkshenoy.dhcp.ti.com [172.24.235.208]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 5AKCEHE13636470; Thu, 20 Nov 2025 06:14:57 -0600 From: Harikrishna Shenoy To: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH RESEND v9 6/6] drm/bridge: cadence: cdns-mhdp8546-core: Reduce log level for DPCD read/write Date: Thu, 20 Nov 2025 17:44:16 +0530 Message-ID: <20251120121416.660781-7-h-shenoy@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251120121416.660781-1-h-shenoy@ti.com> References: <20251120121416.660781-1-h-shenoy@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0002992E:EE_|IA1PR10MB7334:EE_ X-MS-Office365-Filtering-Correlation-Id: c0ea5cf5-69b0-45a6-845e-08de282e73fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|82310400026|36860700013|1800799024|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Rzd2XXoBJqrFymC6zNPxHVL4kR7cxUS2HatR4canFEknDhdsUS6yoAmFiQGg?= =?us-ascii?Q?thd5UdqZDyOzNph9MRUFcVwbQnCyhBVwo79aJhwgMLRfn1UQB6VZ2O+qK6AF?= =?us-ascii?Q?9EizNcX5neVyvgUOWNqDdzvpOis0XGESq258XsBhw9SbqtICE4Y1FwDZlRb9?= =?us-ascii?Q?HSonvTpcAbaWwp5+tYTAixwVgTubMqYN/hRm6xaZo3AAh4I6bcgE9xFgYbZk?= =?us-ascii?Q?jx1Xm2hgSmdCmVlPiZbOoIwiSM2s0FUmDDiRMz8Vy015Muz2RDYkOg17s5Bk?= =?us-ascii?Q?4XDVTyDOQ825Ir3zmLmRJ4Icsh6YHY+kMDtKLsPV8MeZU4gWns6fNHnsyeSr?= =?us-ascii?Q?ScfJkswAJyYMiXT5+5o35AAWG/jSVRToJ0vemIQCs+V0jzt+azyadYjA1Znj?= =?us-ascii?Q?eW7YGkSfFrpmrQ/GAz6gvtL1Qj/yrIYqn4Y46OLGRVc1eGbkjLUbrnyxoPR0?= =?us-ascii?Q?KcR3+NxvJT/JzKLcpUlHNad8G5zHQAF8omnM9Q++6lvQqrRn1t7KV8f5mRsD?= =?us-ascii?Q?MfbEGvMVM8gkzMciEveDFSaydCJH/W8gvuPwILKPXCX6fFfXV0/CKQC3HSsa?= =?us-ascii?Q?WHl77cAWv69MPQnyTWkYZWbEXROClL1mhNTnMMX8L9ZgJayHf9KvAr5Pf7iz?= =?us-ascii?Q?95g3XJazCVCzHATLiTaoKlfnRXX440RwOEVLw2TxN2ykfJ5qEWAPmAwRFC+j?= =?us-ascii?Q?5JwOVHoVmPDT20/enGlJuu7ROQ17D4m4NX5JSr8eo2aSxSz8fnLOq63xuI9R?= =?us-ascii?Q?q4BcXdUJ8rTrvH2+wmRR/nrv8by6r/kwBi9xrDRMz8hxQUXdWUdVJlQmN7tu?= =?us-ascii?Q?hC3oEC225F5EuZSOUbdjzsfLj8WDrPQ0FTgS2VohfZiySyE2gbSSf409BVIP?= =?us-ascii?Q?4to+fdogTHib0YG/llqbCiBaUNUYrn5zXpCgm1sK3WE8sjPjTnS/FSS3+S3f?= =?us-ascii?Q?rPsTUzSaQcYUpWYz0pOoDReo3PVWIPLZa5a+Mzi3Nk/kF4xlH71joZK3iyEX?= =?us-ascii?Q?oNIUJqmMgi6AIj6U3xCbGEx0w9BGrc2xJ0Qz9h6Fyk1ecKWrq1gEHLWjn56t?= =?us-ascii?Q?AfsA8XMMaO2eWYWY3EfM0tKdHdsUAqCduyYkodzcgHD1gaZKvOBKMqZOBdV/?= =?us-ascii?Q?EsWXDUZGIJTSoG1Z9/7zbq/RakVjxoFF8RJnYww7rgOFYlYKtQIwIJppnC+v?= =?us-ascii?Q?Q3WVAchhGocUyAzL7GejzAKSWhaMtDLepcvc/m3nE6/REnlDX4mxTmPVp2tm?= =?us-ascii?Q?NKdEXDJRnDkIEyziJbCXXQkaTLgmqMBPT9CJg/+AIGVD8WNICh81gjVkHu5H?= =?us-ascii?Q?76vtgqiMIWt6wtUyMohlMXmhz6QBDpUDKLP+4sIcru0HUg7jY4ztZeHXuhXI?= =?us-ascii?Q?0VCOZzEY5F0UI1yLV4watCOF5Aygw0s0vSYuzLeI8wwVDdisLwwvA+zGFDGk?= =?us-ascii?Q?NdI03GYz6v7QfV+/GvR8uDokDPToSzaP85o/r3j7SgAmV8Rao9zNFWZ+I4gU?= =?us-ascii?Q?+xu5e17OgvP3z2d86F0cMEhVr6r2U5m11MVebm2OFZP9lrlzzTRddnmpv+Hr?= =?us-ascii?Q?QXQIhywtboBPtqFzqyav9nSq6cvKRK8QQYB4KDhn?= X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(82310400026)(36860700013)(1800799024)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 12:15:11.1423 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0ea5cf5-69b0-45a6-845e-08de282e73fa X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0002992E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7334 Content-Type: text/plain; charset="utf-8" From: Jayesh Choudhary Reduce the log level for cdns_mhdp_dpcd_read and cdns_mhdp_dpcd_write errors in cdns_mhdp_transfer function as in case of failure, there is flooding of these prints along with other indicators like EDID failure logs which are fairly intuitive in themselves rendering these error logs useless. Also, the caller functions for the cdns_mhdp_transfer in drm_dp_helper.c (which calls it 32 times), has debug log level in case transfer fails. So having a superseding log level in cdns_mhdp_transfer seems bad. Reviewed-by: Tomi Valkeinen Signed-off-by: Jayesh Choudhary Signed-off-by: Harikrishna Shenoy --- drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/= gpu/drm/bridge/cadence/cdns-mhdp8546-core.c index 002b4be3de674..120eb7ffe20c0 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c @@ -778,7 +778,7 @@ static ssize_t cdns_mhdp_transfer(struct drm_dp_aux *au= x, if (!ret) continue; =20 - dev_err(mhdp->dev, + dev_dbg(mhdp->dev, "Failed to write DPCD addr %u\n", msg->address + i); =20 @@ -788,7 +788,7 @@ static ssize_t cdns_mhdp_transfer(struct drm_dp_aux *au= x, ret =3D cdns_mhdp_dpcd_read(mhdp, msg->address, msg->buffer, msg->size); if (ret) { - dev_err(mhdp->dev, + dev_dbg(mhdp->dev, "Failed to read DPCD addr %u\n", msg->address); =20 --=20 2.34.1