From nobody Tue Dec 2 02:20:16 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62705326D6B for ; Thu, 20 Nov 2025 08:26:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763627190; cv=none; b=fJBgEi7CFb7rJ6JT5i+muwplUpgIYcyOVIbjaMVGaUC+t2drpjlxIcLXjSmb5EK7SMdVYz8XeGRwE61qWgNB39QwRqIuxIV5mpkmFNI9WPu8lp+wF0hPTQNXA/mhSxTHqyc/FgbORcb+bbFU/UdP1Qk28TNoYSKeeNzYsSqgxv4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763627190; c=relaxed/simple; bh=K/Kx2VbEDfL4oHgE4vCOHbqOhUH6e20qujkg/9y5Ho0=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PrOQuAvipPwABFyzFkOZaJ4ia9sLo+7Ox/gnDUzAEdiuNhgs7QwVMu2kTX0xWFWko6bpNrAsqPwHOFr/5dTYNujAz4WeVfPpZo1p/5/V4KA0pwzaqamvunV59zEOvt0pOM/y6A2zC0Z5p8t4slITMC+S75VLsS1LPcV09/tNknc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=abd/Ko/Z; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="abd/Ko/Z" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-47775fb6c56so5098495e9.1 for ; Thu, 20 Nov 2025 00:26:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1763627187; x=1764231987; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=KGqFACH/HkVCJjUX6Ee9GAnpXzUkKAqrFu9bfRLxaHs=; b=abd/Ko/ZK+iJKfu1T/zNLT1eIA91srp0x/QmgwvcsS25JyLWLnuZQPtqgg5gZO/+vr NkRkM3jlxOrralFT8BULLKYil+FpIBWkAD7aBCA7buPpEOuq0ItyVi+80zbltu/i0XqV 5bhvFoTpIK1SlomwDcILnLmxWO0IH8uVETk+g24NFPfHUUAUm4JHI6IX3n9dDM20ef57 ncA36uq50WjB/uQtMrZVLHQMnaQqWHNJMTDkbUVoqGYtrUT6QW2ecr+LWKi8IUuxBY1p yFVZRDv56MTpED8/jHDyudC6ZcBZNgI5/n7tW7FsVRtn/PKon4rC4QYShtAvwkJkX8mk DrJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763627187; x=1764231987; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=KGqFACH/HkVCJjUX6Ee9GAnpXzUkKAqrFu9bfRLxaHs=; b=kLKERyojMpyGeJdEKgQreSKHsOdG9F9DtM5WVs4UBxNS1WSHoRlswYtLH+wqEglkDO sOlQVewkzqDxmzUAN6IdErzEW8ap92iQ4xhm4ffbPfXK39khGOpc7Xson48WY84zo+jS sJJkNG0gGMwWRVyINKCwd5up0+P7seymriGyKX82HxiTlnV8Ip3NLpj+SATMW0u4jpmP RxpEw2XIRBC60eEB+fryfANab/6uWGxUnkiSR/8dMZHPQyBwNtswUCoJ1kgpHhXUwEEu 0HMxOFyB5vnjyq2aBLi88Th6De6v3zAnzD4UqZ5QWW+Vfte8P+aob3eVzjoQYwsaox6P pzeA== X-Forwarded-Encrypted: i=1; AJvYcCW2eaX/sZuNLAOpIigMCMt7AefWtSscgRF8s2r31Frxx+2tUHjc05254AKM0M9yybR0DSHfXByuS+sqMmw=@vger.kernel.org X-Gm-Message-State: AOJu0YzAiRkwhFX5PTy3QJ9FklUpQ7HPicwawBXsfdbhvy9jx1M20e4a n8LkmDxpmLx6ej1SXvYwCDawXfez57ZsiPGey0rZfGgF6e3nIF0XFik2xhYii2XZKv0= X-Gm-Gg: ASbGnctzfFTrnQSLpg/Vug/lv1FahhbsJxhAOLOQatBlEGFxIsEKobT3B3Gpqoy+ugf X5V3UsMRsd3SpqbTlcUPhaGaVh9hm/luULougRUOfLUMiFI4525eOwp7xDBNnpK+nAIcb/NT1/H r8VQjxqzp9Brym33f2WGCfwZJ6Uw9WTferBYYGt+FR4dJI04FhPoDS9+xEPc0z/2ldDAUMqRAOT vPipOcBGIs84goxDL2T5/jxHrUZDAS9kxmthdMBPu9Yd6IeIZ0oSjexv7pj13COUiT/2/6KRsCB 0eeGzWlnGE/3iVqYIY7hPRHTa8N/PhvaNDXLOjwlW/Vaxwrmelu1cnIv3g3QHYxnQLznHtKDuaP W5pRwikwEN2at4rE6DyeOPR8lFHNgl/19tJHvH9M0Uckf07wzdBlXpUg= X-Google-Smtp-Source: AGHT+IGypkUV/VzoWTzOaqQfFG9GB1sWrnoHEOhRUWD8sKoUwzZ7+2zS/Gxes1QuD0FpTMBaXZHAwQ== X-Received: by 2002:a05:600c:1550:b0:477:b0b9:3131 with SMTP id 5b1f17b1804b1-477b8951fe9mr19532675e9.8.1763627186741; Thu, 20 Nov 2025 00:26:26 -0800 (PST) Received: from localhost ([151.35.219.2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b82cc6c4sm41891105e9.2.2025.11.20.00.26.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 00:26:26 -0800 (PST) From: Francesco Lavra To: Lorenzo Bianconi , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 8/9] iio: imu: st_lsm6dsx: add event spec parameter to iio_chan_spec initializer Date: Thu, 20 Nov 2025 09:26:14 +0100 Message-Id: <20251120082615.3263892-9-flavra@baylibre.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251120082615.3263892-1-flavra@baylibre.com> References: <20251120082615.3263892-1-flavra@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3483; i=flavra@baylibre.com; h=from:subject; bh=K/Kx2VbEDfL4oHgE4vCOHbqOhUH6e20qujkg/9y5Ho0=; b=owEB7QES/pANAwAKAe3xO3POlDZfAcsmYgBpHtB7IN101XbBsRr0amGEISqgWrInYK8eYv6eC OFTgE1sBJmJAbMEAAEKAB0WIQSGV4VPlTvcox7DFObt8TtzzpQ2XwUCaR7QewAKCRDt8TtzzpQ2 X70KC/9MBp24o7acI41gAAgjhCHXoQo1UNiW6xBH7/53rquR2RcFT+6bCrXDaF4D2yVabMOzrsY 6Y4haFqOz/vV/IKlf7yD5scsaaFojUQ/h1g6S5Rm37HQPf1A8pNbTltY+PQgWpx2cUqLc+M2YH2 uEyaPHig4tJW9Yd8yCUiAvEWRG25XU6fM4s87Tw7prx+geagfa/cmqvnljuJYnjPEgfaC7+WBqs 5vkWwmXmihXINVhJN++Ruy7O4FMIatbCzaOOFH9Y4i+C9lL/38h9UNjoCOpEwXW9gVluNta87Nx OvvwX+mM9dkkTjNS5fSZoqCjPjn46kDYThoyXy4I7cG3rDONaGj1E43neZFLovpEgr5kW5yToSj e4MJyp5RpuNCljyhDA2hryXss2Ag/qg4DUHqXvEmQ1LBmgcNGTmjVS5Pe0G0rQhhbI1xAMilXbK +jJ2BBqGKLji/aB5DTN5n+rcb/jEEegKxvVxoqDTV9aUkjBNIoUImNPvAuumb/HS/wlBI= X-Developer-Key: i=flavra@baylibre.com; a=openpgp; fpr=8657854F953BDCA31EC314E6EDF13B73CE94365F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for adding support for more event sources, add to the ST_LSM6DSX_CHANNEL_ACC() iio_chan_spec initializer macro an iio_event_spec array argument, so that this macro can be used with different arrays by sensors that support different event sources; change the st_lsm6dsx_event struct declaration to an array (renamed as st_lsm6dsx_ev_motion) so that it can be passed to the macro (and opportunistically move it from the header file where it does not belong to the C file where it is used). In addition, remove from this macro the channel type parameter and hard-code IIO_ACCEL in the macro definition, since all callers use IIO_ACCEL as channel type argument. Signed-off-by: Francesco Lavra --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 15 ++++----------- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 15 ++++++++++++--- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_l= sm6dsx/st_lsm6dsx.h index 6f68508e5769..3b90261e6bb1 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h @@ -81,9 +81,9 @@ enum st_lsm6dsx_hw_id { #define ST_LSM6DSX_SHIFT_VAL(val, mask) (((val) << __ffs(mask)) & (mask)) #define st_lsm6dsx_field_get(mask, reg) ((reg & mask) >> __ffs(mask)) =20 -#define ST_LSM6DSX_CHANNEL_ACC(chan_type, addr, mod, scan_idx) \ +#define ST_LSM6DSX_CHANNEL_ACC(addr, mod, scan_idx, events) \ { \ - .type =3D chan_type, \ + .type =3D IIO_ACCEL, \ .address =3D addr, \ .modified =3D 1, \ .channel2 =3D mod, \ @@ -97,9 +97,9 @@ enum st_lsm6dsx_hw_id { .storagebits =3D 16, \ .endianness =3D IIO_LE, \ }, \ - .event_spec =3D &st_lsm6dsx_event, \ + .event_spec =3D events, \ + .num_event_specs =3D ARRAY_SIZE(events), \ .ext_info =3D st_lsm6dsx_ext_info, \ - .num_event_specs =3D 1, \ } =20 #define ST_LSM6DSX_CHANNEL(chan_type, addr, mod, scan_idx) \ @@ -469,13 +469,6 @@ struct st_lsm6dsx_hw { } scan[ST_LSM6DSX_ID_MAX]; }; =20 -static __maybe_unused const struct iio_event_spec st_lsm6dsx_event =3D { - .type =3D IIO_EV_TYPE_THRESH, - .dir =3D IIO_EV_DIR_EITHER, - .mask_separate =3D BIT(IIO_EV_INFO_VALUE) | - BIT(IIO_EV_INFO_ENABLE) -}; - static __maybe_unused const unsigned long st_lsm6dsx_available_scan_masks[= ] =3D { 0x7, 0x0, }; diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu= /st_lsm6dsx/st_lsm6dsx_core.c index da914a58a875..562544636f36 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -96,10 +96,19 @@ =20 #define ST_LSM6DSX_TS_SENSITIVITY 25000UL /* 25us */ =20 +static const struct iio_event_spec st_lsm6dsx_ev_motion[] =3D { + { + .type =3D IIO_EV_TYPE_THRESH, + .dir =3D IIO_EV_DIR_EITHER, + .mask_separate =3D BIT(IIO_EV_INFO_VALUE) | + BIT(IIO_EV_INFO_ENABLE), + }, +}; + static const struct iio_chan_spec st_lsm6dsx_acc_channels[] =3D { - ST_LSM6DSX_CHANNEL_ACC(IIO_ACCEL, 0x28, IIO_MOD_X, 0), - ST_LSM6DSX_CHANNEL_ACC(IIO_ACCEL, 0x2a, IIO_MOD_Y, 1), - ST_LSM6DSX_CHANNEL_ACC(IIO_ACCEL, 0x2c, IIO_MOD_Z, 2), + ST_LSM6DSX_CHANNEL_ACC(0x28, IIO_MOD_X, 0, st_lsm6dsx_ev_motion), + ST_LSM6DSX_CHANNEL_ACC(0x2a, IIO_MOD_Y, 1, st_lsm6dsx_ev_motion), + ST_LSM6DSX_CHANNEL_ACC(0x2c, IIO_MOD_Z, 2, st_lsm6dsx_ev_motion), IIO_CHAN_SOFT_TIMESTAMP(3), }; =20 --=20 2.39.5