From nobody Tue Dec 2 02:05:18 2025 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44CDF289824 for ; Thu, 20 Nov 2025 04:16:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763612193; cv=none; b=Fcdc2jJrF2yfxzySnN5QPuq4zHHnSmXjHG6rfeJTTYbvyJp4+ahNJfFbJT5JPctwpPPmfhgccm5MbK8QELfIEWOeZ7Je4rpvFYs/e3rOaXAlf7KSubd59as/BIC83MfVqYu/cyZz72MTTBMLU7OYyBkZuVDoPBUcOinTNzMtXSs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763612193; c=relaxed/simple; bh=pkOpsCdmeW3ExT8MjqMMgG9gs9dCzYhTub4Hn8jfayA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=CBezKEyw16FL4CKrQ43jtXRzRIDbir8bVq7x3qksgRXc5ejbVL9H1lRVod6+R/O8k7O5mvT5t30M5X6ogNRmryrIvscWHbzqoNvnR8Pb7e5C9zfB6LAAXIH2GoNfPMzB9JCzrA8lPs684lfwXNMuWxlT/Uzx7w2kEc3kOJWGaA8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CNgEqiAS; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CNgEqiAS" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-64149f78c0dso530919a12.3 for ; Wed, 19 Nov 2025 20:16:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763612189; x=1764216989; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ke0jCxxr1nY0cEvcerSphkfz/Tc2+RuiCKy89HRuYRM=; b=CNgEqiASyNp37ez2s3IWU4Zqn/w7NIGzAs4B25myBPM6TaGMneAZNTZt73THAWYKmi n6CW4TtZW3yGchpTHSlrr38TQLPvNUtt9YKkfa6YwYdP6zIYHjGL1OV/AzrqRJPdPpqz 62wLNUZ00vsy9ILGOiaNOt+XzdiPx2qCJZmPAg0ykHFB+KN/2fUjzO9UoDnUw0UTFNnZ M/eOFqnmuIb2JJWpRSAZekVRJ1wcv4d8ZOGasj11rdC26yVOtwmnHyAQLmzdWooZiMtU vc50KoBQlPAHz5lA6hRsydI7iIuMQFiyWKBvW8gnaG5L/AMOqTRk53zVrkkpUxwhlV3F Mtew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763612189; x=1764216989; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ke0jCxxr1nY0cEvcerSphkfz/Tc2+RuiCKy89HRuYRM=; b=lTCc5j2RaU+DBr5aiCjzYzXqhPkVFVC92R2utRXYIWzNbYzYy9NfIpqHCW0cfADgSX /qTVMRgCrGV0CMYyJ6Zs8WndpOz9xAv7nkaLgx9MIDMarTKdrqK0oQIXO1R84UYLI4ME NSehRVCb3HIAMQY6XlT75kBbxx2nUZQUxDz+JlRUBLrSvwh9sgGKBlBPl3/43A+/fA0Q Uhj+ZPTBl3BU1PozfAz7alh33m3OCGch5aUV7KrzaxjeU22I0s2tLtWw6ievMx+Rg1GK 6jvhug+qz3fLZ6ucDmUndErWyR/Y40sCCd6ryEb0hNcs0ZZWlXPu4VVG5P4k7uzLOd9y niMg== X-Forwarded-Encrypted: i=1; AJvYcCUpQD9+Rz3Q0wjvIUgZS57XToS+xAVopRvb01MOfOfiF3We8epeEXFUcJx0/+coOSTVvuvn86pA5ZZY5Yc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/6UxxtCsDs7ibXnUkPylVF3my+iU3sSH+ki/aZBVvhZ3aGQKy hilPcEnNbA30YSciGRM1K60yRCgZdpjgUi23HESBGykLE1iF5bVYi3rH X-Gm-Gg: ASbGncuhDvv3g5C63awncKcBHj7KIF05LDNyp5y3NWbzzKSQCeFJmmPdpyHO6FRsnfB VWijFpRZ8LRdb+U65pypSp3cBxOAXB913y7QMTNvSO2V/5q3r0x5S6P8i3mk19tmaEX47O39xWt shJW9VMr0VkgwEpGI/abXb8vH8QKbUEeAVPHnUkeev+0N6SfGX9vMR1TE1EV+wBFW8lPn7vBUUP //VuVR1w60RdX9MG1LcK9qtDrDrps2t34M8rQjEPL6gZdNUJyimZfmGdoSkjsG3NRXB/6TkfVGR eOpCGezIAIh4/t2+AhbIiHk4R2g7KFQkp7BKwP8M2uWAtLUJAIH6Z7y7OaSTFOc9/ZDMKX6ZRlW Jt4QaP2h6qM6yzQrKlR6/WFQoQ9MXl9May/HIP0Qs6WmV8CWT1XlGZOIYtoc8SD5yLFzzCiYHr+ d+zI2K1TPdZXOreye8QMyegH7ybQVx7aeoYH3yNi9ftgl1bs+NlOL0BrVjBd9L+sitbi7Qv7ixZ SPzQQ== X-Google-Smtp-Source: AGHT+IGqn5oXr/h3c2O6rTOyQf01J2AYNnPmwNsh9JRVrcfyj3qioQ6SqB2JsYWuuxozcP7S9Ahx+w== X-Received: by 2002:a17:907:96a7:b0:b6d:6d66:e8e9 with SMTP id a640c23a62f3a-b7654fcfd37mr150210766b.61.1763612189064; Wed, 19 Nov 2025 20:16:29 -0800 (PST) Received: from ubuntu-2204.speedport.ip (p5de55abc.dip0.t-ipconnect.de. [93.229.90.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654ce15e7sm111441966b.8.2025.11.19.20.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 20:16:27 -0800 (PST) From: Hrishikesh Suresh To: acme@kernel.org Cc: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, james.clark@linaro.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Hrishikesh Suresh Subject: [PATCH] perf: replace strcpy() with strncpy() in util/jitdump.c Date: Wed, 19 Nov 2025 23:16:10 -0500 Message-Id: <20251120041610.299972-1-hrishikesh123s@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Usage of strcpy() can lead to buffer overflows. Therefore, it has been replaced with strncpy(). The output file path is provided as a parameter and might be restricted by command-line by default. But this defensive patch will prevent any potential overflow, making the code more robust against future changes in input handling. Testing: - ran perf test from tools/perf and did not observe any regression with the earlier code Signed-off-by: Hrishikesh Suresh --- tools/perf/util/jitdump.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/jitdump.c b/tools/perf/util/jitdump.c index b062b1f234b6..496ca2d2bfdb 100644 --- a/tools/perf/util/jitdump.c +++ b/tools/perf/util/jitdump.c @@ -233,7 +233,8 @@ jit_open(struct jit_buf_desc *jd, const char *name) /* * keep dirname for generating files and mmap records */ - strcpy(jd->dir, name); + strncpy(jd->dir, name, PATH_MAX); + jd->dir[PATH_MAX - 1] =3D '\0'; dirname(jd->dir); free(buf); =20 --=20 2.34.1