From nobody Tue Dec 2 02:05:23 2025 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A38B922128B for ; Thu, 20 Nov 2025 02:41:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763606470; cv=none; b=a76H5w0v7hVy4IzpqQquup/OW0IlAAsGm+Fl7D0q2cEvSxhED3US7ecEf7XcpRA0bBlnfoUNFODck3JAQ4XnHYa8AciRapptLrd+I9Md0Pu7+iEYaRiiur5NqAfkNLqFclLR7nr4I4aDOxY/hU9lQ7YwEom1KRXVbx7h+ZvUp1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763606470; c=relaxed/simple; bh=cUzmpNUy+nlHuwubS1iq1YNJLL0evrlXqj6CAcqQpzw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=p9UoBW3Lj4c6LkwXFXvPJnryVHjwfLt3IO03MCPhh1V0mGJnoFYCo9jvHwioCe0nJjyPHnRmHkSCqXwRbfZM+fu6gS8S8MCAYnEsiUpXrjxRCvkX1oAfNssnlcHHAPBEI5O6whJC7pJz1/H70kVGBK56scOnwATnTgVJ9bEtTF0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [124.16.141.245]) by APP-01 (Coremail) with SMTP id qwCowAAHns20fx5pCj1QAQ--.19711S2; Thu, 20 Nov 2025 10:40:54 +0800 (CST) From: Haotian Zhang To: jassisinghbrar@gmail.com Cc: linux-kernel@vger.kernel.org, Haotian Zhang Subject: [PATCH] mailbox: mailbox-test: Fix debugfs_create_dir error checking Date: Thu, 20 Nov 2025 10:40:39 +0800 Message-ID: <20251120024040.453-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowAAHns20fx5pCj1QAQ--.19711S2 X-Coremail-Antispam: 1UD129KBjvdXoWrZFWfAr4fZw1fCr18GF1xZrb_yoWDGwcEkr n5ZasrWrs3CFyUZ34DGa4YyFWa9ayFga1Fqr93tryag347ZryYqryUZrsYgw48Z3yDCrya v34UXw17Jw1fAjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbz8FF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr 0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAK I48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7 xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUXVWUAwCIc40Y0x0EwIxGrwCI42IY6xII jxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw2 0EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x02 67AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfU5WlkUUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwwMA2keYBRTagABs- Content-Type: text/plain; charset="utf-8" The debugfs_create_dir() function returns ERR_PTR() on error, not NULL. The current null-check fails to catch errors. Use IS_ERR() to correctly check for errors. Fixes: 8ea4484d0c2b ("mailbox: Add generic mechanism for testing Mailbox Co= ntrollers") Signed-off-by: Haotian Zhang --- drivers/mailbox/mailbox-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c index c9dd8c42c0cd..3a28ab5c42e5 100644 --- a/drivers/mailbox/mailbox-test.c +++ b/drivers/mailbox/mailbox-test.c @@ -268,7 +268,7 @@ static int mbox_test_add_debugfs(struct platform_device= *pdev, return 0; =20 tdev->root_debugfs_dir =3D debugfs_create_dir(dev_name(&pdev->dev), NULL); - if (!tdev->root_debugfs_dir) { + if (IS_ERR(tdev->root_debugfs_dir)) { dev_err(&pdev->dev, "Failed to create Mailbox debugfs\n"); return -EINVAL; } --=20 2.50.1.windows.1