From nobody Tue Dec 2 01:50:43 2025 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B73CA29D29C for ; Fri, 21 Nov 2025 05:45:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763703907; cv=none; b=SN2/cods/+XYE+lAzahEHl95QNRMZAsUmw20KAdVoDP6f1VJWQ2TQmfGHcQG2WwIGXNYhozoJpZNL0FXHInlHdouvNknJsnyrSQW6GoQPQx0hPZAAVcIjFOKYSWt7wjy/kaCgb83e0F48m5O3NMBtC50nrPDNA+ujjFCDPHGW4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763703907; c=relaxed/simple; bh=S0OTYm3s0WeftWD4AqPQ/rzlCPMOTr3mHqDyBo2IzPM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RsuLljMf1RMHTJna/AO2vmYdrpflp2haEjg0XNDlQHYK5XGI9FvbJ2u9aOrx06nYXr4+aA7KGH2PM6E4Dy8w73Ac14HtjaKmrjw8LEiyygAwUFCkR+x7G1pXy3hPepaEEPqPRx9CMCLwQANOhStiiRocDjzvtoy1GE0wQ1ZGYeQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FNf8Z88Y; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FNf8Z88Y" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-343684a06b2so1651335a91.1 for ; Thu, 20 Nov 2025 21:45:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763703902; x=1764308702; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ukEcgJRgkjZjmBgpWiJDnd24uu19PQYcukqnsJV0jE0=; b=FNf8Z88Y4Oz5X1VuMZOrmSJ4CyYP18JGMeaD3wE91y7au4XThrpiH8BZqKV3XUDEVl rxFqwwuDAVbK4fqMzsU9dAswOj3xEVv0+BvlWae09hSiV8PMc3FgD0BfC8BgNLNsoPyh kPjTeSTZsuuvlqYgKa7Zk3Y7DLdl2vpDh5tYMZA1adAV5VV3VPcaiEIRju/cCdcSYs1Q D0AEWZhC7tL33IS+cG6fUKMKGBSTfpXT+XpRAhNswlWS/hlRuYr+9VNe2JF5bp+FQwwX iJDoDsnfgRZQdflGqJaqxiilnOF5A7Z/9EvJ2AUNOyVGMQ3DnRUS1eKom9LkG61t6Z58 2yoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763703902; x=1764308702; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ukEcgJRgkjZjmBgpWiJDnd24uu19PQYcukqnsJV0jE0=; b=pXxUtnbbmwcQ4he+0Sz+Zp4DxqZuAtDAmmxEeLmlo1w5X5yoUCyywSKjtxWxq93kGz PrvCBba2lDvMtC8MQmPpjv7QIV2R3MYVbSSULK/jF+WbtT65aG3jmYu4ympWn0kayyp8 +Xv2D1KQpcjwX+EviZ/Tu/hr7CZlAPLvwbUsqHLLdRroizo9pMdjHVdM36+adJyGz0So gGYL1WSNLcwnaflbuhm+aqOwCzFFTZOy2tFQ1h01+vZBIfgq08tJ5iDKdOyGjn7+r6yd kczBtYSHypUzOFrChdh6A/6A4KQUmYQynUD9YOu2rYEwfP8DaJZhE3humFKpYm+qW3gO CKMw== X-Gm-Message-State: AOJu0YyN4JYCoVT7PBfbR1/QqDnznxOIzv4YrEm2D4/HKq3qI+4LI/GG e1aCs7ggt5oqaaNgryR3RFu0aFgwrXBdNp0RgB+EIoA5cc9gksLQAEJm X-Gm-Gg: ASbGnctZHO05TNOqfSkU9f31av+x+Zzw1yX7IP0y3K7RqqUSZ9YI7JhFHRdtZN2dixa LVfC4dOgrHdzAMHVxNq3NPdPZ9Sdk8GLED5KdIu3yMp67/TpHO1OyMibmdRzGDuHaSa5CbUe77t x43iJ65EbiFSSjwnGACpq8OUwvTxOXvsBrTjFJ/yo4VpLV6iv59yokPLJeTD5QOdZbbGXMTcU8U rOBhhM0m5gjoT9UOmPldOndDRS7XCNo0Lub0HMwpY3Gg5o38eCKvklh6nkKQ0u8yt8vJA4pOPXG le4A8HAd1uJZNCN4aJ2ONVvO5Sp1M7AU73e2OyNG+qzNTlQqDuRIzKs3kUCRKjagBONc5jvx+NE 2RfrytsiFANeK2chJKWuH/IXTG9Xa64UhQu7LDTEXytWMjBgVc+bNKjfaudKgBXPb1TjyFhhbt7 5wBpS+tLBCS2UghyXbJg/C X-Google-Smtp-Source: AGHT+IFELQgLCRsG8NRuOCsGBzSRJdEH8+ehXXOKkL8vFZuPvZ3QfZTp5lGjY+9g40dgcEdSszo9Aw== X-Received: by 2002:a17:90a:c2cd:b0:339:eff5:ef26 with SMTP id 98e67ed59e1d1-34733f40d29mr1247312a91.30.1763703901651; Thu, 20 Nov 2025 21:45:01 -0800 (PST) Received: from localhost ([2a03:2880:2ff:70::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34727be2fa7sm4195843a91.6.2025.11.20.21.45.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 21:45:01 -0800 (PST) From: Bobby Eshleman Date: Thu, 20 Nov 2025 21:44:43 -0800 Subject: [PATCH net-next v11 11/13] selftests/vsock: add namespace tests for CID collisions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251120-vsock-vmtest-v11-11-55cbc80249a7@meta.com> References: <20251120-vsock-vmtest-v11-0-55cbc80249a7@meta.com> In-Reply-To: <20251120-vsock-vmtest-v11-0-55cbc80249a7@meta.com> To: Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , =?utf-8?q?Eugenio_P=C3=A9rez?= , Xuan Zhuo , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , Shuah Khan Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kselftest@vger.kernel.org, berrange@redhat.com, Sargun Dhillon , Bobby Eshleman , Bobby Eshleman X-Mailer: b4 0.14.3 From: Bobby Eshleman Add tests to verify CID collision rules across different vsock namespace modes. 1. Two VMs with the same CID cannot start in different global namespaces (ns_global_same_cid_fails) 2. Two VMs with the same CID can start in different local namespaces (ns_local_same_cid_ok) 3. VMs with the same CID can coexist when one is in a global namespace and another is in a local namespace (ns_global_local_same_cid_ok and ns_local_global_same_cid_ok) The tests ns_global_local_same_cid_ok and ns_local_global_same_cid_ok make sure that ordering does not matter. The tests use a shared helper function namespaces_can_boot_same_cid() that attempts to start two VMs with identical CIDs in the specified namespaces and verifies whether VM initialization failed or succeeded. Signed-off-by: Bobby Eshleman Reviewed-by: Stefano Garzarella --- Changes in v11: - check vm_start() rc in namespaces_can_boot_same_cid() (Stefano) - fix ns_local_same_cid_ok() to use local0 and local1 instead of reusing local0 twice. This check should pass, ensuring local namespaces do not collide (Stefano) --- tools/testing/selftests/vsock/vmtest.sh | 78 +++++++++++++++++++++++++++++= ++++ 1 file changed, 78 insertions(+) diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selfte= sts/vsock/vmtest.sh index 2e077e8a1777..f84da1e8ad14 100755 --- a/tools/testing/selftests/vsock/vmtest.sh +++ b/tools/testing/selftests/vsock/vmtest.sh @@ -51,6 +51,10 @@ readonly TEST_NAMES=3D( ns_host_vsock_ns_mode_ok ns_host_vsock_ns_mode_write_once_ok ns_vm_local_mode_rejected + ns_global_same_cid_fails + ns_local_same_cid_ok + ns_global_local_same_cid_ok + ns_local_global_same_cid_ok ) readonly TEST_DESCS=3D( # vm_server_host_client @@ -70,6 +74,18 @@ readonly TEST_DESCS=3D( =20 # ns_vm_local_mode_rejected "Test that guest VM with G2H transport cannot set namespace mode to 'loca= l'" + + # ns_global_same_cid_fails + "Check QEMU fails to start two VMs with same CID in two different global = namespaces." + + # ns_local_same_cid_ok + "Check QEMU successfully starts two VMs with same CID in two different lo= cal namespaces." + + # ns_global_local_same_cid_ok + "Check QEMU successfully starts one VM in a global ns and then another VM= in a local ns with the same CID." + + # ns_local_global_same_cid_ok + "Check QEMU successfully starts one VM in a local ns and then another VM = in a global ns with the same CID." ) =20 readonly USE_SHARED_VM=3D( @@ -581,6 +597,68 @@ test_ns_host_vsock_ns_mode_ok() { return "${KSFT_PASS}" } =20 +namespaces_can_boot_same_cid() { + local ns0=3D$1 + local ns1=3D$2 + local pidfile1 pidfile2 + local rc + + pidfile1=3D"$(create_pidfile)" + + # The first VM should be able to start. If it can't then we have + # problems and need to return non-zero. + if ! vm_start "${pidfile1}" "${ns0}"; then + return 1 + fi + + pidfile2=3D"$(create_pidfile)" + vm_start "${pidfile2}" "${ns1}" + rc=3D$? + terminate_pidfiles "${pidfile1}" "${pidfile2}" + + return "${rc}" +} + +test_ns_global_same_cid_fails() { + init_namespaces + + if namespaces_can_boot_same_cid "global0" "global1"; then + return "${KSFT_FAIL}" + fi + + return "${KSFT_PASS}" +} + +test_ns_local_global_same_cid_ok() { + init_namespaces + + if namespaces_can_boot_same_cid "local0" "global0"; then + return "${KSFT_PASS}" + fi + + return "${KSFT_FAIL}" +} + +test_ns_global_local_same_cid_ok() { + init_namespaces + + if namespaces_can_boot_same_cid "global0" "local0"; then + return "${KSFT_PASS}" + fi + + return "${KSFT_FAIL}" +} + +test_ns_local_same_cid_ok() { + init_namespaces + + if namespaces_can_boot_same_cid "local0" "local1"; then + return "${KSFT_PASS}" + fi + + return "${KSFT_FAIL}" +} + test_ns_host_vsock_ns_mode_write_once_ok() { for mode in "${NS_MODES[@]}"; do local ns=3D"${mode}0" --=20 2.47.3