From nobody Tue Dec 2 02:06:09 2025 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09B30285CB3 for ; Thu, 20 Nov 2025 14:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763649490; cv=none; b=uyN104miu82HXJoYL78MXfRf0JIfTaNSMHJ3yxtd31Ut8nmCAtPQcPheCPufQxstajeSfKPV7CwHv5xCBSv2HaALUA5vHEpiNb1pnRh6wi7iM5IcEoZjGoSKdeo4vM6hWTZaXethXW761r+aWnOffK8HV5d2Wr+R7vXOJZxKCkA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763649490; c=relaxed/simple; bh=T7NQcuSTK0Wgag7FnGB316ybnPYMXfKzLolu3Rg73KQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Dti32n3kBSd1AJleRg50IkosMDhibmZkDXi3K+vMK6OZEvPC2z8br7ttJ0WwZUGXRUK2tfdolHRLnvY2TOFvPRD1zydfrQnEB+EElae67Ys43hpqupvaoA7iO8SkaVMXjGi3zDXgrQ5u/T4ktx+pWNx3v82aJ0Zz2ssa4r49Lv8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tM7IpI3i; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tM7IpI3i" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b735e278fa1so196410366b.0 for ; Thu, 20 Nov 2025 06:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763649486; x=1764254286; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TKVEwuNeEzYnlKtvmByCf7hR27qjuXrjbBMyGBFxDEU=; b=tM7IpI3iTc8e9VR6PlwXY7laJoWAGUkNUUFTnOJA7ksqJ8EyAME0R63q0Ky0YSUb1j ttI8hYCOwZx4TP45CaV65CwRuVMtEETgnrUwY8RY+o/jSimtkx+Hu0TuSlME9ZWKVf1M bNiG+Kye4mxWEmeu6g/48nzAassEJMX6MqGpLM5heL7PXfOXjzlSWrKgpvLKnCf7Fbky DlIRNHZ6cEdRg7AxgbgBnqLnUXfwPd5AtlrYhSUUfq9CQMvEUTNp7K1dWhr69oMIqDZ9 GpoEteAQVbtxDa7zXSJdCgACeXyEG1u+uNq+wXFBKTd0sIblngj+CO+a+1RNjGvRzKKs I0rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763649486; x=1764254286; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TKVEwuNeEzYnlKtvmByCf7hR27qjuXrjbBMyGBFxDEU=; b=Bb1u9TC0d4Jkq1Pe4JREJoyrFzl0zO8boJyiLJOfvQ8wRrVtcZjPAi9QCwh4I6KHWo JJhWqgMuDXQPw7MZg7ADl3PBRGbPM3PVBQX5gojh5UZoumLM2vp9di8lwHUbzb/NnDf0 GLL+kKfrF+jeJMY0bAz+TPZFGEuYSypJVjhHt2zQ5xp3KCKTtQ3FtmUXe98LlpfXklpz dECtruC8YFlVaDu/NRqaJBAUcDnT9O5JLdP3gL7nLjVte4JQqM8ChS4rF4XyZfNVef6N k1W9CoqVBzeBQzjddsTT0SrU2uLJcsqbRyvFT9eRXT1q843STkc+vZzpw4OmsAPdNx37 VuBw== X-Forwarded-Encrypted: i=1; AJvYcCV0IffE7jLT3s2+YbGFh5HnKwhshQ61ZQ4r7iTtxkNR3GYONWGmHjxr7foyXf9sEiIqwx3Uad1ZOlhVTSw=@vger.kernel.org X-Gm-Message-State: AOJu0YwJRGiWOaIrKT9sh3swdPc3ejAbSQaWOmWmhh1QcQI3q9UgbWTt eO5CiBZbLxwDQmm7HtAcOtsVV8p0C3zzEtMnNESVZlGsaE2UCT9/2TPoR9CwhjNbvO8= X-Gm-Gg: ASbGncuGoXUXX3outXktoIqqqlFwRarW9n7YgwQ1AJ10L7JoVaYZIxSAoIHVN5IC5tr CP7qrzgeV9t5Bpx69xlTO9+fYVi/yjk06ob3K0AzAh63j7FarCrBTcB91GSi36geindD58JgQpZ /feTn628NrXUN5aLIT6//3SSQPRQ7Htb3ha1nfVtGUvXR1VlWFCN7na7ta+CZbOTjdWCRDwwUqz farflRIftf8JhitmNBlUrNFO0QO+FtJ5zG/MSMXjfxIjbP3skndPXPAJngf+rC0UpPzbMefJscZ rcAERAL9JUH+DoLaYz/wDq7DwQOmdJvfi5Q6Sik41ezCDcrgzZbG2FXYaSRva/IOVKfC6iElgsl xmmmiVlKkSd8lQYbeokB8nD8DDEucVj9ozYYiZoKMCVuuzi6J2F6r7wRZTcr/qdugSOOiEUl6hQ FCbMxN3MP74kl1yAqVNEhNjr+OOkorz2+ksPlMwVtEREsI3HYT8ECQNWhP2R+Yb7pXz/mmRtKKw ttj1A== X-Google-Smtp-Source: AGHT+IGNU5sr6+plfXZt3ru5qeOfPaQbRzm/Ldfsyxj62YchoQXmawCsQ5xOWRL1NW15aw9u6Zb1PQ== X-Received: by 2002:a17:906:c103:b0:b76:3a86:bccc with SMTP id a640c23a62f3a-b7654d8cfefmr397361066b.2.1763649486145; Thu, 20 Nov 2025 06:38:06 -0800 (PST) Received: from puffmais2.c.googlers.com (180.192.141.34.bc.googleusercontent.com. [34.141.192.180]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7655050927sm214326566b.71.2025.11.20.06.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 06:38:05 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Thu, 20 Nov 2025 14:38:05 +0000 Subject: [PATCH v2 2/3] rtc: s5m: query platform device IRQ resource for alarm IRQ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251120-s5m-alarm-v2-2-cc15f0e32161@linaro.org> References: <20251120-s5m-alarm-v2-0-cc15f0e32161@linaro.org> In-Reply-To: <20251120-s5m-alarm-v2-0-cc15f0e32161@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , Douglas Anderson , kernel-team@android.com, Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The core driver now exposes the alarm IRQ as a resource, so we can drop the lookup from here to simplify the code and make adding support for additional variants easier in this driver. Acked-by: Alexandre Belloni Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-s5m.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index a7220b4d0e8dd35786b060e2a4106e2a39fe743f..c6ed5a4ca8a0e4554b1c88c879b= 01fc384735007 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include =20 @@ -683,22 +682,18 @@ static int s5m_rtc_probe(struct platform_device *pdev) case S2MPS15X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps15_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S2MPS14X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps14_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S2MPS13X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps13_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S5M8767X: regmap_cfg =3D &s5m_rtc_regmap_config; info->regs =3D &s5m_rtc_regs; - alarm_irq =3D S5M8767_IRQ_RTCA1; break; default: return dev_err_probe(&pdev->dev, -ENODEV, @@ -719,7 +714,6 @@ static int s5m_rtc_probe(struct platform_device *pdev) "Failed to allocate regmap\n"); } else if (device_type =3D=3D S2MPG10) { info->regs =3D &s2mpg10_rtc_regs; - alarm_irq =3D S2MPG10_IRQ_RTCA0; } else { return dev_err_probe(&pdev->dev, -ENODEV, "Unsupported device type %d\n", @@ -730,13 +724,14 @@ static int s5m_rtc_probe(struct platform_device *pdev) info->s5m87xx =3D s5m87xx; info->device_type =3D device_type; =20 - if (s5m87xx->irq_data) { - info->irq =3D regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); - if (info->irq <=3D 0) - return dev_err_probe(&pdev->dev, -EINVAL, - "Failed to get virtual IRQ %d\n", - alarm_irq); - } + alarm_irq =3D platform_get_irq_byname_optional(pdev, "alarm"); + if (alarm_irq > 0) + info->irq =3D alarm_irq; + else if (alarm_irq =3D=3D -ENXIO) + info->irq =3D 0; + else + return dev_err_probe(&pdev->dev, alarm_irq ? : -EINVAL, + "IRQ 'alarm' not found\n"); =20 platform_set_drvdata(pdev, info); =20 --=20 2.52.0.rc1.455.g30608eb744-goog