From nobody Tue Dec 2 02:19:57 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9683836CE14; Thu, 20 Nov 2025 17:04:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763658270; cv=none; b=MmS8NWrIVCNvLQjLwUzSqK2vR/hGgCUYYDDMPiBXC/uT4SXm2v8QltTKIVUFIYeMf6ziGKkrLEI+m3ti7hjlJn/m48j4NY5VnYFAZzdrknNxIec+cEQIngZP7AuEMong1p7xS6yLyoi1KwIYJxVkDV3kclLSZJmkd7IytgIEneQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763658270; c=relaxed/simple; bh=nTMOUodaz/NXhF4L146vsKpXqIbsHlK/9A+E95H6+W8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RroAHK46Q6wkmN5n51n7kE56OLN+5tIeu02N2aRQS+pkkogxQBr8ZMgLl9YC6QxU5HGY89W/xpZG9Ti9HmYLihOjI3J42hR/j3bPrLDQR3pJ9TEj8aP9Z+I3BQQoI3nm5raZMd5T0hMAuRF/rEKUK9DYk4hVnHT3WBYSOclVQjE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=UPeZXQ/I; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="UPeZXQ/I" Received: by smtp.kernel.org (Postfix) with ESMTPS id 18DEFC2BCB1; Thu, 20 Nov 2025 17:04:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux.dev; s=korg; t=1763658270; bh=nTMOUodaz/NXhF4L146vsKpXqIbsHlK/9A+E95H6+W8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=UPeZXQ/Ie7dawUwYl2DbX4e8OXa4Qc3hg8G6IUUSKb1JmERE3YqQx/2xS5hi3zUaO rzF2szYu98U912HcBkz2D4ZNco2+IKhBOXGLN7P3lnJ0JRjf2yVhL2YFxPe3aSMnEV OrriGGh7ZIh9AeoQqjPVjTxaYXkDO1SU72cQ2PW8= Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11496CF9C71; Thu, 20 Nov 2025 17:04:30 +0000 (UTC) From: Richard Leitner Date: Thu, 20 Nov 2025 18:04:25 +0100 Subject: [PATCH v9 5/8] media: i2c: ov9282: add strobe output enable v4l2 control Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251120-ov9282-flash-strobe-v9-5-6c9e3a4301d7@linux.dev> References: <20251120-ov9282-flash-strobe-v9-0-6c9e3a4301d7@linux.dev> In-Reply-To: <20251120-ov9282-flash-strobe-v9-0-6c9e3a4301d7@linux.dev> To: Sakari Ailus , Dave Stevenson , Mauro Carvalho Chehab , Lee Jones , Pavel Machek , Laurent Pinchart Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Richard Leitner , Hans Verkuil X-Mailer: b4 0.15-dev-a3fc8 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763658268; l=2315; i=richard.leitner@linux.dev; s=20250225; h=from:subject:message-id; bh=nTMOUodaz/NXhF4L146vsKpXqIbsHlK/9A+E95H6+W8=; b=2b0xkeVfzf3ElTahX4TWTx/S2S5AgXb0c+L82SUCB76PxTy44j6SCPYHnWAsmIQnuLIVI3CEx tTLZzgKL5/MCwU/m9s8U8bCn22anRVUZmGcVpH5V02x+MXpE6jbSN99 X-Developer-Key: i=richard.leitner@linux.dev; a=ed25519; pk=8hZNyyyQFqZ5ruVJsSGBSPIrmJpfDm5HwHU4QVOP1Pk= X-Endpoint-Received: by B4 Relay for richard.leitner@linux.dev/20250225 with auth_id=350 Add V4L2_CID_FLASH_STROBE_OE enable/disable support using the "strobe output enable" feature of the sensor. All values are based on the OV9281 datasheet v1.53 (january 2019) and tested using an ov9281 VisionComponents module. Signed-off-by: Richard Leitner --- drivers/media/i2c/ov9282.c | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c index e67cff6c30ff..6afce803a049 100644 --- a/drivers/media/i2c/ov9282.c +++ b/drivers/media/i2c/ov9282.c @@ -670,6 +670,23 @@ static int ov9282_set_ctrl_vflip(struct ov9282 *ov9282= , int value) current_val); } =20 +static int ov9282_set_ctrl_flash_strobe_oe(struct ov9282 *ov9282, bool ena= ble) +{ + u32 current_val; + int ret; + + ret =3D ov9282_read_reg(ov9282, OV9282_REG_OUTPUT_ENABLE6, 1, ¤t_va= l); + if (ret) + return ret; + + if (enable) + current_val |=3D OV9282_OUTPUT_ENABLE6_STROBE; + else + current_val &=3D ~OV9282_OUTPUT_ENABLE6_STROBE; + + return ov9282_write_reg(ov9282, OV9282_REG_OUTPUT_ENABLE6, 1, current_val= ); +} + /** * ov9282_set_ctrl() - Set subdevice control * @ctrl: pointer to v4l2_ctrl structure @@ -736,6 +753,9 @@ static int ov9282_set_ctrl(struct v4l2_ctrl *ctrl) ret =3D ov9282_write_reg(ov9282, OV9282_REG_TIMING_HTS, 2, (ctrl->val + ov9282->cur_mode->width) >> 1); break; + case V4L2_CID_FLASH_STROBE_OE: + ret =3D ov9282_set_ctrl_flash_strobe_oe(ov9282, ctrl->val); + break; default: dev_err(ov9282->dev, "Invalid control %d", ctrl->id); ret =3D -EINVAL; @@ -1325,7 +1345,7 @@ static int ov9282_init_controls(struct ov9282 *ov9282) u32 lpfr; int ret; =20 - ret =3D v4l2_ctrl_handler_init(ctrl_hdlr, 10); + ret =3D v4l2_ctrl_handler_init(ctrl_hdlr, 11); if (ret) return ret; =20 @@ -1390,6 +1410,10 @@ static int ov9282_init_controls(struct ov9282 *ov928= 2) OV9282_TIMING_HTS_MAX - mode->width, 1, hblank_min); =20 + /* Flash/Strobe controls */ + v4l2_ctrl_new_std(ctrl_hdlr, &ov9282_ctrl_ops, + V4L2_CID_FLASH_STROBE_OE, 0, 1, 1, 0); + ret =3D v4l2_fwnode_device_parse(ov9282->dev, &props); if (!ret) { /* Failure sets ctrl_hdlr->error, which we check afterwards anyway */ --=20 2.47.3