From nobody Tue Dec 2 02:19:59 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B0CD313E3F for ; Thu, 20 Nov 2025 11:29:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638183; cv=none; b=NYuuVAy/cKUEE74Md3hN1mOUVmAG/8zeJOKFmqDqeI9hputWEGWBNm6Y6NBLQaH4k430gJF9R1nMY9F+HJpytRStdB7rPVfFWwnjD4pwSBbsaUXu2+19Xva3tYsUWDCimM/UH5UgkVUrWomThwfEf3rTjrN7tdZVfKYLF+or+OM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638183; c=relaxed/simple; bh=ydziPpmvPsHAqypZZhan8Qbcj761T47in3GhwmLevxY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DX9KzDEVjU/fTTDcGb95ndCnZgCTwVgvTiQizOHIA846CNF/s5mPmUJBcvd+yUbz8NdLecRR2tt4MkvOzNrZvnCrmUIpDStMwdNiI+YGnvPdvWtgHzFRqeAuThPzPnDJqhKsBRaD/WZ4ahEzj7W1NRQ26HYgVBQo2aShEldPNFs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yXo0eDH8; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yXo0eDH8" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42b3669ca3dso319893f8f.0 for ; Thu, 20 Nov 2025 03:29:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763638180; x=1764242980; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XaAjSoY/nku4Rf/DgaeK7ZZ3RvPX6WjghtPiUfT8Z6E=; b=yXo0eDH8a39wf2mJZi5ZCmO24JkO8uqcNDlofYdzhqODguuHUFfSOEjClgSBkBldGI bELcTfoT9IufzwIV0FFnxFsx6YOTA8Tu3BEHBZb0bzmr+gx60CYpbHa6XJGrcc2EoYkg T/EFqPjqKIiKLBjwPfb5sUkt9jZCXKZoY7TO6nt6d1cFYz7ooIpeG0EilIUkA7gcmOvh lsilJuMTD+Bid+C6E9SPRegYHoMYypzhVFmUM070b4rC3RjXyvfEGpSA22zyANYVgeXb YQrYDuw+9v9ugMntVQGPHqdkUszOI+NUIwoRELfkV+k9cS74qJ40DZ9DSrGdlvRsdJ9q bPCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763638180; x=1764242980; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XaAjSoY/nku4Rf/DgaeK7ZZ3RvPX6WjghtPiUfT8Z6E=; b=uUD7a+qafV8EqVnak/ro9Bqea4xIsdZnOJU84qsHHdA1CrIQA4dVitvmkIAiQo+QxA M6tlk51CHPFqTpVf2JznLq6ZWpHsfcAAL06zhu6pHjVgMslZcNjWX5EMZuIKDAdWsk4T 7RXiastdESSraFEtvFfHDrVB7qQmyMC4JuiJhOA6qsB6rnPiQE2EIearZdOOzYg6iaxE qDHxs+dPwIz/cNq/LQmong+pcT49NtsjVRSftmoUoeEpH3ISODkbNGn3Py+8zlTfEpXn ryOSNVr4oCL9qv4PMxO0WxxLwHSkVgkt6pEnTCA5xe37S744uxudxUqFfbc/hpCeMpCS jHYQ== X-Forwarded-Encrypted: i=1; AJvYcCV91TymQGK9kR7r+NO3bca0V7DH5yg8NuENrPhX4lMXAF/vV+bVxZWf9iQkMC3M94INnB8IwtzDhbbWhuw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5AikhjA/kTx1HAI35sv1cZ3y86w5xnwdmvGiXm/XWyxd7HXo8 dWfCCIpVzsU3v8Y4QKwKtWmyncbSQqWTT455iwOfY4oMNNkmbJvgPgHghZlOLMVWqRs= X-Gm-Gg: ASbGnctoxiUtm2V365CwI4a5C6uBkyYFVrT6XkbPVT7RyTfAke3lJp9BcgeCW53gHz7 MGl/Nd5wxe88L6AayV2SiHuqcRti+VWc1pS5y3fqjmYBsPJR+LizVziKpBUSRsKUPnSfWZsizeq h4wQSguu2ET0x+XP2n5GN4ZVBx4Fa9eGs3s2NRN1G3LfeTqUF6odBJLKVJNU7809Orf+LXG04Sy /hZoUPu6o8SFlrNTeOhznWzgUCpEhyHvd4pHTKwAMY83ZVrJBXkyC3L1nhpEo4nCb/NIdkLEOuL 7aVhmLuKADya4evGG0XgG/SF88IHxGCUxRHZaS2D+MbD0a8fHHk0RCOe5JQryJ+B5aRon4zGUb/ 61RtNZG8h5eud0ROQxPx/mFhTOl9rwdkt9r/24HPtGpGWFUoycXH+qlq9NYZqQOYh0798jLXnO0 ELIlX4evSlPM/vj4uqIfcur7kQ5zbRvZCisUbxATWdxQW5eWbMX0oHMZ4k5BKOs+UIkdk= X-Google-Smtp-Source: AGHT+IGbKsNEy/oueUtizdEXhVcAeX3YEdD+UJr2wvqpgctEkJQ/yJL/aveJn6ori9RZU00wT99XRw== X-Received: by 2002:a05:6000:1846:b0:42b:5448:7b06 with SMTP id ffacd0b85a97d-42cb9a219ecmr2426328f8f.13.1763638179927; Thu, 20 Nov 2025 03:29:39 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34fd1sm4961040f8f.11.2025.11.20.03.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 03:29:39 -0800 (PST) From: Tudor Ambarus Date: Thu, 20 Nov 2025 11:29:36 +0000 Subject: [PATCH v3 2/6] soc: samsung: exynos-chipid: use dev_err_probe where appropiate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251120-gs101-chipid-v3-2-1aeaa8b7fe35@linaro.org> References: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> In-Reply-To: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763638176; l=3106; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=ydziPpmvPsHAqypZZhan8Qbcj761T47in3GhwmLevxY=; b=3QfKC33suSvG0rhHt/+ek4MMRHqRHtNEUYflZ9HpBIoEjKBWMgp5OHbOKUXglp9RLJujxdm4Y eJ0sTaG3i8yAL0fq7oX5LmnwNS87zA7ibX3lE4bZJ0CXepRz/sSZvBV X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Use dev_err_probe() to benefit of the standardized format of the error code (e.g. "ENODEV" instead of -19), to get meanigful error messages, and for more compact error paths. Signed-off-by: Tudor Ambarus --- drivers/soc/samsung/exynos-chipid.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index 49cb113d99f314ed94730cec2b98f48a1a7b87f2..b9a30452ad21c326af35c06a341= b28491cee6979 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -81,8 +81,8 @@ static const char *product_id_to_soc_id(unsigned int prod= uct_id) return NULL; } =20 -static int exynos_chipid_get_chipid_info(struct regmap *regmap, - const struct exynos_chipid_variant *data, +static int exynos_chipid_get_chipid_info(struct device *dev, + struct regmap *regmap, const struct exynos_chipid_variant *data, struct exynos_chipid_info *soc_info) { int ret; @@ -90,13 +90,14 @@ static int exynos_chipid_get_chipid_info(struct regmap = *regmap, =20 ret =3D regmap_read(regmap, EXYNOS_CHIPID_REG_PRO_ID, &val); if (ret < 0) - return ret; + return dev_err_probe(dev, ret, "failed to read Product ID\n"); soc_info->product_id =3D val & EXYNOS_MASK; =20 if (data->rev_reg !=3D EXYNOS_CHIPID_REG_PRO_ID) { ret =3D regmap_read(regmap, data->rev_reg, &val); if (ret < 0) - return ret; + return dev_err_probe(dev, ret, + "failed to read revision\n"); } main_rev =3D (val >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; sub_rev =3D (val >> data->sub_rev_shift) & EXYNOS_REV_PART_MASK; @@ -123,13 +124,15 @@ static int exynos_chipid_probe(struct platform_device= *pdev) =20 drv_data =3D of_device_get_match_data(dev); if (!drv_data) - return -EINVAL; + return dev_err_probe(dev, -EINVAL, + "failed to get match data\n"); =20 regmap =3D device_node_to_regmap(dev->of_node); if (IS_ERR(regmap)) - return PTR_ERR(regmap); + return dev_err_probe(dev, PTR_ERR(regmap), + "failed to get regmap\n"); =20 - ret =3D exynos_chipid_get_chipid_info(regmap, drv_data, &soc_info); + ret =3D exynos_chipid_get_chipid_info(dev, regmap, drv_data, &soc_info); if (ret < 0) return ret; =20 @@ -148,15 +151,14 @@ static int exynos_chipid_probe(struct platform_device= *pdev) if (!soc_dev_attr->revision) return -ENOMEM; soc_dev_attr->soc_id =3D product_id_to_soc_id(soc_info.product_id); - if (!soc_dev_attr->soc_id) { - pr_err("Unknown SoC\n"); - return -ENODEV; - } + if (!soc_dev_attr->soc_id) + return dev_err_probe(dev, -ENODEV, "Unknown SoC\n"); =20 /* please note that the actual registration will be deferred */ soc_dev =3D soc_device_register(soc_dev_attr); if (IS_ERR(soc_dev)) - return PTR_ERR(soc_dev); + return dev_err_probe(dev, PTR_ERR(soc_dev), + "failed to register to the soc interface\n"); =20 ret =3D devm_add_action_or_reset(dev, exynos_chipid_unregister_soc, soc_dev); --=20 2.52.0.rc1.455.g30608eb744-goog