From nobody Tue Feb 10 04:14:39 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70480372AC9 for ; Thu, 20 Nov 2025 11:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638182; cv=none; b=FuUE3loPFVaexsQtIO84YDgZ39Qo5tyLJ8g5n2OzDd9tfZDTyDoaWctHNQcduEEWzv1/Eg3+nImoBxBslsTsVZp3MshdrgCYLNpWYW270uvbTy27B/LlNymAAeoWwf0ZQ8ruAfq1aANVLRHFRc6FLUPQ04stoLt5jqMP2EGtWN4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638182; c=relaxed/simple; bh=q4SLhBlNs3t93tDVbeMVgBT6CvDIqD2qRVhlhlaXWaw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IimFdpYbgzE0oSVG8cit5sfDVcUrqCmCYvbcMQs8iOS2aXOq7kDXxZ+IlsHL4FafWraGkBlPbVKUGbeczwuFLOkNHKim2KYosz/A2+z+oK38MydvdJk4wgOKOGaJd4V0ArsvpQu2Hh5IudktosOymP6smi3EEf+EMT/Nj5+RCM8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V0NHX+wb; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V0NHX+wb" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-42b3c5defb2so471972f8f.2 for ; Thu, 20 Nov 2025 03:29:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763638179; x=1764242979; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PuKrcuoBI7d5g4q4orKG9nRm+eFjAB5tnSDzYO6y5WQ=; b=V0NHX+wbWwNwM2r8DpiOMQQ1egjGv6JSAI6A76ss9M9w4FQqACSfqeTQFpfjZnjez7 9sdtOH7ZC3yaZAPtNcVu9pg9Q3S80sy+eX3KszWhzKbLjqR02ecqfNi3Al9f6OkhZrPo vYCmVBdBC4G7y7vNMTyv3ZIyj4+ufoHKETeSWDi7fh3mI4aKpgSpz4u6+xlNvHXKEA+X XPG+scsE9ywKsaKUv6jFXxKGbqR2gjLPWX8L7RPbz8ZG5+cDG+6/f398Ow+wgs8B1l43 i7rPPLqO6zoX9nQ/pMoKLdxyGbvJE54I2+D8cDiJaHBuKlqG+nhhZIJ2P7VQjZFFk4mJ V2QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763638179; x=1764242979; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PuKrcuoBI7d5g4q4orKG9nRm+eFjAB5tnSDzYO6y5WQ=; b=TDa4hf4+NgDVlQFprrH7TYAgrH67v2ND8Zn0f+RQlaIoqmIF+6n6VmZBgk3lLmRoDz 5Oi36ZBMsoYdLYhlmRE5HprKhbNof0jQI9w5zZVxO1bER12om+0KjatfYdK6qsiBI8m9 h6wzcrpllHiSr1pML8HyRSQwvYmCRypyQ83/QalCa3N55Z0LcCWlOVfxm/PcqVY2D+vM 0LbM9d0PVKjw6LhVLO9p2gUTwFkC3+jHSwhdaVCJmZkrBxyMohj4mDm8TsmIzh4Bmeph zkoSegxTwnvOvSzToY/3W61royrTDnDEqLANRqgP4Botqpk8lTKxkEyT3jzfaKUVruAF ZTuw== X-Forwarded-Encrypted: i=1; AJvYcCWyttGjICH0pq/8060yb6SBvA00xnY0wA1Wk2a2GVrntwbZ/ky7ZRtxPwPCSbS7qfJwD4YzpoibLPA7xfI=@vger.kernel.org X-Gm-Message-State: AOJu0YzOJhJbxQYfZCuS1IQeSa5S8xJPPAXdP4j/d/7w0EMHdqa8fDMq 79LixZxRMjYv55jS7O3J8Mz2qIZBZEuzFi5ZiVUEtdg5KsyHR1/tkhb/BHGcUgfjs1g= X-Gm-Gg: ASbGnctU3u5IewKttmm31E9OQ6iGkI9ho37Lm9ynL9pw4cBQVQJBgsj901lLey8tsHB unD+VQ+q2e6BjjAmRTzjZiblHCC9U3kfcZmw9DYnqLgzXl6gdI4Q84MSgtm4JBKC6SJFuiWh8M1 biidfUaGGUg155hL9fUUYf++ZKU5UF5i9CjJyYCFDVGkZNde1mSskSztybW2H1XqnfN48ZOt6vX See6XcwKa7wTim3JIEuJplvHnXdsk1jAfvylP+Llpel+PJb5egZ/t6sjtaVJWuBf7Xx1z+GgIjY R4MuHVSP9JYAthA3fMiQv54ohI+hfoFUlcCFDjnFQtGte2LTByd2Us1pFF8EbXSX6PtbUApmdfG G7Y8XlY1O+tx7DXmiehIPsHqEpIU3liXsv6lwe6MFjBxi8+F78m4auS1UAek7e9dDo9RScZqZzb y5Q/O1JfTYSO5KmTEjj7Qca8nZpH4doVaRKqc3zcQaNlcxEs2/5e+asZ/xQUDEebzoYa4= X-Google-Smtp-Source: AGHT+IEvA1MyH031OEvH24ynuE0LyStn/WEmFOJ9u6ZU8yrQYuFsjPCmysl8RrhQB/MEu5VH/0+U8A== X-Received: by 2002:a05:6000:2388:b0:42b:3366:6330 with SMTP id ffacd0b85a97d-42cb9a65915mr2696231f8f.57.1763638178815; Thu, 20 Nov 2025 03:29:38 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34fd1sm4961040f8f.11.2025.11.20.03.29.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 03:29:38 -0800 (PST) From: Tudor Ambarus Date: Thu, 20 Nov 2025 11:29:35 +0000 Subject: [PATCH v3 1/6] soc: samsung: exynos-chipid: use devm action to unregister soc device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251120-gs101-chipid-v3-1-1aeaa8b7fe35@linaro.org> References: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> In-Reply-To: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763638176; l=2398; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=q4SLhBlNs3t93tDVbeMVgBT6CvDIqD2qRVhlhlaXWaw=; b=nK061O76WMFoYj9rMWr/tOtXFH2+xEeqZerjwnB7A5ZG9eGCMLEYmueI7BG1LxSjTJ8CCK8ZB sgwYqPwxkbQD0CIyqIOcBPEiT2aDWcKRx3u/B8eAEUDo0B4tH3RLzZu X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Simplify the unwinding of the soc device by using a devm action. Add the action before the exynos_asv_init() to avoid an explicit call to soc_device_unregister(). Signed-off-by: Tudor Ambarus Reviewed-by: Andr=C3=A9 Draszik --- drivers/soc/samsung/exynos-chipid.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index d3b4b5508e0c808ee9f7b0039073ef57915d60fc..49cb113d99f314ed94730cec2b9= 8f48a1a7b87f2 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -14,6 +14,7 @@ =20 #include #include +#include #include #include #include @@ -104,6 +105,11 @@ static int exynos_chipid_get_chipid_info(struct regmap= *regmap, return 0; } =20 +static void exynos_chipid_unregister_soc(void *data) +{ + soc_device_unregister(data); +} + static int exynos_chipid_probe(struct platform_device *pdev) { const struct exynos_chipid_variant *drv_data; @@ -152,28 +158,19 @@ static int exynos_chipid_probe(struct platform_device= *pdev) if (IS_ERR(soc_dev)) return PTR_ERR(soc_dev); =20 - ret =3D exynos_asv_init(dev, regmap); + ret =3D devm_add_action_or_reset(dev, exynos_chipid_unregister_soc, + soc_dev); if (ret) - goto err; + return dev_err_probe(dev, ret, "failed to add devm action\n"); =20 - platform_set_drvdata(pdev, soc_dev); + ret =3D exynos_asv_init(dev, regmap); + if (ret) + return ret; =20 dev_info(dev, "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n", soc_dev_attr->soc_id, soc_info.product_id, soc_info.revision); =20 return 0; - -err: - soc_device_unregister(soc_dev); - - return ret; -} - -static void exynos_chipid_remove(struct platform_device *pdev) -{ - struct soc_device *soc_dev =3D platform_get_drvdata(pdev); - - soc_device_unregister(soc_dev); } =20 static const struct exynos_chipid_variant exynos4210_chipid_drv_data =3D { @@ -206,7 +203,6 @@ static struct platform_driver exynos_chipid_driver =3D { .of_match_table =3D exynos_chipid_of_device_ids, }, .probe =3D exynos_chipid_probe, - .remove =3D exynos_chipid_remove, }; module_platform_driver(exynos_chipid_driver); =20 --=20 2.52.0.rc1.455.g30608eb744-goog