From nobody Tue Dec 2 02:05:26 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70480372AC9 for ; Thu, 20 Nov 2025 11:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638182; cv=none; b=FuUE3loPFVaexsQtIO84YDgZ39Qo5tyLJ8g5n2OzDd9tfZDTyDoaWctHNQcduEEWzv1/Eg3+nImoBxBslsTsVZp3MshdrgCYLNpWYW270uvbTy27B/LlNymAAeoWwf0ZQ8ruAfq1aANVLRHFRc6FLUPQ04stoLt5jqMP2EGtWN4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638182; c=relaxed/simple; bh=q4SLhBlNs3t93tDVbeMVgBT6CvDIqD2qRVhlhlaXWaw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IimFdpYbgzE0oSVG8cit5sfDVcUrqCmCYvbcMQs8iOS2aXOq7kDXxZ+IlsHL4FafWraGkBlPbVKUGbeczwuFLOkNHKim2KYosz/A2+z+oK38MydvdJk4wgOKOGaJd4V0ArsvpQu2Hh5IudktosOymP6smi3EEf+EMT/Nj5+RCM8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V0NHX+wb; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V0NHX+wb" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-42b3c5defb2so471972f8f.2 for ; Thu, 20 Nov 2025 03:29:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763638179; x=1764242979; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PuKrcuoBI7d5g4q4orKG9nRm+eFjAB5tnSDzYO6y5WQ=; b=V0NHX+wbWwNwM2r8DpiOMQQ1egjGv6JSAI6A76ss9M9w4FQqACSfqeTQFpfjZnjez7 9sdtOH7ZC3yaZAPtNcVu9pg9Q3S80sy+eX3KszWhzKbLjqR02ecqfNi3Al9f6OkhZrPo vYCmVBdBC4G7y7vNMTyv3ZIyj4+ufoHKETeSWDi7fh3mI4aKpgSpz4u6+xlNvHXKEA+X XPG+scsE9ywKsaKUv6jFXxKGbqR2gjLPWX8L7RPbz8ZG5+cDG+6/f398Ow+wgs8B1l43 i7rPPLqO6zoX9nQ/pMoKLdxyGbvJE54I2+D8cDiJaHBuKlqG+nhhZIJ2P7VQjZFFk4mJ V2QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763638179; x=1764242979; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PuKrcuoBI7d5g4q4orKG9nRm+eFjAB5tnSDzYO6y5WQ=; b=TDa4hf4+NgDVlQFprrH7TYAgrH67v2ND8Zn0f+RQlaIoqmIF+6n6VmZBgk3lLmRoDz 5Oi36ZBMsoYdLYhlmRE5HprKhbNof0jQI9w5zZVxO1bER12om+0KjatfYdK6qsiBI8m9 h6wzcrpllHiSr1pML8HyRSQwvYmCRypyQ83/QalCa3N55Z0LcCWlOVfxm/PcqVY2D+vM 0LbM9d0PVKjw6LhVLO9p2gUTwFkC3+jHSwhdaVCJmZkrBxyMohj4mDm8TsmIzh4Bmeph zkoSegxTwnvOvSzToY/3W61royrTDnDEqLANRqgP4Botqpk8lTKxkEyT3jzfaKUVruAF ZTuw== X-Forwarded-Encrypted: i=1; AJvYcCWyttGjICH0pq/8060yb6SBvA00xnY0wA1Wk2a2GVrntwbZ/ky7ZRtxPwPCSbS7qfJwD4YzpoibLPA7xfI=@vger.kernel.org X-Gm-Message-State: AOJu0YzOJhJbxQYfZCuS1IQeSa5S8xJPPAXdP4j/d/7w0EMHdqa8fDMq 79LixZxRMjYv55jS7O3J8Mz2qIZBZEuzFi5ZiVUEtdg5KsyHR1/tkhb/BHGcUgfjs1g= X-Gm-Gg: ASbGnctU3u5IewKttmm31E9OQ6iGkI9ho37Lm9ynL9pw4cBQVQJBgsj901lLey8tsHB unD+VQ+q2e6BjjAmRTzjZiblHCC9U3kfcZmw9DYnqLgzXl6gdI4Q84MSgtm4JBKC6SJFuiWh8M1 biidfUaGGUg155hL9fUUYf++ZKU5UF5i9CjJyYCFDVGkZNde1mSskSztybW2H1XqnfN48ZOt6vX See6XcwKa7wTim3JIEuJplvHnXdsk1jAfvylP+Llpel+PJb5egZ/t6sjtaVJWuBf7Xx1z+GgIjY R4MuHVSP9JYAthA3fMiQv54ohI+hfoFUlcCFDjnFQtGte2LTByd2Us1pFF8EbXSX6PtbUApmdfG G7Y8XlY1O+tx7DXmiehIPsHqEpIU3liXsv6lwe6MFjBxi8+F78m4auS1UAek7e9dDo9RScZqZzb y5Q/O1JfTYSO5KmTEjj7Qca8nZpH4doVaRKqc3zcQaNlcxEs2/5e+asZ/xQUDEebzoYa4= X-Google-Smtp-Source: AGHT+IEvA1MyH031OEvH24ynuE0LyStn/WEmFOJ9u6ZU8yrQYuFsjPCmysl8RrhQB/MEu5VH/0+U8A== X-Received: by 2002:a05:6000:2388:b0:42b:3366:6330 with SMTP id ffacd0b85a97d-42cb9a65915mr2696231f8f.57.1763638178815; Thu, 20 Nov 2025 03:29:38 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34fd1sm4961040f8f.11.2025.11.20.03.29.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 03:29:38 -0800 (PST) From: Tudor Ambarus Date: Thu, 20 Nov 2025 11:29:35 +0000 Subject: [PATCH v3 1/6] soc: samsung: exynos-chipid: use devm action to unregister soc device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251120-gs101-chipid-v3-1-1aeaa8b7fe35@linaro.org> References: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> In-Reply-To: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763638176; l=2398; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=q4SLhBlNs3t93tDVbeMVgBT6CvDIqD2qRVhlhlaXWaw=; b=nK061O76WMFoYj9rMWr/tOtXFH2+xEeqZerjwnB7A5ZG9eGCMLEYmueI7BG1LxSjTJ8CCK8ZB sgwYqPwxkbQD0CIyqIOcBPEiT2aDWcKRx3u/B8eAEUDo0B4tH3RLzZu X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Simplify the unwinding of the soc device by using a devm action. Add the action before the exynos_asv_init() to avoid an explicit call to soc_device_unregister(). Signed-off-by: Tudor Ambarus --- drivers/soc/samsung/exynos-chipid.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index d3b4b5508e0c808ee9f7b0039073ef57915d60fc..49cb113d99f314ed94730cec2b9= 8f48a1a7b87f2 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -14,6 +14,7 @@ =20 #include #include +#include #include #include #include @@ -104,6 +105,11 @@ static int exynos_chipid_get_chipid_info(struct regmap= *regmap, return 0; } =20 +static void exynos_chipid_unregister_soc(void *data) +{ + soc_device_unregister(data); +} + static int exynos_chipid_probe(struct platform_device *pdev) { const struct exynos_chipid_variant *drv_data; @@ -152,28 +158,19 @@ static int exynos_chipid_probe(struct platform_device= *pdev) if (IS_ERR(soc_dev)) return PTR_ERR(soc_dev); =20 - ret =3D exynos_asv_init(dev, regmap); + ret =3D devm_add_action_or_reset(dev, exynos_chipid_unregister_soc, + soc_dev); if (ret) - goto err; + return dev_err_probe(dev, ret, "failed to add devm action\n"); =20 - platform_set_drvdata(pdev, soc_dev); + ret =3D exynos_asv_init(dev, regmap); + if (ret) + return ret; =20 dev_info(dev, "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n", soc_dev_attr->soc_id, soc_info.product_id, soc_info.revision); =20 return 0; - -err: - soc_device_unregister(soc_dev); - - return ret; -} - -static void exynos_chipid_remove(struct platform_device *pdev) -{ - struct soc_device *soc_dev =3D platform_get_drvdata(pdev); - - soc_device_unregister(soc_dev); } =20 static const struct exynos_chipid_variant exynos4210_chipid_drv_data =3D { @@ -206,7 +203,6 @@ static struct platform_driver exynos_chipid_driver =3D { .of_match_table =3D exynos_chipid_of_device_ids, }, .probe =3D exynos_chipid_probe, - .remove =3D exynos_chipid_remove, }; module_platform_driver(exynos_chipid_driver); =20 --=20 2.52.0.rc1.455.g30608eb744-goog From nobody Tue Dec 2 02:05:26 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B0CD313E3F for ; Thu, 20 Nov 2025 11:29:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638183; cv=none; b=NYuuVAy/cKUEE74Md3hN1mOUVmAG/8zeJOKFmqDqeI9hputWEGWBNm6Y6NBLQaH4k430gJF9R1nMY9F+HJpytRStdB7rPVfFWwnjD4pwSBbsaUXu2+19Xva3tYsUWDCimM/UH5UgkVUrWomThwfEf3rTjrN7tdZVfKYLF+or+OM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638183; c=relaxed/simple; bh=ydziPpmvPsHAqypZZhan8Qbcj761T47in3GhwmLevxY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DX9KzDEVjU/fTTDcGb95ndCnZgCTwVgvTiQizOHIA846CNF/s5mPmUJBcvd+yUbz8NdLecRR2tt4MkvOzNrZvnCrmUIpDStMwdNiI+YGnvPdvWtgHzFRqeAuThPzPnDJqhKsBRaD/WZ4ahEzj7W1NRQ26HYgVBQo2aShEldPNFs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yXo0eDH8; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yXo0eDH8" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42b3669ca3dso319893f8f.0 for ; Thu, 20 Nov 2025 03:29:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763638180; x=1764242980; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XaAjSoY/nku4Rf/DgaeK7ZZ3RvPX6WjghtPiUfT8Z6E=; b=yXo0eDH8a39wf2mJZi5ZCmO24JkO8uqcNDlofYdzhqODguuHUFfSOEjClgSBkBldGI bELcTfoT9IufzwIV0FFnxFsx6YOTA8Tu3BEHBZb0bzmr+gx60CYpbHa6XJGrcc2EoYkg T/EFqPjqKIiKLBjwPfb5sUkt9jZCXKZoY7TO6nt6d1cFYz7ooIpeG0EilIUkA7gcmOvh lsilJuMTD+Bid+C6E9SPRegYHoMYypzhVFmUM070b4rC3RjXyvfEGpSA22zyANYVgeXb YQrYDuw+9v9ugMntVQGPHqdkUszOI+NUIwoRELfkV+k9cS74qJ40DZ9DSrGdlvRsdJ9q bPCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763638180; x=1764242980; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XaAjSoY/nku4Rf/DgaeK7ZZ3RvPX6WjghtPiUfT8Z6E=; b=uUD7a+qafV8EqVnak/ro9Bqea4xIsdZnOJU84qsHHdA1CrIQA4dVitvmkIAiQo+QxA M6tlk51CHPFqTpVf2JznLq6ZWpHsfcAAL06zhu6pHjVgMslZcNjWX5EMZuIKDAdWsk4T 7RXiastdESSraFEtvFfHDrVB7qQmyMC4JuiJhOA6qsB6rnPiQE2EIearZdOOzYg6iaxE qDHxs+dPwIz/cNq/LQmong+pcT49NtsjVRSftmoUoeEpH3ISODkbNGn3Py+8zlTfEpXn ryOSNVr4oCL9qv4PMxO0WxxLwHSkVgkt6pEnTCA5xe37S744uxudxUqFfbc/hpCeMpCS jHYQ== X-Forwarded-Encrypted: i=1; AJvYcCV91TymQGK9kR7r+NO3bca0V7DH5yg8NuENrPhX4lMXAF/vV+bVxZWf9iQkMC3M94INnB8IwtzDhbbWhuw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5AikhjA/kTx1HAI35sv1cZ3y86w5xnwdmvGiXm/XWyxd7HXo8 dWfCCIpVzsU3v8Y4QKwKtWmyncbSQqWTT455iwOfY4oMNNkmbJvgPgHghZlOLMVWqRs= X-Gm-Gg: ASbGnctoxiUtm2V365CwI4a5C6uBkyYFVrT6XkbPVT7RyTfAke3lJp9BcgeCW53gHz7 MGl/Nd5wxe88L6AayV2SiHuqcRti+VWc1pS5y3fqjmYBsPJR+LizVziKpBUSRsKUPnSfWZsizeq h4wQSguu2ET0x+XP2n5GN4ZVBx4Fa9eGs3s2NRN1G3LfeTqUF6odBJLKVJNU7809Orf+LXG04Sy /hZoUPu6o8SFlrNTeOhznWzgUCpEhyHvd4pHTKwAMY83ZVrJBXkyC3L1nhpEo4nCb/NIdkLEOuL 7aVhmLuKADya4evGG0XgG/SF88IHxGCUxRHZaS2D+MbD0a8fHHk0RCOe5JQryJ+B5aRon4zGUb/ 61RtNZG8h5eud0ROQxPx/mFhTOl9rwdkt9r/24HPtGpGWFUoycXH+qlq9NYZqQOYh0798jLXnO0 ELIlX4evSlPM/vj4uqIfcur7kQ5zbRvZCisUbxATWdxQW5eWbMX0oHMZ4k5BKOs+UIkdk= X-Google-Smtp-Source: AGHT+IGbKsNEy/oueUtizdEXhVcAeX3YEdD+UJr2wvqpgctEkJQ/yJL/aveJn6ori9RZU00wT99XRw== X-Received: by 2002:a05:6000:1846:b0:42b:5448:7b06 with SMTP id ffacd0b85a97d-42cb9a219ecmr2426328f8f.13.1763638179927; Thu, 20 Nov 2025 03:29:39 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34fd1sm4961040f8f.11.2025.11.20.03.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 03:29:39 -0800 (PST) From: Tudor Ambarus Date: Thu, 20 Nov 2025 11:29:36 +0000 Subject: [PATCH v3 2/6] soc: samsung: exynos-chipid: use dev_err_probe where appropiate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251120-gs101-chipid-v3-2-1aeaa8b7fe35@linaro.org> References: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> In-Reply-To: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763638176; l=3106; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=ydziPpmvPsHAqypZZhan8Qbcj761T47in3GhwmLevxY=; b=3QfKC33suSvG0rhHt/+ek4MMRHqRHtNEUYflZ9HpBIoEjKBWMgp5OHbOKUXglp9RLJujxdm4Y eJ0sTaG3i8yAL0fq7oX5LmnwNS87zA7ibX3lE4bZJ0CXepRz/sSZvBV X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Use dev_err_probe() to benefit of the standardized format of the error code (e.g. "ENODEV" instead of -19), to get meanigful error messages, and for more compact error paths. Signed-off-by: Tudor Ambarus --- drivers/soc/samsung/exynos-chipid.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index 49cb113d99f314ed94730cec2b98f48a1a7b87f2..b9a30452ad21c326af35c06a341= b28491cee6979 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -81,8 +81,8 @@ static const char *product_id_to_soc_id(unsigned int prod= uct_id) return NULL; } =20 -static int exynos_chipid_get_chipid_info(struct regmap *regmap, - const struct exynos_chipid_variant *data, +static int exynos_chipid_get_chipid_info(struct device *dev, + struct regmap *regmap, const struct exynos_chipid_variant *data, struct exynos_chipid_info *soc_info) { int ret; @@ -90,13 +90,14 @@ static int exynos_chipid_get_chipid_info(struct regmap = *regmap, =20 ret =3D regmap_read(regmap, EXYNOS_CHIPID_REG_PRO_ID, &val); if (ret < 0) - return ret; + return dev_err_probe(dev, ret, "failed to read Product ID\n"); soc_info->product_id =3D val & EXYNOS_MASK; =20 if (data->rev_reg !=3D EXYNOS_CHIPID_REG_PRO_ID) { ret =3D regmap_read(regmap, data->rev_reg, &val); if (ret < 0) - return ret; + return dev_err_probe(dev, ret, + "failed to read revision\n"); } main_rev =3D (val >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; sub_rev =3D (val >> data->sub_rev_shift) & EXYNOS_REV_PART_MASK; @@ -123,13 +124,15 @@ static int exynos_chipid_probe(struct platform_device= *pdev) =20 drv_data =3D of_device_get_match_data(dev); if (!drv_data) - return -EINVAL; + return dev_err_probe(dev, -EINVAL, + "failed to get match data\n"); =20 regmap =3D device_node_to_regmap(dev->of_node); if (IS_ERR(regmap)) - return PTR_ERR(regmap); + return dev_err_probe(dev, PTR_ERR(regmap), + "failed to get regmap\n"); =20 - ret =3D exynos_chipid_get_chipid_info(regmap, drv_data, &soc_info); + ret =3D exynos_chipid_get_chipid_info(dev, regmap, drv_data, &soc_info); if (ret < 0) return ret; =20 @@ -148,15 +151,14 @@ static int exynos_chipid_probe(struct platform_device= *pdev) if (!soc_dev_attr->revision) return -ENOMEM; soc_dev_attr->soc_id =3D product_id_to_soc_id(soc_info.product_id); - if (!soc_dev_attr->soc_id) { - pr_err("Unknown SoC\n"); - return -ENODEV; - } + if (!soc_dev_attr->soc_id) + return dev_err_probe(dev, -ENODEV, "Unknown SoC\n"); =20 /* please note that the actual registration will be deferred */ soc_dev =3D soc_device_register(soc_dev_attr); if (IS_ERR(soc_dev)) - return PTR_ERR(soc_dev); + return dev_err_probe(dev, PTR_ERR(soc_dev), + "failed to register to the soc interface\n"); =20 ret =3D devm_add_action_or_reset(dev, exynos_chipid_unregister_soc, soc_dev); --=20 2.52.0.rc1.455.g30608eb744-goog From nobody Tue Dec 2 02:05:26 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E72932FA18 for ; Thu, 20 Nov 2025 11:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638185; cv=none; b=U5ES/8v0GPQzbnOaD73Bwtc56CRMz3oNDWmzCjpRjc+iuCnB3PIdEPSXEk2oJNopQXznDJRIz4WtVlRx9VsPDD8Qt0okYphuNfYJuA1Qo4sqU+lgqm/Bwm9yG0ijoEIHEVsjSWzpbPg40/c8+zsiVMUvqj37QVsjwn8wqa3ppAY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638185; c=relaxed/simple; bh=QuLzD1mgISg4zkjQX+NNcW0jz68RwUFmOx017oxWLlg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BOM0szpdB2QRhbYczDMBhU2cuF76UmtVo8wZxHwFP3cYJxoU2pN0FSmGRIEUlF2O0QM10SygNQP0fqO7pjBeU3ntXl5Z5QVAU7HUeeOEME9sUG2vW/uUn84qK3Ie72X1Ylkf0yi7pN/W8jc/KIrc/Evng7Vc5dcTTdyyJ2N8pLg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=j8twkoKf; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="j8twkoKf" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-42b3c965df5so430528f8f.1 for ; Thu, 20 Nov 2025 03:29:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763638182; x=1764242982; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vrfTebO8rNsGDrFrDajdUyVNoAVMli4DcnLnNa0zpcw=; b=j8twkoKfdnQ9GWW7GDaJldMC00UajzS5AivPA7Fc8gjZFpSoPpiKMOmo5dnSdxxRYL UGe41LbHENmdTNkvixXtX17gv064qCnWp/EDTzObvlYNkOya/cArlGDoQzNGksk1aw2l 87nK/ZC8xwB+WrAiFTVpNIboV5Vyo95oX5/SMpcBtbJMg/idsGWavozjDto54GcgJp1U 3MSZ77IndXUAhP+m3axtTuDJmUExIn1BWpIn7J2BOmsa7AjXjcYn4uNU9JhpczNZvdye z1x+12RWiO85PfIWVgCGzCghIyZInO2XQSyuIFMKHMD89nACfnLft9vcFCz04UcdeVoE NkOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763638182; x=1764242982; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vrfTebO8rNsGDrFrDajdUyVNoAVMli4DcnLnNa0zpcw=; b=jj9ekNgfOju3It9xoy0SgCUrXCJsOS3lBlCj0cuYP7tl3ThDf1EJrTh6/1ffffhCuk PoFc4ZRpTw/uh0WVifqG27pSw+4EVP8snwpWcQw44wteps7UbmOglV7zjQOYKTSfIDNS RgRIf6c9vPEFJ33WDHQw4igSWvFjQhE7fmiga2y7N9PhozmwjeqIOcPZlPS1ugZ59hZU RY5r8Cw/SS++pe8sOK9C0b4p9XhKt33eqjafW9NNUJqR6HpYHBNpwHRHXJQ4Xpw4legz BMO9wbAL6w6d6IjnpVNHkeCRDx3hHYw8Gz/3n140noqkA5VPMyuNGQiPfD5cMIZwvAnH Qmjg== X-Forwarded-Encrypted: i=1; AJvYcCWfN0pu+c7ANy7GTCwu6fABoqwXsHCAc7vGJ/NOIx5Hn2DGcI2lH625wcz29CaatLlYZnZvjpckrSuas9E=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+vLYnFJS4IoepXP6SU4VKqzmGNvH6oCDS7/2sMhSczmRwOTyE b6zIIzbj08wIt4Q053ZJGdMEfF5ZEK3TsWC+TGwR3mgFoMnwYjW7Axb8G9ab92QynaY= X-Gm-Gg: ASbGncuQtwV2oEVlevfLCU0cLhHCdkjBhzq2LLceQYde2Dy3ilkH/xRLM5a5O1gwZ2q sXvBf16LSlE2z+MArc5NZRCezyRYbNFJ+CVGNtkbLFNdhs1M4JWrLbovizYsguKmmGB/YGnkdwJ 0wO4D4FvDaRQvuaQcranUxAAoqlt7t4nqgx5RYaYSz7PBQY4B6IBe/4bWABPMkrq2rTwflOYBAC DtGO4Y3yavJLN7AltdqBc+PuE6MzXYCKTyzc+iMXXsT/u3N/XuNc9Z2+9ekONrBpgb0TzuxvrrB 5jO/i2dIeFBvV4DPsTysMYD0u0/EzZPaCRgojABbmWYy6YTaCbO3FsKKWt1XINhjQV9KjchBObU SwZI0xGBe/G2NAmDKSPiSChLgcGvlbUxGfuaF0s1oSmXIqi2KaQaWF9NgfUTOkLb61yyhBpwDg3 g0/bzIlS0yU4llzG6pRnaF0ewveYNE2viJcEPJySCbgfNIlAbNvbtOluOYGDe4xspK1G3tTB2ol odWVg== X-Google-Smtp-Source: AGHT+IGMAZHNjJ7KaxZQW1CKSy0e9pKm4Sui3wq/A13ZWcUF9r4m0xVl2YKFgMjFczOXBPsIBVjfGg== X-Received: by 2002:a5d:64e3:0:b0:429:c2fb:c268 with SMTP id ffacd0b85a97d-42cb9a7091cmr2496273f8f.56.1763638181851; Thu, 20 Nov 2025 03:29:41 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34fd1sm4961040f8f.11.2025.11.20.03.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 03:29:40 -0800 (PST) From: Tudor Ambarus Date: Thu, 20 Nov 2025 11:29:37 +0000 Subject: [PATCH v3 3/6] soc: samsung: exynos-chipid: rename method Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251120-gs101-chipid-v3-3-1aeaa8b7fe35@linaro.org> References: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> In-Reply-To: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763638176; l=1404; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=QuLzD1mgISg4zkjQX+NNcW0jz68RwUFmOx017oxWLlg=; b=QwrG8SY+YQBiiH7MPcJkxfx1Dq3aLNOQbU0oxhLO628nA25GYuZ2PBNpZnlbdqR+mDmqspLbe gtSnFLhRo5TDgGu+KU8rF/8hHzrHdNmGF12KCR3TWXjovKn+lNDkDqn X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= s/product_id_to_soc_id/exynos_product_id_to_name. Prepend exynos_ to avoid name space pollution. The method translates the product id to a name, rename the method to make that clear. While touching the code where it is called, add a blank line for readability purposes. Signed-off-by: Tudor Ambarus --- drivers/soc/samsung/exynos-chipid.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index b9a30452ad21c326af35c06a341b28491cee6979..88d264ef1b8835e15f774ff5a31= f5b3de20f74ea 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -71,7 +71,7 @@ static const struct exynos_soc_id { { "EXYNOSAUTOV920", 0x0A920000 }, }; =20 -static const char *product_id_to_soc_id(unsigned int product_id) +static const char *exynos_product_id_to_name(unsigned int product_id) { int i; =20 @@ -150,7 +150,8 @@ static int exynos_chipid_probe(struct platform_device *= pdev) soc_info.revision); if (!soc_dev_attr->revision) return -ENOMEM; - soc_dev_attr->soc_id =3D product_id_to_soc_id(soc_info.product_id); + + soc_dev_attr->soc_id =3D exynos_product_id_to_name(soc_info.product_id); if (!soc_dev_attr->soc_id) return dev_err_probe(dev, -ENODEV, "Unknown SoC\n"); =20 --=20 2.52.0.rc1.455.g30608eb744-goog From nobody Tue Dec 2 02:05:26 2025 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE27A331200 for ; Thu, 20 Nov 2025 11:29:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638188; cv=none; b=ExJh6/eo91fHp/X3QqsN4S/vrsVhiaeX7U7xHWfT4OfOgz5zloa6elYTieZtEiESNUclUgq27nCTteHlwqO4fXm4A40wZGyOzvDBbHruPfcTT2ZAUjXEcd8vVM2QYwRFNQ09bMIokLMOoatAJtvuC8kIAqVHYzq0Re098EhODOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638188; c=relaxed/simple; bh=Y18z4hcXC90TeZ6W8D9Rbg20IQrWgPSKie5Vj93bfbM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FUQGnUm8SaZvX3vx3eRqQEtSOJWKU7u/PFMHFIlrQ14IPIPMTbsOO/0pS1X6TrqR0Mup5EAE2LUBGZppdfRw91anPwb/ARjxyNI7HFORRRapJbWAs4aG3kcbhjctm3FWrxvG29PbAVPFrB029yNCfyS5M3IVDDzMbktsaxZZjeo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GL0QwrkG; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GL0QwrkG" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-42b38693c4dso362795f8f.3 for ; Thu, 20 Nov 2025 03:29:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763638183; x=1764242983; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=A3hYzhfbEc/1h0Rp/vYsV0pqk39zwnFra4S41/QfDJQ=; b=GL0QwrkGuvGhbVazsPyQkZb4wFxNIsEY8vxRo6lK/nRc0l3MTiOXxzXC8++pNzkxFf DVEGhxZlx826OT3Cw/q5s+/76drcDNZ/LquMHI8uN3CVDBbzHhcnmpI9l17XTUqjMB+q AaK7BC3hJ9XmLCuwG0VBlGfvsmTEoMiwInK3uwa//gwyIXtrX6cW96WQ9uMBcL0oXhCc /vSlxdqvjvuWKIpWZ2HaROFfJiU1oCjunLg7zedIR4enKcLM3yw0E+1Yagc9e+7gX2Ye z4OGAofutYI/ftLizWFXWgHkd5wZ7nWXdsV2JD1lr7BUFGk9gL9uoPNvKcNd+UkoZwWn r77g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763638183; x=1764242983; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=A3hYzhfbEc/1h0Rp/vYsV0pqk39zwnFra4S41/QfDJQ=; b=uZ5+qf7GThHgM1E3lsII/DZeL69cUQ/m+C72IhHUUdChd60C+4Tz7HC52Q9kOZVu// pIpMNI3juc9LBAzBXG9QhxbP8NhwLH+7sBjNfLfT4QFZHSbzEAAcSDLFM+haYe+mvaaj AEfpGI8Z0aIoexAPtPrBp1Z91P/c6ItVwm34DXGvhw21XhwHk+2IhRONcw4sFAfF15jk y4qsEKNM/CpG6vVlEx5+zCVPTX74n6UiuXm4+FD07djC3p5BSUVCkfuHzHod8ivJIfIl UJXt/GsL2UrdOGfXFIPyrqTiuWQcVYOS6LSdvTGsyhw7GfV8GcS8Oz5IdUTP4RBpbj0U 85cA== X-Forwarded-Encrypted: i=1; AJvYcCUk0pibKnPc46S/sgXqBtWPg13KWDmpNkkIFHeusydmydpg8B2eX4LdQct7yMI8+4v7xUz+rSBz+Jv3A2k=@vger.kernel.org X-Gm-Message-State: AOJu0YzUZgVllUc0xe/O7CkaMgkZdjiqTwDbSSL71ePHz+gsGUHHqjfh RLumRWR+1KC36zfJbicMMRqCD73wUCKxQMl85b/0FiZBK0E0HE54FnDwWO+gEcgPs9Duc//53g3 FUAEiwMs= X-Gm-Gg: ASbGnctIZ4pK448gLJsyMzFm/PvfcKjw7sc5iUeEiP+B07WGlFBCB8GVNslsVsTjJ0l fYWbGrOsJXC/NbMo8KZPFLHTbmrhSNWqkJhk9rBg3WwN8DRN1lK5OtpZKflmZERcm6IjbLTrap8 xvDh47JKg8p0GeSKIO3fasc2TKfAFwRc+Z9Y0w8dQzqE4tKkXnGIS5Ug/7QA6/p2KGSaK/wYkti J3HpmLe3PCP8p9264MmZmNVUbutfGdRegzC7GKxBHnzHprFfA6k7CkTNGPu18rHjC2JMGfUhDub porY77M/SphTGLwyzSC24buklDkgyqU8FGnwkTgrjBgwGzlvbkRGrqeAcGM1LyJm0bIy+5h0uQj bVp7ZIAwEt+1W0E2RPC+w60qXBsOXaU3o9XomR+fhr1rHsyfOwWnEy9uKPTlLkg+hoOALGAK7E0 sTF3aqDGOoCb2YG9kRZeiydI7x8Irl/uAu0AZmWWgSrYqXIhiFu9JA1A/2gnhY34lsNYc= X-Google-Smtp-Source: AGHT+IG4ntQvX7ciO/wU08V89VgHHrDt7L2n7nGEulisMc35UphimRXBwOW+cZM5Xe/Cnjl9vBsYow== X-Received: by 2002:a05:6000:22c7:b0:42b:3b55:8929 with SMTP id ffacd0b85a97d-42cb9a2c101mr2454960f8f.19.1763638182983; Thu, 20 Nov 2025 03:29:42 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34fd1sm4961040f8f.11.2025.11.20.03.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 03:29:42 -0800 (PST) From: Tudor Ambarus Date: Thu, 20 Nov 2025 11:29:38 +0000 Subject: [PATCH v3 4/6] soc: samsung: exynos-chipid: downgrade dev_info to dev_dbg for soc info Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251120-gs101-chipid-v3-4-1aeaa8b7fe35@linaro.org> References: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> In-Reply-To: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763638176; l=1017; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=Y18z4hcXC90TeZ6W8D9Rbg20IQrWgPSKie5Vj93bfbM=; b=x7UrtlIUxcERWQm8HpONr2RHp67YbtcMLunqjbK/iMafjMqh43jKa8vPbr0uc0A3LNBdYp78R 2RkQ+44aAl/CZIOW58N+VCip6YSMoUJ1DOYB0/MfEsW1dxBkj/FqLOd X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= The SoC information is exposed to userspace using the standard soc interface. Downgrade to dev_dbg to stop polluting the console log. Signed-off-by: Tudor Ambarus --- drivers/soc/samsung/exynos-chipid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index 88d264ef1b8835e15f774ff5a31f5b3de20f74ea..5c8660374269c87ec38ebca2429= 18bd7b1d362e5 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -170,8 +170,8 @@ static int exynos_chipid_probe(struct platform_device *= pdev) if (ret) return ret; =20 - dev_info(dev, "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n", - soc_dev_attr->soc_id, soc_info.product_id, soc_info.revision); + dev_dbg(dev, "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n", + soc_dev_attr->soc_id, soc_info.product_id, soc_info.revision); =20 return 0; } --=20 2.52.0.rc1.455.g30608eb744-goog From nobody Tue Dec 2 02:05:26 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDFFE32F774 for ; Thu, 20 Nov 2025 11:29:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638188; cv=none; b=F5VacpYXrmirdVfB7kruMhfWV5m2f/jRFmIDGIpHp4DtO8YnIk7pmlCSTGtDw5e/H2c50qiy2OHJa06Y6jwtx8ZDyTHHPwecTf97KFoCf2Ubk9lqsc9iXxzpaKUw05dJfY5LSm0+r7XuHAUNgYB8uvih78A5N/zAJH4IABCdA4w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638188; c=relaxed/simple; bh=Hx0Wk3GLsyUiGvEN/qp5B6nJmnx3EpkHuI8i+qqhClA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bAB/FHG5SAiy5Ktr4aY4wIywUz9b74W0o4M8xrLNDvyARbkW0fLRE8jC7XxSSCXtWY38ten+HwjYWYZLA8wTFMwisrDjUgPYno0r/z5OFFB3aYJN+S18FTc0eUGxD3WSYgscc9sQ+wk5nh2UMvlfgIjbQFFyeHJv9goHY52t2bQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SOMoTk+L; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SOMoTk+L" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-42b32a3e78bso649680f8f.0 for ; Thu, 20 Nov 2025 03:29:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763638184; x=1764242984; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xGjx4noM1tm5gVaifoDiY0Cc8fekcKfT3Xb17cdNq9w=; b=SOMoTk+LLXZ/LBOyJP11kx4f/F2h5Wo1jwbokgQUa8YulaGR6unZDH8QJlMNDXPjTu TpfuPO76F8eABjvJHUCWyp9N2fOOoTQXg2lK4HCes3UX/GAFIpE8Ucb88LxV99tXt30l tRLSkmWcSGaufXSqOv3jmCMbaUeOAlXhOT1Y3/LUL1pZpVAN9q9gPWADr/Pn7+cdaDO8 Rqz4TfP0lmb/SW0hTwM1m7Ix6VWLlbZeF2g4XeLxxIEX/Zy+1yAWyDuo1EIF9IpD2T70 UYUdLBvrita1IpRdUT+Fo/PFO99yBH7WsVYr2qTQV/NJ6y8Y3KNPEkEo7KIe2zqVWnLB +VXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763638184; x=1764242984; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xGjx4noM1tm5gVaifoDiY0Cc8fekcKfT3Xb17cdNq9w=; b=Ytb4+dMEVkb1vLN+0HTP/EYzISSHZAEUlvcap8eQk79znn12bKzJKd67+73qP/zvQS LdCAXge9Sa5Jr7FxSuCJWCXJHWyIlKr045sPmW8WNCy+QgTzcrD22EO/H29b5IJv3Grm eMQBTQu6hRra+fdMa9GKIZVgSGaVpMawv2zu5HJzvUb+w5fTe8H+USG2LobNz8mRbLGJ DoECZck+L2uXCgprlot42cjkpOZrGX1Fw3b5wWuNoGRvLZjsYTxqsPGkyd8HMGgCjQqy UUFuImz82p0WKQhefVm+aCEK5LTyEySvzpPFECxmWPQ3Io0fH/TfIV2SEZFmp3yRthv0 Fi/w== X-Forwarded-Encrypted: i=1; AJvYcCUGpxZlLWYLEcz7SB/l52rebqrXthrbysgPa2jJhIXAiDNf3mlGL5UJOC4AGdDH88105N70ByyujdZ4yiY=@vger.kernel.org X-Gm-Message-State: AOJu0YynL7iS7QG2gYKiUIfFr58DEqwwGdW8H2oXbCONGwflWeXGvnKC MfqYuDx8c9oSaboyv/igz0qtL0G1NEPFL3jwcqCLU5OQ+kDA1ilEyTWgAaZCP4IzRCg= X-Gm-Gg: ASbGncvU00+LO5eDQnr+mbV73i4atDTCcQ/lvL9aXwsuHxjTvKOe5BMdWQdTeeyrC+x oucp9AI8cQaE7Ij+FCFA9LLZGmjAPnfRwb9++ZOHVoIxopSBa+1XTb6IumXdF84ddUfyPjRuoFE I+EltjUrPW8h0OXqCtRzSjKPwRyFwwyotGG5PhYpH0x9C2+CIUbPhEcJ9G9x18tNmnf/mc3nrFX 4/fWxvPNpCKcM7p4s2v6Xghf1oJssBx2vJtng4dzMfb/ZWmUFOu2QJghOxogMgOesLHYTJzQhbZ V1NLy3gYMi/ct/wQw3/RBIOWOJ9/HCZ/msB5y189bUPZVK65b2e7tztCWrpRqzM0PoeSF/mlC54 PAmFNJVMSbjcsriF+ZHfWUJh4JcRQ1zX6rz+WNK9Vu1ZnaVe6rm/HHCF0AE7qzOetkBL0iumo71 HenFkccxfxcQeU47iPdfJFyXe4wnfwDEBIhepxXiD3xflbPtlyKO0KS9HkJn526xQaB3k= X-Google-Smtp-Source: AGHT+IHLwhppa11NSu0fg35jlo/DjGMaiLuTQ/yFrCLaSK5ubFNizQXGeSmz5gWNNC42PHU7x92MmA== X-Received: by 2002:a05:6000:288a:b0:42b:3746:3b85 with SMTP id ffacd0b85a97d-42cb9a5c1c9mr2024241f8f.45.1763638184091; Thu, 20 Nov 2025 03:29:44 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34fd1sm4961040f8f.11.2025.11.20.03.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 03:29:43 -0800 (PST) From: Tudor Ambarus Date: Thu, 20 Nov 2025 11:29:39 +0000 Subject: [PATCH v3 5/6] soc: samsung: exynos-chipid: add google,gs101-otp support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251120-gs101-chipid-v3-5-1aeaa8b7fe35@linaro.org> References: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> In-Reply-To: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763638176; l=6167; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=Hx0Wk3GLsyUiGvEN/qp5B6nJmnx3EpkHuI8i+qqhClA=; b=tAcT5R8w819O9dIOPhFo9z2LAc7AhyX1zJ2nQpev2tr5239eUppOc+DfySeDBbmPZIRtuXl7y SGEQQBpFilmCBQ1nTDK/qRBO4HJ1oNoxhRljdDsF7IckRFf6T92p/M9 X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= GS101 is different (but also e850 and autov9 I assume) from the SoCs that are currently handled by the exynos-chipid driver because the chip ID info is part of the OTP registers. GS101 OTP has a clock, an interrupt line, a register space (that contains product and chip ID, TMU data, ASV, etc) and a 32Kbit memory space that can be read/program/locked with specific commands. On GS101 the "ChipID block" is just an abstraction, it's not a physical device. When the power-on sequence progresses, the OTP chipid values are loaded to the OTP registers. Add the GS101 chip ID support. The support is intentionally added in the exynos-chipid driver, and not in a dedicated Exynos OTP driver, because we estimate that there will not be any OTP consumers in the kernel other than the chip ID/SoC interface. The downstream GS101 drivers confirm this supposition. Signed-off-by: Tudor Ambarus --- drivers/soc/samsung/exynos-chipid.c | 87 ++++++++++++++++++++++++++++++++-= ---- 1 file changed, 75 insertions(+), 12 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index 5c8660374269c87ec38ebca242918bd7b1d362e5..06eb6ef8740d3f58eda52c8e71c= f40074d2deb1f 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -13,9 +13,11 @@ */ =20 #include +#include #include #include -#include +#include +#include #include #include #include @@ -28,9 +30,11 @@ #include "exynos-asv.h" =20 struct exynos_chipid_variant { - unsigned int rev_reg; /* revision register offset */ + unsigned int main_rev_reg; /* main revision register offset */ + unsigned int sub_rev_reg; /* sub revision register offset */ unsigned int main_rev_shift; /* main revision offset in rev_reg */ unsigned int sub_rev_shift; /* sub revision offset in rev_reg */ + bool efuse; }; =20 struct exynos_chipid_info { @@ -69,6 +73,8 @@ static const struct exynos_soc_id { { "EXYNOS990", 0xE9830000 }, { "EXYNOSAUTOV9", 0xAAA80000 }, { "EXYNOSAUTOV920", 0x0A920000 }, + /* Compatible with: google,gs101-otp */ + { "GS101", 0x9845000 }, }; =20 static const char *exynos_product_id_to_name(unsigned int product_id) @@ -93,19 +99,53 @@ static int exynos_chipid_get_chipid_info(struct device = *dev, return dev_err_probe(dev, ret, "failed to read Product ID\n"); soc_info->product_id =3D val & EXYNOS_MASK; =20 - if (data->rev_reg !=3D EXYNOS_CHIPID_REG_PRO_ID) { - ret =3D regmap_read(regmap, data->rev_reg, &val); + if (data->sub_rev_reg =3D=3D EXYNOS_CHIPID_REG_PRO_ID) { + /* exynos4210 case */ + main_rev =3D (val >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; + sub_rev =3D (val >> data->sub_rev_shift) & EXYNOS_REV_PART_MASK; + } else { + unsigned int val2; + + ret =3D regmap_read(regmap, data->sub_rev_reg, &val2); if (ret < 0) return dev_err_probe(dev, ret, "failed to read revision\n"); + + if (data->main_rev_reg =3D=3D EXYNOS_CHIPID_REG_PRO_ID) + /* gs101 case */ + main_rev =3D (val >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; + else + /* exynos850 case */ + main_rev =3D (val2 >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; + + sub_rev =3D (val2 >> data->sub_rev_shift) & EXYNOS_REV_PART_MASK; } - main_rev =3D (val >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; - sub_rev =3D (val >> data->sub_rev_shift) & EXYNOS_REV_PART_MASK; + soc_info->revision =3D (main_rev << EXYNOS_REV_PART_SHIFT) | sub_rev; =20 return 0; } =20 +static struct regmap *exynos_chipid_get_efuse_regmap(struct platform_devic= e *pdev) +{ + struct resource *res; + void __iomem *base; + + base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); + if (IS_ERR(base)) + return ERR_CAST(base); + + const struct regmap_config reg_config =3D { + .reg_bits =3D 32, + .reg_stride =3D 4, + .val_bits =3D 32, + .use_relaxed_mmio =3D true, + .max_register =3D (resource_size(res) - reg_config.reg_stride), + }; + + return devm_regmap_init_mmio(&pdev->dev, base, ®_config); +} + static void exynos_chipid_unregister_soc(void *data) { soc_device_unregister(data); @@ -127,10 +167,24 @@ static int exynos_chipid_probe(struct platform_device= *pdev) return dev_err_probe(dev, -EINVAL, "failed to get match data\n"); =20 - regmap =3D device_node_to_regmap(dev->of_node); - if (IS_ERR(regmap)) - return dev_err_probe(dev, PTR_ERR(regmap), - "failed to get regmap\n"); + if (drv_data->efuse) { + struct clk *clk; + + regmap =3D exynos_chipid_get_efuse_regmap(pdev); + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), + "failed to get efuse regmap\n"); + + clk =3D devm_clk_get_enabled(dev, NULL); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "failed to get clock\n"); + } else { + regmap =3D device_node_to_regmap(dev->of_node); + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), + "failed to get regmap\n"); + } =20 ret =3D exynos_chipid_get_chipid_info(dev, regmap, drv_data, &soc_info); if (ret < 0) @@ -177,19 +231,28 @@ static int exynos_chipid_probe(struct platform_device= *pdev) } =20 static const struct exynos_chipid_variant exynos4210_chipid_drv_data =3D { - .rev_reg =3D 0x0, .main_rev_shift =3D 4, .sub_rev_shift =3D 0, }; =20 static const struct exynos_chipid_variant exynos850_chipid_drv_data =3D { - .rev_reg =3D 0x10, + .main_rev_reg =3D 0x10, + .sub_rev_reg =3D 0x10, .main_rev_shift =3D 20, .sub_rev_shift =3D 16, }; =20 +static const struct exynos_chipid_variant gs101_chipid_drv_data =3D { + .sub_rev_reg =3D 0x10, + .sub_rev_shift =3D 16, + .efuse =3D true, +}; + static const struct of_device_id exynos_chipid_of_device_ids[] =3D { { + .compatible =3D "google,gs101-otp", + .data =3D &gs101_chipid_drv_data, + }, { .compatible =3D "samsung,exynos4210-chipid", .data =3D &exynos4210_chipid_drv_data, }, { --=20 2.52.0.rc1.455.g30608eb744-goog From nobody Tue Dec 2 02:05:26 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52D6D3328F9 for ; Thu, 20 Nov 2025 11:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638192; cv=none; b=kSZk/nH0xifhKQplrtVnvc2lADn0biNr0vpZOS1xyqx9/Meu9EofdcJl+sMPF5j9PtfRVCdl7TcU4uiBJRY00uOafoMnmGjCQ92IDXMNPvl7O8FyqLAHh+QWWaZG8Ejl+GZDs6Q12MNfFdNhsGWMhyEN3cEHvBThesULtm4NdJk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763638192; c=relaxed/simple; bh=bpikWqcBMsiIMl/jbWq2QmBbah7xAa4FAfmzSq15MIU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dRBP2cZahLuaXSHjTEsSZi0bU+4eYHtWaMfrBGeoQhoIz+mwIuVyVH3dd1DTSP6uIIyzeX6POdawIzGnwhlUCKLpCDchvP6cxTnzE7uixawPQjMOl5cWBb456DieJjZwq3/2ntRhXlmsLNFzoHXaRJ/KSB7U1nDCp2Pd0FcZQh0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=c+Pg5BX3; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="c+Pg5BX3" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-42b3c965cc4so365462f8f.0 for ; Thu, 20 Nov 2025 03:29:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763638188; x=1764242988; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=A/NH+ihGTI+pHubvmXFI57IU6F78/DwM75gJfoYXgOw=; b=c+Pg5BX3PuLiYyuKuEtQVmZ+lO2kTrZQyqJ28q5rJPKlot5QynzX2g6FK/+jX6efmr s+Jyg/3R7VRpO3yGmheBmFvaOAyrI3NVGsQX4ea8zjVkn/nCndPsb1mxVUNEAj4omGys l3mpJufsx2exAZRgEWCg6IlIk/KlZZu0aSSXbJyl//RDu5sKHQQxqOC0ORj8W/iJcZuQ dFp+4mKrli6MZVz7OKYyQUlbA5wOTJt8K4EEiFCoi5a6ZD6lZK4ALODo0oSB1W2nsOZP ITPNOijIkFOm31howfBpeRtxKhjwKAQzzLntHrykPnvzclaH7TkBDnUfexIJ1BXtXXzq N9Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763638188; x=1764242988; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=A/NH+ihGTI+pHubvmXFI57IU6F78/DwM75gJfoYXgOw=; b=eVlb6XPYk55xAcL6zfqyuPRP3Cbim5UGgtEZwumdlr+dM8Oa/P216sm50kIuGAULPi XWqagZ3x4liK8ATiYrUqosJrcr16espJH4dGkDsxxVUV66lGCz4Id18HXziv6h85WkEo XN8hUCr6eMZKkR5YoTK2xKVll+K+QXcMnA7AVzbU9BkK8ynpoe4DbBJRNTAdMO6ONMqN We4UrFJ5kMnwlw4bbW4sLrQ/y9qZiHsbHyWzdSnfjp8kzOY0b682QrFLxLl8KezJuxJo ruYLgn1Y698Ciseu+EMGpYp0gP0RehehNIyzVPRYQ0d7V1h1WqbR1aJVhIH7ADLneBCH L8ig== X-Forwarded-Encrypted: i=1; AJvYcCWm4pZUJUP7lPBuHyNG54Gp6aAqSrjz466QfSHNqKICadvPrbGAdYZn6OwDFph20NgU3i7E9kMyAc1hAFY=@vger.kernel.org X-Gm-Message-State: AOJu0YwAYbE9DrdCAcaMa6o3EJqVvcoqyzBuTiZExPhDteWFv3h7cyw0 gpolgMfOPyOoDGPmTvqbC1j7K+Apnig3pu56eYRSEh8qkkMIYW9vocgWT8TkkwV+eb4= X-Gm-Gg: ASbGncsAE1yyTtIiJwat6V5QzmPfC8VHBiJ+J7tduvi6Sg6xW2X6iBLMHKmTknTS6FH 1wRrKoKN0YYMV5zbapmScnEMFGvkM7Q2HFXJ0zhaeoItX9+NHaW4UdcmZdRV2Kp7qTxkTIhzWqC 8vtGGooBZoKCu81HyfiJe2+CkMkj+u56W+AQr/reMQmj32SwkRLau7VLeT3tYPn1ii2yevZD2n8 gl1HI8TSQJj5Xt2bWZGcJ+HJXlWZiJ4orARmYyCy5U2wxzzHOME3oEnTOUI9YWcj0NVOJscWJdb kasnarkgOwcZsu/3jviiqF9tfKr6k4lwpuAUj4nstgMSEwA5WAyqJoCuaWGBZRzLTckCuCnEWfF BcU4BuW+RIUXmWVLGgDBb4svm4wC0d+8ovVE2Ii0aMPX8Npfi/0eAI8ppddS3ZmArI0DBfIWuMe ptXeM1ujhjmH2FhrzebaYvB0lbDameRRmGHWKvk+WcUQxg2Fh2cI4YNv8Q8n7i+qMfFrw= X-Google-Smtp-Source: AGHT+IH8k/MswTwGLqwMNfZfEAxN7h+lqxYRkrxtUElx9mhpAEHdT/2K3XzbTjmmMw+BEdrQo+kzoQ== X-Received: by 2002:a5d:45cd:0:b0:429:c8f6:5875 with SMTP id ffacd0b85a97d-42cba767c05mr2038488f8f.20.1763638185369; Thu, 20 Nov 2025 03:29:45 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34fd1sm4961040f8f.11.2025.11.20.03.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 03:29:44 -0800 (PST) From: Tudor Ambarus Date: Thu, 20 Nov 2025 11:29:40 +0000 Subject: [PATCH v3 6/6] arm64: dts: exynos: gs101: add OTP node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251120-gs101-chipid-v3-6-1aeaa8b7fe35@linaro.org> References: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> In-Reply-To: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763638176; l=968; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=bpikWqcBMsiIMl/jbWq2QmBbah7xAa4FAfmzSq15MIU=; b=oujFnjxZs2wibNVC2xxzFlbBl/q8pivW+chJMAutHAp5GASDYX9ux7hOfoiFw5KOgRgKW8M/n DHqqDaSpRwBBr9VAPGAejPUE/N7kvAgZxqQMLNxJPWpBv35J5h4lmpA X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Add the OTP controller node. Signed-off-by: Tudor Ambarus --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot= /dts/exynos/google/gs101.dtsi index d06d1d05f36408137a8acd98e43d48ea7d4f4292..4be983d4e291b3afe3530fbea01= 63f70c1a74671 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -571,6 +571,13 @@ soc: soc@0 { #size-cells =3D <1>; ranges =3D <0x0 0x0 0x0 0x40000000>; =20 + efuse@10000000 { + compatible =3D "google,gs101-otp"; + reg =3D <0x10000000 0xf084>; + clocks =3D <&cmu_misc CLK_GOUT_MISC_OTP_CON_TOP_PCLK>; + interrupts =3D ; + }; + cmu_misc: clock-controller@10010000 { compatible =3D "google,gs101-cmu-misc"; reg =3D <0x10010000 0x10000>; --=20 2.52.0.rc1.455.g30608eb744-goog